From: Jakub Kicinski <kuba@kernel.org>
To: Ilya Lipnitskiy <ilya.lipnitskiy@gmail.com>
Cc: Felix Fietkau <nbd@nbd.name>, John Crispin <john@phrozen.org>,
Sean Wang <sean.wang@mediatek.com>,
Mark Lee <Mark-MC.Lee@mediatek.com>,
"David S. Miller" <davem@davemloft.net>,
Matthias Brugger <matthias.bgg@gmail.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org
Subject: Re: [PATCH net-next 12/14] net: ethernet: mtk_eth_soc: reduce unnecessary interrupts
Date: Thu, 22 Apr 2021 09:26:08 -0700 [thread overview]
Message-ID: <20210422092608.6b8ed5ff@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> (raw)
In-Reply-To: <20210422040914.47788-13-ilya.lipnitskiy@gmail.com>
On Wed, 21 Apr 2021 21:09:12 -0700 Ilya Lipnitskiy wrote:
> @@ -1551,8 +1551,9 @@ static int mtk_napi_rx(struct napi_struct *napi, int budget)
> remain_budget -= rx_done;
> goto poll_again;
> }
> - napi_complete(napi);
> - mtk_rx_irq_enable(eth, MTK_RX_DONE_INT);
> +
> + if (napi_complete(napi))
> + mtk_rx_irq_enable(eth, MTK_RX_DONE_INT);
Why not napi_complete_done(napi, rx_done + budget - remain_budget)?
(Modulo possible elimination of rx_done in this function.)
WARNING: multiple messages have this Message-ID (diff)
From: Jakub Kicinski <kuba@kernel.org>
To: Ilya Lipnitskiy <ilya.lipnitskiy@gmail.com>
Cc: Felix Fietkau <nbd@nbd.name>, John Crispin <john@phrozen.org>,
Sean Wang <sean.wang@mediatek.com>,
Mark Lee <Mark-MC.Lee@mediatek.com>,
"David S. Miller" <davem@davemloft.net>,
Matthias Brugger <matthias.bgg@gmail.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org
Subject: Re: [PATCH net-next 12/14] net: ethernet: mtk_eth_soc: reduce unnecessary interrupts
Date: Thu, 22 Apr 2021 09:26:08 -0700 [thread overview]
Message-ID: <20210422092608.6b8ed5ff@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> (raw)
In-Reply-To: <20210422040914.47788-13-ilya.lipnitskiy@gmail.com>
On Wed, 21 Apr 2021 21:09:12 -0700 Ilya Lipnitskiy wrote:
> @@ -1551,8 +1551,9 @@ static int mtk_napi_rx(struct napi_struct *napi, int budget)
> remain_budget -= rx_done;
> goto poll_again;
> }
> - napi_complete(napi);
> - mtk_rx_irq_enable(eth, MTK_RX_DONE_INT);
> +
> + if (napi_complete(napi))
> + mtk_rx_irq_enable(eth, MTK_RX_DONE_INT);
Why not napi_complete_done(napi, rx_done + budget - remain_budget)?
(Modulo possible elimination of rx_done in this function.)
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
WARNING: multiple messages have this Message-ID (diff)
From: Jakub Kicinski <kuba@kernel.org>
To: Ilya Lipnitskiy <ilya.lipnitskiy@gmail.com>
Cc: Felix Fietkau <nbd@nbd.name>, John Crispin <john@phrozen.org>,
Sean Wang <sean.wang@mediatek.com>,
Mark Lee <Mark-MC.Lee@mediatek.com>,
"David S. Miller" <davem@davemloft.net>,
Matthias Brugger <matthias.bgg@gmail.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org
Subject: Re: [PATCH net-next 12/14] net: ethernet: mtk_eth_soc: reduce unnecessary interrupts
Date: Thu, 22 Apr 2021 09:26:08 -0700 [thread overview]
Message-ID: <20210422092608.6b8ed5ff@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> (raw)
In-Reply-To: <20210422040914.47788-13-ilya.lipnitskiy@gmail.com>
On Wed, 21 Apr 2021 21:09:12 -0700 Ilya Lipnitskiy wrote:
> @@ -1551,8 +1551,9 @@ static int mtk_napi_rx(struct napi_struct *napi, int budget)
> remain_budget -= rx_done;
> goto poll_again;
> }
> - napi_complete(napi);
> - mtk_rx_irq_enable(eth, MTK_RX_DONE_INT);
> +
> + if (napi_complete(napi))
> + mtk_rx_irq_enable(eth, MTK_RX_DONE_INT);
Why not napi_complete_done(napi, rx_done + budget - remain_budget)?
(Modulo possible elimination of rx_done in this function.)
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-04-22 16:26 UTC|newest]
Thread overview: 69+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-22 4:09 [PATCH net-next 00/14] mtk_eth_soc: fixes and performance improvements Ilya Lipnitskiy
2021-04-22 4:09 ` Ilya Lipnitskiy
2021-04-22 4:09 ` Ilya Lipnitskiy
2021-04-22 4:09 ` [PATCH net-next 01/14] net: ethernet: mtk_eth_soc: fix RX VLAN offload Ilya Lipnitskiy
2021-04-22 4:09 ` Ilya Lipnitskiy
2021-04-22 4:09 ` Ilya Lipnitskiy
2021-04-22 4:09 ` [PATCH net-next 02/14] net: ethernet: mtk_eth_soc: unmap RX data before calling build_skb Ilya Lipnitskiy
2021-04-22 4:09 ` Ilya Lipnitskiy
2021-04-22 4:09 ` Ilya Lipnitskiy
2021-04-22 4:09 ` [PATCH net-next 03/14] net: ethernet: mtk_eth_soc: fix build_skb cleanup Ilya Lipnitskiy
2021-04-22 4:09 ` Ilya Lipnitskiy
2021-04-22 4:09 ` Ilya Lipnitskiy
2021-04-22 4:09 ` [PATCH net-next 04/14] net: ethernet: mtk_eth_soc: use napi_consume_skb Ilya Lipnitskiy
2021-04-22 4:09 ` Ilya Lipnitskiy
2021-04-22 4:09 ` Ilya Lipnitskiy
2021-04-22 4:09 ` [PATCH net-next 05/14] net: ethernet: mtk_eth_soc: reduce MDIO bus access latency Ilya Lipnitskiy
2021-04-22 4:09 ` Ilya Lipnitskiy
2021-04-22 4:09 ` Ilya Lipnitskiy
2021-04-22 12:18 ` Andrew Lunn
2021-04-22 12:18 ` Andrew Lunn
2021-04-22 12:18 ` Andrew Lunn
2021-04-22 12:33 ` Felix Fietkau
2021-04-22 12:33 ` Felix Fietkau
2021-04-22 12:33 ` Felix Fietkau
2021-04-23 4:16 ` Ilya Lipnitskiy
2021-04-23 4:16 ` Ilya Lipnitskiy
2021-04-23 4:16 ` Ilya Lipnitskiy
2021-04-22 4:09 ` [PATCH net-next 06/14] net: ethernet: mtk_eth_soc: remove unnecessary TX queue stops Ilya Lipnitskiy
2021-04-22 4:09 ` Ilya Lipnitskiy
2021-04-22 4:09 ` Ilya Lipnitskiy
2021-04-22 4:09 ` [PATCH net-next 07/14] net: ethernet: mtk_eth_soc: use larger burst size for QDMA TX Ilya Lipnitskiy
2021-04-22 4:09 ` Ilya Lipnitskiy
2021-04-22 4:09 ` Ilya Lipnitskiy
2021-04-22 4:09 ` [PATCH net-next 08/14] net: ethernet: mtk_eth_soc: increase DMA ring sizes Ilya Lipnitskiy
2021-04-22 4:09 ` Ilya Lipnitskiy
2021-04-22 4:09 ` Ilya Lipnitskiy
2021-04-22 4:09 ` [PATCH net-next 09/14] net: ethernet: mtk_eth_soc: implement dynamic interrupt moderation Ilya Lipnitskiy
2021-04-22 4:09 ` Ilya Lipnitskiy
2021-04-22 4:09 ` Ilya Lipnitskiy
2021-04-22 4:09 ` [PATCH net-next 10/14] net: ethernet: mtk_eth_soc: cache HW pointer of last freed TX descriptor Ilya Lipnitskiy
2021-04-22 4:09 ` Ilya Lipnitskiy
2021-04-22 4:09 ` Ilya Lipnitskiy
2021-04-22 4:09 ` [PATCH net-next 11/14] net: ethernet: mtk_eth_soc: only read the full RX descriptor if DMA is done Ilya Lipnitskiy
2021-04-22 4:09 ` Ilya Lipnitskiy
2021-04-22 4:09 ` Ilya Lipnitskiy
2021-04-22 4:09 ` [PATCH net-next 12/14] net: ethernet: mtk_eth_soc: reduce unnecessary interrupts Ilya Lipnitskiy
2021-04-22 4:09 ` Ilya Lipnitskiy
2021-04-22 4:09 ` Ilya Lipnitskiy
2021-04-22 16:26 ` Jakub Kicinski [this message]
2021-04-22 16:26 ` Jakub Kicinski
2021-04-22 16:26 ` Jakub Kicinski
2021-04-23 4:20 ` Ilya Lipnitskiy
2021-04-23 4:20 ` Ilya Lipnitskiy
2021-04-23 4:20 ` Ilya Lipnitskiy
2021-04-22 4:09 ` [PATCH net-next 13/14] net: ethernet: mtk_eth_soc: set PPE flow hash as skb hash if present Ilya Lipnitskiy
2021-04-22 4:09 ` Ilya Lipnitskiy
2021-04-22 4:09 ` Ilya Lipnitskiy
2021-04-22 4:09 ` [PATCH net-next 14/14] net: ethernet: mtk_eth_soc: use iopoll.h macro for DMA init Ilya Lipnitskiy
2021-04-22 4:09 ` Ilya Lipnitskiy
2021-04-22 4:09 ` Ilya Lipnitskiy
2021-04-22 12:20 ` Andrew Lunn
2021-04-22 12:20 ` Andrew Lunn
2021-04-22 12:20 ` Andrew Lunn
2021-04-22 12:23 ` [PATCH net-next 00/14] mtk_eth_soc: fixes and performance improvements Andrew Lunn
2021-04-22 12:23 ` Andrew Lunn
2021-04-22 12:23 ` Andrew Lunn
2021-04-23 4:18 ` Ilya Lipnitskiy
2021-04-23 4:18 ` Ilya Lipnitskiy
2021-04-23 4:18 ` Ilya Lipnitskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210422092608.6b8ed5ff@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com \
--to=kuba@kernel.org \
--cc=Mark-MC.Lee@mediatek.com \
--cc=davem@davemloft.net \
--cc=ilya.lipnitskiy@gmail.com \
--cc=john@phrozen.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=nbd@nbd.name \
--cc=netdev@vger.kernel.org \
--cc=sean.wang@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.