Re: [PATCH RFC 12/15] fanotify: Introduce the FAN_ERROR mark

[kernel test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 3869 bytes --]

Hi Gabriel,

[FYI, it's a private test report for your RFC patch.]
[auto build test WARNING on pcmoore-audit/next]
[also build test WARNING on ext4/dev linus/master v5.12]
[cannot apply to ext3/fsnotify next-20210426]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Gabriel-Krisman-Bertazi/File-system-wide-monitoring/20210427-024627
base:   https://git.kernel.org/pub/scm/linux/kernel/git/pcmoore/audit.git next
config: x86_64-randconfig-a001-20210426 (attached as .config)
compiler: clang version 13.0.0 (https://github.com/llvm/llvm-project d941863de2becb3d8d2e00676fc7125974934c7f)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # install x86_64 cross compiling tool for clang build
        # apt-get install binutils-x86-64-linux-gnu
        # https://github.com/0day-ci/linux/commit/6179a61e1067e69a0e24e98bad3cb0eebdbfbee0
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Gabriel-Krisman-Bertazi/File-system-wide-monitoring/20210427-024627
        git checkout 6179a61e1067e69a0e24e98bad3cb0eebdbfbee0
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 ARCH=x86_64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

>> fs/notify/fanotify/fanotify_user.c:112:12: warning: address of array 'fee->fs_data' will always evaluate to 'true' [-Wpointer-bool-conversion]
                   if (fee->fs_data)
                   ~~  ~~~~~^~~~~~~
   1 warning generated.


vim +112 fs/notify/fanotify/fanotify_user.c

    89	
    90	static size_t fanotify_event_len(struct fanotify_event *event,
    91					 unsigned int fid_mode)
    92	{
    93		size_t event_len = FAN_EVENT_METADATA_LEN;
    94		struct fanotify_info *info;
    95		int dir_fh_len;
    96		int fh_len;
    97		int dot_len = 0;
    98	
    99		if (fanotify_is_error_event(event->mask)) {
   100			struct fanotify_error_event *fee = FANOTIFY_EE(event);
   101			/*
   102			 *  Error events (FAN_ERROR) have a different format
   103			 *  as follows:
   104			 * [ event_metadata            ]
   105			 * [ fs-generic error header   ]
   106			 * [ error location (optional) ]
   107			 * [ fs-specific blob          ]
   108			 */
   109			event_len = fanotify_error_info_len(fee);
   110			if (fee->loc.function)
   111				event_len += fanotify_location_info_len(&fee->loc);
 > 112			if (fee->fs_data)
   113				event_len += fanotify_error_fsdata_len(fee);
   114			return event_len;
   115		}
   116	
   117		if (!fid_mode)
   118			return event_len;
   119	
   120		info = fanotify_event_info(event);
   121		dir_fh_len = fanotify_event_dir_fh_len(event);
   122		fh_len = fanotify_event_object_fh_len(event);
   123	
   124		if (dir_fh_len) {
   125			event_len += fanotify_fid_info_len(dir_fh_len, info->name_len);
   126		} else if ((fid_mode & FAN_REPORT_NAME) && (event->mask & FAN_ONDIR)) {
   127			/*
   128			 * With group flag FAN_REPORT_NAME, if name was not recorded in
   129			 * event on a directory, we will report the name ".".
   130			 */
   131			dot_len = 1;
   132		}
   133	
   134		if (fh_len)
   135			event_len += fanotify_fid_info_len(fh_len, dot_len);
   136	
   137		return event_len;
   138	}
   139	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 37920 bytes --]