All of lore.kernel.org
 help / color / mirror / Atom feed
* [km13park-linux-1:master 4/4] drivers/scan_at_field/scan_at_field.c:219:18: error: too many arguments to function 'scan_blob_sanity_check'
@ 2021-04-27  5:25 kernel test robot
  0 siblings, 0 replies; only message in thread
From: kernel test robot @ 2021-04-27  5:25 UTC (permalink / raw)
  To: kbuild-all

[-- Attachment #1: Type: text/plain, Size: 4572 bytes --]

tree:   https://github.com/km13park/linux-1.git master
head:   a101b2eee22165a2a507d0d6f843897c4ff5d830
commit: a101b2eee22165a2a507d0d6f843897c4ff5d830 [4/4] saf: scan at field warnings fix
config: x86_64-randconfig-r021-20210426 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce (this is a W=1 build):
        # https://github.com/km13park/linux-1/commit/a101b2eee22165a2a507d0d6f843897c4ff5d830
        git remote add km13park-linux-1 https://github.com/km13park/linux-1.git
        git fetch --no-tags km13park-linux-1 master
        git checkout a101b2eee22165a2a507d0d6f843897c4ff5d830
        # save the attached .config to linux build tree
        make W=1 W=1 ARCH=x86_64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

   In file included from drivers/scan_at_field/scan_at_field.c:8:
   arch/x86/include/asm/microcode_intel.h: In function 'scan_blob_sanity_check':
   arch/x86/include/asm/microcode_intel.h:84:1: error: no return statement in function returning non-void [-Werror=return-type]
      84 | static inline bool scan_blob_sanity_check(void) {}
         | ^~~~~~
   drivers/scan_at_field/scan_at_field.c: In function 'load_scan_binary':
>> drivers/scan_at_field/scan_at_field.c:219:18: error: too many arguments to function 'scan_blob_sanity_check'
     219 |  if (is_hash && !scan_blob_sanity_check((void *)fw->data)) {
         |                  ^~~~~~~~~~~~~~~~~~~~~~
   In file included from drivers/scan_at_field/scan_at_field.c:8:
   arch/x86/include/asm/microcode_intel.h:84:20: note: declared here
      84 | static inline bool scan_blob_sanity_check(void) {}
         |                    ^~~~~~~~~~~~~~~~~~~~~~
   cc1: some warnings being treated as errors


vim +/scan_blob_sanity_check +219 drivers/scan_at_field/scan_at_field.c

4dab1d6923971a Kyung Min Park 2021-04-18  198  
4dab1d6923971a Kyung Min Park 2021-04-18  199  /*
4dab1d6923971a Kyung Min Park 2021-04-18  200   * Scan binary blob loading. Intel distributes the scan binary blob to vendors
4dab1d6923971a Kyung Min Park 2021-04-18  201   * and vendor installed the hash and scan binary blobs to /lib/firmware/intel-saf.
4dab1d6923971a Kyung Min Park 2021-04-18  202   */
4dab1d6923971a Kyung Min Park 2021-04-18  203  static const struct firmware *load_scan_binary(const char *path, bool is_hash)
4dab1d6923971a Kyung Min Park 2021-04-18  204  {
4dab1d6923971a Kyung Min Park 2021-04-18  205  	const struct firmware *fw;
4dab1d6923971a Kyung Min Park 2021-04-18  206  	int err;
4dab1d6923971a Kyung Min Park 2021-04-18  207  
4dab1d6923971a Kyung Min Park 2021-04-18  208  	saf_pdev = platform_device_register_simple("saf", -1, NULL, 0);
4dab1d6923971a Kyung Min Park 2021-04-18  209  	if (IS_ERR(saf_pdev)) {
4dab1d6923971a Kyung Min Park 2021-04-18  210  		pr_err("Error: platform_device_register_simple");
a101b2eee22165 Kyung Min Park 2021-04-26  211  		return NULL;
4dab1d6923971a Kyung Min Park 2021-04-18  212  	}
4dab1d6923971a Kyung Min Park 2021-04-18  213  	err = request_firmware_direct(&fw, path, &saf_pdev->dev);
4dab1d6923971a Kyung Min Park 2021-04-18  214  	if (err) {
4dab1d6923971a Kyung Min Park 2021-04-18  215  		pr_err("Error: request_firmware_direct return");
4dab1d6923971a Kyung Min Park 2021-04-18  216  		goto out;
4dab1d6923971a Kyung Min Park 2021-04-18  217  	}
4dab1d6923971a Kyung Min Park 2021-04-18  218  
4dab1d6923971a Kyung Min Park 2021-04-18 @219  	if (is_hash && !scan_blob_sanity_check((void *)fw->data)) {
4dab1d6923971a Kyung Min Park 2021-04-18  220  		pr_err("scan blob header sanity check failed");
4dab1d6923971a Kyung Min Park 2021-04-18  221  		goto out;
4dab1d6923971a Kyung Min Park 2021-04-18  222  	}
4dab1d6923971a Kyung Min Park 2021-04-18  223  out:
4dab1d6923971a Kyung Min Park 2021-04-18  224  	platform_device_unregister(saf_pdev);
4dab1d6923971a Kyung Min Park 2021-04-18  225  
4dab1d6923971a Kyung Min Park 2021-04-18  226  	return fw;
4dab1d6923971a Kyung Min Park 2021-04-18  227  }
4dab1d6923971a Kyung Min Park 2021-04-18  228  

:::::: The code at line 219 was first introduced by commit
:::::: 4dab1d6923971a00f7de82497cb99b0a2a54f6d2 drivers/saf: Introduce Scan At Field driver

:::::: TO: Kyung Min Park <kyung.min.park@intel.com>
:::::: CC: Kyung Min Park <kyung.min.park@intel.com>

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 29738 bytes --]

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2021-04-27  5:25 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-27  5:25 [km13park-linux-1:master 4/4] drivers/scan_at_field/scan_at_field.c:219:18: error: too many arguments to function 'scan_blob_sanity_check' kernel test robot

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.