From: Magnus Karlsson <magnus.karlsson@gmail.com> To: magnus.karlsson@intel.com, intel-wired-lan@lists.osuosl.org, anthony.l.nguyen@intel.com, maciej.fijalkowski@intel.com Cc: netdev@vger.kernel.org, brouer@redhat.com Subject: [PATCH intel-net v2 4/6] igb: add correct exception tracing for XDP Date: Mon, 10 May 2021 11:38:52 +0200 [thread overview] Message-ID: <20210510093854.31652-5-magnus.karlsson@gmail.com> (raw) In-Reply-To: <20210510093854.31652-1-magnus.karlsson@gmail.com> From: Magnus Karlsson <magnus.karlsson@intel.com> Add missing exception tracing to XDP when a number of different errors can occur. The support was only partial. Several errors where not logged which would confuse the user quite a lot not knowing where and why the packets disappeared. Fixes: 9cbc948b5a20 ("igb: add XDP support") Reported-by: Jesper Dangaard Brouer <brouer@redhat.com> Signed-off-by: Magnus Karlsson <magnus.karlsson@intel.com> --- drivers/net/ethernet/intel/igb/igb_main.c | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/drivers/net/ethernet/intel/igb/igb_main.c b/drivers/net/ethernet/intel/igb/igb_main.c index 038a9fd1af44..004a5b15fadb 100644 --- a/drivers/net/ethernet/intel/igb/igb_main.c +++ b/drivers/net/ethernet/intel/igb/igb_main.c @@ -8401,18 +8401,20 @@ static struct sk_buff *igb_run_xdp(struct igb_adapter *adapter, break; case XDP_TX: result = igb_xdp_xmit_back(adapter, xdp); + if (result == IGB_XDP_CONSUMED) + goto out_failure; break; case XDP_REDIRECT: err = xdp_do_redirect(adapter->netdev, xdp, xdp_prog); - if (!err) - result = IGB_XDP_REDIR; - else - result = IGB_XDP_CONSUMED; + if (err) + goto out_failure; + result = IGB_XDP_REDIR; break; default: bpf_warn_invalid_xdp_action(act); fallthrough; case XDP_ABORTED: +out_failure: trace_xdp_exception(rx_ring->netdev, xdp_prog, act); fallthrough; case XDP_DROP: -- 2.29.0
WARNING: multiple messages have this Message-ID (diff)
From: Magnus Karlsson <magnus.karlsson@gmail.com> To: intel-wired-lan@osuosl.org Subject: [Intel-wired-lan] [PATCH intel-net v2 4/6] igb: add correct exception tracing for XDP Date: Mon, 10 May 2021 11:38:52 +0200 [thread overview] Message-ID: <20210510093854.31652-5-magnus.karlsson@gmail.com> (raw) In-Reply-To: <20210510093854.31652-1-magnus.karlsson@gmail.com> From: Magnus Karlsson <magnus.karlsson@intel.com> Add missing exception tracing to XDP when a number of different errors can occur. The support was only partial. Several errors where not logged which would confuse the user quite a lot not knowing where and why the packets disappeared. Fixes: 9cbc948b5a20 ("igb: add XDP support") Reported-by: Jesper Dangaard Brouer <brouer@redhat.com> Signed-off-by: Magnus Karlsson <magnus.karlsson@intel.com> --- drivers/net/ethernet/intel/igb/igb_main.c | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/drivers/net/ethernet/intel/igb/igb_main.c b/drivers/net/ethernet/intel/igb/igb_main.c index 038a9fd1af44..004a5b15fadb 100644 --- a/drivers/net/ethernet/intel/igb/igb_main.c +++ b/drivers/net/ethernet/intel/igb/igb_main.c @@ -8401,18 +8401,20 @@ static struct sk_buff *igb_run_xdp(struct igb_adapter *adapter, break; case XDP_TX: result = igb_xdp_xmit_back(adapter, xdp); + if (result == IGB_XDP_CONSUMED) + goto out_failure; break; case XDP_REDIRECT: err = xdp_do_redirect(adapter->netdev, xdp, xdp_prog); - if (!err) - result = IGB_XDP_REDIR; - else - result = IGB_XDP_CONSUMED; + if (err) + goto out_failure; + result = IGB_XDP_REDIR; break; default: bpf_warn_invalid_xdp_action(act); fallthrough; case XDP_ABORTED: +out_failure: trace_xdp_exception(rx_ring->netdev, xdp_prog, act); fallthrough; case XDP_DROP: -- 2.29.0
next prev parent reply other threads:[~2021-05-10 9:39 UTC|newest] Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-05-10 9:38 [PATCH intel-net v2 0/6] i40e: ice: ixgbe: ixgbevf: igb: igc: add correct exception tracing for XDP Magnus Karlsson 2021-05-10 9:38 ` [Intel-wired-lan] " Magnus Karlsson 2021-05-10 9:38 ` [PATCH intel-net v2 1/6] i40e: " Magnus Karlsson 2021-05-10 9:38 ` [Intel-wired-lan] " Magnus Karlsson 2021-05-19 16:12 ` Bhandare, KiranX 2021-05-19 16:12 ` Bhandare, KiranX 2021-05-10 9:38 ` [PATCH intel-net v2 2/6] ice: " Magnus Karlsson 2021-05-10 9:38 ` [Intel-wired-lan] " Magnus Karlsson 2021-05-19 16:14 ` Bhandare, KiranX 2021-05-19 16:14 ` Bhandare, KiranX 2021-05-10 9:38 ` [PATCH intel-net v2 3/6] ixgbe: " Magnus Karlsson 2021-05-10 9:38 ` [Intel-wired-lan] " Magnus Karlsson 2021-05-28 4:16 ` Jambekar, Vishakha 2021-05-28 4:16 ` Jambekar, Vishakha 2021-05-10 9:38 ` Magnus Karlsson [this message] 2021-05-10 9:38 ` [Intel-wired-lan] [PATCH intel-net v2 4/6] igb: " Magnus Karlsson 2021-05-21 11:44 ` Jambekar, Vishakha 2021-05-21 11:44 ` Jambekar, Vishakha 2021-05-10 9:38 ` [PATCH intel-net v2 5/6] ixgbevf: " Magnus Karlsson 2021-05-10 9:38 ` [Intel-wired-lan] " Magnus Karlsson 2021-05-21 11:42 ` Jambekar, Vishakha 2021-05-21 11:42 ` Jambekar, Vishakha 2021-05-10 9:38 ` [PATCH intel-net v2 6/6] igc: " Magnus Karlsson 2021-05-10 9:38 ` [Intel-wired-lan] " Magnus Karlsson 2021-05-24 10:05 ` Dvora Fuxbrumer 2021-05-24 10:05 ` Dvora Fuxbrumer 2021-05-24 10:08 ` Dvora Fuxbrumer 2021-05-24 10:08 ` Dvora Fuxbrumer
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20210510093854.31652-5-magnus.karlsson@gmail.com \ --to=magnus.karlsson@gmail.com \ --cc=anthony.l.nguyen@intel.com \ --cc=brouer@redhat.com \ --cc=intel-wired-lan@lists.osuosl.org \ --cc=maciej.fijalkowski@intel.com \ --cc=magnus.karlsson@intel.com \ --cc=netdev@vger.kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.