From: "Krzysztof Wilczyński" <kw@linux.com>
To: Bjorn Helgaas <bhelgaas@google.com>
Cc: Oliver O'Halloran <oohall@gmail.com>,
Michael Ellerman <mpe@ellerman.id.au>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Paul Mackerras <paulus@samba.org>,
Tyrel Datwyler <tyreld@linux.ibm.com>,
Russell Currey <ruscur@russell.cc>,
Kurt Schwemmer <kurt.schwemmer@microsemi.com>,
Logan Gunthorpe <logang@deltatee.com>,
Joe Perches <joe@perches.com>,
linux-pci@vger.kernel.org, linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH 01/11] PCI: Use sysfs_emit() and sysfs_emit_at() in "show" functions
Date: Mon, 10 May 2021 12:30:12 +0200 [thread overview]
Message-ID: <20210510103012.GA76437@rocinante.localdomain> (raw)
In-Reply-To: <20210510041424.233565-1-kw@linux.com>
[+cc Joe for visibility]
[...]
> spin_lock(&resource_alignment_lock);
> if (resource_alignment_param)
> - count = scnprintf(buf, PAGE_SIZE, "%s", resource_alignment_param);
> + count = sysfs_emit(buf, "%s", resource_alignment_param);
> spin_unlock(&resource_alignment_lock);
Following the work that Joe did recently, see:
https://lore.kernel.org/lkml/aa1819fa5faf786573df298e5e2e7d357ba7d4ad.camel@perches.com/
I think we ought to also add the missing newline to our sysfs_emit() and
sysfs_emit_at() users, like the one above and the following:
drivers/pci/pci-sysfs.c
540: return sysfs_emit(buf, "%pOF", np);
To keep things correct and consistent.
Bjorn, I can follow-up with a small patch after this one, or send a v2,
or, if that would be OK with you, then you could fix it during merging,
provided you decide to merge things as-is.
Krzysztof
WARNING: multiple messages have this Message-ID (diff)
From: "Krzysztof Wilczyński" <kw@linux.com>
To: Bjorn Helgaas <bhelgaas@google.com>
Cc: Tyrel Datwyler <tyreld@linux.ibm.com>,
linux-pci@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
Oliver O'Halloran <oohall@gmail.com>,
Joe Perches <joe@perches.com>, Paul Mackerras <paulus@samba.org>,
Kurt Schwemmer <kurt.schwemmer@microsemi.com>,
Logan Gunthorpe <logang@deltatee.com>
Subject: Re: [PATCH 01/11] PCI: Use sysfs_emit() and sysfs_emit_at() in "show" functions
Date: Mon, 10 May 2021 12:30:12 +0200 [thread overview]
Message-ID: <20210510103012.GA76437@rocinante.localdomain> (raw)
In-Reply-To: <20210510041424.233565-1-kw@linux.com>
[+cc Joe for visibility]
[...]
> spin_lock(&resource_alignment_lock);
> if (resource_alignment_param)
> - count = scnprintf(buf, PAGE_SIZE, "%s", resource_alignment_param);
> + count = sysfs_emit(buf, "%s", resource_alignment_param);
> spin_unlock(&resource_alignment_lock);
Following the work that Joe did recently, see:
https://lore.kernel.org/lkml/aa1819fa5faf786573df298e5e2e7d357ba7d4ad.camel@perches.com/
I think we ought to also add the missing newline to our sysfs_emit() and
sysfs_emit_at() users, like the one above and the following:
drivers/pci/pci-sysfs.c
540: return sysfs_emit(buf, "%pOF", np);
To keep things correct and consistent.
Bjorn, I can follow-up with a small patch after this one, or send a v2,
or, if that would be OK with you, then you could fix it during merging,
provided you decide to merge things as-is.
Krzysztof
next prev parent reply other threads:[~2021-05-10 10:32 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-10 4:14 [PATCH 01/11] PCI: Use sysfs_emit() and sysfs_emit_at() in "show" functions Krzysztof Wilczyński
2021-05-10 4:14 ` Krzysztof Wilczyński
2021-05-10 4:14 ` [PATCH 02/11] PCI/AER: " Krzysztof Wilczyński
2021-05-10 4:14 ` Krzysztof Wilczyński
2021-05-10 4:14 ` [PATCH 03/11] PCI: " Krzysztof Wilczyński
2021-05-10 4:14 ` Krzysztof Wilczyński
2021-05-10 4:14 ` [PATCH 04/11] PCI/MSI: " Krzysztof Wilczyński
2021-05-10 4:14 ` Krzysztof Wilczyński
2021-05-10 4:14 ` [PATCH 05/11] PCI/IOV: " Krzysztof Wilczyński
2021-05-10 4:14 ` Krzysztof Wilczyński
2021-05-10 4:14 ` [PATCH 06/11] PCI/P2PDMA: " Krzysztof Wilczyński
2021-05-10 4:14 ` Krzysztof Wilczyński
2021-05-10 4:14 ` [PATCH 07/11] PCI/ASPM: " Krzysztof Wilczyński
2021-05-10 4:14 ` Krzysztof Wilczyński
2021-05-10 4:14 ` [PATCH 08/11] PCI: switchtec: " Krzysztof Wilczyński
2021-05-10 4:14 ` Krzysztof Wilczyński
2021-05-10 4:14 ` [PATCH 09/11] PCI: rpadlpar: " Krzysztof Wilczyński
2021-05-10 4:14 ` Krzysztof Wilczyński
2021-05-10 4:14 ` [PATCH 10/11] PCI: hotplug: " Krzysztof Wilczyński
2021-05-10 4:14 ` Krzysztof Wilczyński
2021-05-10 4:14 ` [PATCH 11/11] PCI: shpchp: " Krzysztof Wilczyński
2021-05-10 4:14 ` Krzysztof Wilczyński
2021-05-10 10:30 ` Krzysztof Wilczyński [this message]
2021-05-10 10:30 ` [PATCH 01/11] PCI: " Krzysztof Wilczyński
2021-05-10 15:57 ` Logan Gunthorpe
2021-05-10 15:57 ` Logan Gunthorpe
2021-05-13 12:49 ` Krzysztof Wilczyński
2021-05-13 12:49 ` Krzysztof Wilczyński
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210510103012.GA76437@rocinante.localdomain \
--to=kw@linux.com \
--cc=benh@kernel.crashing.org \
--cc=bhelgaas@google.com \
--cc=joe@perches.com \
--cc=kurt.schwemmer@microsemi.com \
--cc=linux-pci@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=logang@deltatee.com \
--cc=mpe@ellerman.id.au \
--cc=oohall@gmail.com \
--cc=paulus@samba.org \
--cc=ruscur@russell.cc \
--cc=tyreld@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.