From: Rob Herring <robh@kernel.org> To: Srinivas Kandagatla <srinivas.kandagatla@linaro.org> Cc: broonie@kernel.org, devicetree@vger.kernel.org, perex@perex.cz, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, lgirdwood@gmail.com Subject: Re: [PATCH v6 1/9] ASoC: dt-bindings: wcd938x: add bindings for wcd938x Date: Wed, 19 May 2021 18:54:54 -0500 [thread overview] Message-ID: <20210519235454.GA3752127@robh.at.kernel.org> (raw) In-Reply-To: <20210518143759.16837-2-srinivas.kandagatla@linaro.org> On Tue, May 18, 2021 at 03:37:51PM +0100, Srinivas Kandagatla wrote: > Qualcomm WCD9380/WCD9385 Codec is a standalone Hi-Fi audio codec IC > connected over SoundWire. This device has two SoundWire device RX and > TX respectively, supporting 4 x ADCs, ClassH, Ear, Aux PA, 2xHPH, > 7 x TX diff inputs, 8 DMICs, MBHC. > > Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org> > --- > .../bindings/sound/qcom,wcd938x.yaml | 148 ++++++++++++++++++ > 1 file changed, 148 insertions(+) > create mode 100644 Documentation/devicetree/bindings/sound/qcom,wcd938x.yaml > > diff --git a/Documentation/devicetree/bindings/sound/qcom,wcd938x.yaml b/Documentation/devicetree/bindings/sound/qcom,wcd938x.yaml > new file mode 100644 > index 000000000000..b04c5e90e283 > --- /dev/null > +++ b/Documentation/devicetree/bindings/sound/qcom,wcd938x.yaml > @@ -0,0 +1,148 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/sound/qcom,wcd938x.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Bindings for Qualcomm WCD9380/WCD9385 Audio Codec > + > +maintainers: > + - Srinivas Kandagatla <srinivas.kandagatla@linaro.org> > + > +description: | > + Qualcomm WCD9380/WCD9385 Codec is a standalone Hi-Fi audio codec IC. > + It has RX and TX Soundwire slave devices. > + > +properties: > + compatible: > + enum: > + - qcom,wcd9380-codec > + - qcom,wcd9385-codec > + > + reset-gpios: > + description: GPIO spec for reset line to use > + maxItems: 1 > + > + vdd-buck-supply: > + description: A reference to the 1.8V buck supply > + > + vdd-rxtx-supply: > + description: A reference to the 1.8V rx supply > + > + vdd-io-supply: > + description: A reference to the 1.8V I/O supply > + > + qcom,tx-device: > + $ref: /schemas/types.yaml#/definitions/phandle-array Only 1 and no args, so just 'phandle'. > + maxItems: 1 And drop this. > + description: A reference to Soundwire tx device phandle > + > + qcom,rx-device: > + $ref: /schemas/types.yaml#/definitions/phandle-array > + maxItems: 1 And here. With that, Reviewed-by: Rob Herring <robh@kernel.org> > + description: A reference to Soundwire rx device phandle > + > + qcom,micbias1-microvolt: > + description: micbias1 voltage > + minimum: 1800000 > + maximum: 2850000 > + > + qcom,micbias2-microvolt: > + description: micbias2 voltage > + minimum: 1800000 > + maximum: 2850000 > + > + qcom,micbias3-microvolt: > + description: micbias3 voltage > + minimum: 1800000 > + maximum: 2850000 > + > + qcom,micbias4-microvolt: > + description: micbias4 voltage > + minimum: 1800000 > + maximum: 2850000 > + > + qcom,hphl-jack-type-normally-closed: > + description: Indicates that HPHL jack switch type is normally closed > + type: boolean > + > + qcom,ground-jack-type-normally-closed: > + description: Indicates that Headset Ground switch type is normally closed > + type: boolean > + > + qcom,mbhc-headset-vthreshold-microvolt: > + description: Voltage threshold value for headset detection > + minimum: 0 > + maximum: 2850000 > + > + qcom,mbhc-headphone-vthreshold-microvolt: > + description: Voltage threshold value for headphone detection > + minimum: 0 > + maximum: 2850000 > + > + qcom,mbhc-buttons-vthreshold-microvolt: > + description: > + Array of 8 Voltage threshold values corresponding to headset > + button0 - button7 > + minItems: 8 > + maxItems: 8 > + > + '#sound-dai-cells': > + const: 1 > + > +required: > + - compatible > + - reset-gpios > + - qcom,tx-device > + - qcom,rx-device > + - qcom,micbias1-microvolt > + - qcom,micbias2-microvolt > + - qcom,micbias3-microvolt > + - qcom,micbias4-microvolt > + - "#sound-dai-cells" > + > +additionalProperties: false > + > +examples: > + - | > + codec { > + compatible = "qcom,wcd9380-codec"; > + reset-gpios = <&tlmm 32 0>; > + #sound-dai-cells = <1>; > + qcom,tx-device = <&wcd938x_tx>; > + qcom,rx-device = <&wcd938x_rx>; > + qcom,micbias1-microvolt = <1800000>; > + qcom,micbias2-microvolt = <1800000>; > + qcom,micbias3-microvolt = <1800000>; > + qcom,micbias4-microvolt = <1800000>; > + qcom,hphl-jack-type-normally-closed; > + qcom,ground-jack-type-normally-closed; > + qcom,mbhc-buttons-vthreshold-microvolt = <75000 150000 237000 500000 500000 500000 500000 500000>; > + qcom,mbhc-headphone-vthreshold-microvolt = <50000>; > + }; > + > + /* ... */ > + > + soundwire@3210000 { > + #address-cells = <2>; > + #size-cells = <0>; > + reg = <0x03210000 0x2000>; > + wcd938x_rx: codec@0,4 { > + compatible = "sdw20217010d00"; > + reg = <0 4>; > + qcom,rx-port-mapping = <1 2 3 4 5>; > + }; > + }; > + > + soundwire@3230000 { > + #address-cells = <2>; > + #size-cells = <0>; > + reg = <0x03230000 0x2000>; > + wcd938x_tx: codec@0,3 { > + compatible = "sdw20217010d00"; > + reg = <0 3>; > + qcom,tx-port-mapping = <2 3 4 5>; > + }; > + }; > + > +... > -- > 2.21.0 >
WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org> To: Srinivas Kandagatla <srinivas.kandagatla@linaro.org> Cc: devicetree@vger.kernel.org, alsa-devel@alsa-project.org, lgirdwood@gmail.com, linux-kernel@vger.kernel.org, broonie@kernel.org Subject: Re: [PATCH v6 1/9] ASoC: dt-bindings: wcd938x: add bindings for wcd938x Date: Wed, 19 May 2021 18:54:54 -0500 [thread overview] Message-ID: <20210519235454.GA3752127@robh.at.kernel.org> (raw) In-Reply-To: <20210518143759.16837-2-srinivas.kandagatla@linaro.org> On Tue, May 18, 2021 at 03:37:51PM +0100, Srinivas Kandagatla wrote: > Qualcomm WCD9380/WCD9385 Codec is a standalone Hi-Fi audio codec IC > connected over SoundWire. This device has two SoundWire device RX and > TX respectively, supporting 4 x ADCs, ClassH, Ear, Aux PA, 2xHPH, > 7 x TX diff inputs, 8 DMICs, MBHC. > > Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org> > --- > .../bindings/sound/qcom,wcd938x.yaml | 148 ++++++++++++++++++ > 1 file changed, 148 insertions(+) > create mode 100644 Documentation/devicetree/bindings/sound/qcom,wcd938x.yaml > > diff --git a/Documentation/devicetree/bindings/sound/qcom,wcd938x.yaml b/Documentation/devicetree/bindings/sound/qcom,wcd938x.yaml > new file mode 100644 > index 000000000000..b04c5e90e283 > --- /dev/null > +++ b/Documentation/devicetree/bindings/sound/qcom,wcd938x.yaml > @@ -0,0 +1,148 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/sound/qcom,wcd938x.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Bindings for Qualcomm WCD9380/WCD9385 Audio Codec > + > +maintainers: > + - Srinivas Kandagatla <srinivas.kandagatla@linaro.org> > + > +description: | > + Qualcomm WCD9380/WCD9385 Codec is a standalone Hi-Fi audio codec IC. > + It has RX and TX Soundwire slave devices. > + > +properties: > + compatible: > + enum: > + - qcom,wcd9380-codec > + - qcom,wcd9385-codec > + > + reset-gpios: > + description: GPIO spec for reset line to use > + maxItems: 1 > + > + vdd-buck-supply: > + description: A reference to the 1.8V buck supply > + > + vdd-rxtx-supply: > + description: A reference to the 1.8V rx supply > + > + vdd-io-supply: > + description: A reference to the 1.8V I/O supply > + > + qcom,tx-device: > + $ref: /schemas/types.yaml#/definitions/phandle-array Only 1 and no args, so just 'phandle'. > + maxItems: 1 And drop this. > + description: A reference to Soundwire tx device phandle > + > + qcom,rx-device: > + $ref: /schemas/types.yaml#/definitions/phandle-array > + maxItems: 1 And here. With that, Reviewed-by: Rob Herring <robh@kernel.org> > + description: A reference to Soundwire rx device phandle > + > + qcom,micbias1-microvolt: > + description: micbias1 voltage > + minimum: 1800000 > + maximum: 2850000 > + > + qcom,micbias2-microvolt: > + description: micbias2 voltage > + minimum: 1800000 > + maximum: 2850000 > + > + qcom,micbias3-microvolt: > + description: micbias3 voltage > + minimum: 1800000 > + maximum: 2850000 > + > + qcom,micbias4-microvolt: > + description: micbias4 voltage > + minimum: 1800000 > + maximum: 2850000 > + > + qcom,hphl-jack-type-normally-closed: > + description: Indicates that HPHL jack switch type is normally closed > + type: boolean > + > + qcom,ground-jack-type-normally-closed: > + description: Indicates that Headset Ground switch type is normally closed > + type: boolean > + > + qcom,mbhc-headset-vthreshold-microvolt: > + description: Voltage threshold value for headset detection > + minimum: 0 > + maximum: 2850000 > + > + qcom,mbhc-headphone-vthreshold-microvolt: > + description: Voltage threshold value for headphone detection > + minimum: 0 > + maximum: 2850000 > + > + qcom,mbhc-buttons-vthreshold-microvolt: > + description: > + Array of 8 Voltage threshold values corresponding to headset > + button0 - button7 > + minItems: 8 > + maxItems: 8 > + > + '#sound-dai-cells': > + const: 1 > + > +required: > + - compatible > + - reset-gpios > + - qcom,tx-device > + - qcom,rx-device > + - qcom,micbias1-microvolt > + - qcom,micbias2-microvolt > + - qcom,micbias3-microvolt > + - qcom,micbias4-microvolt > + - "#sound-dai-cells" > + > +additionalProperties: false > + > +examples: > + - | > + codec { > + compatible = "qcom,wcd9380-codec"; > + reset-gpios = <&tlmm 32 0>; > + #sound-dai-cells = <1>; > + qcom,tx-device = <&wcd938x_tx>; > + qcom,rx-device = <&wcd938x_rx>; > + qcom,micbias1-microvolt = <1800000>; > + qcom,micbias2-microvolt = <1800000>; > + qcom,micbias3-microvolt = <1800000>; > + qcom,micbias4-microvolt = <1800000>; > + qcom,hphl-jack-type-normally-closed; > + qcom,ground-jack-type-normally-closed; > + qcom,mbhc-buttons-vthreshold-microvolt = <75000 150000 237000 500000 500000 500000 500000 500000>; > + qcom,mbhc-headphone-vthreshold-microvolt = <50000>; > + }; > + > + /* ... */ > + > + soundwire@3210000 { > + #address-cells = <2>; > + #size-cells = <0>; > + reg = <0x03210000 0x2000>; > + wcd938x_rx: codec@0,4 { > + compatible = "sdw20217010d00"; > + reg = <0 4>; > + qcom,rx-port-mapping = <1 2 3 4 5>; > + }; > + }; > + > + soundwire@3230000 { > + #address-cells = <2>; > + #size-cells = <0>; > + reg = <0x03230000 0x2000>; > + wcd938x_tx: codec@0,3 { > + compatible = "sdw20217010d00"; > + reg = <0 3>; > + qcom,tx-port-mapping = <2 3 4 5>; > + }; > + }; > + > +... > -- > 2.21.0 >
next prev parent reply other threads:[~2021-05-19 23:55 UTC|newest] Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-05-18 14:37 [PATCH v6 0/9] ASoC: codecs: add wcd938x support Srinivas Kandagatla 2021-05-18 14:37 ` Srinivas Kandagatla 2021-05-18 14:37 ` [PATCH v6 1/9] ASoC: dt-bindings: wcd938x: add bindings for wcd938x Srinivas Kandagatla 2021-05-18 14:37 ` Srinivas Kandagatla 2021-05-19 23:54 ` Rob Herring [this message] 2021-05-19 23:54 ` Rob Herring 2021-05-18 14:37 ` [PATCH v6 2/9] ASoC: codecs: wcd-clsh: add new version support Srinivas Kandagatla 2021-05-18 14:37 ` Srinivas Kandagatla 2021-05-18 14:37 ` [PATCH v6 3/9] ASoC: codecs: wcd938x: add basic driver Srinivas Kandagatla 2021-05-18 14:37 ` Srinivas Kandagatla 2021-05-18 14:37 ` [PATCH v6 4/9] ASoC: dt-bindings: wcd938x-sdw: add bindings for wcd938x-sdw Srinivas Kandagatla 2021-05-18 14:37 ` Srinivas Kandagatla 2021-05-18 14:37 ` [PATCH v6 5/9] ASoC: codecs: wcd938x-sdw: add SoundWire driver Srinivas Kandagatla 2021-05-18 14:37 ` Srinivas Kandagatla 2021-05-18 14:37 ` [PATCH v6 6/9] ASoC: codecs: wcd938x: add basic controls Srinivas Kandagatla 2021-05-18 14:37 ` Srinivas Kandagatla 2021-05-18 14:37 ` [PATCH v6 7/9] ASoC: codecs: wcd938x: add playback dapm widgets Srinivas Kandagatla 2021-05-18 14:37 ` Srinivas Kandagatla 2021-05-18 14:37 ` [PATCH v6 8/9] ASoC: codecs: wcd938x: add capture " Srinivas Kandagatla 2021-05-18 14:37 ` Srinivas Kandagatla 2021-05-18 14:37 ` [PATCH v6 9/9] ASoC: codecs: wcd938x: add audio routing Srinivas Kandagatla 2021-05-18 14:37 ` Srinivas Kandagatla
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20210519235454.GA3752127@robh.at.kernel.org \ --to=robh@kernel.org \ --cc=alsa-devel@alsa-project.org \ --cc=broonie@kernel.org \ --cc=devicetree@vger.kernel.org \ --cc=lgirdwood@gmail.com \ --cc=linux-kernel@vger.kernel.org \ --cc=perex@perex.cz \ --cc=srinivas.kandagatla@linaro.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.