From: Gao Xiang <xiang@kernel.org> To: Chao Yu <yuchao0@huawei.com> Cc: Gao Xiang <xiang@kernel.org>, Dan Carpenter <dan.carpenter@oracle.com>, Wei Yongjun <weiyongjun1@huawei.com>, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org, Hulk Robot <hulkci@huawei.com>, linux-erofs@lists.ozlabs.org Subject: Re: [PATCH -next] erofs: fix error return code in erofs_read_superblock() Date: Fri, 21 May 2021 09:57:01 +0800 [thread overview] Message-ID: <20210521015700.GA5725@hsiangkao-HP-ZHAN-66-Pro-G1> (raw) In-Reply-To: <9f96b12f-b05b-c118-4391-448f780702ff@huawei.com> On Fri, May 21, 2021 at 09:14:58AM +0800, Chao Yu wrote: > On 2021/5/20 16:40, Gao Xiang wrote: > > Hi Yongjun and Dan, > > > > On Thu, May 20, 2021 at 08:32:26AM +0300, Dan Carpenter wrote: > > > On Wed, May 19, 2021 at 02:16:57PM +0000, Wei Yongjun wrote: > > > > 'ret' will be overwritten to 0 if erofs_sb_has_sb_chksum() return true, > > > > thus 0 will return in some error handling cases. Fix to return negative > > > > error code -EINVAL instead of 0. > > > > > > > > Reported-by: Hulk Robot <hulkci@huawei.com> > > > > Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com> > > > > > > You need to add Fixes tags to bug fix patches and you need to ensure > > > that the authors of the Fixes commit are CC'd so they can review your > > > fix. get_maintainer.pl will add the author automatically, but normally > > > I like to put them in the To header to make sure they see it. > > > > > > Fixes: b858a4844cfb ("erofs: support superblock checksum") > > > > The commit and the tag look good to me (sorry for a bit delay on this), > > > > Fixes: b858a4844cfb ("erofs: support superblock checksum") > > Cc: stable <stable@vger.kernel.org> # 5.5+ > > Reviewed-by: Gao Xiang <xiang@kernel.org> > > Reviewed-by: Chao Yu <yuchao0@huawei.com> Thanks Chao, will add soon. :) > > Thanks, > > > > > (will apply to dev-test for a while and then to -next.) > > > > Thanks, > > Gao Xiang > > > > . > >
WARNING: multiple messages have this Message-ID (diff)
From: Gao Xiang <xiang@kernel.org> To: Chao Yu <yuchao0@huawei.com> Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org, Hulk Robot <hulkci@huawei.com>, Wei Yongjun <weiyongjun1@huawei.com>, Gao Xiang <xiang@kernel.org>, linux-erofs@lists.ozlabs.org, Dan Carpenter <dan.carpenter@oracle.com> Subject: Re: [PATCH -next] erofs: fix error return code in erofs_read_superblock() Date: Fri, 21 May 2021 09:57:01 +0800 [thread overview] Message-ID: <20210521015700.GA5725@hsiangkao-HP-ZHAN-66-Pro-G1> (raw) In-Reply-To: <9f96b12f-b05b-c118-4391-448f780702ff@huawei.com> On Fri, May 21, 2021 at 09:14:58AM +0800, Chao Yu wrote: > On 2021/5/20 16:40, Gao Xiang wrote: > > Hi Yongjun and Dan, > > > > On Thu, May 20, 2021 at 08:32:26AM +0300, Dan Carpenter wrote: > > > On Wed, May 19, 2021 at 02:16:57PM +0000, Wei Yongjun wrote: > > > > 'ret' will be overwritten to 0 if erofs_sb_has_sb_chksum() return true, > > > > thus 0 will return in some error handling cases. Fix to return negative > > > > error code -EINVAL instead of 0. > > > > > > > > Reported-by: Hulk Robot <hulkci@huawei.com> > > > > Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com> > > > > > > You need to add Fixes tags to bug fix patches and you need to ensure > > > that the authors of the Fixes commit are CC'd so they can review your > > > fix. get_maintainer.pl will add the author automatically, but normally > > > I like to put them in the To header to make sure they see it. > > > > > > Fixes: b858a4844cfb ("erofs: support superblock checksum") > > > > The commit and the tag look good to me (sorry for a bit delay on this), > > > > Fixes: b858a4844cfb ("erofs: support superblock checksum") > > Cc: stable <stable@vger.kernel.org> # 5.5+ > > Reviewed-by: Gao Xiang <xiang@kernel.org> > > Reviewed-by: Chao Yu <yuchao0@huawei.com> Thanks Chao, will add soon. :) > > Thanks, > > > > > (will apply to dev-test for a while and then to -next.) > > > > Thanks, > > Gao Xiang > > > > . > >
next prev parent reply other threads:[~2021-05-21 1:57 UTC|newest] Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-05-19 14:16 [PATCH -next] erofs: fix error return code in erofs_read_superblock() Wei Yongjun 2021-05-19 14:16 ` Wei Yongjun 2021-05-20 5:32 ` Dan Carpenter 2021-05-20 5:32 ` Dan Carpenter 2021-05-20 8:40 ` Gao Xiang 2021-05-20 8:40 ` Gao Xiang 2021-05-21 1:14 ` Chao Yu 2021-05-21 1:14 ` Chao Yu 2021-05-21 1:57 ` Gao Xiang [this message] 2021-05-21 1:57 ` Gao Xiang
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20210521015700.GA5725@hsiangkao-HP-ZHAN-66-Pro-G1 \ --to=xiang@kernel.org \ --cc=dan.carpenter@oracle.com \ --cc=hulkci@huawei.com \ --cc=kernel-janitors@vger.kernel.org \ --cc=linux-erofs@lists.ozlabs.org \ --cc=linux-kernel@vger.kernel.org \ --cc=weiyongjun1@huawei.com \ --cc=yuchao0@huawei.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.