All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stephen Rothwell <sfr@canb.auug.org.au>
To: DRI <dri-devel@lists.freedesktop.org>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	Dave Airlie <airlied@linux.ie>
Cc: "Daniel Vetter" <daniel.vetter@ffwll.ch>,
	"Jani Nikula" <jani.nikula@linux.intel.com>,
	"Joonas Lahtinen" <joonas.lahtinen@linux.intel.com>,
	"Rodrigo Vivi" <rodrigo.vivi@intel.com>,
	"Intel Graphics" <intel-gfx@lists.freedesktop.org>,
	"James Ausmus" <james.ausmus@intel.com>,
	"José Roberto de Souza" <jose.souza@intel.com>,
	"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
	"Linux Next Mailing List" <linux-next@vger.kernel.org>
Subject: Re: linux-next: manual merge of the drm-intel tree with Linus' tree
Date: Fri, 21 May 2021 11:45:17 +1000	[thread overview]
Message-ID: <20210521114517.4142ad73@canb.auug.org.au> (raw)
In-Reply-To: <20210520101910.26606a78@canb.auug.org.au>

[-- Attachment #1: Type: text/plain, Size: 1694 bytes --]

Hi all,

On Thu, 20 May 2021 10:19:10 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> Today's linux-next merge of the drm-intel tree got a conflict in:
> 
>   drivers/gpu/drm/i915/i915_mm.c
> 
> between commit:
> 
>   293837b9ac8d ("Revert "i915: fix remap_io_sg to verify the pgprot"")
> 
> from Linus' tree and commit:
> 
>   ec279384c6a0 ("drm/i915: Initialize err in remap_io_sg()")
> 
> from the drm-intel tree.
> 
> I fixed it up (see below) and can carry the fix as necessary. This
> is now fixed as far as linux-next is concerned, but any non trivial
> conflicts should be mentioned to your upstream maintainer when your tree
> is submitted for merging.  You may also want to consider cooperating
> with the maintainer of the conflicting tree to minimise any particularly
> complex conflicts.
> 
> 
> diff --cc drivers/gpu/drm/i915/i915_mm.c
> index 9a777b0ff59b,25576fa73ff0..000000000000
> --- a/drivers/gpu/drm/i915/i915_mm.c
> +++ b/drivers/gpu/drm/i915/i915_mm.c
> @@@ -82,13 -46,8 +82,13 @@@ int remap_io_sg(struct vm_area_struct *
>   		unsigned long addr, unsigned long size,
>   		struct scatterlist *sgl, resource_size_t iobase)
>   {
>  -	unsigned long pfn, len, remapped = 0;
>  +	struct remap_pfn r = {
>  +		.mm = vma->vm_mm,
>  +		.prot = vma->vm_page_prot,
>  +		.sgt = __sgt_iter(sgl, use_dma(iobase)),
>  +		.iobase = iobase,
>  +	};
> - 	int err;
> + 	int err = 0;
>   
>   	/* We rely on prevalidation of the io-mapping to skip track_pfn(). */
>   	GEM_BUG_ON((vma->vm_flags & EXPECTED_FLAGS) != EXPECTED_FLAGS);

This is now a conflict between the drm tree and Linus' tree.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

WARNING: multiple messages have this Message-ID (diff)
From: Stephen Rothwell <sfr@canb.auug.org.au>
To: DRI <dri-devel@lists.freedesktop.org>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	Dave Airlie <airlied@linux.ie>
Cc: "James Ausmus" <james.ausmus@intel.com>,
	"Daniel Vetter" <daniel.vetter@ffwll.ch>,
	"Intel Graphics" <intel-gfx@lists.freedesktop.org>,
	"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
	"Linux Next Mailing List" <linux-next@vger.kernel.org>,
	"José Roberto de Souza" <jose.souza@intel.com>,
	"Rodrigo Vivi" <rodrigo.vivi@intel.com>
Subject: Re: linux-next: manual merge of the drm-intel tree with Linus' tree
Date: Fri, 21 May 2021 11:45:17 +1000	[thread overview]
Message-ID: <20210521114517.4142ad73@canb.auug.org.au> (raw)
In-Reply-To: <20210520101910.26606a78@canb.auug.org.au>

[-- Attachment #1: Type: text/plain, Size: 1694 bytes --]

Hi all,

On Thu, 20 May 2021 10:19:10 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> Today's linux-next merge of the drm-intel tree got a conflict in:
> 
>   drivers/gpu/drm/i915/i915_mm.c
> 
> between commit:
> 
>   293837b9ac8d ("Revert "i915: fix remap_io_sg to verify the pgprot"")
> 
> from Linus' tree and commit:
> 
>   ec279384c6a0 ("drm/i915: Initialize err in remap_io_sg()")
> 
> from the drm-intel tree.
> 
> I fixed it up (see below) and can carry the fix as necessary. This
> is now fixed as far as linux-next is concerned, but any non trivial
> conflicts should be mentioned to your upstream maintainer when your tree
> is submitted for merging.  You may also want to consider cooperating
> with the maintainer of the conflicting tree to minimise any particularly
> complex conflicts.
> 
> 
> diff --cc drivers/gpu/drm/i915/i915_mm.c
> index 9a777b0ff59b,25576fa73ff0..000000000000
> --- a/drivers/gpu/drm/i915/i915_mm.c
> +++ b/drivers/gpu/drm/i915/i915_mm.c
> @@@ -82,13 -46,8 +82,13 @@@ int remap_io_sg(struct vm_area_struct *
>   		unsigned long addr, unsigned long size,
>   		struct scatterlist *sgl, resource_size_t iobase)
>   {
>  -	unsigned long pfn, len, remapped = 0;
>  +	struct remap_pfn r = {
>  +		.mm = vma->vm_mm,
>  +		.prot = vma->vm_page_prot,
>  +		.sgt = __sgt_iter(sgl, use_dma(iobase)),
>  +		.iobase = iobase,
>  +	};
> - 	int err;
> + 	int err = 0;
>   
>   	/* We rely on prevalidation of the io-mapping to skip track_pfn(). */
>   	GEM_BUG_ON((vma->vm_flags & EXPECTED_FLAGS) != EXPECTED_FLAGS);

This is now a conflict between the drm tree and Linus' tree.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

WARNING: multiple messages have this Message-ID (diff)
From: Stephen Rothwell <sfr@canb.auug.org.au>
To: DRI <dri-devel@lists.freedesktop.org>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	Dave Airlie <airlied@linux.ie>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>,
	Intel Graphics <intel-gfx@lists.freedesktop.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Linux Next Mailing List <linux-next@vger.kernel.org>
Subject: Re: [Intel-gfx] linux-next: manual merge of the drm-intel tree with Linus' tree
Date: Fri, 21 May 2021 11:45:17 +1000	[thread overview]
Message-ID: <20210521114517.4142ad73@canb.auug.org.au> (raw)
In-Reply-To: <20210520101910.26606a78@canb.auug.org.au>


[-- Attachment #1.1: Type: text/plain, Size: 1694 bytes --]

Hi all,

On Thu, 20 May 2021 10:19:10 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> Today's linux-next merge of the drm-intel tree got a conflict in:
> 
>   drivers/gpu/drm/i915/i915_mm.c
> 
> between commit:
> 
>   293837b9ac8d ("Revert "i915: fix remap_io_sg to verify the pgprot"")
> 
> from Linus' tree and commit:
> 
>   ec279384c6a0 ("drm/i915: Initialize err in remap_io_sg()")
> 
> from the drm-intel tree.
> 
> I fixed it up (see below) and can carry the fix as necessary. This
> is now fixed as far as linux-next is concerned, but any non trivial
> conflicts should be mentioned to your upstream maintainer when your tree
> is submitted for merging.  You may also want to consider cooperating
> with the maintainer of the conflicting tree to minimise any particularly
> complex conflicts.
> 
> 
> diff --cc drivers/gpu/drm/i915/i915_mm.c
> index 9a777b0ff59b,25576fa73ff0..000000000000
> --- a/drivers/gpu/drm/i915/i915_mm.c
> +++ b/drivers/gpu/drm/i915/i915_mm.c
> @@@ -82,13 -46,8 +82,13 @@@ int remap_io_sg(struct vm_area_struct *
>   		unsigned long addr, unsigned long size,
>   		struct scatterlist *sgl, resource_size_t iobase)
>   {
>  -	unsigned long pfn, len, remapped = 0;
>  +	struct remap_pfn r = {
>  +		.mm = vma->vm_mm,
>  +		.prot = vma->vm_page_prot,
>  +		.sgt = __sgt_iter(sgl, use_dma(iobase)),
>  +		.iobase = iobase,
>  +	};
> - 	int err;
> + 	int err = 0;
>   
>   	/* We rely on prevalidation of the io-mapping to skip track_pfn(). */
>   	GEM_BUG_ON((vma->vm_flags & EXPECTED_FLAGS) != EXPECTED_FLAGS);

This is now a conflict between the drm tree and Linus' tree.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2021-05-21  1:45 UTC|newest]

Thread overview: 109+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-20  0:19 linux-next: manual merge of the drm-intel tree with Linus' tree Stephen Rothwell
2021-05-20  0:19 ` [Intel-gfx] " Stephen Rothwell
2021-05-20  0:19 ` Stephen Rothwell
2021-05-21  1:45 ` Stephen Rothwell [this message]
2021-05-21  1:45   ` [Intel-gfx] " Stephen Rothwell
2021-05-21  1:45   ` Stephen Rothwell
  -- strict thread matches above, loose matches on Subject: below --
2024-01-09  0:22 Stephen Rothwell
2024-01-09  0:22 ` Stephen Rothwell
2023-11-22  0:51 Stephen Rothwell
2023-11-22  0:51 ` Stephen Rothwell
2023-11-22  1:10 ` Stephen Rothwell
2023-11-22  1:10   ` Stephen Rothwell
2023-03-06 23:09 Stephen Rothwell
2023-03-06 23:09 ` Stephen Rothwell
2022-11-13 23:23 Stephen Rothwell
2022-11-13 23:23 ` Stephen Rothwell
2022-11-14  8:19 ` Hans de Goede
2022-11-14  8:19   ` Hans de Goede
2022-11-14 10:10   ` Jani Nikula
2022-11-14 10:10     ` Jani Nikula
2022-11-14 10:35     ` Hans de Goede
2022-11-14 10:35       ` Hans de Goede
2022-11-14 11:02       ` Jani Nikula
2022-11-14 11:02         ` Jani Nikula
2022-10-17 22:05 Stephen Rothwell
2022-10-17 22:05 ` Stephen Rothwell
2022-06-07 23:59 Stephen Rothwell
2022-06-07 23:59 ` Stephen Rothwell
2022-06-07 23:53 Stephen Rothwell
2022-06-07 23:53 ` Stephen Rothwell
2022-04-05  1:00 Stephen Rothwell
2022-04-05  1:00 ` Stephen Rothwell
2022-04-05  0:53 Stephen Rothwell
2022-04-05  0:53 ` Stephen Rothwell
2022-01-24 22:39 Stephen Rothwell
2022-01-24 22:39 ` Stephen Rothwell
2022-01-24 22:33 Stephen Rothwell
2022-01-24 22:33 ` Stephen Rothwell
2021-08-02 15:29 Mark Brown
2021-05-12  0:28 Stephen Rothwell
2021-05-12  0:28 ` Stephen Rothwell
2020-09-08  4:00 Stephen Rothwell
2020-09-08  4:00 ` Stephen Rothwell
2020-09-08  8:22 ` Hans de Goede
2020-09-08  8:22   ` Hans de Goede
2020-09-08 11:04   ` Stephen Rothwell
2020-09-08 11:04     ` Stephen Rothwell
2020-09-08 13:20     ` Hans de Goede
2020-09-08 13:20       ` Hans de Goede
2020-06-23  1:35 Stephen Rothwell
2020-06-23  1:35 ` Stephen Rothwell
2018-03-22  2:21 Stephen Rothwell
2018-03-22  2:21 ` Stephen Rothwell
2018-03-23  0:50 ` Stephen Rothwell
2018-03-23  0:50   ` Stephen Rothwell
2017-09-19  1:42 Stephen Rothwell
2016-09-16  0:38 Stephen Rothwell
2016-09-16  0:38 ` Stephen Rothwell
2016-09-08  2:08 Stephen Rothwell
2016-09-08  2:08 ` Stephen Rothwell
2016-05-31  1:06 Stephen Rothwell
2016-05-31  1:06 ` Stephen Rothwell
2016-05-31  1:00 Stephen Rothwell
2016-05-31  1:00 ` Stephen Rothwell
2015-12-22  1:03 Stephen Rothwell
2015-12-22  1:03 ` Stephen Rothwell
2015-11-19  0:23 Stephen Rothwell
2015-11-19  0:23 ` Stephen Rothwell
2015-09-29  1:20 Stephen Rothwell
2015-09-29  1:20 ` Stephen Rothwell
2015-09-29  1:20 Stephen Rothwell
2015-09-29  1:20 ` Stephen Rothwell
2015-09-17  0:13 Stephen Rothwell
2015-09-17  0:13 ` Stephen Rothwell
2015-07-09  1:02 Stephen Rothwell
2015-07-09  1:02 ` Stephen Rothwell
2015-04-29  1:15 Stephen Rothwell
2015-04-29  1:15 ` Stephen Rothwell
2014-09-08  4:32 Stephen Rothwell
2014-09-08  4:32 ` Stephen Rothwell
2013-12-18  2:50 Stephen Rothwell
2013-12-18  2:50 ` Stephen Rothwell
2013-12-13  0:58 Stephen Rothwell
2013-12-13  0:58 ` Stephen Rothwell
2013-09-18  1:25 Stephen Rothwell
2013-09-18  1:25 ` Stephen Rothwell
2013-09-18  1:20 Stephen Rothwell
2013-09-18  1:20 ` Stephen Rothwell
2013-06-26  3:54 Stephen Rothwell
2013-06-26  3:54 ` Stephen Rothwell
2013-06-17  3:32 Stephen Rothwell
2013-06-17  3:32 ` Stephen Rothwell
2013-06-17  3:25 Stephen Rothwell
2013-06-17  3:25 ` Stephen Rothwell
2013-05-21  1:58 Stephen Rothwell
2013-05-21  1:58 ` Stephen Rothwell
2013-05-07  1:27 Stephen Rothwell
2013-05-07  1:27 ` Stephen Rothwell
2013-05-07  8:43 ` Daniel Vetter
2013-05-07  8:43   ` Daniel Vetter
2013-05-08  0:11   ` Stephen Rothwell
2013-05-08  0:11     ` Stephen Rothwell
2013-04-03  2:43 Stephen Rothwell
2013-04-03  2:43 ` Stephen Rothwell
2013-04-03  8:31 ` Daniel Vetter
2013-04-02  2:46 Stephen Rothwell
2013-04-02  2:46 ` Stephen Rothwell
2013-03-04 23:23 Stephen Rothwell
2013-03-04 23:23 ` Stephen Rothwell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210521114517.4142ad73@canb.auug.org.au \
    --to=sfr@canb.auug.org.au \
    --cc=airlied@linux.ie \
    --cc=daniel.vetter@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=james.ausmus@intel.com \
    --cc=jani.nikula@linux.intel.com \
    --cc=joonas.lahtinen@linux.intel.com \
    --cc=jose.souza@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=rodrigo.vivi@intel.com \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.