All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 0/3] J7200: Add support for HS400 speed mode
@ 2021-05-25  9:38 Aswath Govindraju
  2021-05-25  9:38 ` [PATCH 1/3] mmc: sdhci_am654: Read ti, strobe-sel property from device tree Aswath Govindraju
                   ` (4 more replies)
  0 siblings, 5 replies; 7+ messages in thread
From: Aswath Govindraju @ 2021-05-25  9:38 UTC (permalink / raw)
  Cc: Kishon Vijay Abraham I, Aswath Govindraju, Lokesh Vutla,
	Peng Fan, Faiz Abbas, Suman Anna, Vignesh Raghavendra, u-boot

The following series of patches add support for HS400 speed mode on J7200
SoC.

For HS400 support to work, the following series of patches depend on,
https://patchwork.ozlabs.org/project/uboot/patch/20210405144428.12159-1-a-govindraju@ti.com/

Aswath Govindraju (3):
  mmc: sdhci_am654: Read ti,strobe-sel property from device tree
  arm: dts: k3-j7200-main: Add support for HS400 and update delay select
    values for MMCSD subsystems
  configs: j7200_evm_*_defconfig: Enable configs for HS400 support

 arch/arm/dts/k3-j7200-main.dtsi | 11 ++++++++++-
 configs/j7200_evm_a72_defconfig |  4 ++--
 configs/j7200_evm_r5_defconfig  |  2 +-
 drivers/mmc/am654_sdhci.c       |  1 +
 4 files changed, 14 insertions(+), 4 deletions(-)

-- 
2.17.1


^ permalink raw reply	[flat|nested] 7+ messages in thread

* [PATCH 1/3] mmc: sdhci_am654: Read ti, strobe-sel property from device tree
  2021-05-25  9:38 [PATCH 0/3] J7200: Add support for HS400 speed mode Aswath Govindraju
@ 2021-05-25  9:38 ` Aswath Govindraju
  2021-05-25 21:45   ` Jaehoon Chung
  2021-05-25  9:38 ` [PATCH 2/3] arm: dts: k3-j7200-main: Add support for HS400 and update delay select values for MMCSD subsystems Aswath Govindraju
                   ` (3 subsequent siblings)
  4 siblings, 1 reply; 7+ messages in thread
From: Aswath Govindraju @ 2021-05-25  9:38 UTC (permalink / raw)
  Cc: Kishon Vijay Abraham I, Aswath Govindraju, Lokesh Vutla,
	Peng Fan, Faiz Abbas, Suman Anna, Vignesh Raghavendra, u-boot

Read the strobe select value from the device tree property ti,strobe-sel,
required for HS400 speed mode

Fixes: a20008eabd95 ("mmc: am654_sdhci: Add Support for configuring PHY in J721e")
Signed-off-by: Aswath Govindraju <a-govindraju@ti.com>
---
 drivers/mmc/am654_sdhci.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/mmc/am654_sdhci.c b/drivers/mmc/am654_sdhci.c
index a86d96aacd2b..4305967d7845 100644
--- a/drivers/mmc/am654_sdhci.c
+++ b/drivers/mmc/am654_sdhci.c
@@ -619,6 +619,7 @@ static int am654_sdhci_of_to_plat(struct udevice *dev)
 		}
 	}
 
+	dev_read_u32(dev, "ti,strobe-sel", &plat->strb_sel);
 	dev_read_u32(dev, "ti,clkbuf-sel", &plat->clkbuf_sel);
 
 	ret = mmc_of_parse(dev, cfg);
-- 
2.17.1


^ permalink raw reply related	[flat|nested] 7+ messages in thread

* [PATCH 2/3] arm: dts: k3-j7200-main: Add support for HS400 and update delay select values for MMCSD subsystems
  2021-05-25  9:38 [PATCH 0/3] J7200: Add support for HS400 speed mode Aswath Govindraju
  2021-05-25  9:38 ` [PATCH 1/3] mmc: sdhci_am654: Read ti, strobe-sel property from device tree Aswath Govindraju
@ 2021-05-25  9:38 ` Aswath Govindraju
  2021-05-25  9:38 ` [PATCH 3/3] configs: j7200_evm_*_defconfig: Enable configs for HS400 support Aswath Govindraju
                   ` (2 subsequent siblings)
  4 siblings, 0 replies; 7+ messages in thread
From: Aswath Govindraju @ 2021-05-25  9:38 UTC (permalink / raw)
  Cc: Kishon Vijay Abraham I, Aswath Govindraju, Lokesh Vutla,
	Peng Fan, Faiz Abbas, Vignesh Raghavendra, Suman Anna, u-boot

HS400 speed mode is now supported in J7200 SoC[1]. Therefore add
mmc-hs400-1_8v tag in sdhci0 device tree node.

Also update the delay values for various speed modes supported, based on
the revised january 2021 J7200 datasheet[2].

[1] - section 12.3.6.1.1 MMCSD Features, in
      https://www.ti.com/lit/ug/spruiu1a/spruiu1a.pdf,
      (SPRUIU1A – JULY 2020 – REVISED JANUARY 2021)

[2] - https://www.ti.com/lit/ds/symlink/dra821u.pdf,
      (SPRSP57B – APRIL 2020 – REVISED JANUARY 2021)

Signed-off-by: Aswath Govindraju <a-govindraju@ti.com>
---
 arch/arm/dts/k3-j7200-main.dtsi | 11 ++++++++++-
 1 file changed, 10 insertions(+), 1 deletion(-)

diff --git a/arch/arm/dts/k3-j7200-main.dtsi b/arch/arm/dts/k3-j7200-main.dtsi
index 11314640750d..ae4f7896ef4b 100644
--- a/arch/arm/dts/k3-j7200-main.dtsi
+++ b/arch/arm/dts/k3-j7200-main.dtsi
@@ -428,10 +428,14 @@
 		ti,otap-del-sel-mmc-hs = <0x0>;
 		ti,otap-del-sel-ddr52 = <0x6>;
 		ti,otap-del-sel-hs200 = <0x8>;
-		ti,otap-del-sel-hs400 = <0x0>;
+		ti,otap-del-sel-hs400 = <0x5>;
+		ti,itap-del-sel-legacy = <0x10>;
+		ti,itap-del-sel-mmc-hs = <0xa>;
 		ti,strobe-sel = <0x77>;
+		ti,clkbuf-sel = <0x7>;
 		ti,trm-icp = <0x8>;
 		bus-width = <8>;
+		mmc-hs400-1_8v;
 		mmc-hs200-1_8v;
 		mmc-ddr-1_8v;
 		dma-coherent;
@@ -451,7 +455,12 @@
 		ti,otap-del-sel-sdr50 = <0xc>;
 		ti,otap-del-sel-sdr104 = <0x5>;
 		ti,otap-del-sel-ddr50 = <0xc>;
+		ti,itap-del-sel-legacy = <0x0>;
+		ti,itap-del-sel-sd-hs = <0x0>;
+		ti,itap-del-sel-sdr12 = <0x0>;
+		ti,itap-del-sel-sdr25 = <0x0>;
 		ti,clkbuf-sel = <0x7>;
+		ti,trm-icp = <0x8>;
 		dma-coherent;
 	};
 
-- 
2.17.1


^ permalink raw reply related	[flat|nested] 7+ messages in thread

* [PATCH 3/3] configs: j7200_evm_*_defconfig: Enable configs for HS400 support
  2021-05-25  9:38 [PATCH 0/3] J7200: Add support for HS400 speed mode Aswath Govindraju
  2021-05-25  9:38 ` [PATCH 1/3] mmc: sdhci_am654: Read ti, strobe-sel property from device tree Aswath Govindraju
  2021-05-25  9:38 ` [PATCH 2/3] arm: dts: k3-j7200-main: Add support for HS400 and update delay select values for MMCSD subsystems Aswath Govindraju
@ 2021-05-25  9:38 ` Aswath Govindraju
  2021-06-03  5:29 ` [PATCH 0/3] J7200: Add support for HS400 speed mode Lokesh Vutla
  2021-07-29  5:14 ` Lokesh Vutla
  4 siblings, 0 replies; 7+ messages in thread
From: Aswath Govindraju @ 2021-05-25  9:38 UTC (permalink / raw)
  Cc: Kishon Vijay Abraham I, Aswath Govindraju, Lokesh Vutla,
	Peng Fan, Faiz Abbas, Vignesh Raghavendra, Suman Anna, u-boot

Enable configs to add support for HS400 speed mode.

Signed-off-by: Aswath Govindraju <a-govindraju@ti.com>
---
 configs/j7200_evm_a72_defconfig | 4 ++--
 configs/j7200_evm_r5_defconfig  | 2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/configs/j7200_evm_a72_defconfig b/configs/j7200_evm_a72_defconfig
index b204c7a73e98..1ceba8b52513 100644
--- a/configs/j7200_evm_a72_defconfig
+++ b/configs/j7200_evm_a72_defconfig
@@ -118,8 +118,8 @@ CONFIG_K3_SEC_PROXY=y
 CONFIG_SUPPORT_EMMC_BOOT=y
 CONFIG_MMC_IO_VOLTAGE=y
 CONFIG_MMC_UHS_SUPPORT=y
-CONFIG_MMC_HS200_SUPPORT=y
-CONFIG_SPL_MMC_HS200_SUPPORT=y
+CONFIG_MMC_HS400_SUPPORT=y
+CONFIG_SPL_MMC_HS400_SUPPORT=y
 CONFIG_MMC_SDHCI=y
 CONFIG_MMC_SDHCI_ADMA=y
 CONFIG_SPL_MMC_SDHCI_ADMA=y
diff --git a/configs/j7200_evm_r5_defconfig b/configs/j7200_evm_r5_defconfig
index 08fad3e04b18..96394d5d54d3 100644
--- a/configs/j7200_evm_r5_defconfig
+++ b/configs/j7200_evm_r5_defconfig
@@ -88,7 +88,7 @@ CONFIG_DM_MAILBOX=y
 CONFIG_K3_SEC_PROXY=y
 CONFIG_FS_LOADER=y
 CONFIG_SUPPORT_EMMC_BOOT=y
-CONFIG_SPL_MMC_HS200_SUPPORT=y
+CONFIG_SPL_MMC_HS400_SUPPORT=y
 CONFIG_MMC_SDHCI=y
 CONFIG_SPL_MMC_SDHCI_ADMA=y
 CONFIG_MMC_SDHCI_AM654=y
-- 
2.17.1


^ permalink raw reply related	[flat|nested] 7+ messages in thread

* Re: [PATCH 1/3] mmc: sdhci_am654: Read ti, strobe-sel property from device tree
  2021-05-25  9:38 ` [PATCH 1/3] mmc: sdhci_am654: Read ti, strobe-sel property from device tree Aswath Govindraju
@ 2021-05-25 21:45   ` Jaehoon Chung
  0 siblings, 0 replies; 7+ messages in thread
From: Jaehoon Chung @ 2021-05-25 21:45 UTC (permalink / raw)
  To: Aswath Govindraju
  Cc: Kishon Vijay Abraham I, Lokesh Vutla, Peng Fan, Faiz Abbas,
	Suman Anna, Vignesh Raghavendra, u-boot

On 5/25/21 6:38 PM, Aswath Govindraju wrote:
> Read the strobe select value from the device tree property ti,strobe-sel,
> required for HS400 speed mode
> 
> Fixes: a20008eabd95 ("mmc: am654_sdhci: Add Support for configuring PHY in J721e")
> Signed-off-by: Aswath Govindraju <a-govindraju@ti.com>

Reviewed-by: Jaehoon Chung <jh80.chung@samsung.com>

Best Regards,
Jaehoon Chung

> ---
>  drivers/mmc/am654_sdhci.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/mmc/am654_sdhci.c b/drivers/mmc/am654_sdhci.c
> index a86d96aacd2b..4305967d7845 100644
> --- a/drivers/mmc/am654_sdhci.c
> +++ b/drivers/mmc/am654_sdhci.c
> @@ -619,6 +619,7 @@ static int am654_sdhci_of_to_plat(struct udevice *dev)
>  		}
>  	}
>  
> +	dev_read_u32(dev, "ti,strobe-sel", &plat->strb_sel);
>  	dev_read_u32(dev, "ti,clkbuf-sel", &plat->clkbuf_sel);
>  
>  	ret = mmc_of_parse(dev, cfg);
> 


^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH 0/3] J7200: Add support for HS400 speed mode
  2021-05-25  9:38 [PATCH 0/3] J7200: Add support for HS400 speed mode Aswath Govindraju
                   ` (2 preceding siblings ...)
  2021-05-25  9:38 ` [PATCH 3/3] configs: j7200_evm_*_defconfig: Enable configs for HS400 support Aswath Govindraju
@ 2021-06-03  5:29 ` Lokesh Vutla
  2021-07-29  5:14 ` Lokesh Vutla
  4 siblings, 0 replies; 7+ messages in thread
From: Lokesh Vutla @ 2021-06-03  5:29 UTC (permalink / raw)
  To: Aswath Govindraju
  Cc: Kishon Vijay Abraham I, Peng Fan, Faiz Abbas, Suman Anna,
	Vignesh Raghavendra, u-boot



On 25/05/21 3:08 pm, Aswath Govindraju wrote:
> The following series of patches add support for HS400 speed mode on J7200
> SoC.
> 
> For HS400 support to work, the following series of patches depend on,
> https://patchwork.ozlabs.org/project/uboot/patch/20210405144428.12159-1-a-govindraju@ti.com/

Can you ping me once the above patch is merged?

Thanks and regards,
Lokesh


^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH 0/3] J7200: Add support for HS400 speed mode
  2021-05-25  9:38 [PATCH 0/3] J7200: Add support for HS400 speed mode Aswath Govindraju
                   ` (3 preceding siblings ...)
  2021-06-03  5:29 ` [PATCH 0/3] J7200: Add support for HS400 speed mode Lokesh Vutla
@ 2021-07-29  5:14 ` Lokesh Vutla
  4 siblings, 0 replies; 7+ messages in thread
From: Lokesh Vutla @ 2021-07-29  5:14 UTC (permalink / raw)
  To: Aswath Govindraju
  Cc: Lokesh Vutla, Suman Anna, Peng Fan, Kishon Vijay Abraham I,
	u-boot, Vignesh Raghavendra, Faiz Abbas

On Tue, 25 May 2021 15:08:22 +0530, Aswath Govindraju wrote:
> The following series of patches add support for HS400 speed mode on J7200
> SoC.
> 
> For HS400 support to work, the following series of patches depend on,
> https://patchwork.ozlabs.org/project/uboot/patch/20210405144428.12159-1-a-govindraju@ti.com/
> 
> Aswath Govindraju (3):
>   mmc: sdhci_am654: Read ti,strobe-sel property from device tree
>   arm: dts: k3-j7200-main: Add support for HS400 and update delay select
>     values for MMCSD subsystems
>   configs: j7200_evm_*_defconfig: Enable configs for HS400 support
> 
> [...]
 
Applied to https://source.denx.de/u-boot/custodians/u-boot-ti.git for-rc, thanks!
[1/3] mmc: sdhci_am654: Read ti, strobe-sel property from device tree
      https://source.denx.de/u-boot/custodians/u-boot-ti/-/commit/46077ef251
[2/3] arm: dts: k3-j7200-main: Add support for HS400 and update delay select values for MMCSD subsystems
      https://source.denx.de/u-boot/custodians/u-boot-ti/-/commit/455f9dddc8
[3/3] configs: j7200_evm_*_defconfig: Enable configs for HS400 support
      https://source.denx.de/u-boot/custodians/u-boot-ti/-/commit/f490d359d7
 
--
Thanks and Regards,
Lokesh

^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2021-07-29  5:14 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-25  9:38 [PATCH 0/3] J7200: Add support for HS400 speed mode Aswath Govindraju
2021-05-25  9:38 ` [PATCH 1/3] mmc: sdhci_am654: Read ti, strobe-sel property from device tree Aswath Govindraju
2021-05-25 21:45   ` Jaehoon Chung
2021-05-25  9:38 ` [PATCH 2/3] arm: dts: k3-j7200-main: Add support for HS400 and update delay select values for MMCSD subsystems Aswath Govindraju
2021-05-25  9:38 ` [PATCH 3/3] configs: j7200_evm_*_defconfig: Enable configs for HS400 support Aswath Govindraju
2021-06-03  5:29 ` [PATCH 0/3] J7200: Add support for HS400 speed mode Lokesh Vutla
2021-07-29  5:14 ` Lokesh Vutla

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.