All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Paul A. Clarke" <pc@us.ibm.com>
To: Kajol Jain <kjain@linux.ibm.com>,
	Nageswara Sastry <rnsastry@linux.ibm.com>
Cc: acme@kernel.org, maddy@linux.vnet.ibm.com,
	atrajeev@linux.vnet.ibm.com, linux-kernel@vger.kernel.org,
	jolsa@redhat.com, mpe@ellerman.id.au,
	ravi.bangoria@linux.ibm.com, linux-perf-users@vger.kernel.org,
	linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH] perf vendor events: Fix eventcode of power10 json events
Date: Tue, 25 May 2021 10:27:36 -0500	[thread overview]
Message-ID: <20210525152736.GB2135213@li-24c3614c-2adc-11b2-a85c-85f334518bdb.ibm.com> (raw)
In-Reply-To: <20210525144215.GA2135213@li-24c3614c-2adc-11b2-a85c-85f334518bdb.ibm.com>

On Tue, May 25, 2021 at 09:42:15AM -0500, Paul A. Clarke wrote:
> On Tue, May 25, 2021 at 12:07:23PM +0530, Kajol Jain wrote:
> > Fixed the eventcode values in the power10 json event files to append
> > "0x" since these are hexadecimal values.
> > Patch also changes event description of PM_EXEC_STALL_LOAD_FINISH and
> > PM_EXEC_STALL_NTC_FLUSH event and move some events to correct files.
> > 
> > Fixes: 32daa5d7899e ("perf vendor events: Initial JSON/events list for power10 platform")
> > Signed-off-by: Kajol Jain <kjain@linux.ibm.com>
> 
> I checked that everything that was "removed" was actually just moved
> somewhere else, that all the added EventCodes indeed had '0x', the
> number of EventCodes added matched the number removed, and that the
> additional text added seemed reasonable.  LGTM.
> 
> Reviewed-by: Paul A. Clarke <pc@us.ibm.com>

I lost the original message, but Nageswara Sastry said:
> 1. Extracted all the 244 events from the patch.
> 2. Check them in 'perf list' - all 244 events found
> 3. Ran all the events with 'perf stat -e "event name" sleep 1', all ran fine.
>     No errors were seen in 'dmesg'

I count 255 events.

PC

WARNING: multiple messages have this Message-ID (diff)
From: "Paul A. Clarke" <pc@us.ibm.com>
To: Kajol Jain <kjain@linux.ibm.com>,
	Nageswara Sastry <rnsastry@linux.ibm.com>
Cc: ravi.bangoria@linux.ibm.com, atrajeev@linux.vnet.ibm.com,
	linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org,
	acme@kernel.org, linux-perf-users@vger.kernel.org,
	maddy@linux.vnet.ibm.com, jolsa@redhat.com
Subject: Re: [PATCH] perf vendor events: Fix eventcode of power10 json events
Date: Tue, 25 May 2021 10:27:36 -0500	[thread overview]
Message-ID: <20210525152736.GB2135213@li-24c3614c-2adc-11b2-a85c-85f334518bdb.ibm.com> (raw)
In-Reply-To: <20210525144215.GA2135213@li-24c3614c-2adc-11b2-a85c-85f334518bdb.ibm.com>

On Tue, May 25, 2021 at 09:42:15AM -0500, Paul A. Clarke wrote:
> On Tue, May 25, 2021 at 12:07:23PM +0530, Kajol Jain wrote:
> > Fixed the eventcode values in the power10 json event files to append
> > "0x" since these are hexadecimal values.
> > Patch also changes event description of PM_EXEC_STALL_LOAD_FINISH and
> > PM_EXEC_STALL_NTC_FLUSH event and move some events to correct files.
> > 
> > Fixes: 32daa5d7899e ("perf vendor events: Initial JSON/events list for power10 platform")
> > Signed-off-by: Kajol Jain <kjain@linux.ibm.com>
> 
> I checked that everything that was "removed" was actually just moved
> somewhere else, that all the added EventCodes indeed had '0x', the
> number of EventCodes added matched the number removed, and that the
> additional text added seemed reasonable.  LGTM.
> 
> Reviewed-by: Paul A. Clarke <pc@us.ibm.com>

I lost the original message, but Nageswara Sastry said:
> 1. Extracted all the 244 events from the patch.
> 2. Check them in 'perf list' - all 244 events found
> 3. Ran all the events with 'perf stat -e "event name" sleep 1', all ran fine.
>     No errors were seen in 'dmesg'

I count 255 events.

PC

  reply	other threads:[~2021-05-25 15:28 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-25  6:37 [PATCH] perf vendor events: Fix eventcode of power10 json events Kajol Jain
2021-05-25  6:37 ` Kajol Jain
2021-05-25 13:18 ` Nageswara Sastry
2021-05-25 13:18   ` Nageswara Sastry
2021-05-25 14:42 ` Paul A. Clarke
2021-05-25 14:42   ` Paul A. Clarke
2021-05-25 15:27   ` Paul A. Clarke [this message]
2021-05-25 15:27     ` Paul A. Clarke
2021-05-26  6:12     ` Nageswara Sastry
2021-05-26  6:12       ` Nageswara Sastry
2021-05-28  7:56       ` kajoljain
2021-05-28  7:56         ` kajoljain
2021-05-28 12:21         ` Arnaldo Carvalho de Melo
2021-05-28 12:21           ` Arnaldo Carvalho de Melo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210525152736.GB2135213@li-24c3614c-2adc-11b2-a85c-85f334518bdb.ibm.com \
    --to=pc@us.ibm.com \
    --cc=acme@kernel.org \
    --cc=atrajeev@linux.vnet.ibm.com \
    --cc=jolsa@redhat.com \
    --cc=kjain@linux.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=maddy@linux.vnet.ibm.com \
    --cc=mpe@ellerman.id.au \
    --cc=ravi.bangoria@linux.ibm.com \
    --cc=rnsastry@linux.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.