* [linux-platform-drivers-x86:review-hans 40/42] drivers/platform/x86/firmware_attributes_class.c:11:5: sparse: sparse: symbol 'fw_attr_inuse' was not declared. Should it be static?
@ 2021-06-03 15:39 kernel test robot
2021-06-03 15:39 ` [RFC PATCH linux-platform-drivers-x86] platform/x86: dell-wmi-sysman: fw_attr_inuse can be static kernel test robot
0 siblings, 1 reply; 3+ messages in thread
From: kernel test robot @ 2021-06-03 15:39 UTC (permalink / raw)
To: kbuild-all
[-- Attachment #1: Type: text/plain, Size: 1492 bytes --]
tree: https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git review-hans
head: 7fac4861a9747efe442a9c4b20cec4133b9ceb0d
commit: d97de653d18f689d590021599c79d34b646b594a [40/42] platform/x86: dell-wmi-sysman: Use firmware_attributes_class helper
config: i386-randconfig-s002-20210603 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce:
# apt-get install sparse
# sparse version: v0.6.3-341-g8af24329-dirty
# https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/commit/?id=d97de653d18f689d590021599c79d34b646b594a
git remote add linux-platform-drivers-x86 https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git
git fetch --no-tags linux-platform-drivers-x86 review-hans
git checkout d97de653d18f689d590021599c79d34b646b594a
# save the attached .config to linux build tree
make W=1 C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' W=1 ARCH=i386
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
sparse warnings: (new ones prefixed by >>)
>> drivers/platform/x86/firmware_attributes_class.c:11:5: sparse: sparse: symbol 'fw_attr_inuse' was not declared. Should it be static?
Please review and possibly fold the followup patch.
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 41044 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* [RFC PATCH linux-platform-drivers-x86] platform/x86: dell-wmi-sysman: fw_attr_inuse can be static
2021-06-03 15:39 [linux-platform-drivers-x86:review-hans 40/42] drivers/platform/x86/firmware_attributes_class.c:11:5: sparse: sparse: symbol 'fw_attr_inuse' was not declared. Should it be static? kernel test robot
@ 2021-06-03 15:39 ` kernel test robot
2021-06-03 17:04 ` Hans de Goede
0 siblings, 1 reply; 3+ messages in thread
From: kernel test robot @ 2021-06-03 15:39 UTC (permalink / raw)
To: kbuild-all
[-- Attachment #1: Type: text/plain, Size: 825 bytes --]
drivers/platform/x86/firmware_attributes_class.c:11:5: warning: symbol 'fw_attr_inuse' was not declared. Should it be static?
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: kernel test robot <lkp@intel.com>
---
firmware_attributes_class.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/platform/x86/firmware_attributes_class.c b/drivers/platform/x86/firmware_attributes_class.c
index d62ec3d71ede3..fafe8eaf6e3e4 100644
--- a/drivers/platform/x86/firmware_attributes_class.c
+++ b/drivers/platform/x86/firmware_attributes_class.c
@@ -8,7 +8,7 @@
#include "firmware_attributes_class.h"
static DEFINE_MUTEX(fw_attr_lock);
-int fw_attr_inuse;
+static int fw_attr_inuse;
static struct class firmware_attributes_class = {
.name = "firmware-attributes",
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [RFC PATCH linux-platform-drivers-x86] platform/x86: dell-wmi-sysman: fw_attr_inuse can be static
2021-06-03 15:39 ` [RFC PATCH linux-platform-drivers-x86] platform/x86: dell-wmi-sysman: fw_attr_inuse can be static kernel test robot
@ 2021-06-03 17:04 ` Hans de Goede
0 siblings, 0 replies; 3+ messages in thread
From: Hans de Goede @ 2021-06-03 17:04 UTC (permalink / raw)
To: kbuild-all
[-- Attachment #1: Type: text/plain, Size: 1461 bytes --]
Hi,
On 6/3/21 5:39 PM, kernel test robot wrote:
> drivers/platform/x86/firmware_attributes_class.c:11:5: warning: symbol 'fw_attr_inuse' was not declared. Should it be static?
>
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: kernel test robot <lkp@intel.com>
Thank you for your patch, I've applied this patch to my review-hans
branch:
https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans
Note it will show up in my review-hans branch once I've pushed my
local branch there, which might take a while.
Once I've run some tests on this branch the patches there will be
added to the platform-drivers-x86/for-next branch and eventually
will be included in the pdx86 pull-request to Linus for the next
merge-window.
Regards,
Hans
> ---
> firmware_attributes_class.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/platform/x86/firmware_attributes_class.c b/drivers/platform/x86/firmware_attributes_class.c
> index d62ec3d71ede3..fafe8eaf6e3e4 100644
> --- a/drivers/platform/x86/firmware_attributes_class.c
> +++ b/drivers/platform/x86/firmware_attributes_class.c
> @@ -8,7 +8,7 @@
> #include "firmware_attributes_class.h"
>
> static DEFINE_MUTEX(fw_attr_lock);
> -int fw_attr_inuse;
> +static int fw_attr_inuse;
>
> static struct class firmware_attributes_class = {
> .name = "firmware-attributes",
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-06-03 17:04 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-03 15:39 [linux-platform-drivers-x86:review-hans 40/42] drivers/platform/x86/firmware_attributes_class.c:11:5: sparse: sparse: symbol 'fw_attr_inuse' was not declared. Should it be static? kernel test robot
2021-06-03 15:39 ` [RFC PATCH linux-platform-drivers-x86] platform/x86: dell-wmi-sysman: fw_attr_inuse can be static kernel test robot
2021-06-03 17:04 ` Hans de Goede
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.