All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tyler Hicks <tyhicks@linux.microsoft.com>
To: Jens Wiklander <jens.wiklander@linaro.org>
Cc: linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	op-tee@lists.trustedfirmware.org,
	Sumit Garg <sumit.garg@linaro.org>,
	Herbert Xu <herbert@gondor.apana.org.au>,
	Sakkinen <jarkko.sakkinen@linux.intel.com>,
	Sasha Levin <sashal@kernel.org>,
	Thirupathaiah Annapureddy <thiruan@microsoft.com>,
	Vikas Gupta <vikas.gupta@broadcom.com>,
	"David S . Miller" <davem@davemloft.net>
Subject: Re: [PATCH 4/7] hwrng: optee-rng: use tee_shm_alloc_kernel_buf()
Date: Wed, 9 Jun 2021 09:51:53 -0500	[thread overview]
Message-ID: <20210609145153.GH4910@sequoia> (raw)
In-Reply-To: <20210609102324.2222332-5-jens.wiklander@linaro.org>

On 2021-06-09 12:23:21, Jens Wiklander wrote:
> Uses the new simplified tee_shm_alloc_kernel_buf() function instead of
> the old deprecated tee_shm_alloc() function which required specific
> TEE_SHM-flags.
> 
> Signed-off-by: Jens Wiklander <jens.wiklander@linaro.org>

Reviewed-by: Tyler Hicks <tyhicks@linux.microsoft.com>

Tyler

> ---
>  drivers/char/hw_random/optee-rng.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/char/hw_random/optee-rng.c b/drivers/char/hw_random/optee-rng.c
> index 135a82590923..a948c0727b2b 100644
> --- a/drivers/char/hw_random/optee-rng.c
> +++ b/drivers/char/hw_random/optee-rng.c
> @@ -145,10 +145,10 @@ static int optee_rng_init(struct hwrng *rng)
>  	struct optee_rng_private *pvt_data = to_optee_rng_private(rng);
>  	struct tee_shm *entropy_shm_pool = NULL;
>  
> -	entropy_shm_pool = tee_shm_alloc(pvt_data->ctx, MAX_ENTROPY_REQ_SZ,
> -					 TEE_SHM_MAPPED | TEE_SHM_DMA_BUF);
> +	entropy_shm_pool = tee_shm_alloc_kernel_buf(pvt_data->ctx,
> +						    MAX_ENTROPY_REQ_SZ);
>  	if (IS_ERR(entropy_shm_pool)) {
> -		dev_err(pvt_data->dev, "tee_shm_alloc failed\n");
> +		dev_err(pvt_data->dev, "tee_shm_alloc_kernel_buf failed\n");
>  		return PTR_ERR(entropy_shm_pool);
>  	}
>  
> -- 
> 2.31.1
> 

WARNING: multiple messages have this Message-ID (diff)
From: Tyler Hicks <tyhicks@linux.microsoft.com>
To: Jens Wiklander <jens.wiklander@linaro.org>
Cc: linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	op-tee@lists.trustedfirmware.org,
	Sumit Garg <sumit.garg@linaro.org>,
	Herbert Xu <herbert@gondor.apana.org.au>,
	Sakkinen <jarkko.sakkinen@linux.intel.com>,
	Sasha Levin <sashal@kernel.org>,
	Thirupathaiah Annapureddy <thiruan@microsoft.com>,
	Vikas Gupta <vikas.gupta@broadcom.com>,
	"David S . Miller" <davem@davemloft.net>
Subject: Re: [PATCH 4/7] hwrng: optee-rng: use tee_shm_alloc_kernel_buf()
Date: Wed, 9 Jun 2021 09:51:53 -0500	[thread overview]
Message-ID: <20210609145153.GH4910@sequoia> (raw)
In-Reply-To: <20210609102324.2222332-5-jens.wiklander@linaro.org>

On 2021-06-09 12:23:21, Jens Wiklander wrote:
> Uses the new simplified tee_shm_alloc_kernel_buf() function instead of
> the old deprecated tee_shm_alloc() function which required specific
> TEE_SHM-flags.
> 
> Signed-off-by: Jens Wiklander <jens.wiklander@linaro.org>

Reviewed-by: Tyler Hicks <tyhicks@linux.microsoft.com>

Tyler

> ---
>  drivers/char/hw_random/optee-rng.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/char/hw_random/optee-rng.c b/drivers/char/hw_random/optee-rng.c
> index 135a82590923..a948c0727b2b 100644
> --- a/drivers/char/hw_random/optee-rng.c
> +++ b/drivers/char/hw_random/optee-rng.c
> @@ -145,10 +145,10 @@ static int optee_rng_init(struct hwrng *rng)
>  	struct optee_rng_private *pvt_data = to_optee_rng_private(rng);
>  	struct tee_shm *entropy_shm_pool = NULL;
>  
> -	entropy_shm_pool = tee_shm_alloc(pvt_data->ctx, MAX_ENTROPY_REQ_SZ,
> -					 TEE_SHM_MAPPED | TEE_SHM_DMA_BUF);
> +	entropy_shm_pool = tee_shm_alloc_kernel_buf(pvt_data->ctx,
> +						    MAX_ENTROPY_REQ_SZ);
>  	if (IS_ERR(entropy_shm_pool)) {
> -		dev_err(pvt_data->dev, "tee_shm_alloc failed\n");
> +		dev_err(pvt_data->dev, "tee_shm_alloc_kernel_buf failed\n");
>  		return PTR_ERR(entropy_shm_pool);
>  	}
>  
> -- 
> 2.31.1
> 

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2021-06-09 14:52 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-09 10:23 [PATCH 0/7] tee: shared memory updates Jens Wiklander
2021-06-09 10:23 ` Jens Wiklander
2021-06-09 10:23 ` [PATCH 1/7] tee: remove unused tee_shm_pool_alloc_res_mem() Jens Wiklander
2021-06-09 10:23   ` Jens Wiklander
2021-06-09 14:03   ` Tyler Hicks
2021-06-09 14:03     ` Tyler Hicks
2021-06-09 10:23 ` [PATCH 2/7] tee: simplify shm pool handling Jens Wiklander
2021-06-09 10:23   ` Jens Wiklander
2021-06-09 14:50   ` Tyler Hicks
2021-06-09 14:50     ` Tyler Hicks
2021-06-10  9:01     ` Jens Wiklander
2021-06-10  9:01       ` Jens Wiklander
2021-06-09 10:23 ` [PATCH 3/7] tee: add tee_shm_alloc_kernel_buf() Jens Wiklander
2021-06-09 10:23   ` Jens Wiklander
2021-06-09 14:51   ` Tyler Hicks
2021-06-09 14:51     ` Tyler Hicks
2021-06-09 10:23 ` [PATCH 4/7] hwrng: optee-rng: use tee_shm_alloc_kernel_buf() Jens Wiklander
2021-06-09 10:23   ` Jens Wiklander
2021-06-09 14:51   ` Tyler Hicks [this message]
2021-06-09 14:51     ` Tyler Hicks
2021-06-09 10:23 ` [PATCH 5/7] tpm_ftpm_tee: " Jens Wiklander
2021-06-09 10:23   ` Jens Wiklander
2021-06-09 14:53   ` Tyler Hicks
2021-06-09 14:53     ` Tyler Hicks
2021-06-09 10:23 ` [PATCH 6/7] firmware: tee_bnxt: " Jens Wiklander
2021-06-09 10:23   ` Jens Wiklander
2021-06-09 14:58   ` Tyler Hicks
2021-06-09 14:58     ` Tyler Hicks
2021-06-10  9:08     ` Jens Wiklander
2021-06-10  9:08       ` Jens Wiklander
2021-06-09 10:23 ` [PATCH 7/7] tee: replace tee_shm_alloc() Jens Wiklander
2021-06-09 10:23   ` Jens Wiklander
2021-06-09 15:32   ` Tyler Hicks
2021-06-09 15:32     ` Tyler Hicks
2021-06-09 15:38     ` Tyler Hicks
2021-06-09 15:38       ` Tyler Hicks
2021-06-11  7:42     ` Jens Wiklander
2021-06-11  7:42       ` Jens Wiklander

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210609145153.GH4910@sequoia \
    --to=tyhicks@linux.microsoft.com \
    --cc=davem@davemloft.net \
    --cc=herbert@gondor.apana.org.au \
    --cc=jarkko.sakkinen@linux.intel.com \
    --cc=jens.wiklander@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=op-tee@lists.trustedfirmware.org \
    --cc=sashal@kernel.org \
    --cc=sumit.garg@linaro.org \
    --cc=thiruan@microsoft.com \
    --cc=vikas.gupta@broadcom.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.