* [Intel-wired-lan] [PATCH net v1] igb: Fix position of assignment to *ring
2021-06-11 22:42 [Intel-wired-lan] [PATCH net v1] igb: Fix position of assignment to *ring =?unknown-8bit?q?J=C4=99drzej?= Jagielski
@ 2021-06-10 18:07 ` Vinicius Costa Gomes
2021-06-25 22:38 ` Brelinski, TonyX
1 sibling, 0 replies; 3+ messages in thread
From: Vinicius Costa Gomes @ 2021-06-10 18:07 UTC (permalink / raw)
To: intel-wired-lan
Hi,
J?drzej Jagielski <jedrzej.jagielski@intel.com> writes:
> Assignment to *ring should be done after correctness check of the
> argument queue.
>
> Fixes: 91db364236c8 ("igb: Refactor igb_configure_cbs()")
> Signed-off-by: Jedrzej Jagielski <jedrzej.jagielski@intel.com>
> ---
Acked-by: Vinicius Costa Gomes <vinicius.gomes@intel.com>
--
Vinicius
^ permalink raw reply [flat|nested] 3+ messages in thread
* [Intel-wired-lan] [PATCH net v1] igb: Fix position of assignment to *ring
@ 2021-06-11 22:42 =?unknown-8bit?q?J=C4=99drzej?= Jagielski
2021-06-10 18:07 ` Vinicius Costa Gomes
2021-06-25 22:38 ` Brelinski, TonyX
0 siblings, 2 replies; 3+ messages in thread
From: =?unknown-8bit?q?J=C4=99drzej?= Jagielski @ 2021-06-11 22:42 UTC (permalink / raw)
To: intel-wired-lan
Assignment to *ring should be done after correctness check of the
argument queue.
Fixes: 91db364236c8 ("igb: Refactor igb_configure_cbs()")
Signed-off-by: Jedrzej Jagielski <jedrzej.jagielski@intel.com>
---
drivers/net/ethernet/intel/igb/igb_main.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/intel/igb/igb_main.c b/drivers/net/ethernet/intel/igb/igb_main.c
index e6fa1e3c8..e49b2bda1 100644
--- a/drivers/net/ethernet/intel/igb/igb_main.c
+++ b/drivers/net/ethernet/intel/igb/igb_main.c
@@ -1683,14 +1683,15 @@ static bool is_any_txtime_enabled(struct igb_adapter *adapter)
**/
static void igb_config_tx_modes(struct igb_adapter *adapter, int queue)
{
- struct igb_ring *ring = adapter->tx_ring[queue];
struct net_device *netdev = adapter->netdev;
struct e1000_hw *hw = &adapter->hw;
+ struct igb_ring *ring;
u32 tqavcc, tqavctrl;
u16 value;
WARN_ON(hw->mac.type != e1000_i210);
WARN_ON(queue < 0 || queue > 1);
+ ring = adapter->tx_ring[queue];
/* If any of the Qav features is enabled, configure queues as SR and
* with HIGH PRIO. If none is, then configure them with LOW PRIO and
--
2.27.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [Intel-wired-lan] [PATCH net v1] igb: Fix position of assignment to *ring
2021-06-11 22:42 [Intel-wired-lan] [PATCH net v1] igb: Fix position of assignment to *ring =?unknown-8bit?q?J=C4=99drzej?= Jagielski
2021-06-10 18:07 ` Vinicius Costa Gomes
@ 2021-06-25 22:38 ` Brelinski, TonyX
1 sibling, 0 replies; 3+ messages in thread
From: Brelinski, TonyX @ 2021-06-25 22:38 UTC (permalink / raw)
To: intel-wired-lan
> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@osuosl.org> On Behalf Of
> Jedrzej Jagielski
> Sent: Friday, June 11, 2021 3:42 PM
> To: intel-wired-lan at lists.osuosl.org
> Cc: Jagielski, Jedrzej <jedrzej.jagielski@intel.com>
> Subject: [Intel-wired-lan] [PATCH net v1] igb: Fix position of assignment to
> *ring
>
> Assignment to *ring should be done after correctness check of the argument
> queue.
>
> Fixes: 91db364236c8 ("igb: Refactor igb_configure_cbs()")
> Signed-off-by: Jedrzej Jagielski <jedrzej.jagielski@intel.com>
> ---
> drivers/net/ethernet/intel/igb/igb_main.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
Tested-by: Tony Brelinski <tonyx.brelinski@intel.com> (A Contingent Worker at Intel)
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-06-25 22:38 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-11 22:42 [Intel-wired-lan] [PATCH net v1] igb: Fix position of assignment to *ring =?unknown-8bit?q?J=C4=99drzej?= Jagielski
2021-06-10 18:07 ` Vinicius Costa Gomes
2021-06-25 22:38 ` Brelinski, TonyX
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.