From: Zhihao Cheng <chengzhihao1@huawei.com> To: <miquel.raynal@bootlin.com>, <richard@nod.at>, <vigneshr@ti.com> Cc: <linux-mtd@lists.infradead.org>, <linux-kernel@vger.kernel.org>, <chengzhihao1@huawei.com>, <yukuai3@huawei.com> Subject: [PATCH 0/6] Fix deadlock in ftl formating on mtd Date: Sun, 13 Jun 2021 19:30:29 +0800 [thread overview] Message-ID: <20210613113035.2329421-1-chengzhihao1@huawei.com> (raw) There is an AA-deadlock problem while formating mtd device to generate a ftl device. Fix it by reverting "mtd: allow to unload the mtdtrans module if its block devices aren't open" recommended in [1]. [<0>] blktrans_open+0x47/0x340 LOCK(mtd_table_mutex) [<0>] __blkdev_get+0x5b/0x3e0 [<0>] blkdev_get_by_dev+0x18f/0x370 [<0>] __device_add_disk+0x2db/0x700 [<0>] device_add_disk+0x17/0x20 [<0>] add_mtd_blktrans_dev+0x39e/0x6d0 [<0>] ftl_add_mtd+0x792/0x908 [ftl] [<0>] register_mtd_blktrans+0xfb/0x170 LOCK(mtd_table_mutex) [<0>] ftl_tr_init+0x18/0x1000 [ftl] [<0>] do_one_initcall+0x71/0x330 [<0>] do_init_module+0xa6/0x350 [1] http://lists.infradead.org/pipermail/linux-mtd/2017-March/072899.html Zhihao Cheng (6): Revert "mtd: blkdevs: fix potential deadlock + lockdep warnings" Revert "mtd: fix: avoid race condition when accessing mtd->usecount" Revert "mtd: mtd_blkdevs: don't increase 'open' count on error path" Revert "mtd: mtd_blkdevs: fix error path in blktrans_open" Revert "mtd: Remove redundant mutex from mtd_blkdevs.c" Revert "mtd: allow to unload the mtdtrans module if its block devices aren't open" drivers/mtd/mtd_blkdevs.c | 77 +++++++++++++++------------------------ 1 file changed, 30 insertions(+), 47 deletions(-) -- 2.31.1
WARNING: multiple messages have this Message-ID (diff)
From: Zhihao Cheng <chengzhihao1@huawei.com> To: <miquel.raynal@bootlin.com>, <richard@nod.at>, <vigneshr@ti.com> Cc: <linux-mtd@lists.infradead.org>, <linux-kernel@vger.kernel.org>, <chengzhihao1@huawei.com>, <yukuai3@huawei.com> Subject: [PATCH 0/6] Fix deadlock in ftl formating on mtd Date: Sun, 13 Jun 2021 19:30:29 +0800 [thread overview] Message-ID: <20210613113035.2329421-1-chengzhihao1@huawei.com> (raw) There is an AA-deadlock problem while formating mtd device to generate a ftl device. Fix it by reverting "mtd: allow to unload the mtdtrans module if its block devices aren't open" recommended in [1]. [<0>] blktrans_open+0x47/0x340 LOCK(mtd_table_mutex) [<0>] __blkdev_get+0x5b/0x3e0 [<0>] blkdev_get_by_dev+0x18f/0x370 [<0>] __device_add_disk+0x2db/0x700 [<0>] device_add_disk+0x17/0x20 [<0>] add_mtd_blktrans_dev+0x39e/0x6d0 [<0>] ftl_add_mtd+0x792/0x908 [ftl] [<0>] register_mtd_blktrans+0xfb/0x170 LOCK(mtd_table_mutex) [<0>] ftl_tr_init+0x18/0x1000 [ftl] [<0>] do_one_initcall+0x71/0x330 [<0>] do_init_module+0xa6/0x350 [1] http://lists.infradead.org/pipermail/linux-mtd/2017-March/072899.html Zhihao Cheng (6): Revert "mtd: blkdevs: fix potential deadlock + lockdep warnings" Revert "mtd: fix: avoid race condition when accessing mtd->usecount" Revert "mtd: mtd_blkdevs: don't increase 'open' count on error path" Revert "mtd: mtd_blkdevs: fix error path in blktrans_open" Revert "mtd: Remove redundant mutex from mtd_blkdevs.c" Revert "mtd: allow to unload the mtdtrans module if its block devices aren't open" drivers/mtd/mtd_blkdevs.c | 77 +++++++++++++++------------------------ 1 file changed, 30 insertions(+), 47 deletions(-) -- 2.31.1 ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/
next reply other threads:[~2021-06-13 11:22 UTC|newest] Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-06-13 11:30 Zhihao Cheng [this message] 2021-06-13 11:30 ` [PATCH 0/6] Fix deadlock in ftl formating on mtd Zhihao Cheng 2021-06-13 11:30 ` [PATCH 1/6] Revert "mtd: blkdevs: fix potential deadlock + lockdep warnings" Zhihao Cheng 2021-06-13 11:30 ` Zhihao Cheng 2021-06-13 11:30 ` [PATCH 2/6] Revert "mtd: fix: avoid race condition when accessing mtd->usecount" Zhihao Cheng 2021-06-13 11:30 ` Zhihao Cheng 2021-06-13 11:30 ` [PATCH 3/6] Revert "mtd: mtd_blkdevs: don't increase 'open' count on error path" Zhihao Cheng 2021-06-13 11:30 ` Zhihao Cheng 2021-06-13 11:30 ` [PATCH 4/6] Revert "mtd: mtd_blkdevs: fix error path in blktrans_open" Zhihao Cheng 2021-06-13 11:30 ` Zhihao Cheng 2021-06-13 11:30 ` [PATCH 5/6] Revert "mtd: Remove redundant mutex from mtd_blkdevs.c" Zhihao Cheng 2021-06-13 11:30 ` Zhihao Cheng 2021-06-13 11:30 ` [PATCH 6/6] Revert "mtd: allow to unload the mtdtrans module if its block devices aren't open" Zhihao Cheng 2021-06-13 11:30 ` Zhihao Cheng 2021-06-13 15:12 ` [PATCH 0/6] Fix deadlock in ftl formating on mtd Miquel Raynal 2021-06-13 15:12 ` Miquel Raynal 2021-06-15 9:02 ` Zhihao Cheng 2021-06-15 9:02 ` Zhihao Cheng 2021-06-15 9:08 ` Zhihao Cheng 2021-06-15 9:08 ` Zhihao Cheng
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20210613113035.2329421-1-chengzhihao1@huawei.com \ --to=chengzhihao1@huawei.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mtd@lists.infradead.org \ --cc=miquel.raynal@bootlin.com \ --cc=richard@nod.at \ --cc=vigneshr@ti.com \ --cc=yukuai3@huawei.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.