From: Bjorn Helgaas <helgaas@kernel.org>
To: "Krzysztof Wilczyński" <kw@linux.com>
Cc: Qi Liu <liuqi115@huawei.com>,
will@kernel.org, mark.rutland@arm.com, bhelgaas@google.com,
linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linuxarm@huawei.com,
zhangshaokun@hisilicon.com
Subject: Re: [PATCH v6 2/2] drivers/perf: hisi: Add driver for HiSilicon PCIe PMU
Date: Wed, 16 Jun 2021 09:14:47 -0500 [thread overview]
Message-ID: <20210616141447.GA2973335@bjorn-Precision-5520> (raw)
In-Reply-To: <20210611233355.GA183580@rocinante>
On Sat, Jun 12, 2021 at 01:33:55AM +0200, Krzysztof Wilczyński wrote:
> > +static ssize_t hisi_pcie_bus_show(struct device *dev,
> > + struct device_attribute *attr, char *buf)
> > +{
> > + struct hisi_pcie_pmu *pcie_pmu = to_pcie_pmu(dev_get_drvdata(dev));
> > +
> > + return sysfs_emit(buf, "0x%02x\n", PCI_BUS_NUM(pcie_pmu->bdf_min));
> > +}
>
> Same as above, what about "%#02x"?
I think you'd need "%#04x" because the field width includes the
leading "0x", so printing 1 with "%#02x" would result in "0x1" instead
of "0x01".
WARNING: multiple messages have this Message-ID (diff)
From: Bjorn Helgaas <helgaas@kernel.org>
To: "Krzysztof Wilczyński" <kw@linux.com>
Cc: Qi Liu <liuqi115@huawei.com>,
will@kernel.org, mark.rutland@arm.com, bhelgaas@google.com,
linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linuxarm@huawei.com,
zhangshaokun@hisilicon.com
Subject: Re: [PATCH v6 2/2] drivers/perf: hisi: Add driver for HiSilicon PCIe PMU
Date: Wed, 16 Jun 2021 09:14:47 -0500 [thread overview]
Message-ID: <20210616141447.GA2973335@bjorn-Precision-5520> (raw)
In-Reply-To: <20210611233355.GA183580@rocinante>
On Sat, Jun 12, 2021 at 01:33:55AM +0200, Krzysztof Wilczyński wrote:
> > +static ssize_t hisi_pcie_bus_show(struct device *dev,
> > + struct device_attribute *attr, char *buf)
> > +{
> > + struct hisi_pcie_pmu *pcie_pmu = to_pcie_pmu(dev_get_drvdata(dev));
> > +
> > + return sysfs_emit(buf, "0x%02x\n", PCI_BUS_NUM(pcie_pmu->bdf_min));
> > +}
>
> Same as above, what about "%#02x"?
I think you'd need "%#04x" because the field width includes the
leading "0x", so printing 1 with "%#02x" would result in "0x1" instead
of "0x01".
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-06-16 14:14 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-31 13:32 [PATCH v6 0/2] drivers/perf: hisi: Add support for PCIe PMU Qi Liu
2021-05-31 13:32 ` Qi Liu
2021-05-31 13:32 ` [PATCH v6 1/2] docs: perf: Add description for HiSilicon PCIe PMU driver Qi Liu
2021-05-31 13:32 ` Qi Liu
2021-05-31 13:32 ` [PATCH v6 2/2] drivers/perf: hisi: Add driver for HiSilicon PCIe PMU Qi Liu
2021-05-31 13:32 ` Qi Liu
2021-06-11 16:23 ` Will Deacon
2021-06-11 16:23 ` Will Deacon
2021-06-14 9:20 ` Jonathan Cameron
2021-06-14 9:20 ` Jonathan Cameron
2021-06-15 9:26 ` Will Deacon
2021-06-15 9:26 ` Will Deacon
2021-06-15 8:57 ` liuqi (BA)
2021-06-15 8:57 ` liuqi (BA)
2021-06-15 9:35 ` Will Deacon
2021-06-15 9:35 ` Will Deacon
2021-06-16 1:54 ` liuqi (BA)
2021-06-16 1:54 ` liuqi (BA)
2021-06-16 13:42 ` Will Deacon
2021-06-16 13:42 ` Will Deacon
2021-06-17 11:00 ` liuqi (BA)
2021-06-17 11:00 ` liuqi (BA)
2021-06-17 17:57 ` Will Deacon
2021-06-17 17:57 ` Will Deacon
2021-06-18 9:32 ` liuqi (BA)
2021-06-18 9:32 ` liuqi (BA)
2021-06-21 17:59 ` Will Deacon
2021-06-21 17:59 ` Will Deacon
2021-06-23 9:59 ` liuqi (BA)
2021-06-23 9:59 ` liuqi (BA)
2021-06-11 23:33 ` Krzysztof Wilczyński
2021-06-11 23:33 ` Krzysztof Wilczyński
2021-06-16 1:09 ` liuqi (BA)
2021-06-16 1:09 ` liuqi (BA)
2021-06-16 15:23 ` Bjorn Helgaas
2021-06-16 15:23 ` Bjorn Helgaas
2021-06-16 17:27 ` Will Deacon
2021-06-16 17:27 ` Will Deacon
2021-06-16 14:14 ` Bjorn Helgaas [this message]
2021-06-16 14:14 ` Bjorn Helgaas
2021-06-11 10:04 ` [PATCH v6 0/2] drivers/perf: hisi: Add support for " liuqi (BA)
2021-06-11 10:04 ` liuqi (BA)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210616141447.GA2973335@bjorn-Precision-5520 \
--to=helgaas@kernel.org \
--cc=bhelgaas@google.com \
--cc=kw@linux.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=liuqi115@huawei.com \
--cc=mark.rutland@arm.com \
--cc=will@kernel.org \
--cc=zhangshaokun@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.