* fs/btrfs/zoned.c:616:34: error: 'max_zone_append_size' undeclared
@ 2021-06-28 16:22 kernel test robot
0 siblings, 0 replies; only message in thread
From: kernel test robot @ 2021-06-28 16:22 UTC (permalink / raw)
To: kbuild-all
[-- Attachment #1: Type: text/plain, Size: 10126 bytes --]
tree: https://github.com/0day-ci/linux/commits/UPDATE-20210628-194638/Johannes-Thumshirn/btrfs-zoned-remove-fs_info-max_zone_append_size/20210628-171537
head: e856f57f235576e962b0eb6e2d167cedc9a6a397
commit: e856f57f235576e962b0eb6e2d167cedc9a6a397 btrfs: drop check for lowest max_zone_append_size in btrfs_check_zoned_mode
date: 5 hours ago
config: x86_64-allyesconfig (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce (this is a W=1 build):
# https://github.com/0day-ci/linux/commit/e856f57f235576e962b0eb6e2d167cedc9a6a397
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review UPDATE-20210628-194638/Johannes-Thumshirn/btrfs-zoned-remove-fs_info-max_zone_append_size/20210628-171537
git checkout e856f57f235576e962b0eb6e2d167cedc9a6a397
# save the attached .config to linux build tree
mkdir build_dir
make W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
fs/btrfs/zoned.c: In function 'btrfs_check_zoned_mode':
>> fs/btrfs/zoned.c:616:34: error: 'max_zone_append_size' undeclared (first use in this function)
616 | fs_info->max_zone_append_size = max_zone_append_size;
| ^~~~~~~~~~~~~~~~~~~~
fs/btrfs/zoned.c:616:34: note: each undeclared identifier is reported only once for each function it appears in
vim +/max_zone_append_size +616 fs/btrfs/zoned.c
b70f509774ad4b Naohiro Aota 2020-11-10 524
b70f509774ad4b Naohiro Aota 2020-11-10 525 int btrfs_check_zoned_mode(struct btrfs_fs_info *fs_info)
b70f509774ad4b Naohiro Aota 2020-11-10 526 {
b70f509774ad4b Naohiro Aota 2020-11-10 527 struct btrfs_fs_devices *fs_devices = fs_info->fs_devices;
b70f509774ad4b Naohiro Aota 2020-11-10 528 struct btrfs_device *device;
b70f509774ad4b Naohiro Aota 2020-11-10 529 u64 zoned_devices = 0;
b70f509774ad4b Naohiro Aota 2020-11-10 530 u64 nr_devices = 0;
b70f509774ad4b Naohiro Aota 2020-11-10 531 u64 zone_size = 0;
3c9daa09ccd43f Johannes Thumshirn 2021-02-04 532 const bool incompat_zoned = btrfs_fs_incompat(fs_info, ZONED);
b70f509774ad4b Naohiro Aota 2020-11-10 533 int ret = 0;
b70f509774ad4b Naohiro Aota 2020-11-10 534
b70f509774ad4b Naohiro Aota 2020-11-10 535 /* Count zoned devices */
b70f509774ad4b Naohiro Aota 2020-11-10 536 list_for_each_entry(device, &fs_devices->devices, dev_list) {
b70f509774ad4b Naohiro Aota 2020-11-10 537 enum blk_zoned_model model;
b70f509774ad4b Naohiro Aota 2020-11-10 538
b70f509774ad4b Naohiro Aota 2020-11-10 539 if (!device->bdev)
b70f509774ad4b Naohiro Aota 2020-11-10 540 continue;
b70f509774ad4b Naohiro Aota 2020-11-10 541
b70f509774ad4b Naohiro Aota 2020-11-10 542 model = bdev_zoned_model(device->bdev);
3c9daa09ccd43f Johannes Thumshirn 2021-02-04 543 /*
3c9daa09ccd43f Johannes Thumshirn 2021-02-04 544 * A Host-Managed zoned device must be used as a zoned device.
3c9daa09ccd43f Johannes Thumshirn 2021-02-04 545 * A Host-Aware zoned device and a non-zoned devices can be
3c9daa09ccd43f Johannes Thumshirn 2021-02-04 546 * treated as a zoned device, if ZONED flag is enabled in the
3c9daa09ccd43f Johannes Thumshirn 2021-02-04 547 * superblock.
3c9daa09ccd43f Johannes Thumshirn 2021-02-04 548 */
b70f509774ad4b Naohiro Aota 2020-11-10 549 if (model == BLK_ZONED_HM ||
3c9daa09ccd43f Johannes Thumshirn 2021-02-04 550 (model == BLK_ZONED_HA && incompat_zoned) ||
3c9daa09ccd43f Johannes Thumshirn 2021-02-04 551 (model == BLK_ZONED_NONE && incompat_zoned)) {
3c9daa09ccd43f Johannes Thumshirn 2021-02-04 552 struct btrfs_zoned_device_info *zone_info =
3c9daa09ccd43f Johannes Thumshirn 2021-02-04 553 device->zone_info;
862931c76327e5 Naohiro Aota 2020-11-10 554
862931c76327e5 Naohiro Aota 2020-11-10 555 zone_info = device->zone_info;
b70f509774ad4b Naohiro Aota 2020-11-10 556 zoned_devices++;
b70f509774ad4b Naohiro Aota 2020-11-10 557 if (!zone_size) {
862931c76327e5 Naohiro Aota 2020-11-10 558 zone_size = zone_info->zone_size;
862931c76327e5 Naohiro Aota 2020-11-10 559 } else if (zone_info->zone_size != zone_size) {
b70f509774ad4b Naohiro Aota 2020-11-10 560 btrfs_err(fs_info,
b70f509774ad4b Naohiro Aota 2020-11-10 561 "zoned: unequal block device zone sizes: have %llu found %llu",
b70f509774ad4b Naohiro Aota 2020-11-10 562 device->zone_info->zone_size,
b70f509774ad4b Naohiro Aota 2020-11-10 563 zone_size);
b70f509774ad4b Naohiro Aota 2020-11-10 564 ret = -EINVAL;
b70f509774ad4b Naohiro Aota 2020-11-10 565 goto out;
b70f509774ad4b Naohiro Aota 2020-11-10 566 }
b70f509774ad4b Naohiro Aota 2020-11-10 567 }
b70f509774ad4b Naohiro Aota 2020-11-10 568 nr_devices++;
b70f509774ad4b Naohiro Aota 2020-11-10 569 }
b70f509774ad4b Naohiro Aota 2020-11-10 570
b70f509774ad4b Naohiro Aota 2020-11-10 571 if (!zoned_devices && !incompat_zoned)
b70f509774ad4b Naohiro Aota 2020-11-10 572 goto out;
b70f509774ad4b Naohiro Aota 2020-11-10 573
b70f509774ad4b Naohiro Aota 2020-11-10 574 if (!zoned_devices && incompat_zoned) {
b70f509774ad4b Naohiro Aota 2020-11-10 575 /* No zoned block device found on ZONED filesystem */
b70f509774ad4b Naohiro Aota 2020-11-10 576 btrfs_err(fs_info,
b70f509774ad4b Naohiro Aota 2020-11-10 577 "zoned: no zoned devices found on a zoned filesystem");
b70f509774ad4b Naohiro Aota 2020-11-10 578 ret = -EINVAL;
b70f509774ad4b Naohiro Aota 2020-11-10 579 goto out;
b70f509774ad4b Naohiro Aota 2020-11-10 580 }
b70f509774ad4b Naohiro Aota 2020-11-10 581
b70f509774ad4b Naohiro Aota 2020-11-10 582 if (zoned_devices && !incompat_zoned) {
b70f509774ad4b Naohiro Aota 2020-11-10 583 btrfs_err(fs_info,
b70f509774ad4b Naohiro Aota 2020-11-10 584 "zoned: mode not enabled but zoned device found");
b70f509774ad4b Naohiro Aota 2020-11-10 585 ret = -EINVAL;
b70f509774ad4b Naohiro Aota 2020-11-10 586 goto out;
b70f509774ad4b Naohiro Aota 2020-11-10 587 }
b70f509774ad4b Naohiro Aota 2020-11-10 588
b70f509774ad4b Naohiro Aota 2020-11-10 589 if (zoned_devices != nr_devices) {
b70f509774ad4b Naohiro Aota 2020-11-10 590 btrfs_err(fs_info,
b70f509774ad4b Naohiro Aota 2020-11-10 591 "zoned: cannot mix zoned and regular devices");
b70f509774ad4b Naohiro Aota 2020-11-10 592 ret = -EINVAL;
b70f509774ad4b Naohiro Aota 2020-11-10 593 goto out;
b70f509774ad4b Naohiro Aota 2020-11-10 594 }
b70f509774ad4b Naohiro Aota 2020-11-10 595
b70f509774ad4b Naohiro Aota 2020-11-10 596 /*
b70f509774ad4b Naohiro Aota 2020-11-10 597 * stripe_size is always aligned to BTRFS_STRIPE_LEN in
b70f509774ad4b Naohiro Aota 2020-11-10 598 * __btrfs_alloc_chunk(). Since we want stripe_len == zone_size,
b70f509774ad4b Naohiro Aota 2020-11-10 599 * check the alignment here.
b70f509774ad4b Naohiro Aota 2020-11-10 600 */
b70f509774ad4b Naohiro Aota 2020-11-10 601 if (!IS_ALIGNED(zone_size, BTRFS_STRIPE_LEN)) {
b70f509774ad4b Naohiro Aota 2020-11-10 602 btrfs_err(fs_info,
b70f509774ad4b Naohiro Aota 2020-11-10 603 "zoned: zone size %llu not aligned to stripe %u",
b70f509774ad4b Naohiro Aota 2020-11-10 604 zone_size, BTRFS_STRIPE_LEN);
b70f509774ad4b Naohiro Aota 2020-11-10 605 ret = -EINVAL;
b70f509774ad4b Naohiro Aota 2020-11-10 606 goto out;
b70f509774ad4b Naohiro Aota 2020-11-10 607 }
b70f509774ad4b Naohiro Aota 2020-11-10 608
a589dde0bc0bf5 Naohiro Aota 2020-11-10 609 if (btrfs_fs_incompat(fs_info, MIXED_GROUPS)) {
a589dde0bc0bf5 Naohiro Aota 2020-11-10 610 btrfs_err(fs_info, "zoned: mixed block groups not supported");
a589dde0bc0bf5 Naohiro Aota 2020-11-10 611 ret = -EINVAL;
a589dde0bc0bf5 Naohiro Aota 2020-11-10 612 goto out;
a589dde0bc0bf5 Naohiro Aota 2020-11-10 613 }
a589dde0bc0bf5 Naohiro Aota 2020-11-10 614
b70f509774ad4b Naohiro Aota 2020-11-10 615 fs_info->zone_size = zone_size;
862931c76327e5 Naohiro Aota 2020-11-10 @616 fs_info->max_zone_append_size = max_zone_append_size;
1cd6121f2a382a Naohiro Aota 2021-02-04 617 fs_info->fs_devices->chunk_alloc_policy = BTRFS_CHUNK_ALLOC_ZONED;
b70f509774ad4b Naohiro Aota 2020-11-10 618
b53429bad3a355 Johannes Thumshirn 2021-02-04 619 /*
b53429bad3a355 Johannes Thumshirn 2021-02-04 620 * Check mount options here, because we might change fs_info->zoned
b53429bad3a355 Johannes Thumshirn 2021-02-04 621 * from fs_info->zone_size.
b53429bad3a355 Johannes Thumshirn 2021-02-04 622 */
b53429bad3a355 Johannes Thumshirn 2021-02-04 623 ret = btrfs_check_mountopts_zoned(fs_info);
b53429bad3a355 Johannes Thumshirn 2021-02-04 624 if (ret)
b53429bad3a355 Johannes Thumshirn 2021-02-04 625 goto out;
b53429bad3a355 Johannes Thumshirn 2021-02-04 626
b70f509774ad4b Naohiro Aota 2020-11-10 627 btrfs_info(fs_info, "zoned mode enabled with zone size %llu", zone_size);
b70f509774ad4b Naohiro Aota 2020-11-10 628 out:
b70f509774ad4b Naohiro Aota 2020-11-10 629 return ret;
b70f509774ad4b Naohiro Aota 2020-11-10 630 }
5d1ab66c56fed1 Naohiro Aota 2020-11-10 631
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 65658 bytes --]
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2021-06-28 16:22 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-28 16:22 fs/btrfs/zoned.c:616:34: error: 'max_zone_append_size' undeclared kernel test robot
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.