* [PATCH] ext4: fix flags validity checking for EXT4_IOC_CHECKPOINT
@ 2021-07-02 17:34 Theodore Ts'o
2021-07-02 22:45 ` Leah Rumancik
0 siblings, 1 reply; 2+ messages in thread
From: Theodore Ts'o @ 2021-07-02 17:34 UTC (permalink / raw)
To: Ext4 Developers List; +Cc: Theodore Ts'o, Leah Rumancik
Use the correct bitmask when checking for any not-yet-supported flags.
Fixes: 351a0a3fbc35 ("ext4: add ioctl EXT4_IOC_CHECKPOINT")
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
Cc: Leah Rumancik <leah.rumancik@gmail.com>
---
fs/ext4/ioctl.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/ext4/ioctl.c b/fs/ext4/ioctl.c
index 5730aeca563c..6eed6170aded 100644
--- a/fs/ext4/ioctl.c
+++ b/fs/ext4/ioctl.c
@@ -823,7 +823,7 @@ static int ext4_ioctl_checkpoint(struct file *filp, unsigned long arg)
if (!EXT4_SB(sb)->s_journal)
return -ENODEV;
- if (flags & ~JBD2_JOURNAL_FLUSH_VALID)
+ if (flags & ~EXT4_IOC_CHECKPOINT_FLAG_VALID)
return -EINVAL;
q = bdev_get_queue(EXT4_SB(sb)->s_journal->j_dev);
--
2.31.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ext4: fix flags validity checking for EXT4_IOC_CHECKPOINT
2021-07-02 17:34 [PATCH] ext4: fix flags validity checking for EXT4_IOC_CHECKPOINT Theodore Ts'o
@ 2021-07-02 22:45 ` Leah Rumancik
0 siblings, 0 replies; 2+ messages in thread
From: Leah Rumancik @ 2021-07-02 22:45 UTC (permalink / raw)
To: Theodore Ts'o; +Cc: Ext4 Developers List
On Fri, Jul 02, 2021 at 01:34:25PM -0400, Theodore Ts'o wrote:
> Use the correct bitmask when checking for any not-yet-supported flags.
>
> Fixes: 351a0a3fbc35 ("ext4: add ioctl EXT4_IOC_CHECKPOINT")
> Signed-off-by: Theodore Ts'o <tytso@mit.edu>
> Cc: Leah Rumancik <leah.rumancik@gmail.com>
> ---
> fs/ext4/ioctl.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/ext4/ioctl.c b/fs/ext4/ioctl.c
> index 5730aeca563c..6eed6170aded 100644
> --- a/fs/ext4/ioctl.c
> +++ b/fs/ext4/ioctl.c
> @@ -823,7 +823,7 @@ static int ext4_ioctl_checkpoint(struct file *filp, unsigned long arg)
> if (!EXT4_SB(sb)->s_journal)
> return -ENODEV;
>
> - if (flags & ~JBD2_JOURNAL_FLUSH_VALID)
> + if (flags & ~EXT4_IOC_CHECKPOINT_FLAG_VALID)
> return -EINVAL;
>
> q = bdev_get_queue(EXT4_SB(sb)->s_journal->j_dev);
> --
> 2.31.0
>
Thanks for the fix.
Reviewed-by: Leah Rumancik <leah.rumancik@gmail.com>
-Leah
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-07-02 22:45 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-02 17:34 [PATCH] ext4: fix flags validity checking for EXT4_IOC_CHECKPOINT Theodore Ts'o
2021-07-02 22:45 ` Leah Rumancik
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.