drivers/net/wireless/ath/carl9170/tx.c:121 __carl9170_get_tx_sta() warn: potential spectre issue 'ar->vif_priv' [w] (local cap)

drivers/net/wireless/ath/carl9170/tx.c:121 __carl9170_get_tx_sta() warn: potential spectre issue 'ar->vif_priv' [w] (local cap)

[kernel test robot]

[-- Attachment #1: Type: text/plain, Size: 3985 bytes --]

CC: kbuild-all(a)lists.01.org
CC: linux-kernel(a)vger.kernel.org
TO: Will Deacon <will@kernel.org>

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   3dbdb38e286903ec220aaf1fb29a8d94297da246
commit: 3c9184109e78ea2371ca8fa66d7f36986a53af98 asm/rwonce: Remove smp_read_barrier_depends() invocation
date:   12 months ago
:::::: branch date: 17 hours ago
:::::: commit date: 12 months ago
config: arm64-randconfig-m031-20210702 (attached as .config)
compiler: aarch64-linux-gcc (GCC) 9.3.0

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>

smatch warnings:
drivers/net/wireless/ath/carl9170/tx.c:121 __carl9170_get_tx_sta() warn: potential spectre issue 'ar->vif_priv' [w] (local cap)

vim +121 drivers/net/wireless/ath/carl9170/tx.c

a84fab3cbfdc42 Christian Lamparter 2010-09-06  105  
caf1eae2066882 Christian Lamparter 2011-04-24  106  /* needs rcu_read_lock */
caf1eae2066882 Christian Lamparter 2011-04-24  107  static struct ieee80211_sta *__carl9170_get_tx_sta(struct ar9170 *ar,
caf1eae2066882 Christian Lamparter 2011-04-24  108  						   struct sk_buff *skb)
caf1eae2066882 Christian Lamparter 2011-04-24  109  {
caf1eae2066882 Christian Lamparter 2011-04-24  110  	struct _carl9170_tx_superframe *super = (void *) skb->data;
caf1eae2066882 Christian Lamparter 2011-04-24  111  	struct ieee80211_hdr *hdr = (void *) super->frame_data;
caf1eae2066882 Christian Lamparter 2011-04-24  112  	struct ieee80211_vif *vif;
caf1eae2066882 Christian Lamparter 2011-04-24  113  	unsigned int vif_id;
caf1eae2066882 Christian Lamparter 2011-04-24  114  
caf1eae2066882 Christian Lamparter 2011-04-24  115  	vif_id = (super->s.misc & CARL9170_TX_SUPER_MISC_VIF_ID) >>
caf1eae2066882 Christian Lamparter 2011-04-24  116  		 CARL9170_TX_SUPER_MISC_VIF_ID_S;
caf1eae2066882 Christian Lamparter 2011-04-24  117  
caf1eae2066882 Christian Lamparter 2011-04-24  118  	if (WARN_ON_ONCE(vif_id >= AR9170_MAX_VIRTUAL_MAC))
caf1eae2066882 Christian Lamparter 2011-04-24  119  		return NULL;
caf1eae2066882 Christian Lamparter 2011-04-24  120  
caf1eae2066882 Christian Lamparter 2011-04-24 @121  	vif = rcu_dereference(ar->vif_priv[vif_id].vif);
caf1eae2066882 Christian Lamparter 2011-04-24  122  	if (unlikely(!vif))
caf1eae2066882 Christian Lamparter 2011-04-24  123  		return NULL;
caf1eae2066882 Christian Lamparter 2011-04-24  124  
caf1eae2066882 Christian Lamparter 2011-04-24  125  	/*
caf1eae2066882 Christian Lamparter 2011-04-24  126  	 * Normally we should use wrappers like ieee80211_get_DA to get
caf1eae2066882 Christian Lamparter 2011-04-24  127  	 * the correct peer ieee80211_sta.
caf1eae2066882 Christian Lamparter 2011-04-24  128  	 *
caf1eae2066882 Christian Lamparter 2011-04-24  129  	 * But there is a problem with indirect traffic (broadcasts, or
caf1eae2066882 Christian Lamparter 2011-04-24  130  	 * data which is designated for other stations) in station mode.
caf1eae2066882 Christian Lamparter 2011-04-24  131  	 * The frame will be directed to the AP for distribution and not
caf1eae2066882 Christian Lamparter 2011-04-24  132  	 * to the actual destination.
caf1eae2066882 Christian Lamparter 2011-04-24  133  	 */
caf1eae2066882 Christian Lamparter 2011-04-24  134  
caf1eae2066882 Christian Lamparter 2011-04-24  135  	return ieee80211_find_sta(vif, hdr->addr1);
caf1eae2066882 Christian Lamparter 2011-04-24  136  }
caf1eae2066882 Christian Lamparter 2011-04-24  137  

:::::: The code at line 121 was first introduced by commit
:::::: caf1eae206688210f61f3b48627ce4ca3c709784 carl9170: improve unicast PS buffering

:::::: TO: Christian Lamparter <chunkeey@googlemail.com>
:::::: CC: John W. Linville <linville@tuxdriver.com>

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 36715 bytes --]