* [PATCH v1 0/2] drm/atmel-hlcdc: drop use of drm_irq mid-layer
@ 2021-07-11 9:16 ` Sam Ravnborg
0 siblings, 0 replies; 12+ messages in thread
From: Sam Ravnborg @ 2021-07-11 9:16 UTC (permalink / raw)
To: dri-devel
Cc: Alexandre Belloni, Boris Brezillon, Claudiu Beznea,
Ludovic Desroches, Thomas Zimmermann, Sam Ravnborg, Peter Rosin,
linux-arm-kernel
Two small patches to drop the use of the drm irq mid-layer.
My atmel hlcdc target has stopped working - so unfortunately un-tested :-(
I picked up this to continue the work of Thomas Zimmermann.
Sam
Sam Ravnborg (2):
drm/atmel-hlcdc: Move interrupt helper funtions
drm/atmel-hlcdc: Convert to Linux IRQ interfaces
drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c | 63 +++++++++++++---------------
1 file changed, 30 insertions(+), 33 deletions(-)
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 12+ messages in thread
* [PATCH v1 0/2] drm/atmel-hlcdc: drop use of drm_irq mid-layer
@ 2021-07-11 9:16 ` Sam Ravnborg
0 siblings, 0 replies; 12+ messages in thread
From: Sam Ravnborg @ 2021-07-11 9:16 UTC (permalink / raw)
To: dri-devel
Cc: Alexandre Belloni, Boris Brezillon, Nicolas Ferre,
Claudiu Beznea, Ludovic Desroches, Thomas Zimmermann,
Sam Ravnborg, Peter Rosin, linux-arm-kernel
Two small patches to drop the use of the drm irq mid-layer.
My atmel hlcdc target has stopped working - so unfortunately un-tested :-(
I picked up this to continue the work of Thomas Zimmermann.
Sam
Sam Ravnborg (2):
drm/atmel-hlcdc: Move interrupt helper funtions
drm/atmel-hlcdc: Convert to Linux IRQ interfaces
drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c | 63 +++++++++++++---------------
1 file changed, 30 insertions(+), 33 deletions(-)
^ permalink raw reply [flat|nested] 12+ messages in thread
* [PATCH 1/1] drm: bridge: Mark deprecated operations in drm_bridge_funcs
2021-07-11 9:16 ` Sam Ravnborg
@ 2021-07-11 9:16 ` Sam Ravnborg
-1 siblings, 0 replies; 12+ messages in thread
From: Sam Ravnborg @ 2021-07-11 9:16 UTC (permalink / raw)
To: dri-devel
Cc: Alexandre Belloni, Daniel Vetter, Boris Brezillon, David Airlie,
Maarten Lankhorst, Maxime Ripard, Claudiu Beznea, Andrzej Hajda,
Ludovic Desroches, Laurent Pinchart, Thomas Zimmermann,
Sam Ravnborg, Peter Rosin, linux-arm-kernel
drm_bridge_funcs includes several duplicated operations as atomic
variants has been added over time.
New bridge drivers shall use the atomic variants - mark the deprecated
operations to try to avoid usage in new bridge drivers.
Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: Andrzej Hajda <a.hajda@samsung.com>
Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Cc: Maxime Ripard <mripard@kernel.org>
Cc: Thomas Zimmermann <tzimmermann@suse.de>
Cc: David Airlie <airlied@linux.ie>
Cc: Daniel Vetter <daniel@ffwll.ch>
---
include/drm/drm_bridge.h | 28 ++++++++++++++++++++++++++--
1 file changed, 26 insertions(+), 2 deletions(-)
diff --git a/include/drm/drm_bridge.h b/include/drm/drm_bridge.h
index 2195daa289d2..6805898d70f5 100644
--- a/include/drm/drm_bridge.h
+++ b/include/drm/drm_bridge.h
@@ -171,6 +171,11 @@ struct drm_bridge_funcs {
* signals) feeding it is still running when this callback is called.
*
* The @disable callback is optional.
+ *
+ * NOTE:
+ *
+ * This is deprecated, do not use!
+ * New drivers shall use &drm_bridge_funcs.atomic_disable.
*/
void (*disable)(struct drm_bridge *bridge);
@@ -190,6 +195,11 @@ struct drm_bridge_funcs {
* called.
*
* The @post_disable callback is optional.
+ *
+ * NOTE:
+ *
+ * This is deprecated, do not use!
+ * New drivers shall use &drm_bridge_funcs.atomic_post_disable.
*/
void (*post_disable)(struct drm_bridge *bridge);
@@ -213,11 +223,15 @@ struct drm_bridge_funcs {
* For atomic drivers the adjusted_mode is the mode stored in
* &drm_crtc_state.adjusted_mode.
*
- * NOTE:
- *
* If a need arises to store and access modes adjusted for other
* locations than the connection between the CRTC and the first bridge,
* the DRM framework will have to be extended with DRM bridge states.
+ *
+ * NOTE:
+ *
+ * This is deprecated, do not use!
+ * New drivers shall set their mode in &drm_bridge_funcs.atomic_enable
+ * operation.
*/
void (*mode_set)(struct drm_bridge *bridge,
const struct drm_display_mode *mode,
@@ -239,6 +253,11 @@ struct drm_bridge_funcs {
* there is one) when this callback is called.
*
* The @pre_enable callback is optional.
+ *
+ * NOTE:
+ *
+ * This is deprecated, do not use!
+ * New drivers shall use &drm_bridge_funcs.atomic_pre_enable.
*/
void (*pre_enable)(struct drm_bridge *bridge);
@@ -259,6 +278,11 @@ struct drm_bridge_funcs {
* chain if there is one.
*
* The @enable callback is optional.
+ *
+ * NOTE:
+ *
+ * This is deprecated, do not use!
+ * New drivers shall use &drm_bridge_funcs.atomic_enable.
*/
void (*enable)(struct drm_bridge *bridge);
--
2.30.2
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 12+ messages in thread
* [PATCH 1/1] drm: bridge: Mark deprecated operations in drm_bridge_funcs
@ 2021-07-11 9:16 ` Sam Ravnborg
0 siblings, 0 replies; 12+ messages in thread
From: Sam Ravnborg @ 2021-07-11 9:16 UTC (permalink / raw)
To: dri-devel
Cc: Alexandre Belloni, Boris Brezillon, David Airlie, Nicolas Ferre,
Claudiu Beznea, Andrzej Hajda, Ludovic Desroches,
Laurent Pinchart, Thomas Zimmermann, Sam Ravnborg, Peter Rosin,
linux-arm-kernel
drm_bridge_funcs includes several duplicated operations as atomic
variants has been added over time.
New bridge drivers shall use the atomic variants - mark the deprecated
operations to try to avoid usage in new bridge drivers.
Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: Andrzej Hajda <a.hajda@samsung.com>
Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Cc: Maxime Ripard <mripard@kernel.org>
Cc: Thomas Zimmermann <tzimmermann@suse.de>
Cc: David Airlie <airlied@linux.ie>
Cc: Daniel Vetter <daniel@ffwll.ch>
---
include/drm/drm_bridge.h | 28 ++++++++++++++++++++++++++--
1 file changed, 26 insertions(+), 2 deletions(-)
diff --git a/include/drm/drm_bridge.h b/include/drm/drm_bridge.h
index 2195daa289d2..6805898d70f5 100644
--- a/include/drm/drm_bridge.h
+++ b/include/drm/drm_bridge.h
@@ -171,6 +171,11 @@ struct drm_bridge_funcs {
* signals) feeding it is still running when this callback is called.
*
* The @disable callback is optional.
+ *
+ * NOTE:
+ *
+ * This is deprecated, do not use!
+ * New drivers shall use &drm_bridge_funcs.atomic_disable.
*/
void (*disable)(struct drm_bridge *bridge);
@@ -190,6 +195,11 @@ struct drm_bridge_funcs {
* called.
*
* The @post_disable callback is optional.
+ *
+ * NOTE:
+ *
+ * This is deprecated, do not use!
+ * New drivers shall use &drm_bridge_funcs.atomic_post_disable.
*/
void (*post_disable)(struct drm_bridge *bridge);
@@ -213,11 +223,15 @@ struct drm_bridge_funcs {
* For atomic drivers the adjusted_mode is the mode stored in
* &drm_crtc_state.adjusted_mode.
*
- * NOTE:
- *
* If a need arises to store and access modes adjusted for other
* locations than the connection between the CRTC and the first bridge,
* the DRM framework will have to be extended with DRM bridge states.
+ *
+ * NOTE:
+ *
+ * This is deprecated, do not use!
+ * New drivers shall set their mode in &drm_bridge_funcs.atomic_enable
+ * operation.
*/
void (*mode_set)(struct drm_bridge *bridge,
const struct drm_display_mode *mode,
@@ -239,6 +253,11 @@ struct drm_bridge_funcs {
* there is one) when this callback is called.
*
* The @pre_enable callback is optional.
+ *
+ * NOTE:
+ *
+ * This is deprecated, do not use!
+ * New drivers shall use &drm_bridge_funcs.atomic_pre_enable.
*/
void (*pre_enable)(struct drm_bridge *bridge);
@@ -259,6 +278,11 @@ struct drm_bridge_funcs {
* chain if there is one.
*
* The @enable callback is optional.
+ *
+ * NOTE:
+ *
+ * This is deprecated, do not use!
+ * New drivers shall use &drm_bridge_funcs.atomic_enable.
*/
void (*enable)(struct drm_bridge *bridge);
--
2.30.2
^ permalink raw reply related [flat|nested] 12+ messages in thread
* Re: [PATCH 1/1] drm: bridge: Mark deprecated operations in drm_bridge_funcs
2021-07-11 9:16 ` Sam Ravnborg
@ 2021-07-11 9:20 ` Sam Ravnborg
-1 siblings, 0 replies; 12+ messages in thread
From: Sam Ravnborg @ 2021-07-11 9:20 UTC (permalink / raw)
To: dri-devel
Cc: Alexandre Belloni, Daniel Vetter, Boris Brezillon, David Airlie,
Maarten Lankhorst, Maxime Ripard, Claudiu Beznea, Andrzej Hajda,
Ludovic Desroches, Laurent Pinchart, Thomas Zimmermann,
Peter Rosin, linux-arm-kernel
On Sun, Jul 11, 2021 at 11:16:44AM +0200, Sam Ravnborg wrote:
> drm_bridge_funcs includes several duplicated operations as atomic
> variants has been added over time.
> New bridge drivers shall use the atomic variants - mark the deprecated
> operations to try to avoid usage in new bridge drivers.
>
> Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
> Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> Cc: Andrzej Hajda <a.hajda@samsung.com>
> Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> Cc: Maxime Ripard <mripard@kernel.org>
> Cc: Thomas Zimmermann <tzimmermann@suse.de>
> Cc: David Airlie <airlied@linux.ie>
> Cc: Daniel Vetter <daniel@ffwll.ch>
Ignore this patch - I managed to chain the wrong patch to the cover
letter.
Sam
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 1/1] drm: bridge: Mark deprecated operations in drm_bridge_funcs
@ 2021-07-11 9:20 ` Sam Ravnborg
0 siblings, 0 replies; 12+ messages in thread
From: Sam Ravnborg @ 2021-07-11 9:20 UTC (permalink / raw)
To: dri-devel
Cc: Alexandre Belloni, Boris Brezillon, David Airlie, Nicolas Ferre,
Claudiu Beznea, Andrzej Hajda, Ludovic Desroches,
Laurent Pinchart, Thomas Zimmermann, Peter Rosin,
linux-arm-kernel
On Sun, Jul 11, 2021 at 11:16:44AM +0200, Sam Ravnborg wrote:
> drm_bridge_funcs includes several duplicated operations as atomic
> variants has been added over time.
> New bridge drivers shall use the atomic variants - mark the deprecated
> operations to try to avoid usage in new bridge drivers.
>
> Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
> Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> Cc: Andrzej Hajda <a.hajda@samsung.com>
> Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> Cc: Maxime Ripard <mripard@kernel.org>
> Cc: Thomas Zimmermann <tzimmermann@suse.de>
> Cc: David Airlie <airlied@linux.ie>
> Cc: Daniel Vetter <daniel@ffwll.ch>
Ignore this patch - I managed to chain the wrong patch to the cover
letter.
Sam
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH v1 0/2] drm/atmel-hlcdc: drop use of drm_irq mid-layer
2021-07-15 21:55 ` Dan.Sneddon
@ 2021-07-15 22:08 ` Sam Ravnborg
-1 siblings, 0 replies; 12+ messages in thread
From: Sam Ravnborg @ 2021-07-15 22:08 UTC (permalink / raw)
To: Dan.Sneddon
Cc: alexandre.belloni, bbrezillon, dri-devel, peda,
Ludovic.Desroches, tzimmermann, Claudiu.Beznea, linux-arm-kernel
Hi Dan,
On Thu, Jul 15, 2021 at 09:55:09PM +0000, Dan.Sneddon@microchip.com wrote:
> I tested this patch set on the 9x60ek board and unfortunately it causes
> errors. The vbltest returns -1 and I also see the display get out of
> sync while testing with a gui application.
Thanks a lot for the testing, I will take a look tomorrow and see if I
can figure out what is wrong.
Sam
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH v1 0/2] drm/atmel-hlcdc: drop use of drm_irq mid-layer
@ 2021-07-15 22:08 ` Sam Ravnborg
0 siblings, 0 replies; 12+ messages in thread
From: Sam Ravnborg @ 2021-07-15 22:08 UTC (permalink / raw)
To: Dan.Sneddon
Cc: alexandre.belloni, bbrezillon, dri-devel, Claudiu.Beznea,
Ludovic.Desroches, tzimmermann, peda, linux-arm-kernel
Hi Dan,
On Thu, Jul 15, 2021 at 09:55:09PM +0000, Dan.Sneddon@microchip.com wrote:
> I tested this patch set on the 9x60ek board and unfortunately it causes
> errors. The vbltest returns -1 and I also see the display get out of
> sync while testing with a gui application.
Thanks a lot for the testing, I will take a look tomorrow and see if I
can figure out what is wrong.
Sam
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH v1 0/2] drm/atmel-hlcdc: drop use of drm_irq mid-layer
2021-07-11 9:19 ` Sam Ravnborg
@ 2021-07-15 21:55 ` Dan.Sneddon
-1 siblings, 0 replies; 12+ messages in thread
From: Dan.Sneddon @ 2021-07-15 21:55 UTC (permalink / raw)
To: sam
Cc: alexandre.belloni, bbrezillon, Claudiu.Beznea, dri-devel,
linux-arm-kernel, Ludovic.Desroches, peda, tzimmermann
I tested this patch set on the 9x60ek board and unfortunately it causes
errors. The vbltest returns -1 and I also see the display get out of
sync while testing with a gui application.
Regards,
Dan
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH v1 0/2] drm/atmel-hlcdc: drop use of drm_irq mid-layer
@ 2021-07-15 21:55 ` Dan.Sneddon
0 siblings, 0 replies; 12+ messages in thread
From: Dan.Sneddon @ 2021-07-15 21:55 UTC (permalink / raw)
To: sam
Cc: alexandre.belloni, bbrezillon, dri-devel, peda,
Ludovic.Desroches, tzimmermann, Claudiu.Beznea, linux-arm-kernel
I tested this patch set on the 9x60ek board and unfortunately it causes
errors. The vbltest returns -1 and I also see the display get out of
sync while testing with a gui application.
Regards,
Dan
^ permalink raw reply [flat|nested] 12+ messages in thread
* [PATCH v1 0/2] drm/atmel-hlcdc: drop use of drm_irq mid-layer
@ 2021-07-11 9:19 ` Sam Ravnborg
0 siblings, 0 replies; 12+ messages in thread
From: Sam Ravnborg @ 2021-07-11 9:19 UTC (permalink / raw)
To: dri-devel
Cc: Alexandre Belloni, Boris Brezillon, Claudiu Beznea,
Ludovic Desroches, Thomas Zimmermann, Sam Ravnborg, Peter Rosin,
linux-arm-kernel
[Ignore the first mail - wrong patch was attached]
Two small patches to drop the use of the drm irq mid-layer.
My atmel hlcdc target has stopped working - so unfortunately un-tested :-(
I picked up this to continue the work of Thomas Zimmermann.
Sam
Sam Ravnborg (2):
drm/atmel-hlcdc: Move interrupt helper funtions
drm/atmel-hlcdc: Convert to Linux IRQ interfaces
drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c | 63 +++++++++++++---------------
1 file changed, 30 insertions(+), 33 deletions(-)
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 12+ messages in thread
* [PATCH v1 0/2] drm/atmel-hlcdc: drop use of drm_irq mid-layer
@ 2021-07-11 9:19 ` Sam Ravnborg
0 siblings, 0 replies; 12+ messages in thread
From: Sam Ravnborg @ 2021-07-11 9:19 UTC (permalink / raw)
To: dri-devel
Cc: Alexandre Belloni, Boris Brezillon, Nicolas Ferre,
Claudiu Beznea, Ludovic Desroches, Thomas Zimmermann,
Sam Ravnborg, Peter Rosin, linux-arm-kernel
[Ignore the first mail - wrong patch was attached]
Two small patches to drop the use of the drm irq mid-layer.
My atmel hlcdc target has stopped working - so unfortunately un-tested :-(
I picked up this to continue the work of Thomas Zimmermann.
Sam
Sam Ravnborg (2):
drm/atmel-hlcdc: Move interrupt helper funtions
drm/atmel-hlcdc: Convert to Linux IRQ interfaces
drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c | 63 +++++++++++++---------------
1 file changed, 30 insertions(+), 33 deletions(-)
^ permalink raw reply [flat|nested] 12+ messages in thread
end of thread, other threads:[~2021-07-15 22:10 UTC | newest]
Thread overview: 12+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-11 9:16 [PATCH v1 0/2] drm/atmel-hlcdc: drop use of drm_irq mid-layer Sam Ravnborg
2021-07-11 9:16 ` Sam Ravnborg
2021-07-11 9:16 ` [PATCH 1/1] drm: bridge: Mark deprecated operations in drm_bridge_funcs Sam Ravnborg
2021-07-11 9:16 ` Sam Ravnborg
2021-07-11 9:20 ` Sam Ravnborg
2021-07-11 9:20 ` Sam Ravnborg
2021-07-11 9:19 [PATCH v1 0/2] drm/atmel-hlcdc: drop use of drm_irq mid-layer Sam Ravnborg
2021-07-11 9:19 ` Sam Ravnborg
2021-07-15 21:55 ` Dan.Sneddon
2021-07-15 21:55 ` Dan.Sneddon
2021-07-15 22:08 ` Sam Ravnborg
2021-07-15 22:08 ` Sam Ravnborg
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.