From: Kajol Jain <kjain@linux.ibm.com> To: will@kernel.org, hao.wu@intel.com, mark.rutland@arm.com Cc: trix@redhat.com, yilun.xu@intel.com, mdf@kernel.org, linux-fpga@vger.kernel.org, maddy@linux.ibm.com, atrajeev@linux.vnet.ibm.com, kjain@linux.ibm.com, linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, rnsastry@linux.ibm.com, linux-perf-users@vger.kernel.org, stable@vger.kernel.org Subject: [PATCH v3] fpga: dfl: fme: Fix cpu hotplug issue in performance reporting Date: Tue, 13 Jul 2021 13:12:16 +0530 [thread overview] Message-ID: <20210713074216.208391-1-kjain@linux.ibm.com> (raw) The performance reporting driver added cpu hotplug feature but it didn't add pmu migration call in cpu offline function. This can create an issue incase the current designated cpu being used to collect fme pmu data got offline, as based on current code we are not migrating fme pmu to new target cpu. Because of that perf will still try to fetch data from that offline cpu and hence we will not get counter data. Patch fixed this issue by adding pmu_migrate_context call in fme_perf_offline_cpu function. Fixes: 724142f8c42a ("fpga: dfl: fme: add performance reporting support") Tested-by: Xu Yilun <yilun.xu@intel.com> Acked-by: Wu Hao <hao.wu@intel.com> Signed-off-by: Kajol Jain <kjain@linux.ibm.com> Cc: stable@vger.kernel.org --- drivers/fpga/dfl-fme-perf.c | 2 ++ 1 file changed, 2 insertions(+) --- Changelog: v2 -> v3: - Added Acked-by tag - Removed comment as suggested by Wu Hao - Link to patch v2: https://lkml.org/lkml/2021/7/9/143 v1 -> v2: - Add stable@vger.kernel.org in cc list - Link to patch v1: https://lkml.org/lkml/2021/6/28/275 RFC -> PATCH v1 - Remove RFC tag - Did nits changes on subject and commit message as suggested by Xu Yilun - Added Tested-by tag - Link to rfc patch: https://lkml.org/lkml/2021/6/28/112 --- diff --git a/drivers/fpga/dfl-fme-perf.c b/drivers/fpga/dfl-fme-perf.c index 4299145ef347..587c82be12f7 100644 --- a/drivers/fpga/dfl-fme-perf.c +++ b/drivers/fpga/dfl-fme-perf.c @@ -953,6 +953,8 @@ static int fme_perf_offline_cpu(unsigned int cpu, struct hlist_node *node) return 0; priv->cpu = target; + perf_pmu_migrate_context(&priv->pmu, cpu, target); + return 0; } -- 2.31.1
WARNING: multiple messages have this Message-ID (diff)
From: Kajol Jain <kjain@linux.ibm.com> To: will@kernel.org, hao.wu@intel.com, mark.rutland@arm.com Cc: maddy@linux.ibm.com, rnsastry@linux.ibm.com, trix@redhat.com, linux-fpga@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, linux-perf-users@vger.kernel.org, atrajeev@linux.vnet.ibm.com, mdf@kernel.org, kjain@linux.ibm.com, linuxppc-dev@lists.ozlabs.org, yilun.xu@intel.com Subject: [PATCH v3] fpga: dfl: fme: Fix cpu hotplug issue in performance reporting Date: Tue, 13 Jul 2021 13:12:16 +0530 [thread overview] Message-ID: <20210713074216.208391-1-kjain@linux.ibm.com> (raw) The performance reporting driver added cpu hotplug feature but it didn't add pmu migration call in cpu offline function. This can create an issue incase the current designated cpu being used to collect fme pmu data got offline, as based on current code we are not migrating fme pmu to new target cpu. Because of that perf will still try to fetch data from that offline cpu and hence we will not get counter data. Patch fixed this issue by adding pmu_migrate_context call in fme_perf_offline_cpu function. Fixes: 724142f8c42a ("fpga: dfl: fme: add performance reporting support") Tested-by: Xu Yilun <yilun.xu@intel.com> Acked-by: Wu Hao <hao.wu@intel.com> Signed-off-by: Kajol Jain <kjain@linux.ibm.com> Cc: stable@vger.kernel.org --- drivers/fpga/dfl-fme-perf.c | 2 ++ 1 file changed, 2 insertions(+) --- Changelog: v2 -> v3: - Added Acked-by tag - Removed comment as suggested by Wu Hao - Link to patch v2: https://lkml.org/lkml/2021/7/9/143 v1 -> v2: - Add stable@vger.kernel.org in cc list - Link to patch v1: https://lkml.org/lkml/2021/6/28/275 RFC -> PATCH v1 - Remove RFC tag - Did nits changes on subject and commit message as suggested by Xu Yilun - Added Tested-by tag - Link to rfc patch: https://lkml.org/lkml/2021/6/28/112 --- diff --git a/drivers/fpga/dfl-fme-perf.c b/drivers/fpga/dfl-fme-perf.c index 4299145ef347..587c82be12f7 100644 --- a/drivers/fpga/dfl-fme-perf.c +++ b/drivers/fpga/dfl-fme-perf.c @@ -953,6 +953,8 @@ static int fme_perf_offline_cpu(unsigned int cpu, struct hlist_node *node) return 0; priv->cpu = target; + perf_pmu_migrate_context(&priv->pmu, cpu, target); + return 0; } -- 2.31.1
next reply other threads:[~2021-07-13 7:42 UTC|newest] Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-07-13 7:42 Kajol Jain [this message] 2021-07-13 7:42 ` [PATCH v3] fpga: dfl: fme: Fix cpu hotplug issue in performance reporting Kajol Jain 2021-08-02 7:45 ` kajoljain 2021-08-02 7:45 ` kajoljain 2021-08-02 8:58 ` Moritz Fischer 2021-08-02 8:58 ` Moritz Fischer 2021-08-02 11:46 ` kajoljain 2021-08-02 11:46 ` kajoljain
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20210713074216.208391-1-kjain@linux.ibm.com \ --to=kjain@linux.ibm.com \ --cc=atrajeev@linux.vnet.ibm.com \ --cc=hao.wu@intel.com \ --cc=linux-fpga@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-perf-users@vger.kernel.org \ --cc=linuxppc-dev@lists.ozlabs.org \ --cc=maddy@linux.ibm.com \ --cc=mark.rutland@arm.com \ --cc=mdf@kernel.org \ --cc=rnsastry@linux.ibm.com \ --cc=stable@vger.kernel.org \ --cc=trix@redhat.com \ --cc=will@kernel.org \ --cc=yilun.xu@intel.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.