All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH v2] ARM: dts: at91: sama5d4_xplained: Remove spi0 node
@ 2021-07-16 15:47 ` Tudor Ambarus
  0 siblings, 0 replies; 4+ messages in thread
From: Tudor Ambarus @ 2021-07-16 15:47 UTC (permalink / raw)
  To: nicolas.ferre, alexandre.belloni, ludovic.desroches
  Cc: claudiu.beznea, eugen.hristev, codrin.ciubotariu, emil.velikov,
	linux-arm-kernel, linux-kernel, Tudor Ambarus

sama5d4_xplained has an optional on-board serial DataFlash (AT25DF321A),
which does not come populated on board by default. Since the spi0 node
does not have any child populated by default, thus no user on
sama5d4_xplained, remove it. This avoids the following error in SPI NOR,
which reads the values of the pulled downed lines, unrecognizing the flash:

spi-nor spi0.0: unrecognized JEDEC id bytes: 00 00 00 00 00 00

Signed-off-by: Tudor Ambarus <tudor.ambarus@microchip.com>
---
 arch/arm/boot/dts/at91-sama5d4_xplained.dts | 10 ----------
 1 file changed, 10 deletions(-)

diff --git a/arch/arm/boot/dts/at91-sama5d4_xplained.dts b/arch/arm/boot/dts/at91-sama5d4_xplained.dts
index 0b3ad1b580b8..046796c5b9b0 100644
--- a/arch/arm/boot/dts/at91-sama5d4_xplained.dts
+++ b/arch/arm/boot/dts/at91-sama5d4_xplained.dts
@@ -38,16 +38,6 @@ uart0: serial@f8004000 {
 				status = "okay";
 			};
 
-			spi0: spi@f8010000 {
-				cs-gpios = <&pioC 3 0>, <0>, <0>, <0>;
-				status = "okay";
-				m25p80@0 {
-					compatible = "atmel,at25df321a";
-					spi-max-frequency = <50000000>;
-					reg = <0>;
-				};
-			};
-
 			i2c0: i2c@f8014000 {
 				i2c-digital-filter;
 				status = "okay";
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [PATCH v2] ARM: dts: at91: sama5d4_xplained: Remove spi0 node
@ 2021-07-16 15:47 ` Tudor Ambarus
  0 siblings, 0 replies; 4+ messages in thread
From: Tudor Ambarus @ 2021-07-16 15:47 UTC (permalink / raw)
  To: nicolas.ferre, alexandre.belloni, ludovic.desroches
  Cc: claudiu.beznea, eugen.hristev, codrin.ciubotariu, emil.velikov,
	linux-arm-kernel, linux-kernel, Tudor Ambarus

sama5d4_xplained has an optional on-board serial DataFlash (AT25DF321A),
which does not come populated on board by default. Since the spi0 node
does not have any child populated by default, thus no user on
sama5d4_xplained, remove it. This avoids the following error in SPI NOR,
which reads the values of the pulled downed lines, unrecognizing the flash:

spi-nor spi0.0: unrecognized JEDEC id bytes: 00 00 00 00 00 00

Signed-off-by: Tudor Ambarus <tudor.ambarus@microchip.com>
---
 arch/arm/boot/dts/at91-sama5d4_xplained.dts | 10 ----------
 1 file changed, 10 deletions(-)

diff --git a/arch/arm/boot/dts/at91-sama5d4_xplained.dts b/arch/arm/boot/dts/at91-sama5d4_xplained.dts
index 0b3ad1b580b8..046796c5b9b0 100644
--- a/arch/arm/boot/dts/at91-sama5d4_xplained.dts
+++ b/arch/arm/boot/dts/at91-sama5d4_xplained.dts
@@ -38,16 +38,6 @@ uart0: serial@f8004000 {
 				status = "okay";
 			};
 
-			spi0: spi@f8010000 {
-				cs-gpios = <&pioC 3 0>, <0>, <0>, <0>;
-				status = "okay";
-				m25p80@0 {
-					compatible = "atmel,at25df321a";
-					spi-max-frequency = <50000000>;
-					reg = <0>;
-				};
-			};
-
 			i2c0: i2c@f8014000 {
 				i2c-digital-filter;
 				status = "okay";
-- 
2.25.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH v2] ARM: dts: at91: sama5d4_xplained: Remove spi0 node
  2021-07-16 15:47 ` Tudor Ambarus
@ 2021-07-16 19:15   ` Nicolas Ferre
  -1 siblings, 0 replies; 4+ messages in thread
From: Nicolas Ferre @ 2021-07-16 19:15 UTC (permalink / raw)
  To: Tudor Ambarus, alexandre.belloni, ludovic.desroches
  Cc: claudiu.beznea, eugen.hristev, codrin.ciubotariu, emil.velikov,
	linux-arm-kernel, linux-kernel

On 16/07/2021 at 17:47, Tudor Ambarus wrote:
> sama5d4_xplained has an optional on-board serial DataFlash (AT25DF321A),
> which does not come populated on board by default. Since the spi0 node
> does not have any child populated by default, thus no user on
> sama5d4_xplained, remove it. This avoids the following error in SPI NOR,
> which reads the values of the pulled downed lines, unrecognizing the flash:
> 
> spi-nor spi0.0: unrecognized JEDEC id bytes: 00 00 00 00 00 00
> 
> Signed-off-by: Tudor Ambarus <tudor.ambarus@microchip.com>

Acked-by: Nicolas Ferre <nicolas.ferre@microchip.com>

Queued in at91-dt.

Regards,
   Nicolas

> ---
>   arch/arm/boot/dts/at91-sama5d4_xplained.dts | 10 ----------
>   1 file changed, 10 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/at91-sama5d4_xplained.dts b/arch/arm/boot/dts/at91-sama5d4_xplained.dts
> index 0b3ad1b580b8..046796c5b9b0 100644
> --- a/arch/arm/boot/dts/at91-sama5d4_xplained.dts
> +++ b/arch/arm/boot/dts/at91-sama5d4_xplained.dts
> @@ -38,16 +38,6 @@ uart0: serial@f8004000 {
>   				status = "okay";
>   			};
>   
> -			spi0: spi@f8010000 {
> -				cs-gpios = <&pioC 3 0>, <0>, <0>, <0>;
> -				status = "okay";
> -				m25p80@0 {
> -					compatible = "atmel,at25df321a";
> -					spi-max-frequency = <50000000>;
> -					reg = <0>;
> -				};
> -			};
> -
>   			i2c0: i2c@f8014000 {
>   				i2c-digital-filter;
>   				status = "okay";
> 


-- 
Nicolas Ferre

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH v2] ARM: dts: at91: sama5d4_xplained: Remove spi0 node
@ 2021-07-16 19:15   ` Nicolas Ferre
  0 siblings, 0 replies; 4+ messages in thread
From: Nicolas Ferre @ 2021-07-16 19:15 UTC (permalink / raw)
  To: Tudor Ambarus, alexandre.belloni, ludovic.desroches
  Cc: claudiu.beznea, eugen.hristev, codrin.ciubotariu, emil.velikov,
	linux-arm-kernel, linux-kernel

On 16/07/2021 at 17:47, Tudor Ambarus wrote:
> sama5d4_xplained has an optional on-board serial DataFlash (AT25DF321A),
> which does not come populated on board by default. Since the spi0 node
> does not have any child populated by default, thus no user on
> sama5d4_xplained, remove it. This avoids the following error in SPI NOR,
> which reads the values of the pulled downed lines, unrecognizing the flash:
> 
> spi-nor spi0.0: unrecognized JEDEC id bytes: 00 00 00 00 00 00
> 
> Signed-off-by: Tudor Ambarus <tudor.ambarus@microchip.com>

Acked-by: Nicolas Ferre <nicolas.ferre@microchip.com>

Queued in at91-dt.

Regards,
   Nicolas

> ---
>   arch/arm/boot/dts/at91-sama5d4_xplained.dts | 10 ----------
>   1 file changed, 10 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/at91-sama5d4_xplained.dts b/arch/arm/boot/dts/at91-sama5d4_xplained.dts
> index 0b3ad1b580b8..046796c5b9b0 100644
> --- a/arch/arm/boot/dts/at91-sama5d4_xplained.dts
> +++ b/arch/arm/boot/dts/at91-sama5d4_xplained.dts
> @@ -38,16 +38,6 @@ uart0: serial@f8004000 {
>   				status = "okay";
>   			};
>   
> -			spi0: spi@f8010000 {
> -				cs-gpios = <&pioC 3 0>, <0>, <0>, <0>;
> -				status = "okay";
> -				m25p80@0 {
> -					compatible = "atmel,at25df321a";
> -					spi-max-frequency = <50000000>;
> -					reg = <0>;
> -				};
> -			};
> -
>   			i2c0: i2c@f8014000 {
>   				i2c-digital-filter;
>   				status = "okay";
> 


-- 
Nicolas Ferre

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2021-07-16 19:17 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-16 15:47 [PATCH v2] ARM: dts: at91: sama5d4_xplained: Remove spi0 node Tudor Ambarus
2021-07-16 15:47 ` Tudor Ambarus
2021-07-16 19:15 ` Nicolas Ferre
2021-07-16 19:15   ` Nicolas Ferre

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.