All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: Jens Axboe <axboe@kernel.dk>, Mike Snitzer <snitzer@redhat.com>
Cc: dm-devel@redhat.com, linux-block@vger.kernel.org
Subject: use regular gendisk registration in device mapper
Date: Sun, 25 Jul 2021 07:54:50 +0200	[thread overview]
Message-ID: <20210725055458.29008-1-hch@lst.de> (raw)

Hi all,

The device mapper code currently has a somewhat odd gendisk registration
scheme where it calls add_disk early, but uses a special flag to skip the
"queue registration", which is a major part of add_disk.  This series
improves the block layer holder tracking to work on an entirely
unregistered disk and thus allows device mapper to use the normal scheme
of calling add_disk when it is ready to accept I/O.

Note that this leads to a user visible change - the sysfs attributes on
the disk and the dm directory hanging off it are not only visible once
the initial table is loaded.  This did not make a different to my testing
using dmsetup and the lvm2 tools.

Diffstat:
 block/Kconfig             |    4 +
 block/Makefile            |    1 
 block/elevator.c          |    1 
 block/genhd.c             |   42 +++++------
 block/holder.c            |  167 ++++++++++++++++++++++++++++++++++++++++++++++
 drivers/md/Kconfig        |    2 
 drivers/md/bcache/Kconfig |    1 
 drivers/md/dm-ioctl.c     |    4 -
 drivers/md/dm-rq.c        |    1 
 drivers/md/dm.c           |   32 +++-----
 fs/block_dev.c            |  145 ---------------------------------------
 include/linux/blk_types.h |    3 
 include/linux/genhd.h     |   19 ++---
 13 files changed, 219 insertions(+), 203 deletions(-)

WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@lst.de>
To: Jens Axboe <axboe@kernel.dk>, Mike Snitzer <snitzer@redhat.com>
Cc: linux-block@vger.kernel.org, dm-devel@redhat.com
Subject: [dm-devel] use regular gendisk registration in device mapper
Date: Sun, 25 Jul 2021 07:54:50 +0200	[thread overview]
Message-ID: <20210725055458.29008-1-hch@lst.de> (raw)

Hi all,

The device mapper code currently has a somewhat odd gendisk registration
scheme where it calls add_disk early, but uses a special flag to skip the
"queue registration", which is a major part of add_disk.  This series
improves the block layer holder tracking to work on an entirely
unregistered disk and thus allows device mapper to use the normal scheme
of calling add_disk when it is ready to accept I/O.

Note that this leads to a user visible change - the sysfs attributes on
the disk and the dm directory hanging off it are not only visible once
the initial table is loaded.  This did not make a different to my testing
using dmsetup and the lvm2 tools.

Diffstat:
 block/Kconfig             |    4 +
 block/Makefile            |    1 
 block/elevator.c          |    1 
 block/genhd.c             |   42 +++++------
 block/holder.c            |  167 ++++++++++++++++++++++++++++++++++++++++++++++
 drivers/md/Kconfig        |    2 
 drivers/md/bcache/Kconfig |    1 
 drivers/md/dm-ioctl.c     |    4 -
 drivers/md/dm-rq.c        |    1 
 drivers/md/dm.c           |   32 +++-----
 fs/block_dev.c            |  145 ---------------------------------------
 include/linux/blk_types.h |    3 
 include/linux/genhd.h     |   19 ++---
 13 files changed, 219 insertions(+), 203 deletions(-)

--
dm-devel mailing list
dm-devel@redhat.com
https://listman.redhat.com/mailman/listinfo/dm-devel


             reply	other threads:[~2021-07-25  5:55 UTC|newest]

Thread overview: 58+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-25  5:54 Christoph Hellwig [this message]
2021-07-25  5:54 ` [dm-devel] use regular gendisk registration in device mapper Christoph Hellwig
2021-07-25  5:54 ` [PATCH 1/8] block: make the block holder code optional Christoph Hellwig
2021-07-25  5:54   ` [dm-devel] " Christoph Hellwig
2021-07-29 16:25   ` Mike Snitzer
2021-07-29 16:25     ` [dm-devel] " Mike Snitzer
2021-07-25  5:54 ` [PATCH 2/8] block: remove the extra kobject reference in bd_link_disk_holder Christoph Hellwig
2021-07-25  5:54   ` [dm-devel] " Christoph Hellwig
2021-07-29 16:27   ` Mike Snitzer
2021-07-29 16:27     ` [dm-devel] " Mike Snitzer
2021-07-25  5:54 ` [PATCH 3/8] block: look up holders by bdev Christoph Hellwig
2021-07-25  5:54   ` [dm-devel] " Christoph Hellwig
2021-07-25  5:54 ` [PATCH 4/8] block: support delayed holder registration Christoph Hellwig
2021-07-25  5:54   ` [dm-devel] " Christoph Hellwig
2021-07-27 16:06   ` Mike Snitzer
2021-07-27 16:06     ` [dm-devel] " Mike Snitzer
2021-07-28  6:54     ` Christoph Hellwig
2021-07-28  6:54       ` [dm-devel] " Christoph Hellwig
2021-07-29 16:32   ` Mike Snitzer
2021-07-29 16:32     ` [dm-devel] " Mike Snitzer
2021-07-25  5:54 ` [PATCH 5/8] dm: cleanup cleanup_mapped_device Christoph Hellwig
2021-07-25  5:54   ` [dm-devel] " Christoph Hellwig
2021-07-29 16:33   ` Mike Snitzer
2021-07-29 16:33     ` [dm-devel] " Mike Snitzer
2021-07-25  5:54 ` [PATCH 6/8] dm: move setting md->type into dm_setup_md_queue Christoph Hellwig
2021-07-25  5:54   ` [dm-devel] " Christoph Hellwig
2021-07-29 16:34   ` Mike Snitzer
2021-07-29 16:34     ` [dm-devel] " Mike Snitzer
2021-07-25  5:54 ` [PATCH 7/8] dm: delay registering the gendisk Christoph Hellwig
2021-07-25  5:54   ` [dm-devel] " Christoph Hellwig
2021-07-29 16:36   ` Mike Snitzer
2021-07-29 16:36     ` [dm-devel] " Mike Snitzer
2021-07-25  5:54 ` [PATCH 8/8] block: remove support for delayed queue registrations Christoph Hellwig
2021-07-25  5:54   ` [dm-devel] " Christoph Hellwig
2021-07-29 16:37   ` Mike Snitzer
2021-07-29 16:37     ` [dm-devel] " Mike Snitzer
2021-07-27 15:58 ` use regular gendisk registration in device mapper Mike Snitzer
2021-07-27 15:58   ` [dm-devel] " Mike Snitzer
2021-07-27 16:02   ` Christoph Hellwig
2021-07-27 16:02     ` [dm-devel] " Christoph Hellwig
2021-07-27 16:18     ` Mike Snitzer
2021-07-27 16:18       ` [dm-devel] " Mike Snitzer
2021-07-27 20:38       ` Milan Broz
2021-07-27 20:38         ` Milan Broz
2021-07-28  7:06         ` Christoph Hellwig
2021-07-28  7:06           ` Christoph Hellwig
2021-07-28  8:37           ` Milan Broz
2021-07-28  8:37             ` Milan Broz
2021-07-28 11:24             ` Christoph Hellwig
2021-07-28 11:24               ` Christoph Hellwig
2021-07-29 15:01               ` Milan Broz
2021-07-29 15:01                 ` Milan Broz
2021-07-28 16:17         ` Mike Snitzer
2021-07-28 16:17           ` [dm-devel] " Mike Snitzer
2021-07-29  7:50           ` Milan Broz
2021-07-29  7:50             ` [dm-devel] " Milan Broz
2021-07-27 22:52       ` Mike Snitzer
2021-07-27 22:52         ` [dm-devel] " Mike Snitzer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210725055458.29008-1-hch@lst.de \
    --to=hch@lst.de \
    --cc=axboe@kernel.dk \
    --cc=dm-devel@redhat.com \
    --cc=linux-block@vger.kernel.org \
    --cc=snitzer@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.