From: Sudeep Holla <sudeep.holla@arm.com> To: Cristian Marussi <cristian.marussi@arm.com> Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, virtualization@lists.linux-foundation.org, virtio-dev@lists.oasis-open.org, james.quinlan@broadcom.com, Jonathan.Cameron@Huawei.com, f.fainelli@gmail.com, etienne.carriere@linaro.org, vincent.guittot@linaro.org, souvik.chakravarty@arm.com, igor.skalkin@opensynergy.com, peter.hilber@opensynergy.com, alex.bennee@linaro.org, jean-philippe@linaro.org, mikhail.golubev@opensynergy.com, anton.yakovlev@opensynergy.com, Vasyl.Vavrychuk@opensynergy.com, Sudeep Holla <sudeep.holla@arm.com>, Andriy.Tryshnivskyy@opensynergy.com Subject: Re: [PATCH v6 11/17] firmware: arm_scmi: Make SCMI transports configurable Date: Wed, 28 Jul 2021 15:50:33 +0100 [thread overview] Message-ID: <20210728145033.wpobgpxane2t2brc@bogus> (raw) In-Reply-To: <20210712141833.6628-12-cristian.marussi@arm.com> On Mon, Jul 12, 2021 at 03:18:27PM +0100, Cristian Marussi wrote: > Add configuration options to be able to select which SCMI transports have > to be compiled into the SCMI stack. > > Mailbox and SMC are by default enabled if their related dependencies are > satisfied. > > While doing that move all SCMI related config options in their own > dedicated submenu. > > Signed-off-by: Cristian Marussi <cristian.marussi@arm.com> > --- > Used a BUILD_BUG_ON() to avoid the scenario where SCMI is configured > without any transport. Coul dnot do in any other way in Kconfig due to > circular dependencies. > > This will be neeed later on to add new Virtio based transport and > optionally exclude other transports. > --- > drivers/firmware/Kconfig | 34 +-------------- > drivers/firmware/arm_scmi/Kconfig | 70 ++++++++++++++++++++++++++++++ > drivers/firmware/arm_scmi/Makefile | 4 +- > drivers/firmware/arm_scmi/common.h | 4 +- > drivers/firmware/arm_scmi/driver.c | 6 ++- > 5 files changed, 80 insertions(+), 38 deletions(-) > create mode 100644 drivers/firmware/arm_scmi/Kconfig > > diff --git a/drivers/firmware/Kconfig b/drivers/firmware/Kconfig > index 1db738d5b301..8d41f73f5395 100644 > --- a/drivers/firmware/Kconfig > +++ b/drivers/firmware/Kconfig > @@ -6,39 +6,7 @@ > > menu "Firmware Drivers" > > -config ARM_SCMI_PROTOCOL > - tristate "ARM System Control and Management Interface (SCMI) Message Protocol" > - depends on ARM || ARM64 || COMPILE_TEST > - depends on MAILBOX || HAVE_ARM_SMCCC_DISCOVERY > - help > - ARM System Control and Management Interface (SCMI) protocol is a > - set of operating system-independent software interfaces that are > - used in system management. SCMI is extensible and currently provides > - interfaces for: Discovery and self-description of the interfaces > - it supports, Power domain management which is the ability to place > - a given device or domain into the various power-saving states that > - it supports, Performance management which is the ability to control > - the performance of a domain that is composed of compute engines > - such as application processors and other accelerators, Clock > - management which is the ability to set and inquire rates on platform > - managed clocks and Sensor management which is the ability to read > - sensor data, and be notified of sensor value. > - > - This protocol library provides interface for all the client drivers > - making use of the features offered by the SCMI. > - > -config ARM_SCMI_POWER_DOMAIN > - tristate "SCMI power domain driver" > - depends on ARM_SCMI_PROTOCOL || (COMPILE_TEST && OF) > - default y > - select PM_GENERIC_DOMAINS if PM > - help > - This enables support for the SCMI power domains which can be > - enabled or disabled via the SCP firmware > - > - This driver can also be built as a module. If so, the module > - will be called scmi_pm_domain. Note this may needed early in boot > - before rootfs may be available. > +source "drivers/firmware/arm_scmi/Kconfig" > > config ARM_SCPI_PROTOCOL > tristate "ARM System Control and Power Interface (SCPI) Message Protocol" > diff --git a/drivers/firmware/arm_scmi/Kconfig b/drivers/firmware/arm_scmi/Kconfig > new file mode 100644 > index 000000000000..479fc8a3533e > --- /dev/null > +++ b/drivers/firmware/arm_scmi/Kconfig > @@ -0,0 +1,70 @@ > +# SPDX-License-Identifier: GPL-2.0-only > +menu "ARM System Control and Management Interface Protocol" > + > +config ARM_SCMI_PROTOCOL > + tristate "ARM System Control and Management Interface (SCMI) Message Protocol" > + depends on ARM || ARM64 || COMPILE_TEST > + help > + ARM System Control and Management Interface (SCMI) protocol is a > + set of operating system-independent software interfaces that are > + used in system management. SCMI is extensible and currently provides > + interfaces for: Discovery and self-description of the interfaces > + it supports, Power domain management which is the ability to place > + a given device or domain into the various power-saving states that > + it supports, Performance management which is the ability to control > + the performance of a domain that is composed of compute engines > + such as application processors and other accelerators, Clock > + management which is the ability to set and inquire rates on platform > + managed clocks and Sensor management which is the ability to read > + sensor data, and be notified of sensor value. > + > + This protocol library provides interface for all the client drivers > + making use of the features offered by the SCMI. > + May be you can add if condition here to remove the depends on ARM_SCMI_PROTOCOL if ARM_SCMI_PROTOCOL > +config ARM_SCMI_HAVE_TRANSPORT > + bool > + help > + This declares whether at least one SCMI transport has been configured. > + Used to trigger a build bug when trying to build SCMI without any > + configured transport. > + > +config ARM_SCMI_TRANSPORT_MAILBOX > + bool "SCMI transport based on Mailbox" > + depends on ARM_SCMI_PROTOCOL && MAILBOX And drop ARM_SCMI_PROTOCOL above > + select ARM_SCMI_HAVE_TRANSPORT > + default y Do we need a user visible choice if it is always default on ? > + help > + Enable mailbox based transport for SCMI. > + > + If you want the ARM SCMI PROTOCOL stack to include support for a > + transport based on mailboxes, answer Y. > + A matching DT entry will also be needed to indicate the effective > + presence of this kind of transport. > + I would drop the above comment on matching DT. > +config ARM_SCMI_TRANSPORT_SMC > + bool "SCMI transport based on SMC" > + depends on ARM_SCMI_PROTOCOL && HAVE_ARM_SMCCC_DISCOVERY Ditto > + select ARM_SCMI_HAVE_TRANSPORT > + default y > + help > + Enable SMC based transport for SCMI. > + > + If you want the ARM SCMI PROTOCOL stack to include support for a > + transport based on SMC, answer Y. > + A matching DT entry will also be needed to indicate the effective > + presence of this kind of transport. > + endif #ARM_SCMI_PROTOCOL -- Regards, Sudeep
WARNING: multiple messages have this Message-ID (diff)
From: Sudeep Holla <sudeep.holla@arm.com> To: Cristian Marussi <cristian.marussi@arm.com> Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, virtualization@lists.linux-foundation.org, virtio-dev@lists.oasis-open.org, james.quinlan@broadcom.com, Jonathan.Cameron@Huawei.com, f.fainelli@gmail.com, etienne.carriere@linaro.org, vincent.guittot@linaro.org, souvik.chakravarty@arm.com, igor.skalkin@opensynergy.com, peter.hilber@opensynergy.com, alex.bennee@linaro.org, jean-philippe@linaro.org, mikhail.golubev@opensynergy.com, anton.yakovlev@opensynergy.com, Vasyl.Vavrychuk@opensynergy.com, Sudeep Holla <sudeep.holla@arm.com>, Andriy.Tryshnivskyy@opensynergy.com Subject: Re: [PATCH v6 11/17] firmware: arm_scmi: Make SCMI transports configurable Date: Wed, 28 Jul 2021 15:50:33 +0100 [thread overview] Message-ID: <20210728145033.wpobgpxane2t2brc@bogus> (raw) In-Reply-To: <20210712141833.6628-12-cristian.marussi@arm.com> On Mon, Jul 12, 2021 at 03:18:27PM +0100, Cristian Marussi wrote: > Add configuration options to be able to select which SCMI transports have > to be compiled into the SCMI stack. > > Mailbox and SMC are by default enabled if their related dependencies are > satisfied. > > While doing that move all SCMI related config options in their own > dedicated submenu. > > Signed-off-by: Cristian Marussi <cristian.marussi@arm.com> > --- > Used a BUILD_BUG_ON() to avoid the scenario where SCMI is configured > without any transport. Coul dnot do in any other way in Kconfig due to > circular dependencies. > > This will be neeed later on to add new Virtio based transport and > optionally exclude other transports. > --- > drivers/firmware/Kconfig | 34 +-------------- > drivers/firmware/arm_scmi/Kconfig | 70 ++++++++++++++++++++++++++++++ > drivers/firmware/arm_scmi/Makefile | 4 +- > drivers/firmware/arm_scmi/common.h | 4 +- > drivers/firmware/arm_scmi/driver.c | 6 ++- > 5 files changed, 80 insertions(+), 38 deletions(-) > create mode 100644 drivers/firmware/arm_scmi/Kconfig > > diff --git a/drivers/firmware/Kconfig b/drivers/firmware/Kconfig > index 1db738d5b301..8d41f73f5395 100644 > --- a/drivers/firmware/Kconfig > +++ b/drivers/firmware/Kconfig > @@ -6,39 +6,7 @@ > > menu "Firmware Drivers" > > -config ARM_SCMI_PROTOCOL > - tristate "ARM System Control and Management Interface (SCMI) Message Protocol" > - depends on ARM || ARM64 || COMPILE_TEST > - depends on MAILBOX || HAVE_ARM_SMCCC_DISCOVERY > - help > - ARM System Control and Management Interface (SCMI) protocol is a > - set of operating system-independent software interfaces that are > - used in system management. SCMI is extensible and currently provides > - interfaces for: Discovery and self-description of the interfaces > - it supports, Power domain management which is the ability to place > - a given device or domain into the various power-saving states that > - it supports, Performance management which is the ability to control > - the performance of a domain that is composed of compute engines > - such as application processors and other accelerators, Clock > - management which is the ability to set and inquire rates on platform > - managed clocks and Sensor management which is the ability to read > - sensor data, and be notified of sensor value. > - > - This protocol library provides interface for all the client drivers > - making use of the features offered by the SCMI. > - > -config ARM_SCMI_POWER_DOMAIN > - tristate "SCMI power domain driver" > - depends on ARM_SCMI_PROTOCOL || (COMPILE_TEST && OF) > - default y > - select PM_GENERIC_DOMAINS if PM > - help > - This enables support for the SCMI power domains which can be > - enabled or disabled via the SCP firmware > - > - This driver can also be built as a module. If so, the module > - will be called scmi_pm_domain. Note this may needed early in boot > - before rootfs may be available. > +source "drivers/firmware/arm_scmi/Kconfig" > > config ARM_SCPI_PROTOCOL > tristate "ARM System Control and Power Interface (SCPI) Message Protocol" > diff --git a/drivers/firmware/arm_scmi/Kconfig b/drivers/firmware/arm_scmi/Kconfig > new file mode 100644 > index 000000000000..479fc8a3533e > --- /dev/null > +++ b/drivers/firmware/arm_scmi/Kconfig > @@ -0,0 +1,70 @@ > +# SPDX-License-Identifier: GPL-2.0-only > +menu "ARM System Control and Management Interface Protocol" > + > +config ARM_SCMI_PROTOCOL > + tristate "ARM System Control and Management Interface (SCMI) Message Protocol" > + depends on ARM || ARM64 || COMPILE_TEST > + help > + ARM System Control and Management Interface (SCMI) protocol is a > + set of operating system-independent software interfaces that are > + used in system management. SCMI is extensible and currently provides > + interfaces for: Discovery and self-description of the interfaces > + it supports, Power domain management which is the ability to place > + a given device or domain into the various power-saving states that > + it supports, Performance management which is the ability to control > + the performance of a domain that is composed of compute engines > + such as application processors and other accelerators, Clock > + management which is the ability to set and inquire rates on platform > + managed clocks and Sensor management which is the ability to read > + sensor data, and be notified of sensor value. > + > + This protocol library provides interface for all the client drivers > + making use of the features offered by the SCMI. > + May be you can add if condition here to remove the depends on ARM_SCMI_PROTOCOL if ARM_SCMI_PROTOCOL > +config ARM_SCMI_HAVE_TRANSPORT > + bool > + help > + This declares whether at least one SCMI transport has been configured. > + Used to trigger a build bug when trying to build SCMI without any > + configured transport. > + > +config ARM_SCMI_TRANSPORT_MAILBOX > + bool "SCMI transport based on Mailbox" > + depends on ARM_SCMI_PROTOCOL && MAILBOX And drop ARM_SCMI_PROTOCOL above > + select ARM_SCMI_HAVE_TRANSPORT > + default y Do we need a user visible choice if it is always default on ? > + help > + Enable mailbox based transport for SCMI. > + > + If you want the ARM SCMI PROTOCOL stack to include support for a > + transport based on mailboxes, answer Y. > + A matching DT entry will also be needed to indicate the effective > + presence of this kind of transport. > + I would drop the above comment on matching DT. > +config ARM_SCMI_TRANSPORT_SMC > + bool "SCMI transport based on SMC" > + depends on ARM_SCMI_PROTOCOL && HAVE_ARM_SMCCC_DISCOVERY Ditto > + select ARM_SCMI_HAVE_TRANSPORT > + default y > + help > + Enable SMC based transport for SCMI. > + > + If you want the ARM SCMI PROTOCOL stack to include support for a > + transport based on SMC, answer Y. > + A matching DT entry will also be needed to indicate the effective > + presence of this kind of transport. > + endif #ARM_SCMI_PROTOCOL -- Regards, Sudeep _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-07-28 14:51 UTC|newest] Thread overview: 110+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-07-12 14:18 [PATCH v6 00/17] Introduce SCMI transport based on VirtIO Cristian Marussi 2021-07-12 14:18 ` Cristian Marussi 2021-07-12 14:18 ` [PATCH v6 01/17] firmware: arm_scmi: Avoid padding in sensor message structure Cristian Marussi 2021-07-12 14:18 ` Cristian Marussi 2021-07-12 14:18 ` [PATCH v6 02/17] firmware: arm_scmi: Fix max pending messages boundary check Cristian Marussi 2021-07-12 14:18 ` Cristian Marussi 2021-07-14 16:46 ` Sudeep Holla 2021-07-14 16:46 ` Sudeep Holla 2021-07-12 14:18 ` [PATCH v6 03/17] firmware: arm_scmi: Add support for type handling in common functions Cristian Marussi 2021-07-12 14:18 ` Cristian Marussi 2021-07-12 14:18 ` [PATCH v6 04/17] firmware: arm_scmi: Remove scmi_dump_header_dbg() helper Cristian Marussi 2021-07-12 14:18 ` Cristian Marussi 2021-07-12 14:18 ` [PATCH v6 05/17] firmware: arm_scmi: Add transport optional init/exit support Cristian Marussi 2021-07-12 14:18 ` Cristian Marussi 2021-07-28 11:40 ` Sudeep Holla 2021-07-28 11:40 ` Sudeep Holla 2021-07-28 12:28 ` Cristian Marussi 2021-07-28 12:28 ` Cristian Marussi 2021-07-12 14:18 ` [PATCH v6 06/17] firmware: arm_scmi: Introduce monotonically increasing tokens Cristian Marussi 2021-07-12 14:18 ` Cristian Marussi 2021-07-28 14:17 ` Sudeep Holla 2021-07-28 14:17 ` Sudeep Holla 2021-07-28 16:54 ` Cristian Marussi 2021-07-28 16:54 ` [virtio-dev] " Cristian Marussi 2021-07-28 16:54 ` Cristian Marussi 2021-08-02 10:24 ` Sudeep Holla 2021-08-02 10:24 ` Sudeep Holla 2021-08-03 12:52 ` Cristian Marussi 2021-08-03 12:52 ` [virtio-dev] " Cristian Marussi 2021-08-03 12:52 ` Cristian Marussi 2021-07-12 14:18 ` [PATCH v6 07/17] firmware: arm_scmi: Handle concurrent and out-of-order messages Cristian Marussi 2021-07-12 14:18 ` Cristian Marussi 2021-07-15 16:36 ` Peter Hilber 2021-07-15 16:36 ` [virtio-dev] " Peter Hilber 2021-07-15 16:36 ` Peter Hilber 2021-07-19 9:14 ` Cristian Marussi 2021-07-19 9:14 ` Cristian Marussi 2021-07-22 8:32 ` Peter Hilber 2021-07-22 8:32 ` [virtio-dev] " Peter Hilber 2021-07-22 8:32 ` Peter Hilber 2021-07-28 8:31 ` Cristian Marussi 2021-07-28 8:31 ` Cristian Marussi 2021-08-02 10:10 ` Sudeep Holla 2021-08-02 10:10 ` Sudeep Holla 2021-08-02 10:27 ` Cristian Marussi 2021-08-02 10:27 ` [virtio-dev] " Cristian Marussi 2021-08-02 10:27 ` Cristian Marussi 2021-07-12 14:18 ` [PATCH v6 08/17] firmware: arm_scmi: Add priv parameter to scmi_rx_callback Cristian Marussi 2021-07-12 14:18 ` Cristian Marussi 2021-07-28 14:26 ` Sudeep Holla 2021-07-28 14:26 ` Sudeep Holla 2021-07-28 17:25 ` Cristian Marussi 2021-07-28 17:25 ` [virtio-dev] " Cristian Marussi 2021-07-28 17:25 ` Cristian Marussi 2021-07-12 14:18 ` [PATCH v6 09/17] firmware: arm_scmi: Make .clear_channel optional Cristian Marussi 2021-07-12 14:18 ` Cristian Marussi 2021-07-12 14:18 ` [PATCH v6 10/17] firmware: arm_scmi: Make polling mode optional Cristian Marussi 2021-07-12 14:18 ` Cristian Marussi 2021-07-15 16:36 ` Peter Hilber 2021-07-15 16:36 ` [virtio-dev] " Peter Hilber 2021-07-15 16:36 ` Peter Hilber 2021-07-19 9:15 ` Cristian Marussi 2021-07-19 9:15 ` Cristian Marussi 2021-07-28 14:34 ` Sudeep Holla 2021-07-28 14:34 ` Sudeep Holla 2021-07-28 17:41 ` Cristian Marussi 2021-07-28 17:41 ` [virtio-dev] " Cristian Marussi 2021-07-28 17:41 ` Cristian Marussi 2021-07-12 14:18 ` [PATCH v6 11/17] firmware: arm_scmi: Make SCMI transports configurable Cristian Marussi 2021-07-12 14:18 ` Cristian Marussi 2021-07-28 14:50 ` Sudeep Holla [this message] 2021-07-28 14:50 ` Sudeep Holla 2021-07-29 16:18 ` Cristian Marussi 2021-07-29 16:18 ` [virtio-dev] " Cristian Marussi 2021-07-29 16:18 ` Cristian Marussi 2021-07-12 14:18 ` [PATCH v6 12/17] firmware: arm_scmi: Make shmem support optional for transports Cristian Marussi 2021-07-12 14:18 ` Cristian Marussi 2021-07-12 14:18 ` [PATCH v6 13/17] firmware: arm_scmi: Add method to override max message number Cristian Marussi 2021-07-12 14:18 ` Cristian Marussi 2021-07-12 14:18 ` [PATCH v6 14/17] firmware: arm_scmi: Add message passing abstractions for transports Cristian Marussi 2021-07-12 14:18 ` Cristian Marussi 2021-07-15 16:36 ` Peter Hilber 2021-07-15 16:36 ` [virtio-dev] " Peter Hilber 2021-07-15 16:36 ` Peter Hilber 2021-07-19 9:16 ` Cristian Marussi 2021-07-19 9:16 ` Cristian Marussi 2021-07-12 14:18 ` [PATCH v6 15/17] firmware: arm_scmi: Add optional link_supplier() transport op Cristian Marussi 2021-07-12 14:18 ` Cristian Marussi 2021-07-28 15:36 ` Sudeep Holla 2021-07-28 15:36 ` Sudeep Holla 2021-07-29 16:19 ` Cristian Marussi 2021-07-29 16:19 ` [virtio-dev] " Cristian Marussi 2021-07-29 16:19 ` Cristian Marussi 2021-07-12 14:18 ` [PATCH v6 16/17] dt-bindings: arm: Add virtio transport for SCMI Cristian Marussi 2021-07-12 14:18 ` Cristian Marussi 2021-07-12 14:18 ` [PATCH v6 17/17] firmware: arm_scmi: Add virtio transport Cristian Marussi 2021-07-12 14:18 ` Cristian Marussi 2021-07-15 16:35 ` [PATCH v6 00/17] Introduce SCMI transport based on VirtIO Peter Hilber 2021-07-15 16:35 ` [virtio-dev] " Peter Hilber 2021-07-15 16:35 ` Peter Hilber 2021-07-19 11:36 ` Cristian Marussi 2021-07-19 11:36 ` Cristian Marussi 2021-07-22 8:30 ` Peter Hilber 2021-07-22 8:30 ` [virtio-dev] " Peter Hilber 2021-07-22 8:30 ` Peter Hilber 2021-08-11 9:31 ` Floris Westermann 2021-08-11 9:31 ` Floris Westermann 2021-08-11 15:26 ` Cristian Marussi 2021-08-11 15:26 ` [virtio-dev] " Cristian Marussi 2021-08-11 15:26 ` Cristian Marussi
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20210728145033.wpobgpxane2t2brc@bogus \ --to=sudeep.holla@arm.com \ --cc=Andriy.Tryshnivskyy@opensynergy.com \ --cc=Jonathan.Cameron@Huawei.com \ --cc=Vasyl.Vavrychuk@opensynergy.com \ --cc=alex.bennee@linaro.org \ --cc=anton.yakovlev@opensynergy.com \ --cc=cristian.marussi@arm.com \ --cc=etienne.carriere@linaro.org \ --cc=f.fainelli@gmail.com \ --cc=igor.skalkin@opensynergy.com \ --cc=james.quinlan@broadcom.com \ --cc=jean-philippe@linaro.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=mikhail.golubev@opensynergy.com \ --cc=peter.hilber@opensynergy.com \ --cc=souvik.chakravarty@arm.com \ --cc=vincent.guittot@linaro.org \ --cc=virtio-dev@lists.oasis-open.org \ --cc=virtualization@lists.linux-foundation.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.