Re: [RFC PATCH v3 4/6] drm/color: Add sdr boost property

[kernel test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 7589 bytes --]

Hi Harry,

[FYI, it's a private test report for your RFC patch.]
[auto build test WARNING on drm-intel/for-linux-next]
[also build test WARNING on linus/master v5.14-rc3 next-20210730]
[cannot apply to linux-arm/drm-armada-devel linux-arm/drm-armada-fixes]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Harry-Wentland/A-drm_plane-API-to-support-HDR-planes/20210731-044401
base:   git://anongit.freedesktop.org/drm-intel for-linux-next
config: arm-aspeed_g5_defconfig (attached as .config)
compiler: arm-linux-gnueabi-gcc (GCC) 10.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/bfba036c71685824f1fb1e665df47186f4e48be3
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Harry-Wentland/A-drm_plane-API-to-support-HDR-planes/20210731-044401
        git checkout bfba036c71685824f1fb1e665df47186f4e48be3
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-10.3.0 make.cross ARCH=arm 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

>> drivers/gpu/drm/drm_color_mgmt.c:559:5: warning: no previous prototype for 'drm_plane_create_sdr_white_level_property' [-Wmissing-prototypes]
     559 | int drm_plane_create_sdr_white_level_property(struct drm_plane *plane){
         |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   drivers/gpu/drm/drm_color_mgmt.c:583:13: warning: no previous prototype for 'drm_get_transfer_function_name' [-Wmissing-prototypes]
     583 | const char *drm_get_transfer_function_name(enum drm_transfer_function tf)
         |             ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~


vim +/drm_plane_create_sdr_white_level_property +559 drivers/gpu/drm/drm_color_mgmt.c

   558	
 > 559	int drm_plane_create_sdr_white_level_property(struct drm_plane *plane){
   560	
   561		struct drm_property *prop;
   562	
   563		prop = drm_property_create_range(plane->dev, 0, "SDR_WHITE_LEVEL", 0, UINT_MAX);
   564	
   565		if (!prop)
   566			return -ENOMEM;
   567	
   568		plane->sdr_white_level_property = prop;
   569		drm_object_attach_property(&plane->base, prop, DRM_DEFAULT_SDR_WHITE_LEVEL);
   570	
   571		if (plane->state)
   572			plane->state->sdr_white_level = DRM_DEFAULT_SDR_WHITE_LEVEL;
   573	
   574		return 0;
   575	}
   576	/**
   577	 * drm_get_transfer_function - return a string for transfer function
   578	 * @tf: transfer function to compute name of
   579	 *
   580	 * In contrast to the other drm_get_*_name functions this one here returns a
   581	 * const pointer and hence is threadsafe.
   582	 */
   583	const char *drm_get_transfer_function_name(enum drm_transfer_function tf)
   584	{
   585		if (WARN_ON(tf >= ARRAY_SIZE(tf_name)))
   586			return "unknown";
   587	
   588		return tf_name[tf];
   589	}
   590	/**
   591	 * drm_plane_create_color_properties - color encoding related plane properties
   592	 * @plane: plane object
   593	 * @supported_encodings: bitfield indicating supported color encodings
   594	 * @supported_ranges: bitfileld indicating supported color ranges
   595	 * @supported_tfs: bitfield indicating supported transfer functions
   596	 * @default_encoding: default color encoding
   597	 * @default_range: default color range
   598	 * @default_tf: default color transfer function
   599	 *
   600	 * Create and attach plane specific COLOR_ENCODING, COLOR_RANGE and TRANSFER_FUNCTION
   601	 * properties to @plane. The supported encodings, ranges  and tfs should
   602	 * be provided in supported_encodings, supported_ranges and supported_tfs bitmasks.
   603	 * Each bit set in the bitmask indicates that its number as enum
   604	 * value is supported.
   605	 */
   606	int drm_plane_create_color_properties(struct drm_plane *plane,
   607					      u32 supported_encodings,
   608					      u32 supported_ranges,
   609					      u32 supported_tfs,
   610					      enum drm_color_encoding default_encoding,
   611					      enum drm_color_range default_range,
   612					      enum drm_transfer_function default_tf)
   613	{
   614		struct drm_device *dev = plane->dev;
   615		struct drm_property *prop;
   616		struct drm_prop_enum_list enum_list[max_t(int, DRM_COLOR_ENCODING_MAX,
   617							       max_t(int, DRM_COLOR_RANGE_MAX,
   618								     DRM_TF_MAX))];
   619		int i, len;
   620	
   621		if (WARN_ON(supported_encodings == 0 ||
   622			    (supported_encodings & -BIT(DRM_COLOR_ENCODING_MAX)) != 0 ||
   623			    (supported_encodings & BIT(default_encoding)) == 0))
   624			return -EINVAL;
   625	
   626		if (WARN_ON(supported_ranges == 0 ||
   627			    (supported_ranges & -BIT(DRM_COLOR_RANGE_MAX)) != 0 ||
   628			    (supported_ranges & BIT(default_range)) == 0))
   629			return -EINVAL;
   630	
   631		if (WARN_ON(supported_tfs == 0 ||
   632			    (supported_tfs & -BIT(DRM_TF_MAX)) != 0 ||
   633			    (supported_tfs & BIT(default_tf)) == 0))
   634			return -EINVAL;
   635	
   636		len = 0;
   637		for (i = 0; i < DRM_COLOR_ENCODING_MAX; i++) {
   638			if ((supported_encodings & BIT(i)) == 0)
   639				continue;
   640	
   641			enum_list[len].type = i;
   642			enum_list[len].name = color_encoding_name[i];
   643			len++;
   644		}
   645	
   646		prop = drm_property_create_enum(dev, 0, "COLOR_ENCODING",
   647						enum_list, len);
   648		if (!prop)
   649			return -ENOMEM;
   650		plane->color_encoding_property = prop;
   651		drm_object_attach_property(&plane->base, prop, default_encoding);
   652		if (plane->state)
   653			plane->state->color_encoding = default_encoding;
   654	
   655		len = 0;
   656		for (i = 0; i < DRM_COLOR_RANGE_MAX; i++) {
   657			if ((supported_ranges & BIT(i)) == 0)
   658				continue;
   659	
   660			enum_list[len].type = i;
   661			enum_list[len].name = color_range_name[i];
   662			len++;
   663		}
   664	
   665		prop = drm_property_create_enum(dev, 0,	"COLOR_RANGE",
   666						enum_list, len);
   667		if (!prop)
   668			return -ENOMEM;
   669		plane->color_range_property = prop;
   670		drm_object_attach_property(&plane->base, prop, default_range);
   671		if (plane->state)
   672			plane->state->color_range = default_range;
   673	
   674	
   675		len = 0;
   676		for (i = 0; i < DRM_TF_MAX; i++) {
   677			if ((supported_tfs & BIT(i)) == 0)
   678				continue;
   679	
   680			enum_list[len].type = i;
   681			enum_list[len].name = tf_name[i];
   682			len++;
   683		}
   684	
   685		prop = drm_property_create_enum(dev, 0, "TRANSFER_FUNCTION",
   686						enum_list, len);
   687		if (!prop)
   688			return -ENOMEM;
   689		plane->transfer_function_property = prop;
   690		drm_object_attach_property(&plane->base, prop, default_tf);
   691		if (plane->state)
   692			plane->state->transfer_function = default_tf;
   693	
   694		return 0;
   695	}
   696	EXPORT_SYMBOL(drm_plane_create_color_properties);
   697	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 25932 bytes --]