Re: [RFC PATCH v3 3/6] drm/color: Add output transfer function to crtc

[kernel test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 5466 bytes --]

Hi Harry,

[FYI, it's a private test report for your RFC patch.]
[auto build test WARNING on drm-intel/for-linux-next]
[also build test WARNING on linus/master v5.14-rc3 next-20210730]
[cannot apply to linux-arm/drm-armada-devel linux-arm/drm-armada-fixes]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Harry-Wentland/A-drm_plane-API-to-support-HDR-planes/20210731-044401
base:   git://anongit.freedesktop.org/drm-intel for-linux-next
config: arm-allyesconfig (attached as .config)
compiler: arm-linux-gnueabi-gcc (GCC) 10.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/155348b7b734809c9952b773cf44a3f055f29588
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Harry-Wentland/A-drm_plane-API-to-support-HDR-planes/20210731-044401
        git checkout 155348b7b734809c9952b773cf44a3f055f29588
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-10.3.0 make.cross ARCH=arm 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

   In file included from include/linux/device.h:15,
                    from include/linux/acpi.h:15,
                    from include/linux/i2c.h:13,
                    from include/drm/drm_crtc.h:28,
                    from include/drm/drm_atomic.h:31,
                    from drivers/gpu/drm/omapdrm/omap_crtc.c:9:
   drivers/gpu/drm/omapdrm/omap_crtc.c: In function 'omap_crtc_init':
>> drivers/gpu/drm/omapdrm/omap_crtc.c:845:22: warning: too many arguments for format [-Wformat-extra-args]
     845 |    dev_err(dev->dev, "$s(): could not init color management for: %s\n",
         |                      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   include/linux/dev_printk.h:19:22: note: in definition of macro 'dev_fmt'
      19 | #define dev_fmt(fmt) fmt
         |                      ^~~
   drivers/gpu/drm/omapdrm/omap_crtc.c:845:4: note: in expansion of macro 'dev_err'
     845 |    dev_err(dev->dev, "$s(): could not init color management for: %s\n",
         |    ^~~~~~~


vim +845 drivers/gpu/drm/omapdrm/omap_crtc.c

   780	
   781	/* initialize crtc */
   782	struct drm_crtc *omap_crtc_init(struct drm_device *dev,
   783					struct omap_drm_pipeline *pipe,
   784					struct drm_plane *plane)
   785	{
   786		struct omap_drm_private *priv = dev->dev_private;
   787		struct drm_crtc *crtc = NULL;
   788		struct omap_crtc *omap_crtc;
   789		enum omap_channel channel;
   790		int ret;
   791	
   792		channel = pipe->output->dispc_channel;
   793	
   794		DBG("%s", channel_names[channel]);
   795	
   796		omap_crtc = kzalloc(sizeof(*omap_crtc), GFP_KERNEL);
   797		if (!omap_crtc)
   798			return ERR_PTR(-ENOMEM);
   799	
   800		crtc = &omap_crtc->base;
   801	
   802		init_waitqueue_head(&omap_crtc->pending_wait);
   803	
   804		omap_crtc->pipe = pipe;
   805		omap_crtc->channel = channel;
   806		omap_crtc->name = channel_names[channel];
   807	
   808		/*
   809		 * We want to refresh manually updated displays from dirty callback,
   810		 * which is called quite often (e.g. for each drawn line). This will
   811		 * be used to do the display update asynchronously to avoid blocking
   812		 * the rendering process and merges multiple dirty calls into one
   813		 * update if they arrive very fast. We also call this function for
   814		 * atomic display updates (e.g. for page flips), which means we do
   815		 * not need extra locking. Atomic updates should be synchronous, but
   816		 * need to wait for the framedone interrupt anyways.
   817		 */
   818		INIT_DELAYED_WORK(&omap_crtc->update_work,
   819				  omap_crtc_manual_display_update);
   820	
   821		ret = drm_crtc_init_with_planes(dev, crtc, plane, NULL,
   822						&omap_crtc_funcs, NULL);
   823		if (ret < 0) {
   824			dev_err(dev->dev, "%s(): could not init crtc for: %s\n",
   825				__func__, pipe->output->name);
   826			kfree(omap_crtc);
   827			return ERR_PTR(ret);
   828		}
   829	
   830		drm_crtc_helper_add(crtc, &omap_crtc_helper_funcs);
   831	
   832		/* The dispc API adapts to what ever size, but the HW supports
   833		 * 256 element gamma table for LCDs and 1024 element table for
   834		 * OMAP_DSS_CHANNEL_DIGIT. X server assumes 256 element gamma
   835		 * tables so lets use that. Size of HW gamma table can be
   836		 * extracted with dispc_mgr_gamma_size(). If it returns 0
   837		 * gamma table is not supported.
   838		 */
   839		if (dispc_mgr_gamma_size(priv->dispc, channel)) {
   840			unsigned int gamma_lut_size = 256;
   841	
   842			ret = drm_crtc_enable_color_mgmt(crtc, gamma_lut_size, true, 0,
   843							 BIT(DRM_TF_1D_LUT), DRM_TF_1D_LUT);
   844			if (ret) {
 > 845				dev_err(dev->dev, "$s(): could not init color management for: %s\n",

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 78443 bytes --]