From: Nathan Chancellor <nathan@kernel.org>
To: Cezary Rojewski <cezary.rojewski@intel.com>,
Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
Liam Girdwood <liam.r.girdwood@linux.intel.com>,
Jie Yang <yang.jie@linux.intel.com>,
Mark Brown <broonie@kernel.org>
Cc: Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org,
Nathan Chancellor <nathan@kernel.org>
Subject: [PATCH] ASoC: Intel: boards: Fix CONFIG_SND_SOC_SDW_MOCKUP select
Date: Mon, 2 Aug 2021 12:03:52 -0700 [thread overview]
Message-ID: <20210802190351.3201677-1-nathan@kernel.org> (raw)
When CONFIG_SND_SOC_INTEL_SOUNDWIRE_SOF_MACH is enabled without
CONFIG_EXPERT, there is a Kconfig warning about unmet dependencies:
WARNING: unmet direct dependencies detected for SND_SOC_SDW_MOCKUP
Depends on [n]: SOUND [=y] && !UML && SND [=y] && SND_SOC [=y] &&
EXPERT [=n] && SOUNDWIRE [=y]
Selected by [y]:
- SND_SOC_INTEL_SOUNDWIRE_SOF_MACH [=y] && ...
Selecting a symbol does not account for dependencies so if symbol A
selects symbol B which depends on symbol C, symbol B or its select of
symbol A should depend on symbol C as well.
Make the CONFIG_SND_SOC_SDW_MOCKUP select in
CONFIG_SND_SOC_INTEL_SOUNDWIRE_SOF_MACH depend on CONFIG_EXPERT as the
help text for CONFIG_SND_SOC_SDW_MOCKUP indicates it is intended to be a
development option.
Fixes: 0ccac3bcf356 ("ASoC: Intel: boards: sof_sdw: add SoundWire mockup codecs for tests")
Signed-off-by: Nathan Chancellor <nathan@kernel.org>
---
An alternative here is if CONFIG_SND_SOC_INTEL_SOUNDWIRE_SOF_MACH wants
to unconditionally select CONFIG_SND_SOC_SDW_MOCKUP, the "depends on
EXPERT" can be moved to the prompt (tristate "..." if EXPERT). I am
happy to send a new patch if that is what is desired.
sound/soc/intel/boards/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/intel/boards/Kconfig b/sound/soc/intel/boards/Kconfig
index 046955bf717c..8284c46d7435 100644
--- a/sound/soc/intel/boards/Kconfig
+++ b/sound/soc/intel/boards/Kconfig
@@ -602,7 +602,7 @@ config SND_SOC_INTEL_SOUNDWIRE_SOF_MACH
select SND_SOC_DMIC
select SND_SOC_INTEL_HDA_DSP_COMMON
select SND_SOC_INTEL_SOF_MAXIM_COMMON
- select SND_SOC_SDW_MOCKUP
+ select SND_SOC_SDW_MOCKUP if EXPERT
help
Add support for Intel SoundWire-based platforms connected to
MAX98373, RT700, RT711, RT1308 and RT715
base-commit: 170c0d7460fc4aa522995ae4096b5a442f50a1fc
--
2.32.0.264.g75ae10bc75
WARNING: multiple messages have this Message-ID (diff)
From: Nathan Chancellor <nathan@kernel.org>
To: Cezary Rojewski <cezary.rojewski@intel.com>,
Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
Liam Girdwood <liam.r.girdwood@linux.intel.com>,
Jie Yang <yang.jie@linux.intel.com>,
Mark Brown <broonie@kernel.org>
Cc: Nathan Chancellor <nathan@kernel.org>,
linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org,
Takashi Iwai <tiwai@suse.com>
Subject: [PATCH] ASoC: Intel: boards: Fix CONFIG_SND_SOC_SDW_MOCKUP select
Date: Mon, 2 Aug 2021 12:03:52 -0700 [thread overview]
Message-ID: <20210802190351.3201677-1-nathan@kernel.org> (raw)
When CONFIG_SND_SOC_INTEL_SOUNDWIRE_SOF_MACH is enabled without
CONFIG_EXPERT, there is a Kconfig warning about unmet dependencies:
WARNING: unmet direct dependencies detected for SND_SOC_SDW_MOCKUP
Depends on [n]: SOUND [=y] && !UML && SND [=y] && SND_SOC [=y] &&
EXPERT [=n] && SOUNDWIRE [=y]
Selected by [y]:
- SND_SOC_INTEL_SOUNDWIRE_SOF_MACH [=y] && ...
Selecting a symbol does not account for dependencies so if symbol A
selects symbol B which depends on symbol C, symbol B or its select of
symbol A should depend on symbol C as well.
Make the CONFIG_SND_SOC_SDW_MOCKUP select in
CONFIG_SND_SOC_INTEL_SOUNDWIRE_SOF_MACH depend on CONFIG_EXPERT as the
help text for CONFIG_SND_SOC_SDW_MOCKUP indicates it is intended to be a
development option.
Fixes: 0ccac3bcf356 ("ASoC: Intel: boards: sof_sdw: add SoundWire mockup codecs for tests")
Signed-off-by: Nathan Chancellor <nathan@kernel.org>
---
An alternative here is if CONFIG_SND_SOC_INTEL_SOUNDWIRE_SOF_MACH wants
to unconditionally select CONFIG_SND_SOC_SDW_MOCKUP, the "depends on
EXPERT" can be moved to the prompt (tristate "..." if EXPERT). I am
happy to send a new patch if that is what is desired.
sound/soc/intel/boards/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/intel/boards/Kconfig b/sound/soc/intel/boards/Kconfig
index 046955bf717c..8284c46d7435 100644
--- a/sound/soc/intel/boards/Kconfig
+++ b/sound/soc/intel/boards/Kconfig
@@ -602,7 +602,7 @@ config SND_SOC_INTEL_SOUNDWIRE_SOF_MACH
select SND_SOC_DMIC
select SND_SOC_INTEL_HDA_DSP_COMMON
select SND_SOC_INTEL_SOF_MAXIM_COMMON
- select SND_SOC_SDW_MOCKUP
+ select SND_SOC_SDW_MOCKUP if EXPERT
help
Add support for Intel SoundWire-based platforms connected to
MAX98373, RT700, RT711, RT1308 and RT715
base-commit: 170c0d7460fc4aa522995ae4096b5a442f50a1fc
--
2.32.0.264.g75ae10bc75
next reply other threads:[~2021-08-02 19:05 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-02 19:03 Nathan Chancellor [this message]
2021-08-02 19:03 ` [PATCH] ASoC: Intel: boards: Fix CONFIG_SND_SOC_SDW_MOCKUP select Nathan Chancellor
2021-08-02 21:05 ` Pierre-Louis Bossart
2021-08-02 21:05 ` Pierre-Louis Bossart
2021-08-02 21:24 ` [PATCH v2] " Nathan Chancellor
2021-08-02 21:24 ` Nathan Chancellor
2021-09-02 15:02 ` Pierre-Louis Bossart
2021-09-02 15:02 ` Pierre-Louis Bossart
2021-09-02 15:24 ` Mark Brown
2021-09-02 15:24 ` Mark Brown
2021-09-02 18:12 ` [PATCH for-5.15 v3] " Nathan Chancellor
2021-09-02 18:12 ` Nathan Chancellor
2021-09-03 10:27 ` Mark Brown
2021-09-03 10:27 ` Mark Brown
2021-09-03 15:14 ` Nathan Chancellor
2021-09-03 15:14 ` Nathan Chancellor
2021-09-03 16:26 ` Mark Brown
2021-09-03 16:26 ` Mark Brown
2021-09-03 15:18 ` Mark Brown
2021-09-03 15:18 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210802190351.3201677-1-nathan@kernel.org \
--to=nathan@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=cezary.rojewski@intel.com \
--cc=liam.r.girdwood@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=tiwai@suse.com \
--cc=yang.jie@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.