All of lore.kernel.org
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: Yajun Deng <yajun.deng@linux.dev>,
	davem@davemloft.net, kuba@kernel.org,
	mathew.j.martineau@linux.intel.com, matthieu.baerts@tessares.net,
	trond.myklebust@hammerspace.com, anna.schumaker@netapp.com
Cc: kbuild-all@lists.01.org, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org, bpf@vger.kernel.org,
	mptcp@lists.linux.dev
Subject: Re: [PATCH net-next] net: Modify sock_set_keepalive() for more scenarios
Date: Tue, 3 Aug 2021 19:28:54 +0800	[thread overview]
Message-ID: <202108031929.b1AMeeUj-lkp@intel.com> (raw)
In-Reply-To: <20210803082553.25194-1-yajun.deng@linux.dev>

[-- Attachment #1: Type: text/plain, Size: 7107 bytes --]

Hi Yajun,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on net-next/master]

url:    https://github.com/0day-ci/linux/commits/Yajun-Deng/net-Modify-sock_set_keepalive-for-more-scenarios/20210803-162757
base:   https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git 7cdd0a89ec70ce6a720171f1f7817ee9502b134c
config: m68k-allmodconfig (attached as .config)
compiler: m68k-linux-gcc (GCC) 10.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/1dd4cca54718feb13bbafafb8104a414ddc49662
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Yajun-Deng/net-Modify-sock_set_keepalive-for-more-scenarios/20210803-162757
        git checkout 1dd4cca54718feb13bbafafb8104a414ddc49662
        # save the attached .config to linux build tree
        mkdir build_dir
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-10.3.0 make.cross O=build_dir ARCH=m68k SHELL=/bin/bash fs/dlm/

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

   fs/dlm/lowcomms.c: In function 'tcp_create_listen_sock':
>> fs/dlm/lowcomms.c:1359:2: error: too few arguments to function 'sock_set_keepalive'
    1359 |  sock_set_keepalive(sock->sk);
         |  ^~~~~~~~~~~~~~~~~~
   In file included from fs/dlm/lowcomms.c:46:
   include/net/sock.h:2775:6: note: declared here
    2775 | void sock_set_keepalive(struct sock *sk, bool valbool);
         |      ^~~~~~~~~~~~~~~~~~


vim +/sock_set_keepalive +1359 fs/dlm/lowcomms.c

fdda387f73947e fs/dlm/lowcomms-tcp.c Patrick Caulfield 2006-11-02  1319  
d11ccd451b6556 fs/dlm/lowcomms.c     Alexander Aring   2020-11-02  1320  /* On error caller must run dlm_close_sock() for the
d11ccd451b6556 fs/dlm/lowcomms.c     Alexander Aring   2020-11-02  1321   * listen connection socket.
d11ccd451b6556 fs/dlm/lowcomms.c     Alexander Aring   2020-11-02  1322   */
d11ccd451b6556 fs/dlm/lowcomms.c     Alexander Aring   2020-11-02  1323  static int tcp_create_listen_sock(struct listen_connection *con,
ac33d071059557 fs/dlm/lowcomms-tcp.c Patrick Caulfield 2006-12-06  1324  				  struct sockaddr_storage *saddr)
fdda387f73947e fs/dlm/lowcomms-tcp.c Patrick Caulfield 2006-11-02  1325  {
fdda387f73947e fs/dlm/lowcomms-tcp.c Patrick Caulfield 2006-11-02  1326  	struct socket *sock = NULL;
fdda387f73947e fs/dlm/lowcomms-tcp.c Patrick Caulfield 2006-11-02  1327  	int result = 0;
fdda387f73947e fs/dlm/lowcomms-tcp.c Patrick Caulfield 2006-11-02  1328  	int addr_len;
fdda387f73947e fs/dlm/lowcomms-tcp.c Patrick Caulfield 2006-11-02  1329  
6ed7257b46709e fs/dlm/lowcomms.c     Patrick Caulfield 2007-04-17  1330  	if (dlm_local_addr[0]->ss_family == AF_INET)
fdda387f73947e fs/dlm/lowcomms-tcp.c Patrick Caulfield 2006-11-02  1331  		addr_len = sizeof(struct sockaddr_in);
fdda387f73947e fs/dlm/lowcomms-tcp.c Patrick Caulfield 2006-11-02  1332  	else
fdda387f73947e fs/dlm/lowcomms-tcp.c Patrick Caulfield 2006-11-02  1333  		addr_len = sizeof(struct sockaddr_in6);
fdda387f73947e fs/dlm/lowcomms-tcp.c Patrick Caulfield 2006-11-02  1334  
fdda387f73947e fs/dlm/lowcomms-tcp.c Patrick Caulfield 2006-11-02  1335  	/* Create a socket to communicate with */
eeb1bd5c40edb0 fs/dlm/lowcomms.c     Eric W. Biederman 2015-05-08  1336  	result = sock_create_kern(&init_net, dlm_local_addr[0]->ss_family,
eeb1bd5c40edb0 fs/dlm/lowcomms.c     Eric W. Biederman 2015-05-08  1337  				  SOCK_STREAM, IPPROTO_TCP, &sock);
fdda387f73947e fs/dlm/lowcomms-tcp.c Patrick Caulfield 2006-11-02  1338  	if (result < 0) {
617e82e10ccf96 fs/dlm/lowcomms.c     David Teigland    2007-04-26  1339  		log_print("Can't create listening comms socket");
fdda387f73947e fs/dlm/lowcomms-tcp.c Patrick Caulfield 2006-11-02  1340  		goto create_out;
fdda387f73947e fs/dlm/lowcomms-tcp.c Patrick Caulfield 2006-11-02  1341  	}
fdda387f73947e fs/dlm/lowcomms-tcp.c Patrick Caulfield 2006-11-02  1342  
a5b7ab6352bfaa fs/dlm/lowcomms.c     Alexander Aring   2020-06-26  1343  	sock_set_mark(sock->sk, dlm_config.ci_mark);
a5b7ab6352bfaa fs/dlm/lowcomms.c     Alexander Aring   2020-06-26  1344  
cb2d45da81c86d fs/dlm/lowcomms.c     David Teigland    2010-11-12  1345  	/* Turn off Nagle's algorithm */
12abc5ee7873a0 fs/dlm/lowcomms.c     Christoph Hellwig 2020-05-28  1346  	tcp_sock_set_nodelay(sock->sk);
cb2d45da81c86d fs/dlm/lowcomms.c     David Teigland    2010-11-12  1347  
b58f0e8f38c0a4 fs/dlm/lowcomms.c     Christoph Hellwig 2020-05-28  1348  	sock_set_reuseaddr(sock->sk);
6ed7257b46709e fs/dlm/lowcomms.c     Patrick Caulfield 2007-04-17  1349  
d11ccd451b6556 fs/dlm/lowcomms.c     Alexander Aring   2020-11-02  1350  	add_listen_sock(sock, con);
fdda387f73947e fs/dlm/lowcomms-tcp.c Patrick Caulfield 2006-11-02  1351  
fdda387f73947e fs/dlm/lowcomms-tcp.c Patrick Caulfield 2006-11-02  1352  	/* Bind to our port */
68c817a1c4e21b fs/dlm/lowcomms-tcp.c David Teigland    2007-01-09  1353  	make_sockaddr(saddr, dlm_config.ci_tcp_port, &addr_len);
fdda387f73947e fs/dlm/lowcomms-tcp.c Patrick Caulfield 2006-11-02  1354  	result = sock->ops->bind(sock, (struct sockaddr *) saddr, addr_len);
fdda387f73947e fs/dlm/lowcomms-tcp.c Patrick Caulfield 2006-11-02  1355  	if (result < 0) {
617e82e10ccf96 fs/dlm/lowcomms.c     David Teigland    2007-04-26  1356  		log_print("Can't bind to port %d", dlm_config.ci_tcp_port);
fdda387f73947e fs/dlm/lowcomms-tcp.c Patrick Caulfield 2006-11-02  1357  		goto create_out;
fdda387f73947e fs/dlm/lowcomms-tcp.c Patrick Caulfield 2006-11-02  1358  	}
ce3d9544cecacd fs/dlm/lowcomms.c     Christoph Hellwig 2020-05-28 @1359  	sock_set_keepalive(sock->sk);
fdda387f73947e fs/dlm/lowcomms-tcp.c Patrick Caulfield 2006-11-02  1360  
fdda387f73947e fs/dlm/lowcomms-tcp.c Patrick Caulfield 2006-11-02  1361  	result = sock->ops->listen(sock, 5);
fdda387f73947e fs/dlm/lowcomms-tcp.c Patrick Caulfield 2006-11-02  1362  	if (result < 0) {
617e82e10ccf96 fs/dlm/lowcomms.c     David Teigland    2007-04-26  1363  		log_print("Can't listen on port %d", dlm_config.ci_tcp_port);
fdda387f73947e fs/dlm/lowcomms-tcp.c Patrick Caulfield 2006-11-02  1364  		goto create_out;
fdda387f73947e fs/dlm/lowcomms-tcp.c Patrick Caulfield 2006-11-02  1365  	}
fdda387f73947e fs/dlm/lowcomms-tcp.c Patrick Caulfield 2006-11-02  1366  
d11ccd451b6556 fs/dlm/lowcomms.c     Alexander Aring   2020-11-02  1367  	return 0;
d11ccd451b6556 fs/dlm/lowcomms.c     Alexander Aring   2020-11-02  1368  
fdda387f73947e fs/dlm/lowcomms-tcp.c Patrick Caulfield 2006-11-02  1369  create_out:
d11ccd451b6556 fs/dlm/lowcomms.c     Alexander Aring   2020-11-02  1370  	return result;
fdda387f73947e fs/dlm/lowcomms-tcp.c Patrick Caulfield 2006-11-02  1371  }
fdda387f73947e fs/dlm/lowcomms-tcp.c Patrick Caulfield 2006-11-02  1372  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 60696 bytes --]

WARNING: multiple messages have this Message-ID (diff)
From: kernel test robot <lkp@intel.com>
To: kbuild-all@lists.01.org
Subject: Re: [PATCH net-next] net: Modify sock_set_keepalive() for more scenarios
Date: Tue, 03 Aug 2021 19:28:54 +0800	[thread overview]
Message-ID: <202108031929.b1AMeeUj-lkp@intel.com> (raw)
In-Reply-To: <20210803082553.25194-1-yajun.deng@linux.dev>

[-- Attachment #1: Type: text/plain, Size: 7203 bytes --]

Hi Yajun,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on net-next/master]

url:    https://github.com/0day-ci/linux/commits/Yajun-Deng/net-Modify-sock_set_keepalive-for-more-scenarios/20210803-162757
base:   https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git 7cdd0a89ec70ce6a720171f1f7817ee9502b134c
config: m68k-allmodconfig (attached as .config)
compiler: m68k-linux-gcc (GCC) 10.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/1dd4cca54718feb13bbafafb8104a414ddc49662
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Yajun-Deng/net-Modify-sock_set_keepalive-for-more-scenarios/20210803-162757
        git checkout 1dd4cca54718feb13bbafafb8104a414ddc49662
        # save the attached .config to linux build tree
        mkdir build_dir
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-10.3.0 make.cross O=build_dir ARCH=m68k SHELL=/bin/bash fs/dlm/

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

   fs/dlm/lowcomms.c: In function 'tcp_create_listen_sock':
>> fs/dlm/lowcomms.c:1359:2: error: too few arguments to function 'sock_set_keepalive'
    1359 |  sock_set_keepalive(sock->sk);
         |  ^~~~~~~~~~~~~~~~~~
   In file included from fs/dlm/lowcomms.c:46:
   include/net/sock.h:2775:6: note: declared here
    2775 | void sock_set_keepalive(struct sock *sk, bool valbool);
         |      ^~~~~~~~~~~~~~~~~~


vim +/sock_set_keepalive +1359 fs/dlm/lowcomms.c

fdda387f73947e fs/dlm/lowcomms-tcp.c Patrick Caulfield 2006-11-02  1319  
d11ccd451b6556 fs/dlm/lowcomms.c     Alexander Aring   2020-11-02  1320  /* On error caller must run dlm_close_sock() for the
d11ccd451b6556 fs/dlm/lowcomms.c     Alexander Aring   2020-11-02  1321   * listen connection socket.
d11ccd451b6556 fs/dlm/lowcomms.c     Alexander Aring   2020-11-02  1322   */
d11ccd451b6556 fs/dlm/lowcomms.c     Alexander Aring   2020-11-02  1323  static int tcp_create_listen_sock(struct listen_connection *con,
ac33d071059557 fs/dlm/lowcomms-tcp.c Patrick Caulfield 2006-12-06  1324  				  struct sockaddr_storage *saddr)
fdda387f73947e fs/dlm/lowcomms-tcp.c Patrick Caulfield 2006-11-02  1325  {
fdda387f73947e fs/dlm/lowcomms-tcp.c Patrick Caulfield 2006-11-02  1326  	struct socket *sock = NULL;
fdda387f73947e fs/dlm/lowcomms-tcp.c Patrick Caulfield 2006-11-02  1327  	int result = 0;
fdda387f73947e fs/dlm/lowcomms-tcp.c Patrick Caulfield 2006-11-02  1328  	int addr_len;
fdda387f73947e fs/dlm/lowcomms-tcp.c Patrick Caulfield 2006-11-02  1329  
6ed7257b46709e fs/dlm/lowcomms.c     Patrick Caulfield 2007-04-17  1330  	if (dlm_local_addr[0]->ss_family == AF_INET)
fdda387f73947e fs/dlm/lowcomms-tcp.c Patrick Caulfield 2006-11-02  1331  		addr_len = sizeof(struct sockaddr_in);
fdda387f73947e fs/dlm/lowcomms-tcp.c Patrick Caulfield 2006-11-02  1332  	else
fdda387f73947e fs/dlm/lowcomms-tcp.c Patrick Caulfield 2006-11-02  1333  		addr_len = sizeof(struct sockaddr_in6);
fdda387f73947e fs/dlm/lowcomms-tcp.c Patrick Caulfield 2006-11-02  1334  
fdda387f73947e fs/dlm/lowcomms-tcp.c Patrick Caulfield 2006-11-02  1335  	/* Create a socket to communicate with */
eeb1bd5c40edb0 fs/dlm/lowcomms.c     Eric W. Biederman 2015-05-08  1336  	result = sock_create_kern(&init_net, dlm_local_addr[0]->ss_family,
eeb1bd5c40edb0 fs/dlm/lowcomms.c     Eric W. Biederman 2015-05-08  1337  				  SOCK_STREAM, IPPROTO_TCP, &sock);
fdda387f73947e fs/dlm/lowcomms-tcp.c Patrick Caulfield 2006-11-02  1338  	if (result < 0) {
617e82e10ccf96 fs/dlm/lowcomms.c     David Teigland    2007-04-26  1339  		log_print("Can't create listening comms socket");
fdda387f73947e fs/dlm/lowcomms-tcp.c Patrick Caulfield 2006-11-02  1340  		goto create_out;
fdda387f73947e fs/dlm/lowcomms-tcp.c Patrick Caulfield 2006-11-02  1341  	}
fdda387f73947e fs/dlm/lowcomms-tcp.c Patrick Caulfield 2006-11-02  1342  
a5b7ab6352bfaa fs/dlm/lowcomms.c     Alexander Aring   2020-06-26  1343  	sock_set_mark(sock->sk, dlm_config.ci_mark);
a5b7ab6352bfaa fs/dlm/lowcomms.c     Alexander Aring   2020-06-26  1344  
cb2d45da81c86d fs/dlm/lowcomms.c     David Teigland    2010-11-12  1345  	/* Turn off Nagle's algorithm */
12abc5ee7873a0 fs/dlm/lowcomms.c     Christoph Hellwig 2020-05-28  1346  	tcp_sock_set_nodelay(sock->sk);
cb2d45da81c86d fs/dlm/lowcomms.c     David Teigland    2010-11-12  1347  
b58f0e8f38c0a4 fs/dlm/lowcomms.c     Christoph Hellwig 2020-05-28  1348  	sock_set_reuseaddr(sock->sk);
6ed7257b46709e fs/dlm/lowcomms.c     Patrick Caulfield 2007-04-17  1349  
d11ccd451b6556 fs/dlm/lowcomms.c     Alexander Aring   2020-11-02  1350  	add_listen_sock(sock, con);
fdda387f73947e fs/dlm/lowcomms-tcp.c Patrick Caulfield 2006-11-02  1351  
fdda387f73947e fs/dlm/lowcomms-tcp.c Patrick Caulfield 2006-11-02  1352  	/* Bind to our port */
68c817a1c4e21b fs/dlm/lowcomms-tcp.c David Teigland    2007-01-09  1353  	make_sockaddr(saddr, dlm_config.ci_tcp_port, &addr_len);
fdda387f73947e fs/dlm/lowcomms-tcp.c Patrick Caulfield 2006-11-02  1354  	result = sock->ops->bind(sock, (struct sockaddr *) saddr, addr_len);
fdda387f73947e fs/dlm/lowcomms-tcp.c Patrick Caulfield 2006-11-02  1355  	if (result < 0) {
617e82e10ccf96 fs/dlm/lowcomms.c     David Teigland    2007-04-26  1356  		log_print("Can't bind to port %d", dlm_config.ci_tcp_port);
fdda387f73947e fs/dlm/lowcomms-tcp.c Patrick Caulfield 2006-11-02  1357  		goto create_out;
fdda387f73947e fs/dlm/lowcomms-tcp.c Patrick Caulfield 2006-11-02  1358  	}
ce3d9544cecacd fs/dlm/lowcomms.c     Christoph Hellwig 2020-05-28 @1359  	sock_set_keepalive(sock->sk);
fdda387f73947e fs/dlm/lowcomms-tcp.c Patrick Caulfield 2006-11-02  1360  
fdda387f73947e fs/dlm/lowcomms-tcp.c Patrick Caulfield 2006-11-02  1361  	result = sock->ops->listen(sock, 5);
fdda387f73947e fs/dlm/lowcomms-tcp.c Patrick Caulfield 2006-11-02  1362  	if (result < 0) {
617e82e10ccf96 fs/dlm/lowcomms.c     David Teigland    2007-04-26  1363  		log_print("Can't listen on port %d", dlm_config.ci_tcp_port);
fdda387f73947e fs/dlm/lowcomms-tcp.c Patrick Caulfield 2006-11-02  1364  		goto create_out;
fdda387f73947e fs/dlm/lowcomms-tcp.c Patrick Caulfield 2006-11-02  1365  	}
fdda387f73947e fs/dlm/lowcomms-tcp.c Patrick Caulfield 2006-11-02  1366  
d11ccd451b6556 fs/dlm/lowcomms.c     Alexander Aring   2020-11-02  1367  	return 0;
d11ccd451b6556 fs/dlm/lowcomms.c     Alexander Aring   2020-11-02  1368  
fdda387f73947e fs/dlm/lowcomms-tcp.c Patrick Caulfield 2006-11-02  1369  create_out:
d11ccd451b6556 fs/dlm/lowcomms.c     Alexander Aring   2020-11-02  1370  	return result;
fdda387f73947e fs/dlm/lowcomms-tcp.c Patrick Caulfield 2006-11-02  1371  }
fdda387f73947e fs/dlm/lowcomms-tcp.c Patrick Caulfield 2006-11-02  1372  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 60696 bytes --]

  parent reply	other threads:[~2021-08-03 11:29 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-03  8:25 [PATCH net-next] net: Modify sock_set_keepalive() for more scenarios Yajun Deng
2021-08-03  9:44 ` Denis Kirjanov
2021-08-03  9:44   ` Denis Kirjanov
2021-08-03 11:28 ` kernel test robot [this message]
2021-08-03 11:28   ` kernel test robot
2021-08-03 11:42 ` yajun.deng
2021-08-03 11:42   ` yajun.deng
2021-08-03 15:59   ` Jakub Kicinski
2021-08-03 15:59     ` Jakub Kicinski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202108031929.b1AMeeUj-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=anna.schumaker@netapp.com \
    --cc=bpf@vger.kernel.org \
    --cc=davem@davemloft.net \
    --cc=kbuild-all@lists.01.org \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mathew.j.martineau@linux.intel.com \
    --cc=matthieu.baerts@tessares.net \
    --cc=mptcp@lists.linux.dev \
    --cc=netdev@vger.kernel.org \
    --cc=trond.myklebust@hammerspace.com \
    --cc=yajun.deng@linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.