All of lore.kernel.org
 help / color / mirror / Atom feed
* [hch-block:remove-GENHD_FL_UP 2/8] drivers/mmc/core/block.c:2892 mmc_blk_probe() error: uninitialized symbol 'md'.
@ 2021-08-05 11:09 ` Dan Carpenter
  0 siblings, 0 replies; 2+ messages in thread
From: kernel test robot @ 2021-08-04 20:02 UTC (permalink / raw)
  To: kbuild

[-- Attachment #1: Type: text/plain, Size: 6553 bytes --]

CC: kbuild-all(a)lists.01.org
TO: Christoph Hellwig <hch@lst.de>

tree:   git://git.infradead.org/users/hch/block.git remove-GENHD_FL_UP
head:   345cd8ff0e4885951b3c0f4767eac3e0fbf122ee
commit: f1359d20c31e283d08ba5fbcf77496d3579c6e3c [2/8] mmc: block: cleanup gendisk creation
:::::: branch date: 6 hours ago
:::::: commit date: 10 hours ago
config: h8300-randconfig-m031-20210804 (attached as .config)
compiler: h8300-linux-gcc (GCC) 10.3.0

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>

smatch warnings:
drivers/mmc/core/block.c:2892 mmc_blk_probe() error: uninitialized symbol 'md'.

vim +/md +2892 drivers/mmc/core/block.c

627c3ccfb46ada drivers/mmc/core/block.c Linus Walleij     2017-08-20  2871  
96541bac0b4e62 drivers/mmc/card/block.c Ulf Hansson       2015-04-14  2872  static int mmc_blk_probe(struct mmc_card *card)
^1da177e4c3f41 drivers/mmc/mmc_block.c  Linus Torvalds    2005-04-16  2873  {
f1359d20c31e28 drivers/mmc/core/block.c Christoph Hellwig 2021-07-25  2874  	struct mmc_blk_data *md;
6f1d3247662ace drivers/mmc/core/block.c Ulf Hansson       2021-03-03  2875  	int ret = 0;
a7bbb57333447d drivers/mmc/card/block.c Pierre Ossman     2008-09-06  2876  
912490db699d83 drivers/mmc/mmc_block.c  Pierre Ossman     2005-05-21  2877  	/*
912490db699d83 drivers/mmc/mmc_block.c  Pierre Ossman     2005-05-21  2878  	 * Check that the card supports the command class(es) we need.
912490db699d83 drivers/mmc/mmc_block.c  Pierre Ossman     2005-05-21  2879  	 */
912490db699d83 drivers/mmc/mmc_block.c  Pierre Ossman     2005-05-21  2880  	if (!(card->csd.cmdclass & CCC_BLOCK_READ))
^1da177e4c3f41 drivers/mmc/mmc_block.c  Linus Torvalds    2005-04-16  2881  		return -ENODEV;
^1da177e4c3f41 drivers/mmc/mmc_block.c  Linus Torvalds    2005-04-16  2882  
8c7cdbf9272c30 drivers/mmc/core/block.c Shawn Lin         2017-02-15  2883  	mmc_fixup_device(card, mmc_blk_fixups);
5204d00f06ac9a drivers/mmc/card/block.c Lukas Czerner     2014-06-18  2884  
dcf6e2e38a1c7c drivers/mmc/core/block.c Zachary Hays      2019-02-07  2885  	card->complete_wq = alloc_workqueue("mmc_complete",
dcf6e2e38a1c7c drivers/mmc/core/block.c Zachary Hays      2019-02-07  2886  					WQ_MEM_RECLAIM | WQ_HIGHPRI, 0);
1d848c28874e9b drivers/mmc/core/block.c Ulf Hansson       2021-03-03  2887  	if (!card->complete_wq) {
dcf6e2e38a1c7c drivers/mmc/core/block.c Zachary Hays      2019-02-07  2888  		pr_err("Failed to create mmc completion workqueue");
dcf6e2e38a1c7c drivers/mmc/core/block.c Zachary Hays      2019-02-07  2889  		return -ENOMEM;
dcf6e2e38a1c7c drivers/mmc/core/block.c Zachary Hays      2019-02-07  2890  	}
dcf6e2e38a1c7c drivers/mmc/core/block.c Zachary Hays      2019-02-07  2891  
f1359d20c31e28 drivers/mmc/core/block.c Christoph Hellwig 2021-07-25 @2892  	dev_set_drvdata(&card->dev, md);
f1359d20c31e28 drivers/mmc/core/block.c Christoph Hellwig 2021-07-25  2893  
^1da177e4c3f41 drivers/mmc/mmc_block.c  Linus Torvalds    2005-04-16  2894  	md = mmc_blk_alloc(card);
6f1d3247662ace drivers/mmc/core/block.c Ulf Hansson       2021-03-03  2895  	if (IS_ERR(md)) {
6f1d3247662ace drivers/mmc/core/block.c Ulf Hansson       2021-03-03  2896  		ret = PTR_ERR(md);
6f1d3247662ace drivers/mmc/core/block.c Ulf Hansson       2021-03-03  2897  		goto out_free;
6f1d3247662ace drivers/mmc/core/block.c Ulf Hansson       2021-03-03  2898  	}
^1da177e4c3f41 drivers/mmc/mmc_block.c  Linus Torvalds    2005-04-16  2899  
6f1d3247662ace drivers/mmc/core/block.c Ulf Hansson       2021-03-03  2900  	ret = mmc_blk_alloc_parts(card, md);
6f1d3247662ace drivers/mmc/core/block.c Ulf Hansson       2021-03-03  2901  	if (ret)
371a689f64b0da drivers/mmc/card/block.c Andrei Warkentin  2011-04-11  2902  		goto out;
371a689f64b0da drivers/mmc/card/block.c Andrei Warkentin  2011-04-11  2903  
627c3ccfb46ada drivers/mmc/core/block.c Linus Walleij     2017-08-20  2904  	/* Add two debugfs entries */
f9f0da98819503 drivers/mmc/core/block.c Adrian Hunter     2017-11-21  2905  	mmc_blk_add_debugfs(card, md);
627c3ccfb46ada drivers/mmc/core/block.c Linus Walleij     2017-08-20  2906  
e94cfef698aae6 drivers/mmc/card/block.c Ulf Hansson       2013-05-02  2907  	pm_runtime_set_autosuspend_delay(&card->dev, 3000);
e94cfef698aae6 drivers/mmc/card/block.c Ulf Hansson       2013-05-02  2908  	pm_runtime_use_autosuspend(&card->dev);
e94cfef698aae6 drivers/mmc/card/block.c Ulf Hansson       2013-05-02  2909  
e94cfef698aae6 drivers/mmc/card/block.c Ulf Hansson       2013-05-02  2910  	/*
e94cfef698aae6 drivers/mmc/card/block.c Ulf Hansson       2013-05-02  2911  	 * Don't enable runtime PM for SD-combo cards here. Leave that
e94cfef698aae6 drivers/mmc/card/block.c Ulf Hansson       2013-05-02  2912  	 * decision to be taken during the SDIO init sequence instead.
e94cfef698aae6 drivers/mmc/card/block.c Ulf Hansson       2013-05-02  2913  	 */
e94cfef698aae6 drivers/mmc/card/block.c Ulf Hansson       2013-05-02  2914  	if (card->type != MMC_TYPE_SD_COMBO) {
e94cfef698aae6 drivers/mmc/card/block.c Ulf Hansson       2013-05-02  2915  		pm_runtime_set_active(&card->dev);
e94cfef698aae6 drivers/mmc/card/block.c Ulf Hansson       2013-05-02  2916  		pm_runtime_enable(&card->dev);
e94cfef698aae6 drivers/mmc/card/block.c Ulf Hansson       2013-05-02  2917  	}
e94cfef698aae6 drivers/mmc/card/block.c Ulf Hansson       2013-05-02  2918  
^1da177e4c3f41 drivers/mmc/mmc_block.c  Linus Torvalds    2005-04-16  2919  	return 0;
^1da177e4c3f41 drivers/mmc/mmc_block.c  Linus Torvalds    2005-04-16  2920  
^1da177e4c3f41 drivers/mmc/mmc_block.c  Linus Torvalds    2005-04-16  2921  out:
371a689f64b0da drivers/mmc/card/block.c Andrei Warkentin  2011-04-11  2922  	mmc_blk_remove_parts(card, md);
371a689f64b0da drivers/mmc/card/block.c Andrei Warkentin  2011-04-11  2923  	mmc_blk_remove_req(md);
6f1d3247662ace drivers/mmc/core/block.c Ulf Hansson       2021-03-03  2924  out_free:
6f1d3247662ace drivers/mmc/core/block.c Ulf Hansson       2021-03-03  2925  	destroy_workqueue(card->complete_wq);
6f1d3247662ace drivers/mmc/core/block.c Ulf Hansson       2021-03-03  2926  	return ret;
^1da177e4c3f41 drivers/mmc/mmc_block.c  Linus Torvalds    2005-04-16  2927  }
^1da177e4c3f41 drivers/mmc/mmc_block.c  Linus Torvalds    2005-04-16  2928  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 32937 bytes --]

^ permalink raw reply	[flat|nested] 2+ messages in thread
* [hch-block:remove-GENHD_FL_UP 2/8] drivers/mmc/core/block.c:2892 mmc_blk_probe() error: uninitialized symbol 'md'.
@ 2021-08-05 11:09 ` Dan Carpenter
  0 siblings, 0 replies; 2+ messages in thread
From: Dan Carpenter @ 2021-08-05 11:09 UTC (permalink / raw)
  To: kbuild-all

[-- Attachment #1: Type: text/plain, Size: 3847 bytes --]

tree:   git://git.infradead.org/users/hch/block.git remove-GENHD_FL_UP
head:   345cd8ff0e4885951b3c0f4767eac3e0fbf122ee
commit: f1359d20c31e283d08ba5fbcf77496d3579c6e3c [2/8] mmc: block: cleanup gendisk creation
config: h8300-randconfig-m031-20210804 (attached as .config)
compiler: h8300-linux-gcc (GCC) 10.3.0

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>

smatch warnings:
drivers/mmc/core/block.c:2892 mmc_blk_probe() error: uninitialized symbol 'md'.

vim +/md +2892 drivers/mmc/core/block.c

96541bac0b4e62 drivers/mmc/card/block.c Ulf Hansson       2015-04-14  2872  static int mmc_blk_probe(struct mmc_card *card)
^1da177e4c3f41 drivers/mmc/mmc_block.c  Linus Torvalds    2005-04-16  2873  {
f1359d20c31e28 drivers/mmc/core/block.c Christoph Hellwig 2021-07-25  2874  	struct mmc_blk_data *md;
6f1d3247662ace drivers/mmc/core/block.c Ulf Hansson       2021-03-03  2875  	int ret = 0;
a7bbb57333447d drivers/mmc/card/block.c Pierre Ossman     2008-09-06  2876  
912490db699d83 drivers/mmc/mmc_block.c  Pierre Ossman     2005-05-21  2877  	/*
912490db699d83 drivers/mmc/mmc_block.c  Pierre Ossman     2005-05-21  2878  	 * Check that the card supports the command class(es) we need.
912490db699d83 drivers/mmc/mmc_block.c  Pierre Ossman     2005-05-21  2879  	 */
912490db699d83 drivers/mmc/mmc_block.c  Pierre Ossman     2005-05-21  2880  	if (!(card->csd.cmdclass & CCC_BLOCK_READ))
^1da177e4c3f41 drivers/mmc/mmc_block.c  Linus Torvalds    2005-04-16  2881  		return -ENODEV;
^1da177e4c3f41 drivers/mmc/mmc_block.c  Linus Torvalds    2005-04-16  2882  
8c7cdbf9272c30 drivers/mmc/core/block.c Shawn Lin         2017-02-15  2883  	mmc_fixup_device(card, mmc_blk_fixups);
5204d00f06ac9a drivers/mmc/card/block.c Lukas Czerner     2014-06-18  2884  
dcf6e2e38a1c7c drivers/mmc/core/block.c Zachary Hays      2019-02-07  2885  	card->complete_wq = alloc_workqueue("mmc_complete",
dcf6e2e38a1c7c drivers/mmc/core/block.c Zachary Hays      2019-02-07  2886  					WQ_MEM_RECLAIM | WQ_HIGHPRI, 0);
1d848c28874e9b drivers/mmc/core/block.c Ulf Hansson       2021-03-03  2887  	if (!card->complete_wq) {
dcf6e2e38a1c7c drivers/mmc/core/block.c Zachary Hays      2019-02-07  2888  		pr_err("Failed to create mmc completion workqueue");
dcf6e2e38a1c7c drivers/mmc/core/block.c Zachary Hays      2019-02-07  2889  		return -ENOMEM;
dcf6e2e38a1c7c drivers/mmc/core/block.c Zachary Hays      2019-02-07  2890  	}
dcf6e2e38a1c7c drivers/mmc/core/block.c Zachary Hays      2019-02-07  2891  
f1359d20c31e28 drivers/mmc/core/block.c Christoph Hellwig 2021-07-25 @2892  	dev_set_drvdata(&card->dev, md);
                                                                                                            ^^
Not initialized until the next line.

f1359d20c31e28 drivers/mmc/core/block.c Christoph Hellwig 2021-07-25  2893  
^1da177e4c3f41 drivers/mmc/mmc_block.c  Linus Torvalds    2005-04-16  2894  	md = mmc_blk_alloc(card);
6f1d3247662ace drivers/mmc/core/block.c Ulf Hansson       2021-03-03  2895  	if (IS_ERR(md)) {
6f1d3247662ace drivers/mmc/core/block.c Ulf Hansson       2021-03-03  2896  		ret = PTR_ERR(md);
6f1d3247662ace drivers/mmc/core/block.c Ulf Hansson       2021-03-03  2897  		goto out_free;
6f1d3247662ace drivers/mmc/core/block.c Ulf Hansson       2021-03-03  2898  	}
^1da177e4c3f41 drivers/mmc/mmc_block.c  Linus Torvalds    2005-04-16  2899  
6f1d3247662ace drivers/mmc/core/block.c Ulf Hansson       2021-03-03  2900  	ret = mmc_blk_alloc_parts(card, md);
6f1d3247662ace drivers/mmc/core/block.c Ulf Hansson       2021-03-03  2901  	if (ret)
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

^ permalink raw reply	[flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-08-05 11:09 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-04 20:02 [hch-block:remove-GENHD_FL_UP 2/8] drivers/mmc/core/block.c:2892 mmc_blk_probe() error: uninitialized symbol 'md' kernel test robot
2021-08-05 11:09 ` Dan Carpenter

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.