* [Buildroot] [PATCH 1/1] package/osm2pgsql: needs std::future
@ 2021-08-10 18:22 Fabrice Fontaine
2021-08-11 4:43 ` Maxim Kochetkov via buildroot
2021-08-12 21:40 ` Thomas Petazzoni
0 siblings, 2 replies; 3+ messages in thread
From: Fabrice Fontaine @ 2021-08-10 18:22 UTC (permalink / raw)
To: buildroot; +Cc: Maxim Kochetkov, Fabrice Fontaine
osm2pgsql needs std::future since its addition in commit
46c42042867e672eb21b386eb5e29747c30e80ca to avoid the following build
failure:
In file included from /home/buildroot/autobuild/run/instance-3/output-1/build/osm2pgsql-1.4.2/src/db-copy.cpp:12:0:
/home/buildroot/autobuild/run/instance-3/output-1/build/osm2pgsql-1.4.2/src/db-copy.hpp:218:24: error: field 'barrier' has incomplete type
std::promise<void> barrier;
^
/home/buildroot/autobuild/run/instance-3/output-1/build/osm2pgsql-1.4.2/src/db-copy.hpp: In constructor 'db_cmd_sync_t::db_cmd_sync_t(std::promise<void>&&)':
/home/buildroot/autobuild/run/instance-3/output-1/build/osm2pgsql-1.4.2/src/db-copy.hpp:221:37: error: class 'db_cmd_sync_t' does not have any field named 'barrier'
: db_cmd_t(db_cmd_t::Cmd_sync), barrier(std::move(b))
^
In file included from /home/buildroot/autobuild/run/instance-3/output-1/build/osm2pgsql-1.4.2/src/middle.hpp:18:0,
from /home/buildroot/autobuild/run/instance-3/output-1/build/osm2pgsql-1.4.2/src/dependency-manager.cpp:11:
/home/buildroot/autobuild/run/instance-3/output-1/build/osm2pgsql-1.4.2/src/thread-pool.hpp: In member function 'void thread_pool_t::check_for_exceptions()':
/home/buildroot/autobuild/run/instance-3/output-1/build/osm2pgsql-1.4.2/src/thread-pool.hpp:49:19: error: invalid use of incomplete type 'class std::future<void>'
result.get();
^
Fixes:
- http://autobuild.buildroot.org/results/69528232ceba128a2e60aa778bb0943fdefc2ed1
Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
package/osm2pgsql/Config.in | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/package/osm2pgsql/Config.in b/package/osm2pgsql/Config.in
index 1f1200cf46..f9fafb857c 100644
--- a/package/osm2pgsql/Config.in
+++ b/package/osm2pgsql/Config.in
@@ -4,6 +4,7 @@ config BR2_PACKAGE_OSM2PGSQL
depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_7 # C++11, libosmium, protozero
depends on BR2_TOOLCHAIN_HAS_THREADS # boost, libosmium
depends on BR2_USE_WCHAR # boost, fmt, libosmium
+ depends on !BR2_TOOLCHAIN_HAS_GCC_BUG_64735 # std::future
select BR2_PACKAGE_BOOST
select BR2_PACKAGE_BOOST_SYSTEM
select BR2_PACKAGE_BOOST_FILESYSTEM
@@ -24,3 +25,6 @@ config BR2_PACKAGE_OSM2PGSQL
comment "osm2pgsql needs a toolchain w/ C++, wchar, threads, gcc >= 4.7"
depends on !BR2_INSTALL_LIBSTDCPP || !BR2_USE_WCHAR || \
!BR2_TOOLCHAIN_GCC_AT_LEAST_4_7 || !BR2_TOOLCHAIN_HAS_THREADS
+
+comment "osm2pgsql needs a toolchain not affected by GCC bug 64735"
+ depends on BR2_TOOLCHAIN_HAS_GCC_BUG_64735
--
2.30.2
_______________________________________________
buildroot mailing list
buildroot@busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [Buildroot] [PATCH 1/1] package/osm2pgsql: needs std::future
2021-08-10 18:22 [Buildroot] [PATCH 1/1] package/osm2pgsql: needs std::future Fabrice Fontaine
@ 2021-08-11 4:43 ` Maxim Kochetkov via buildroot
2021-08-12 21:40 ` Thomas Petazzoni
1 sibling, 0 replies; 3+ messages in thread
From: Maxim Kochetkov via buildroot @ 2021-08-11 4:43 UTC (permalink / raw)
To: Fabrice Fontaine, buildroot
10.08.2021 21:22, Fabrice Fontaine wrote:
> osm2pgsql needs std::future since its addition in commit
> 46c42042867e672eb21b386eb5e29747c30e80ca to avoid the following build
> failure:
>
> In file included from /home/buildroot/autobuild/run/instance-3/output-1/build/osm2pgsql-1.4.2/src/db-copy.cpp:12:0:
> /home/buildroot/autobuild/run/instance-3/output-1/build/osm2pgsql-1.4.2/src/db-copy.hpp:218:24: error: field 'barrier' has incomplete type
> std::promise<void> barrier;
> ^
> /home/buildroot/autobuild/run/instance-3/output-1/build/osm2pgsql-1.4.2/src/db-copy.hpp: In constructor 'db_cmd_sync_t::db_cmd_sync_t(std::promise<void>&&)':
> /home/buildroot/autobuild/run/instance-3/output-1/build/osm2pgsql-1.4.2/src/db-copy.hpp:221:37: error: class 'db_cmd_sync_t' does not have any field named 'barrier'
> : db_cmd_t(db_cmd_t::Cmd_sync), barrier(std::move(b))
> ^
> In file included from /home/buildroot/autobuild/run/instance-3/output-1/build/osm2pgsql-1.4.2/src/middle.hpp:18:0,
> from /home/buildroot/autobuild/run/instance-3/output-1/build/osm2pgsql-1.4.2/src/dependency-manager.cpp:11:
> /home/buildroot/autobuild/run/instance-3/output-1/build/osm2pgsql-1.4.2/src/thread-pool.hpp: In member function 'void thread_pool_t::check_for_exceptions()':
> /home/buildroot/autobuild/run/instance-3/output-1/build/osm2pgsql-1.4.2/src/thread-pool.hpp:49:19: error: invalid use of incomplete type 'class std::future<void>'
> result.get();
> ^
>
> Fixes:
> - http://autobuild.buildroot.org/results/69528232ceba128a2e60aa778bb0943fdefc2ed1
>
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Reviewed-by: Maxim Kochetkov <fido_max@inbox.ru>
_______________________________________________
buildroot mailing list
buildroot@busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Buildroot] [PATCH 1/1] package/osm2pgsql: needs std::future
2021-08-10 18:22 [Buildroot] [PATCH 1/1] package/osm2pgsql: needs std::future Fabrice Fontaine
2021-08-11 4:43 ` Maxim Kochetkov via buildroot
@ 2021-08-12 21:40 ` Thomas Petazzoni
1 sibling, 0 replies; 3+ messages in thread
From: Thomas Petazzoni @ 2021-08-12 21:40 UTC (permalink / raw)
To: Fabrice Fontaine; +Cc: Maxim Kochetkov, buildroot
On Tue, 10 Aug 2021 20:22:16 +0200
Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:
> osm2pgsql needs std::future since its addition in commit
> 46c42042867e672eb21b386eb5e29747c30e80ca to avoid the following build
> failure:
>
> In file included from /home/buildroot/autobuild/run/instance-3/output-1/build/osm2pgsql-1.4.2/src/db-copy.cpp:12:0:
> /home/buildroot/autobuild/run/instance-3/output-1/build/osm2pgsql-1.4.2/src/db-copy.hpp:218:24: error: field 'barrier' has incomplete type
> std::promise<void> barrier;
> ^
> /home/buildroot/autobuild/run/instance-3/output-1/build/osm2pgsql-1.4.2/src/db-copy.hpp: In constructor 'db_cmd_sync_t::db_cmd_sync_t(std::promise<void>&&)':
> /home/buildroot/autobuild/run/instance-3/output-1/build/osm2pgsql-1.4.2/src/db-copy.hpp:221:37: error: class 'db_cmd_sync_t' does not have any field named 'barrier'
> : db_cmd_t(db_cmd_t::Cmd_sync), barrier(std::move(b))
> ^
> In file included from /home/buildroot/autobuild/run/instance-3/output-1/build/osm2pgsql-1.4.2/src/middle.hpp:18:0,
> from /home/buildroot/autobuild/run/instance-3/output-1/build/osm2pgsql-1.4.2/src/dependency-manager.cpp:11:
> /home/buildroot/autobuild/run/instance-3/output-1/build/osm2pgsql-1.4.2/src/thread-pool.hpp: In member function 'void thread_pool_t::check_for_exceptions()':
> /home/buildroot/autobuild/run/instance-3/output-1/build/osm2pgsql-1.4.2/src/thread-pool.hpp:49:19: error: invalid use of incomplete type 'class std::future<void>'
> result.get();
> ^
>
> Fixes:
> - http://autobuild.buildroot.org/results/69528232ceba128a2e60aa778bb0943fdefc2ed1
>
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
> package/osm2pgsql/Config.in | 4 ++++
> 1 file changed, 4 insertions(+)
Applied to master, thanks.
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-08-12 21:40 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-10 18:22 [Buildroot] [PATCH 1/1] package/osm2pgsql: needs std::future Fabrice Fontaine
2021-08-11 4:43 ` Maxim Kochetkov via buildroot
2021-08-12 21:40 ` Thomas Petazzoni
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.