From: Christoph Hellwig <hch@lst.de> To: Mike Snitzer <snitzer@redhat.com> Cc: Christoph Hellwig <hch@lst.de>, Jens Axboe <axboe@kernel.dk>, dm-devel@redhat.com, linux-block@vger.kernel.org, Tushar Sugandhi <tusharsu@linux.microsoft.com> Subject: Re: holders not working properly, regression [was: Re: use regular gendisk registration in device mapper v2] Date: Thu, 19 Aug 2021 20:05:59 +0200 [thread overview] Message-ID: <20210819180559.GA14001@lst.de> (raw) In-Reply-To: <YR5/wMEkr1TwV7FD@redhat.com> Manually reverting "block: remove the extra kobject reference in bd_link_disk_holder" as show below fixed the issue for me. I'll spend some more time tomorrow trying to fully understan the life time rules tomorrow before sending a patch, though. --- From 6b94f5435900d23769db8d07ff47415aab4ac63e Mon Sep 17 00:00:00 2001 From: Christoph Hellwig <hch@lst.de> Date: Thu, 19 Aug 2021 20:01:43 +0200 Subject: Revert "block: remove the extra kobject reference in bd_link_disk_holder" This reverts commit fbd9a39542ecdd2ade55869c13856b2590db3df8. --- block/holder.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/block/holder.c b/block/holder.c index 4568cc4f6827..ecbc6941e7d8 100644 --- a/block/holder.c +++ b/block/holder.c @@ -106,6 +106,12 @@ int bd_link_disk_holder(struct block_device *bdev, struct gendisk *disk) } list_add(&holder->list, &disk->slave_bdevs); + /* + * bdev could be deleted beneath us which would implicitly destroy + * the holder directory. Hold on to it. + */ + kobject_get(bdev->bd_holder_dir); + out_unlock: mutex_unlock(&disk->open_mutex); return ret; @@ -138,6 +144,7 @@ void bd_unlink_disk_holder(struct block_device *bdev, struct gendisk *disk) if (!WARN_ON_ONCE(holder == NULL) && !--holder->refcnt) { if (disk->slave_dir) __unlink_disk_holder(bdev, disk); + kobject_put(bdev->bd_holder_dir); list_del_init(&holder->list); kfree(holder); } -- 2.30.2
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@lst.de> To: Mike Snitzer <snitzer@redhat.com> Cc: Jens Axboe <axboe@kernel.dk>, linux-block@vger.kernel.org, dm-devel@redhat.com, Tushar Sugandhi <tusharsu@linux.microsoft.com>, Christoph Hellwig <hch@lst.de> Subject: Re: [dm-devel] holders not working properly, regression [was: Re: use regular gendisk registration in device mapper v2] Date: Thu, 19 Aug 2021 20:05:59 +0200 [thread overview] Message-ID: <20210819180559.GA14001@lst.de> (raw) In-Reply-To: <YR5/wMEkr1TwV7FD@redhat.com> Manually reverting "block: remove the extra kobject reference in bd_link_disk_holder" as show below fixed the issue for me. I'll spend some more time tomorrow trying to fully understan the life time rules tomorrow before sending a patch, though. --- >From 6b94f5435900d23769db8d07ff47415aab4ac63e Mon Sep 17 00:00:00 2001 From: Christoph Hellwig <hch@lst.de> Date: Thu, 19 Aug 2021 20:01:43 +0200 Subject: Revert "block: remove the extra kobject reference in bd_link_disk_holder" This reverts commit fbd9a39542ecdd2ade55869c13856b2590db3df8. --- block/holder.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/block/holder.c b/block/holder.c index 4568cc4f6827..ecbc6941e7d8 100644 --- a/block/holder.c +++ b/block/holder.c @@ -106,6 +106,12 @@ int bd_link_disk_holder(struct block_device *bdev, struct gendisk *disk) } list_add(&holder->list, &disk->slave_bdevs); + /* + * bdev could be deleted beneath us which would implicitly destroy + * the holder directory. Hold on to it. + */ + kobject_get(bdev->bd_holder_dir); + out_unlock: mutex_unlock(&disk->open_mutex); return ret; @@ -138,6 +144,7 @@ void bd_unlink_disk_holder(struct block_device *bdev, struct gendisk *disk) if (!WARN_ON_ONCE(holder == NULL) && !--holder->refcnt) { if (disk->slave_dir) __unlink_disk_holder(bdev, disk); + kobject_put(bdev->bd_holder_dir); list_del_init(&holder->list); kfree(holder); } -- 2.30.2 -- dm-devel mailing list dm-devel@redhat.com https://listman.redhat.com/mailman/listinfo/dm-devel
next prev parent reply other threads:[~2021-08-19 18:06 UTC|newest] Thread overview: 66+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-08-04 9:41 use regular gendisk registration in device mapper v2 Christoph Hellwig 2021-08-04 9:41 ` [dm-devel] " Christoph Hellwig 2021-08-04 9:41 ` [PATCH 1/8] block: make the block holder code optional Christoph Hellwig 2021-08-04 9:41 ` [dm-devel] " Christoph Hellwig 2021-08-04 9:41 ` [PATCH 2/8] block: remove the extra kobject reference in bd_link_disk_holder Christoph Hellwig 2021-08-04 9:41 ` [dm-devel] " Christoph Hellwig 2021-08-04 9:41 ` [PATCH 3/8] block: look up holders by bdev Christoph Hellwig 2021-08-04 9:41 ` [dm-devel] " Christoph Hellwig 2021-08-04 9:41 ` [PATCH 4/8] block: support delayed holder registration Christoph Hellwig 2021-08-04 9:41 ` [dm-devel] " Christoph Hellwig [not found] ` <CGME20210810213058eucas1p109323e3c3ecaa76d37d8cf63b6d8ecfd@eucas1p1.samsung.com> 2021-08-10 21:30 ` Marek Szyprowski 2021-08-10 21:30 ` [dm-devel] " Marek Szyprowski 2021-08-14 21:13 ` Guenter Roeck 2021-08-14 21:13 ` Guenter Roeck 2021-08-15 7:07 ` Christoph Hellwig 2021-08-15 7:07 ` Christoph Hellwig 2021-08-15 14:27 ` Guenter Roeck 2021-08-15 14:27 ` Guenter Roeck 2021-08-16 7:21 ` Christoph Hellwig 2021-08-16 7:21 ` Christoph Hellwig 2021-08-16 14:17 ` Guenter Roeck 2021-08-16 14:17 ` Guenter Roeck 2021-08-20 15:08 ` Christoph Hellwig 2021-08-20 15:08 ` Christoph Hellwig 2021-08-21 3:17 ` Guenter Roeck 2021-08-21 3:17 ` Guenter Roeck 2021-08-18 2:51 ` Guenter Roeck 2021-08-18 2:51 ` Guenter Roeck 2021-08-04 9:41 ` [PATCH 5/8] dm: cleanup cleanup_mapped_device Christoph Hellwig 2021-08-04 9:41 ` [dm-devel] " Christoph Hellwig 2021-08-04 9:41 ` [PATCH 6/8] dm: move setting md->type into dm_setup_md_queue Christoph Hellwig 2021-08-04 9:41 ` [dm-devel] " Christoph Hellwig 2021-08-04 9:41 ` [PATCH 7/8] dm: delay registering the gendisk Christoph Hellwig 2021-08-04 9:41 ` [dm-devel] " Christoph Hellwig 2021-08-09 23:31 ` Alasdair G Kergon 2021-08-09 23:31 ` Alasdair G Kergon 2021-08-10 0:17 ` Alasdair G Kergon 2021-08-10 0:17 ` Alasdair G Kergon 2021-08-10 13:12 ` Peter Rajnoha 2021-08-10 13:12 ` Peter Rajnoha 2021-08-10 15:05 ` Alasdair G Kergon 2021-08-10 15:05 ` Alasdair G Kergon 2022-07-07 3:29 ` Yu Kuai 2022-07-07 3:29 ` [dm-devel] " Yu Kuai 2022-07-07 5:24 ` Christoph Hellwig 2022-07-07 5:24 ` [dm-devel] " Christoph Hellwig 2022-07-07 7:20 ` Yu Kuai 2022-07-07 7:20 ` [dm-devel] " Yu Kuai 2022-07-15 3:24 ` Yu Kuai 2022-07-15 3:24 ` [dm-devel] " Yu Kuai 2022-08-01 1:04 ` Yu Kuai 2022-08-01 1:04 ` [dm-devel] " Yu Kuai 2021-08-04 9:41 ` [PATCH 8/8] block: remove support for delayed queue registrations Christoph Hellwig 2021-08-04 9:41 ` [dm-devel] " Christoph Hellwig 2021-08-09 17:51 ` use regular gendisk registration in device mapper v2 Jens Axboe 2021-08-09 17:51 ` [dm-devel] " Jens Axboe 2021-08-10 0:36 ` Alasdair G Kergon 2021-08-10 0:36 ` Alasdair G Kergon 2021-08-10 14:41 ` Alasdair G Kergon 2021-08-10 14:41 ` Alasdair G Kergon 2021-08-19 15:58 ` holders not working properly, regression [was: Re: use regular gendisk registration in device mapper v2] Mike Snitzer 2021-08-19 15:58 ` [dm-devel] " Mike Snitzer 2021-08-19 18:05 ` Christoph Hellwig [this message] 2021-08-19 18:05 ` Christoph Hellwig 2021-08-19 22:08 ` Mike Snitzer 2021-08-19 22:08 ` [dm-devel] " Mike Snitzer
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20210819180559.GA14001@lst.de \ --to=hch@lst.de \ --cc=axboe@kernel.dk \ --cc=dm-devel@redhat.com \ --cc=linux-block@vger.kernel.org \ --cc=snitzer@redhat.com \ --cc=tusharsu@linux.microsoft.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.