From: Christian Brauner <christian.brauner@ubuntu.com>
To: Kari Argillander <kari.argillander@gmail.com>
Cc: "Konstantin Komarov" <almaz.alexandrovich@paragon-software.com>,
"Christoph Hellwig" <hch@lst.de>,
ntfs3@lists.linux.dev, linux-kernel@vger.kernel.org,
linux-fsdevel@vger.kernel.org, "Pali Rohár" <pali@kernel.org>,
"Matthew Wilcox" <willy@infradead.org>
Subject: Re: [PATCH v2 2/6] fs/ntfs3: Remove unnecesarry remount flag handling
Date: Tue, 24 Aug 2021 13:17:20 +0200 [thread overview]
Message-ID: <20210824111720.jzg2cf32ag54dibk@wittgenstein> (raw)
In-Reply-To: <20210819002633.689831-3-kari.argillander@gmail.com>
On Thu, Aug 19, 2021 at 03:26:29AM +0300, Kari Argillander wrote:
> Remove unnecesarry remount flag handling. This does not do anything for
> this driver. We have already set SB_NODIRATIME when we fill super. Also
> noatime should be set from mount option. Now for some reson we try to
> set it when remounting.
>
> Lazytime part looks like it is copied from f2fs and there is own mount
> parameter for it. That is why they use it. We do not set lazytime
> anywhere in our code. So basically this just blocks lazytime when
> remounting.
>
> Signed-off-by: Kari Argillander <kari.argillander@gmail.com>
> ---
Sounds good. Thanks!
Acked-by: Christian Brauner <christian.brauner@ubuntu.com>
next prev parent reply other threads:[~2021-08-24 11:17 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-19 0:26 [PATCH v2 0/6] fs/ntfs3: Use new mount api and change some opts Kari Argillander
2021-08-19 0:26 ` [PATCH v2 1/6] fs/ntfs3: Remove unnecesarry mount option noatime Kari Argillander
2021-08-24 7:58 ` Christoph Hellwig
2021-08-24 11:17 ` Christian Brauner
2021-08-19 0:26 ` [PATCH v2 2/6] fs/ntfs3: Remove unnecesarry remount flag handling Kari Argillander
2021-08-24 7:59 ` Christoph Hellwig
2021-08-24 11:17 ` Christian Brauner [this message]
2021-08-19 0:26 ` [PATCH v2 3/6] fs/ntfs3: Use new api for mounting Kari Argillander
2021-08-19 8:18 ` Pali Rohár
2021-08-19 10:01 ` Kari Argillander
2021-08-19 21:53 ` Kari Argillander
2021-08-24 8:03 ` Christoph Hellwig
2021-08-24 8:21 ` Kari Argillander
2021-08-27 18:44 ` Konstantin Komarov
2021-08-24 11:32 ` Christian Brauner
2021-08-24 14:13 ` Kari Argillander
2021-08-19 0:26 ` [PATCH v2 4/6] fs/ntfs3: Make mount option nohidden more universal Kari Argillander
2021-08-24 8:03 ` Christoph Hellwig
2021-08-24 11:16 ` Christian Brauner
2021-08-19 0:26 ` [PATCH v2 5/6] fs/ntfs3: Add iocharset= mount option as alias for nls= Kari Argillander
2021-08-19 8:26 ` Pali Rohár
2021-08-19 9:45 ` Kari Argillander
2021-08-19 9:55 ` Pali Rohár
2021-08-19 0:26 ` [PATCH v2 6/6] fs/ntfs3: Rename mount option no_acl_rules > (no)acl_rules Kari Argillander
2021-08-24 8:03 ` Christoph Hellwig
2021-08-24 11:15 ` Christian Brauner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210824111720.jzg2cf32ag54dibk@wittgenstein \
--to=christian.brauner@ubuntu.com \
--cc=almaz.alexandrovich@paragon-software.com \
--cc=hch@lst.de \
--cc=kari.argillander@gmail.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ntfs3@lists.linux.dev \
--cc=pali@kernel.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.