From: Konstantin Komarov <almaz.alexandrovich@paragon-software.com>
To: Kari Argillander <kari.argillander@gmail.com>,
Christoph Hellwig <hch@lst.de>
Cc: "ntfs3@lists.linux.dev" <ntfs3@lists.linux.dev>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
"Pali Rohár" <pali@kernel.org>,
"Matthew Wilcox" <willy@infradead.org>,
"Christian Brauner" <christian.brauner@ubuntu.com>
Subject: RE: [PATCH v2 3/6] fs/ntfs3: Use new api for mounting
Date: Fri, 27 Aug 2021 18:44:07 +0000 [thread overview]
Message-ID: <9dcbd4fb0dcf434f9241d2ef13763428@paragon-software.com> (raw)
In-Reply-To: <20210824082157.umppqksjl2vvyd53@kari-VirtualBox>
> From: Kari Argillander <kari.argillander@gmail.com>
> Sent: Tuesday, August 24, 2021 11:22 AM
> To: Christoph Hellwig <hch@lst.de>
> Cc: Konstantin Komarov <almaz.alexandrovich@paragon-software.com>; ntfs3@lists.linux.dev; linux-kernel@vger.kernel.org; linux-
> fsdevel@vger.kernel.org; Pali Rohár <pali@kernel.org>; Matthew Wilcox <willy@infradead.org>; Christian Brauner
> <christian.brauner@ubuntu.com>
> Subject: Re: [PATCH v2 3/6] fs/ntfs3: Use new api for mounting
>
> On Tue, Aug 24, 2021 at 10:03:02AM +0200, Christoph Hellwig wrote:
> > > + /*
> > > + * TODO: We should probably check some mount options does
> > > + * they all work after remount. Example can we really change
> > > + * nls. Remove this comment when all testing is done or
> > > + * even better xfstest is made for it.
> > > + */
> >
> > Instead of the TODO I would suggest a prep patch to drop changing of
> > any options in remount before this one and then only add them back
> > as needed and tested.
>
> This could be good option. I have actually tested nls and it will be
> problem so we definitely drop that. I will wait what Konstantin has
> to say about other.
>
> > The mechanics of the conversion look good to me.
>
> I have made quite few changes to make this series better and will
> send v3 in the near future.
>
> Main change is that we won't allocate sbi when remount. We can
> allocate just options. Also won't let nls/iocharset change.
Hi Kari, looking forward to have v3 series to pick up!
Best regards.
next prev parent reply other threads:[~2021-08-27 18:44 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-19 0:26 [PATCH v2 0/6] fs/ntfs3: Use new mount api and change some opts Kari Argillander
2021-08-19 0:26 ` [PATCH v2 1/6] fs/ntfs3: Remove unnecesarry mount option noatime Kari Argillander
2021-08-24 7:58 ` Christoph Hellwig
2021-08-24 11:17 ` Christian Brauner
2021-08-19 0:26 ` [PATCH v2 2/6] fs/ntfs3: Remove unnecesarry remount flag handling Kari Argillander
2021-08-24 7:59 ` Christoph Hellwig
2021-08-24 11:17 ` Christian Brauner
2021-08-19 0:26 ` [PATCH v2 3/6] fs/ntfs3: Use new api for mounting Kari Argillander
2021-08-19 8:18 ` Pali Rohár
2021-08-19 10:01 ` Kari Argillander
2021-08-19 21:53 ` Kari Argillander
2021-08-24 8:03 ` Christoph Hellwig
2021-08-24 8:21 ` Kari Argillander
2021-08-27 18:44 ` Konstantin Komarov [this message]
2021-08-24 11:32 ` Christian Brauner
2021-08-24 14:13 ` Kari Argillander
2021-08-19 0:26 ` [PATCH v2 4/6] fs/ntfs3: Make mount option nohidden more universal Kari Argillander
2021-08-24 8:03 ` Christoph Hellwig
2021-08-24 11:16 ` Christian Brauner
2021-08-19 0:26 ` [PATCH v2 5/6] fs/ntfs3: Add iocharset= mount option as alias for nls= Kari Argillander
2021-08-19 8:26 ` Pali Rohár
2021-08-19 9:45 ` Kari Argillander
2021-08-19 9:55 ` Pali Rohár
2021-08-19 0:26 ` [PATCH v2 6/6] fs/ntfs3: Rename mount option no_acl_rules > (no)acl_rules Kari Argillander
2021-08-24 8:03 ` Christoph Hellwig
2021-08-24 11:15 ` Christian Brauner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9dcbd4fb0dcf434f9241d2ef13763428@paragon-software.com \
--to=almaz.alexandrovich@paragon-software.com \
--cc=christian.brauner@ubuntu.com \
--cc=hch@lst.de \
--cc=kari.argillander@gmail.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ntfs3@lists.linux.dev \
--cc=pali@kernel.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.