* [Buildroot] [PATCH 1/1] package/qemu: disable fuse-lseek on uclibc-ng
@ 2021-08-27 15:58 Fabrice Fontaine
2021-08-27 20:11 ` Yann E. MORIN
0 siblings, 1 reply; 2+ messages in thread
From: Fabrice Fontaine @ 2021-08-27 15:58 UTC (permalink / raw)
To: buildroot; +Cc: Romain Naour, Fabrice Fontaine
Fix the following build failure on uclibc-ng raised since bump to
version 6.0.0 in commit 6b86c9335fc3ff381878156c6243454d4b688df9:
../block/export/fuse.c: In function 'fuse_lseek':
../block/export/fuse.c:641:19: error: 'SEEK_HOLE' undeclared (first use in this function)
641 | if (whence != SEEK_HOLE && whence != SEEK_DATA) {
| ^~~~~~~~~
../block/export/fuse.c:641:19: note: each undeclared identifier is reported only once for each function it appears in
../block/export/fuse.c:641:42: error: 'SEEK_DATA' undeclared (first use in this function); did you mean 'SEEK_SET'?
641 | if (whence != SEEK_HOLE && whence != SEEK_DATA) {
| ^~~~~~~~~
| SEEK_SET
Fixes:
- http://autobuild.buildroot.org/results/33c90ebf04997f4d3557cfa66abc9cf9a3076137
Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
package/qemu/qemu.mk | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/package/qemu/qemu.mk b/package/qemu/qemu.mk
index 0bd3eafadd..70cf441c9b 100644
--- a/package/qemu/qemu.mk
+++ b/package/qemu/qemu.mk
@@ -94,11 +94,11 @@ endif
ifeq ($(BR2_PACKAGE_LIBFUSE3),y)
QEMU_OPTS += --enable-fuse
QEMU_DEPENDENCIES += libfuse3
-# musl does not support SEEK_HOLE/SEEK_DATA
-ifeq ($(BR2_TOOLCHAIN_USES_MUSL),y)
-QEMU_OPTS += --disable-fuse-lseek
-else
+# musl and uclibc-ng don't support SEEK_HOLE/SEEK_DATA
+ifeq ($(BR2_TOOLCHAIN_USES_GLIBC),y)
QEMU_OPTS += --enable-fuse-lseek
+else
+QEMU_OPTS += --disable-fuse-lseek
endif
else
QEMU_OPTS += --disable-fuse --disable-fuse-lseek
--
2.32.0
_______________________________________________
buildroot mailing list
buildroot@busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [Buildroot] [PATCH 1/1] package/qemu: disable fuse-lseek on uclibc-ng
2021-08-27 15:58 [Buildroot] [PATCH 1/1] package/qemu: disable fuse-lseek on uclibc-ng Fabrice Fontaine
@ 2021-08-27 20:11 ` Yann E. MORIN
0 siblings, 0 replies; 2+ messages in thread
From: Yann E. MORIN @ 2021-08-27 20:11 UTC (permalink / raw)
To: Fabrice Fontaine; +Cc: Romain Naour, buildroot
Fabrice, All,
On 2021-08-27 17:58 +0200, Fabrice Fontaine spake thusly:
> Fix the following build failure on uclibc-ng raised since bump to
> version 6.0.0 in commit 6b86c9335fc3ff381878156c6243454d4b688df9:
>
> ../block/export/fuse.c: In function 'fuse_lseek':
> ../block/export/fuse.c:641:19: error: 'SEEK_HOLE' undeclared (first use in this function)
> 641 | if (whence != SEEK_HOLE && whence != SEEK_DATA) {
> | ^~~~~~~~~
> ../block/export/fuse.c:641:19: note: each undeclared identifier is reported only once for each function it appears in
> ../block/export/fuse.c:641:42: error: 'SEEK_DATA' undeclared (first use in this function); did you mean 'SEEK_SET'?
> 641 | if (whence != SEEK_HOLE && whence != SEEK_DATA) {
> | ^~~~~~~~~
> | SEEK_SET
I think the proper solution would be to #include <linux/fs.h>, maybe
guarded by #ifdef __linux__, like is done for example in:
block/file-posix.c .
And thus relax the requirement against musl at the same time?
Regards,
Yann E. MORIN.
> Fixes:
> - http://autobuild.buildroot.org/results/33c90ebf04997f4d3557cfa66abc9cf9a3076137
>
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
> package/qemu/qemu.mk | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/package/qemu/qemu.mk b/package/qemu/qemu.mk
> index 0bd3eafadd..70cf441c9b 100644
> --- a/package/qemu/qemu.mk
> +++ b/package/qemu/qemu.mk
> @@ -94,11 +94,11 @@ endif
> ifeq ($(BR2_PACKAGE_LIBFUSE3),y)
> QEMU_OPTS += --enable-fuse
> QEMU_DEPENDENCIES += libfuse3
> -# musl does not support SEEK_HOLE/SEEK_DATA
> -ifeq ($(BR2_TOOLCHAIN_USES_MUSL),y)
> -QEMU_OPTS += --disable-fuse-lseek
> -else
> +# musl and uclibc-ng don't support SEEK_HOLE/SEEK_DATA
> +ifeq ($(BR2_TOOLCHAIN_USES_GLIBC),y)
> QEMU_OPTS += --enable-fuse-lseek
> +else
> +QEMU_OPTS += --disable-fuse-lseek
> endif
> else
> QEMU_OPTS += --disable-fuse --disable-fuse-lseek
> --
> 2.32.0
>
> _______________________________________________
> buildroot mailing list
> buildroot@busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-08-27 20:11 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-27 15:58 [Buildroot] [PATCH 1/1] package/qemu: disable fuse-lseek on uclibc-ng Fabrice Fontaine
2021-08-27 20:11 ` Yann E. MORIN
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.