From: Matthew Hagan <mnhagan88@gmail.com> To: unlisted-recipients:; (no To-header on input) Cc: Florian Fainelli <f.fainelli@gmail.com>, Matthew Hagan <mnhagan88@gmail.com>, Rob Herring <robh+dt@kernel.org>, Ray Jui <rjui@broadcom.com>, Scott Branden <sbranden@broadcom.com>, bcm-kernel-feedback-list@broadcom.com, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH 5/5] ARM: dts: NSP: Fix MX65 MDIO mux warnings Date: Sat, 28 Aug 2021 11:27:03 +0000 [thread overview] Message-ID: <20210828112704.2283805-5-mnhagan88@gmail.com> (raw) In-Reply-To: <20210828112704.2283805-1-mnhagan88@gmail.com> Firstly this fixes the following message: mdio-mii-mux: $nodename:0: 'mdio-mii-mux' does not match '^mdio-mux[\\-@]?' Secondly, move the mdio-mux to within the axi node and add the unit address. This requires exposing the axi node via a label in bcm-nsp.dtsi. This fixes the following warning: Warning (unit_address_vs_reg): /mdio-mii-mux: node has a reg or ranges property, but no unit name Signed-off-by: Matthew Hagan <mnhagan88@gmail.com> --- arch/arm/boot/dts/bcm-nsp.dtsi | 2 +- arch/arm/boot/dts/bcm958625-meraki-alamo.dtsi | 6 ++++-- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/arch/arm/boot/dts/bcm-nsp.dtsi b/arch/arm/boot/dts/bcm-nsp.dtsi index 180827500f25..1c08daa18858 100644 --- a/arch/arm/boot/dts/bcm-nsp.dtsi +++ b/arch/arm/boot/dts/bcm-nsp.dtsi @@ -166,7 +166,7 @@ periph_clk: periph_clk { }; }; - axi@18000000 { + axi: axi@18000000 { compatible = "simple-bus"; ranges = <0x00000000 0x18000000 0x0011c40c>; #address-cells = <1>; diff --git a/arch/arm/boot/dts/bcm958625-meraki-alamo.dtsi b/arch/arm/boot/dts/bcm958625-meraki-alamo.dtsi index 57d0c5eb9749..102acd85fab2 100644 --- a/arch/arm/boot/dts/bcm958625-meraki-alamo.dtsi +++ b/arch/arm/boot/dts/bcm958625-meraki-alamo.dtsi @@ -70,10 +70,12 @@ led-5 { gpios = <&gpioa 31 GPIO_ACTIVE_HIGH>; }; }; +}; - mdio-mii-mux { +&axi { + mdio-mux@3f1c0 { compatible = "mdio-mux-mmioreg", "mdio-mux"; - reg = <0x1803f1c0 0x4>; + reg = <0x3f1c0 0x4>; mux-mask = <0x2000>; mdio-parent-bus = <&mdio_ext>; #address-cells = <1>; -- 2.27.0
WARNING: multiple messages have this Message-ID (diff)
From: Matthew Hagan <mnhagan88@gmail.com> Cc: Florian Fainelli <f.fainelli@gmail.com>, Matthew Hagan <mnhagan88@gmail.com>, Rob Herring <robh+dt@kernel.org>, Ray Jui <rjui@broadcom.com>, Scott Branden <sbranden@broadcom.com>, bcm-kernel-feedback-list@broadcom.com, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH 5/5] ARM: dts: NSP: Fix MX65 MDIO mux warnings Date: Sat, 28 Aug 2021 11:27:03 +0000 [thread overview] Message-ID: <20210828112704.2283805-5-mnhagan88@gmail.com> (raw) In-Reply-To: <20210828112704.2283805-1-mnhagan88@gmail.com> Firstly this fixes the following message: mdio-mii-mux: $nodename:0: 'mdio-mii-mux' does not match '^mdio-mux[\\-@]?' Secondly, move the mdio-mux to within the axi node and add the unit address. This requires exposing the axi node via a label in bcm-nsp.dtsi. This fixes the following warning: Warning (unit_address_vs_reg): /mdio-mii-mux: node has a reg or ranges property, but no unit name Signed-off-by: Matthew Hagan <mnhagan88@gmail.com> --- arch/arm/boot/dts/bcm-nsp.dtsi | 2 +- arch/arm/boot/dts/bcm958625-meraki-alamo.dtsi | 6 ++++-- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/arch/arm/boot/dts/bcm-nsp.dtsi b/arch/arm/boot/dts/bcm-nsp.dtsi index 180827500f25..1c08daa18858 100644 --- a/arch/arm/boot/dts/bcm-nsp.dtsi +++ b/arch/arm/boot/dts/bcm-nsp.dtsi @@ -166,7 +166,7 @@ periph_clk: periph_clk { }; }; - axi@18000000 { + axi: axi@18000000 { compatible = "simple-bus"; ranges = <0x00000000 0x18000000 0x0011c40c>; #address-cells = <1>; diff --git a/arch/arm/boot/dts/bcm958625-meraki-alamo.dtsi b/arch/arm/boot/dts/bcm958625-meraki-alamo.dtsi index 57d0c5eb9749..102acd85fab2 100644 --- a/arch/arm/boot/dts/bcm958625-meraki-alamo.dtsi +++ b/arch/arm/boot/dts/bcm958625-meraki-alamo.dtsi @@ -70,10 +70,12 @@ led-5 { gpios = <&gpioa 31 GPIO_ACTIVE_HIGH>; }; }; +}; - mdio-mii-mux { +&axi { + mdio-mux@3f1c0 { compatible = "mdio-mux-mmioreg", "mdio-mux"; - reg = <0x1803f1c0 0x4>; + reg = <0x3f1c0 0x4>; mux-mask = <0x2000>; mdio-parent-bus = <&mdio_ext>; #address-cells = <1>; -- 2.27.0 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-08-28 11:27 UTC|newest] Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-08-28 11:26 [PATCH 1/5] ARM: dts: NSP: Add bcm958623hr board name to dts Matthew Hagan 2021-08-28 11:26 ` Matthew Hagan 2021-08-28 11:27 ` [PATCH 2/5] ARM: dts: NSP: Fix mpcore, mmc node names Matthew Hagan 2021-08-28 11:27 ` Matthew Hagan 2021-08-28 11:27 ` [PATCH 3/5] ARM: dts: NSP: Fix MDIO mux " Matthew Hagan 2021-08-28 11:27 ` Matthew Hagan 2021-08-28 17:07 ` Andrew Lunn 2021-08-28 17:07 ` Andrew Lunn 2021-08-28 21:52 ` Matthew Hagan 2021-08-28 21:52 ` Matthew Hagan 2021-08-28 22:14 ` Andrew Lunn 2021-08-28 22:14 ` Andrew Lunn 2021-09-16 12:52 ` Andrew Lunn 2021-09-16 12:52 ` Andrew Lunn 2021-08-28 11:27 ` [PATCH 4/5] ARM: dts: NSP: Fix MX64/MX65 eeprom node name Matthew Hagan 2021-08-28 11:27 ` Matthew Hagan 2021-08-28 11:27 ` Matthew Hagan [this message] 2021-08-28 11:27 ` [PATCH 5/5] ARM: dts: NSP: Fix MX65 MDIO mux warnings Matthew Hagan
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20210828112704.2283805-5-mnhagan88@gmail.com \ --to=mnhagan88@gmail.com \ --cc=bcm-kernel-feedback-list@broadcom.com \ --cc=devicetree@vger.kernel.org \ --cc=f.fainelli@gmail.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=rjui@broadcom.com \ --cc=robh+dt@kernel.org \ --cc=sbranden@broadcom.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.