* [igt-dev] [PATCH i-g-t] tests/i915/gem_exec_schedule: Resolve missing context for independent subtest
@ 2021-08-30 19:59 Arjun Melkaveri
0 siblings, 0 replies; 5+ messages in thread
From: Arjun Melkaveri @ 2021-08-30 19:59 UTC (permalink / raw)
To: arjun.melkaveri, igt-dev
Resolved missing context id in exec buf, and passing created context
to igt spin .
This change would fix test assertion in gem_execbuf for independent
subtest
v2: Passing original ctx id to gem_execbuf
Signed-off-by: Arjun Melkaveri <arjun.melkaveri@intel.com>
Cc: Zbigniew Kempczyński <zbigniew.kempczynski@intel.com>
Cc: Ashutosh Dixit <ashutosh.dixit@intel.com>
---
tests/i915/gem_exec_schedule.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/tests/i915/gem_exec_schedule.c b/tests/i915/gem_exec_schedule.c
index 62d616f3..e694482f 100644
--- a/tests/i915/gem_exec_schedule.c
+++ b/tests/i915/gem_exec_schedule.c
@@ -390,12 +390,13 @@ static void independent(int fd, const intel_ctx_t *ctx, unsigned int engine,
struct drm_i915_gem_execbuffer2 eb = {
.buffer_count = 1,
.buffers_ptr = to_user_pointer(&spin->obj[IGT_SPIN_BATCH]),
+ .rsvd1 = ctx->id,
.flags = e->flags,
};
gem_execbuf(fd, &eb);
}
- store_dword_fenced(fd, ahnd, ctx, e->flags,
+ store_dword_fenced(fd, ahnd, tmp_ctx, e->flags,
scratch, scratch_offset,
0, e->flags, fence, 0);
}
--
2.25.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [igt-dev] [PATCH i-g-t] tests/i915/gem_exec_schedule: Resolve missing context for independent subtest
2021-08-30 20:00 Arjun Melkaveri
@ 2021-08-30 20:47 ` Dixit, Ashutosh
0 siblings, 0 replies; 5+ messages in thread
From: Dixit, Ashutosh @ 2021-08-30 20:47 UTC (permalink / raw)
To: Arjun Melkaveri; +Cc: igt-dev
On Mon, 30 Aug 2021 13:00:37 -0700, Arjun Melkaveri wrote:
>
> Resolved missing context id in exec buf, and passing created context
> to igt spin .
> This change would fix test assertion in gem_execbuf for independent
> subtest
>
> v2: Passing original ctx id to gem_execbuf
Reviewed-by: Ashutosh Dixit <ashutosh.dixit@intel.com>
> Signed-off-by: Arjun Melkaveri <arjun.melkaveri@intel.com>
> Cc: Zbigniew Kempczyński <zbigniew.kempczynski@intel.com>
> Cc: Ashutosh Dixit <ashutosh.dixit@intel.com>
> ---
> tests/i915/gem_exec_schedule.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/tests/i915/gem_exec_schedule.c b/tests/i915/gem_exec_schedule.c
> index 62d616f3..1f6f71db 100644
> --- a/tests/i915/gem_exec_schedule.c
> +++ b/tests/i915/gem_exec_schedule.c
> @@ -390,6 +390,7 @@ static void independent(int fd, const intel_ctx_t *ctx, unsigned int engine,
> struct drm_i915_gem_execbuffer2 eb = {
> .buffer_count = 1,
> .buffers_ptr = to_user_pointer(&spin->obj[IGT_SPIN_BATCH]),
> + .rsvd1 = ctx->id,
> .flags = e->flags,
> };
> gem_execbuf(fd, &eb);
> --
> 2.25.1
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* [igt-dev] [PATCH i-g-t] tests/i915/gem_exec_schedule: Resolve missing context for independent subtest
@ 2021-08-30 20:00 Arjun Melkaveri
2021-08-30 20:47 ` Dixit, Ashutosh
0 siblings, 1 reply; 5+ messages in thread
From: Arjun Melkaveri @ 2021-08-30 20:00 UTC (permalink / raw)
To: arjun.melkaveri, igt-dev
Resolved missing context id in exec buf, and passing created context
to igt spin .
This change would fix test assertion in gem_execbuf for independent
subtest
v2: Passing original ctx id to gem_execbuf
Signed-off-by: Arjun Melkaveri <arjun.melkaveri@intel.com>
Cc: Zbigniew Kempczyński <zbigniew.kempczynski@intel.com>
Cc: Ashutosh Dixit <ashutosh.dixit@intel.com>
---
tests/i915/gem_exec_schedule.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/tests/i915/gem_exec_schedule.c b/tests/i915/gem_exec_schedule.c
index 62d616f3..1f6f71db 100644
--- a/tests/i915/gem_exec_schedule.c
+++ b/tests/i915/gem_exec_schedule.c
@@ -390,6 +390,7 @@ static void independent(int fd, const intel_ctx_t *ctx, unsigned int engine,
struct drm_i915_gem_execbuffer2 eb = {
.buffer_count = 1,
.buffers_ptr = to_user_pointer(&spin->obj[IGT_SPIN_BATCH]),
+ .rsvd1 = ctx->id,
.flags = e->flags,
};
gem_execbuf(fd, &eb);
--
2.25.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [igt-dev] [PATCH i-g-t] tests/i915/gem_exec_schedule: Resolve missing context for independent subtest
2021-08-29 20:15 Arjun Melkaveri
@ 2021-08-30 18:43 ` Dixit, Ashutosh
0 siblings, 0 replies; 5+ messages in thread
From: Dixit, Ashutosh @ 2021-08-30 18:43 UTC (permalink / raw)
To: Arjun Melkaveri; +Cc: igt-dev
On Sun, 29 Aug 2021 13:15:59 -0700, Arjun Melkaveri wrote:
>
> @@ -380,22 +381,24 @@ static void independent(int fd, const intel_ctx_t *ctx, unsigned int engine,
> if (!gem_class_can_store_dword(fd, e->class))
> continue;
>
> + tmp_ctx = intel_ctx_create(fd, &ctx->cfg);
> if (spin == NULL) {
> spin = __igt_spin_new(fd,
> .ahnd = ahnd,
> - .ctx = ctx,
> + .ctx = tmp_ctx,
> .engine = e->flags,
> .flags = flags);
> } else {
> struct drm_i915_gem_execbuffer2 eb = {
> .buffer_count = 1,
> .buffers_ptr = to_user_pointer(&spin->obj[IGT_SPIN_BATCH]),
> + .rsvd1 = tmp_ctx->id,
.rsvd1 is definitely missing which should explain the assert for
gem_execbuf, but looks like we should not need a new "tmp_ctx" but should
be able to submit against the original "ctx", so all we need is:
.rsvd1 = ctx->id,
^ permalink raw reply [flat|nested] 5+ messages in thread
* [igt-dev] [PATCH i-g-t] tests/i915/gem_exec_schedule: Resolve missing context for independent subtest
@ 2021-08-29 20:15 Arjun Melkaveri
2021-08-30 18:43 ` Dixit, Ashutosh
0 siblings, 1 reply; 5+ messages in thread
From: Arjun Melkaveri @ 2021-08-29 20:15 UTC (permalink / raw)
To: arjun.melkaveri, igt-dev
Resolved missing context id in exec buf, and passing created context
to igt spin .
This change would fix test assertion in gem_execbuf for independent
subtest
Signed-off-by: Arjun Melkaveri <arjun.melkaveri@intel.com>
Cc: Zbigniew Kempczyński <zbigniew.kempczynski@intel.com>
Cc: Ashutosh Dixit <ashutosh.dixit@intel.com>
---
tests/i915/gem_exec_schedule.c | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/tests/i915/gem_exec_schedule.c b/tests/i915/gem_exec_schedule.c
index 62d616f3..846a863f 100644
--- a/tests/i915/gem_exec_schedule.c
+++ b/tests/i915/gem_exec_schedule.c
@@ -363,6 +363,7 @@ static void independent(int fd, const intel_ctx_t *ctx, unsigned int engine,
uint32_t scratch, batch;
uint32_t *ptr;
int fence;
+ const intel_ctx_t *tmp_ctx;
uint64_t ahnd = get_reloc_ahnd(fd, ctx->id), scratch_offset;
scratch = gem_create(fd, 4096);
@@ -380,22 +381,24 @@ static void independent(int fd, const intel_ctx_t *ctx, unsigned int engine,
if (!gem_class_can_store_dword(fd, e->class))
continue;
+ tmp_ctx = intel_ctx_create(fd, &ctx->cfg);
if (spin == NULL) {
spin = __igt_spin_new(fd,
.ahnd = ahnd,
- .ctx = ctx,
+ .ctx = tmp_ctx,
.engine = e->flags,
.flags = flags);
} else {
struct drm_i915_gem_execbuffer2 eb = {
.buffer_count = 1,
.buffers_ptr = to_user_pointer(&spin->obj[IGT_SPIN_BATCH]),
+ .rsvd1 = tmp_ctx->id,
.flags = e->flags,
};
gem_execbuf(fd, &eb);
}
- store_dword_fenced(fd, ahnd, ctx, e->flags,
+ store_dword_fenced(fd, ahnd, tmp_ctx, e->flags,
scratch, scratch_offset,
0, e->flags, fence, 0);
}
--
2.25.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
end of thread, other threads:[~2021-08-30 20:47 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-30 19:59 [igt-dev] [PATCH i-g-t] tests/i915/gem_exec_schedule: Resolve missing context for independent subtest Arjun Melkaveri
-- strict thread matches above, loose matches on Subject: below --
2021-08-30 20:00 Arjun Melkaveri
2021-08-30 20:47 ` Dixit, Ashutosh
2021-08-29 20:15 Arjun Melkaveri
2021-08-30 18:43 ` Dixit, Ashutosh
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.