[linux-next:master 8048/11508] arch/mips/alchemy/devboards/db1550.c:69:2: warning: unannotated fall-through between switch labels

* [linux-next:master 8048/11508] arch/mips/alchemy/devboards/db1550.c:69:2: warning: unannotated fall-through between switch labels
@ 2021-09-03  0:35 ` kernel test robot
  0 siblings, 0 replies; 2+ messages in thread
From: kernel test robot @ 2021-09-03  0:35 UTC (permalink / raw)
  To: Gustavo A. R. Silva
  Cc: llvm, kbuild-all, Linux Memory Management List,
	Nathan Chancellor, Kees Cook

[-- Attachment #1: Type: text/plain, Size: 5468 bytes --]

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
head:   34560ced20599a01660a693f464c7c7dc83db1d9
commit: 7bc04ce6b914a06d5823509d1de237787c58e649 [8048/11508] Makefile: Enable -Wimplicit-fallthrough for Clang
config: mips-randconfig-r016-20210903 (attached as .config)
compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project c9948e9254fbb6ea00f66c7b4542311d21e060be)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # install mips cross compiling tool for clang build
        # apt-get install binutils-mips-linux-gnu
        # https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=7bc04ce6b914a06d5823509d1de237787c58e649
        git remote add linux-next https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
        git fetch --no-tags linux-next master
        git checkout 7bc04ce6b914a06d5823509d1de237787c58e649
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=mips 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

   arch/mips/alchemy/devboards/db1550.c:56:12: warning: no previous prototype for function 'db1550_board_setup' [-Wmissing-prototypes]
   int __init db1550_board_setup(void)
              ^
   arch/mips/alchemy/devboards/db1550.c:56:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
   int __init db1550_board_setup(void)
   ^
   static 
>> arch/mips/alchemy/devboards/db1550.c:69:2: warning: unannotated fall-through between switch labels [-Wimplicit-fallthrough]
           case BCSR_WHOAMI_DB1550:
           ^
   arch/mips/alchemy/devboards/db1550.c:69:2: note: insert 'break;' to avoid fall-through
           case BCSR_WHOAMI_DB1550:
           ^
           break; 
   arch/mips/alchemy/devboards/db1550.c:500:12: warning: no previous prototype for function 'db1550_pci_setup' [-Wmissing-prototypes]
   int __init db1550_pci_setup(int id)
              ^
   arch/mips/alchemy/devboards/db1550.c:500:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
   int __init db1550_pci_setup(int id)
   ^
   static 
   arch/mips/alchemy/devboards/db1550.c:581:12: warning: no previous prototype for function 'db1550_dev_setup' [-Wmissing-prototypes]
   int __init db1550_dev_setup(void)
              ^
   arch/mips/alchemy/devboards/db1550.c:581:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
   int __init db1550_dev_setup(void)
   ^
   static 
   4 warnings generated.
--
>> drivers/pcmcia/db1xxx_ss.c:359:2: warning: unannotated fall-through between switch labels [-Wimplicit-fallthrough]
           case 3:
           ^
   drivers/pcmcia/db1xxx_ss.c:359:2: note: insert 'break;' to avoid fall-through
           case 3:
           ^
           break; 
   1 warning generated.

vim +69 arch/mips/alchemy/devboards/db1550.c

f869d42e580f62 Manuel Lauss 2011-11-10  55  
bd8510df881f63 Manuel Lauss 2012-09-13  56  int __init db1550_board_setup(void)
f869d42e580f62 Manuel Lauss 2011-11-10  57  {
f869d42e580f62 Manuel Lauss 2011-11-10  58  	unsigned short whoami;
f869d42e580f62 Manuel Lauss 2011-11-10  59  
f869d42e580f62 Manuel Lauss 2011-11-10  60  	bcsr_init(DB1550_BCSR_PHYS_ADDR,
f869d42e580f62 Manuel Lauss 2011-11-10  61  		  DB1550_BCSR_PHYS_ADDR + DB1550_BCSR_HEXLED_OFS);
f869d42e580f62 Manuel Lauss 2011-11-10  62  
24e8c1a611a706 Manuel Lauss 2012-09-14  63  	whoami = bcsr_read(BCSR_WHOAMI); /* PB1550 hexled offset differs */
970e268d6ed1f1 Manuel Lauss 2014-02-20  64  	switch (BCSR_WHOAMI_BOARD(whoami)) {
970e268d6ed1f1 Manuel Lauss 2014-02-20  65  	case BCSR_WHOAMI_PB1550_SDR:
970e268d6ed1f1 Manuel Lauss 2014-02-20  66  	case BCSR_WHOAMI_PB1550_DDR:
24e8c1a611a706 Manuel Lauss 2012-09-14  67  		bcsr_init(PB1550_BCSR_PHYS_ADDR,
24e8c1a611a706 Manuel Lauss 2012-09-14  68  			  PB1550_BCSR_PHYS_ADDR + PB1550_BCSR_HEXLED_OFS);
970e268d6ed1f1 Manuel Lauss 2014-02-20 @69  	case BCSR_WHOAMI_DB1550:
970e268d6ed1f1 Manuel Lauss 2014-02-20  70  		break;
970e268d6ed1f1 Manuel Lauss 2014-02-20  71  	default:
970e268d6ed1f1 Manuel Lauss 2014-02-20  72  		return -ENODEV;
970e268d6ed1f1 Manuel Lauss 2014-02-20  73  	}
24e8c1a611a706 Manuel Lauss 2012-09-14  74  
24e8c1a611a706 Manuel Lauss 2012-09-14  75  	pr_info("Alchemy/AMD %s Board, CPLD Rev %d Board-ID %d	"	\
24e8c1a611a706 Manuel Lauss 2012-09-14  76  		"Daughtercard ID %d\n", get_system_type(),
f869d42e580f62 Manuel Lauss 2011-11-10  77  		(whoami >> 4) & 0xf, (whoami >> 8) & 0xf, whoami & 0xf);
f869d42e580f62 Manuel Lauss 2011-11-10  78  
f869d42e580f62 Manuel Lauss 2011-11-10  79  	db1550_hw_setup();
bd8510df881f63 Manuel Lauss 2012-09-13  80  	return 0;
f869d42e580f62 Manuel Lauss 2011-11-10  81  }
f869d42e580f62 Manuel Lauss 2011-11-10  82  

:::::: The code at line 69 was first introduced by commit
:::::: 970e268d6ed1f1799829cc0c87ea271a9e127e79 MIPS: Alchemy: Unify Devboard support.

:::::: TO: Manuel Lauss <manuel.lauss@gmail.com>
:::::: CC: Ralf Baechle <ralf@linux-mips.org>

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 27056 bytes --]

^ permalink raw reply	[flat|nested] 2+ messages in thread