All of lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH 1/1] package/boost: fix fiber dependencies
@ 2021-09-05 18:25 Fabrice Fontaine
  2021-09-06 12:53 ` Michael Nosthoff via buildroot
  2021-09-11 20:58 ` Arnout Vandecappelle
  0 siblings, 2 replies; 3+ messages in thread
From: Fabrice Fontaine @ 2021-09-05 18:25 UTC (permalink / raw)
  To: buildroot; +Cc: Fabrice Fontaine

Commit d39d8f7cee9b4634e6f490020204f63fae419e8e forgot to update fiber
dependencies resulting in the following build failure:

WARNING: unmet direct dependencies detected for BR2_PACKAGE_BOOST_FILESYSTEM
  Depends on [n]: BR2_PACKAGE_BOOST [=y] && BR2_TOOLCHAIN_SUPPORTS_ALWAYS_LOCKFREE_ATOMIC_INTS [=n]
  Selected by [y]:
  - BR2_PACKAGE_BOOST_FIBER [=y] && BR2_PACKAGE_BOOST [=y] && BR2_PACKAGE_BOOST_CONTEXT_ARCH_SUPPORTS [=y] && BR2_TOOLCHAIN_HAS_THREADS_NPTL [=y] && !BR2_MIPS_CPU_MIPS32 [=n] && !BR2_MIPS_CPU_MIPS64 [=n] && (BR2_TOOLCHAIN_SUPPORTS_ALWAYS_LOCKFREE_ATOMIC_INTS [=n] || BR2_TOOLCHAIN_GCC_AT_LEAST_6 [=y]) && !BR2_TOOLCHAIN_HAS_GCC_BUG_64735 [=n]

Fixes:
 - http://autobuild.buildroot.org/results/40b8af6ce273ebd5fca56d6734f64dacd562efb1

Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
 package/boost/Config.in | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/package/boost/Config.in b/package/boost/Config.in
index f6409769c6..536e5b8486 100644
--- a/package/boost/Config.in
+++ b/package/boost/Config.in
@@ -149,8 +149,7 @@ config BR2_PACKAGE_BOOST_FIBER
 	# mips support uses the "pause" instruction, only available
 	# since mips32r2/mips64r2.
 	depends on !BR2_MIPS_CPU_MIPS32 && !BR2_MIPS_CPU_MIPS64
-	depends on BR2_TOOLCHAIN_SUPPORTS_ALWAYS_LOCKFREE_ATOMIC_INTS \
-		|| BR2_TOOLCHAIN_GCC_AT_LEAST_6 # boost-context -> boost-thread
+	depends on BR2_TOOLCHAIN_SUPPORTS_ALWAYS_LOCKFREE_ATOMIC_INTS # boost-filesystem
 	depends on !BR2_TOOLCHAIN_HAS_GCC_BUG_64735 # boost-context
 	select BR2_PACKAGE_BOOST_CONTEXT
 	select BR2_PACKAGE_BOOST_FILESYSTEM
@@ -160,8 +159,7 @@ config BR2_PACKAGE_BOOST_FIBER
 
 comment "boost-fiber needs a toolchain w/ NPTL"
 	depends on BR2_PACKAGE_BOOST_CONTEXT_ARCH_SUPPORTS
-	depends on BR2_TOOLCHAIN_SUPPORTS_ALWAYS_LOCKFREE_ATOMIC_INTS \
-		|| BR2_TOOLCHAIN_GCC_AT_LEAST_6
+	depends on BR2_TOOLCHAIN_SUPPORTS_ALWAYS_LOCKFREE_ATOMIC_INTS
 	depends on !BR2_TOOLCHAIN_HAS_THREADS_NPTL
 
 comment "boost-fiber needs a toolchain not affected by GCC bug 64735"
-- 
2.33.0

_______________________________________________
buildroot mailing list
buildroot@lists.buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [Buildroot] [PATCH 1/1] package/boost: fix fiber dependencies
  2021-09-05 18:25 [Buildroot] [PATCH 1/1] package/boost: fix fiber dependencies Fabrice Fontaine
@ 2021-09-06 12:53 ` Michael Nosthoff via buildroot
  2021-09-11 20:58 ` Arnout Vandecappelle
  1 sibling, 0 replies; 3+ messages in thread
From: Michael Nosthoff via buildroot @ 2021-09-06 12:53 UTC (permalink / raw)
  To: Fabrice Fontaine, buildroot

Hi,

On 05.09.21 20:25, Fabrice Fontaine wrote:
> Commit d39d8f7cee9b4634e6f490020204f63fae419e8e forgot to update fiber
> dependencies resulting in the following build failure:
>
> WARNING: unmet direct dependencies detected for BR2_PACKAGE_BOOST_FILESYSTEM
>    Depends on [n]: BR2_PACKAGE_BOOST [=y] && BR2_TOOLCHAIN_SUPPORTS_ALWAYS_LOCKFREE_ATOMIC_INTS [=n]
>    Selected by [y]:
>    - BR2_PACKAGE_BOOST_FIBER [=y] && BR2_PACKAGE_BOOST [=y] && BR2_PACKAGE_BOOST_CONTEXT_ARCH_SUPPORTS [=y] && BR2_TOOLCHAIN_HAS_THREADS_NPTL [=y] && !BR2_MIPS_CPU_MIPS32 [=n] && !BR2_MIPS_CPU_MIPS64 [=n] && (BR2_TOOLCHAIN_SUPPORTS_ALWAYS_LOCKFREE_ATOMIC_INTS [=n] || BR2_TOOLCHAIN_GCC_AT_LEAST_6 [=y]) && !BR2_TOOLCHAIN_HAS_GCC_BUG_64735 [=n]
>
> Fixes:
>   - http://autobuild.buildroot.org/results/40b8af6ce273ebd5fca56d6734f64dacd562efb1
>
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
>   package/boost/Config.in | 6 ++----
>   1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/package/boost/Config.in b/package/boost/Config.in
> index f6409769c6..536e5b8486 100644
> --- a/package/boost/Config.in
> +++ b/package/boost/Config.in
> @@ -149,8 +149,7 @@ config BR2_PACKAGE_BOOST_FIBER
>   	# mips support uses the "pause" instruction, only available
>   	# since mips32r2/mips64r2.
>   	depends on !BR2_MIPS_CPU_MIPS32 && !BR2_MIPS_CPU_MIPS64
> -	depends on BR2_TOOLCHAIN_SUPPORTS_ALWAYS_LOCKFREE_ATOMIC_INTS \
> -		|| BR2_TOOLCHAIN_GCC_AT_LEAST_6 # boost-context -> boost-thread
> +	depends on BR2_TOOLCHAIN_SUPPORTS_ALWAYS_LOCKFREE_ATOMIC_INTS # boost-filesystem
>   	depends on !BR2_TOOLCHAIN_HAS_GCC_BUG_64735 # boost-context
>   	select BR2_PACKAGE_BOOST_CONTEXT
>   	select BR2_PACKAGE_BOOST_FILESYSTEM
> @@ -160,8 +159,7 @@ config BR2_PACKAGE_BOOST_FIBER
>   
>   comment "boost-fiber needs a toolchain w/ NPTL"
>   	depends on BR2_PACKAGE_BOOST_CONTEXT_ARCH_SUPPORTS
> -	depends on BR2_TOOLCHAIN_SUPPORTS_ALWAYS_LOCKFREE_ATOMIC_INTS \
> -		|| BR2_TOOLCHAIN_GCC_AT_LEAST_6
> +	depends on BR2_TOOLCHAIN_SUPPORTS_ALWAYS_LOCKFREE_ATOMIC_INTS
>   	depends on !BR2_TOOLCHAIN_HAS_THREADS_NPTL
>   
>   comment "boost-fiber needs a toolchain not affected by GCC bug 64735"

whoopsie, I somehow missed that this was an OR dependency. Nice catch!

Reviewed-by: Michael Nosthoff <buildroot@heine.tech>

Regards,
Michael


_______________________________________________
buildroot mailing list
buildroot@lists.buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [Buildroot] [PATCH 1/1] package/boost: fix fiber dependencies
  2021-09-05 18:25 [Buildroot] [PATCH 1/1] package/boost: fix fiber dependencies Fabrice Fontaine
  2021-09-06 12:53 ` Michael Nosthoff via buildroot
@ 2021-09-11 20:58 ` Arnout Vandecappelle
  1 sibling, 0 replies; 3+ messages in thread
From: Arnout Vandecappelle @ 2021-09-11 20:58 UTC (permalink / raw)
  To: Fabrice Fontaine, buildroot



On 05/09/2021 20:25, Fabrice Fontaine wrote:
> Commit d39d8f7cee9b4634e6f490020204f63fae419e8e forgot to update fiber
> dependencies resulting in the following build failure:
> 
> WARNING: unmet direct dependencies detected for BR2_PACKAGE_BOOST_FILESYSTEM
>   Depends on [n]: BR2_PACKAGE_BOOST [=y] && BR2_TOOLCHAIN_SUPPORTS_ALWAYS_LOCKFREE_ATOMIC_INTS [=n]
>   Selected by [y]:
>   - BR2_PACKAGE_BOOST_FIBER [=y] && BR2_PACKAGE_BOOST [=y] && BR2_PACKAGE_BOOST_CONTEXT_ARCH_SUPPORTS [=y] && BR2_TOOLCHAIN_HAS_THREADS_NPTL [=y] && !BR2_MIPS_CPU_MIPS32 [=n] && !BR2_MIPS_CPU_MIPS64 [=n] && (BR2_TOOLCHAIN_SUPPORTS_ALWAYS_LOCKFREE_ATOMIC_INTS [=n] || BR2_TOOLCHAIN_GCC_AT_LEAST_6 [=y]) && !BR2_TOOLCHAIN_HAS_GCC_BUG_64735 [=n]
> 
> Fixes:
>  - http://autobuild.buildroot.org/results/40b8af6ce273ebd5fca56d6734f64dacd562efb1
> 
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>

 Applied to master, thanks.

 Regards,
 Arnout

> ---
>  package/boost/Config.in | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/package/boost/Config.in b/package/boost/Config.in
> index f6409769c6..536e5b8486 100644
> --- a/package/boost/Config.in
> +++ b/package/boost/Config.in
> @@ -149,8 +149,7 @@ config BR2_PACKAGE_BOOST_FIBER
>  	# mips support uses the "pause" instruction, only available
>  	# since mips32r2/mips64r2.
>  	depends on !BR2_MIPS_CPU_MIPS32 && !BR2_MIPS_CPU_MIPS64
> -	depends on BR2_TOOLCHAIN_SUPPORTS_ALWAYS_LOCKFREE_ATOMIC_INTS \
> -		|| BR2_TOOLCHAIN_GCC_AT_LEAST_6 # boost-context -> boost-thread
> +	depends on BR2_TOOLCHAIN_SUPPORTS_ALWAYS_LOCKFREE_ATOMIC_INTS # boost-filesystem
>  	depends on !BR2_TOOLCHAIN_HAS_GCC_BUG_64735 # boost-context
>  	select BR2_PACKAGE_BOOST_CONTEXT
>  	select BR2_PACKAGE_BOOST_FILESYSTEM
> @@ -160,8 +159,7 @@ config BR2_PACKAGE_BOOST_FIBER
>  
>  comment "boost-fiber needs a toolchain w/ NPTL"
>  	depends on BR2_PACKAGE_BOOST_CONTEXT_ARCH_SUPPORTS
> -	depends on BR2_TOOLCHAIN_SUPPORTS_ALWAYS_LOCKFREE_ATOMIC_INTS \
> -		|| BR2_TOOLCHAIN_GCC_AT_LEAST_6
> +	depends on BR2_TOOLCHAIN_SUPPORTS_ALWAYS_LOCKFREE_ATOMIC_INTS
>  	depends on !BR2_TOOLCHAIN_HAS_THREADS_NPTL
>  
>  comment "boost-fiber needs a toolchain not affected by GCC bug 64735"
> 
_______________________________________________
buildroot mailing list
buildroot@lists.buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-09-11 20:58 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-05 18:25 [Buildroot] [PATCH 1/1] package/boost: fix fiber dependencies Fabrice Fontaine
2021-09-06 12:53 ` Michael Nosthoff via buildroot
2021-09-11 20:58 ` Arnout Vandecappelle

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.