* [PATCH] pata_legacy: Remove redundant initialization of variable timing
@ 2021-09-07 10:18 Colin King
0 siblings, 0 replies; only message in thread
From: Colin King @ 2021-09-07 10:18 UTC (permalink / raw)
To: Jens Axboe, linux-ide; +Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
The variable timing is being initialized with a value that is never
read, it is being updated later on. The assignment is redundant and
can be removed.
Addresses-Coverity: ("Unused value")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/ata/pata_legacy.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/ata/pata_legacy.c b/drivers/ata/pata_legacy.c
index c3e6592712c4..bb5694ecdfba 100644
--- a/drivers/ata/pata_legacy.c
+++ b/drivers/ata/pata_legacy.c
@@ -815,7 +815,7 @@ static void winbond_set_piomode(struct ata_port *ap, struct ata_device *adev)
struct legacy_data *ld_winbond = ap->host->private_data;
int active, recovery;
u8 reg;
- int timing = 0x88 + (ap->port_no * 4) + (adev->devno * 2);
+ int timing;
reg = winbond_readcfg(ld_winbond->timing, 0x81);
--
2.32.0
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2021-09-07 10:18 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-07 10:18 [PATCH] pata_legacy: Remove redundant initialization of variable timing Colin King
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.