* [PATCH] mtd: rawnand: intel: Fix potential buffer overflow in probe
@ 2021-09-03 8:26 ` Evgeny Novikov
0 siblings, 0 replies; 4+ messages in thread
From: Evgeny Novikov @ 2021-09-03 8:26 UTC (permalink / raw)
To: Miquel Raynal
Cc: Evgeny Novikov, Richard Weinberger, Vignesh Raghavendra,
Ramuthevar Vadivel Murugan, Martin Blumenstingl,
Christophe JAILLET, Kirill Shilimanov, Anton Vasilyev, linux-mtd,
linux-kernel, ldv-project
ebu_nand_probe() read the value of u32 variable "cs" from the device
firmware description and used it as the index for array ebu_host->cs
that can contain MAX_CS (2) elements at most. That could result in
a buffer overflow and various bad consequences later.
Fix the potential buffer overflow by restricting values of "cs" with
MAX_CS in probe.
Found by Linux Driver Verification project (linuxtesting.org).
Fixes: 0b1039f016e8 ("mtd: rawnand: Add NAND controller support on Intel LGM SoC")
Signed-off-by: Evgeny Novikov <novikov@ispras.ru>
Co-developed-by: Kirill Shilimanov <kirill.shilimanov@huawei.com>
Signed-off-by: Kirill Shilimanov <kirill.shilimanov@huawei.com>
Co-developed-by: Anton Vasilyev <vasilyev@ispras.ru>
Signed-off-by: Anton Vasilyev <vasilyev@ispras.ru>
---
drivers/mtd/nand/raw/intel-nand-controller.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/drivers/mtd/nand/raw/intel-nand-controller.c b/drivers/mtd/nand/raw/intel-nand-controller.c
index 8b49fd56cf96..81678088fdca 100644
--- a/drivers/mtd/nand/raw/intel-nand-controller.c
+++ b/drivers/mtd/nand/raw/intel-nand-controller.c
@@ -609,6 +609,11 @@ static int ebu_nand_probe(struct platform_device *pdev)
dev_err(dev, "failed to get chip select: %d\n", ret);
return ret;
}
+ if (cs >= MAX_CS) {
+ dev_err(dev, "got invalid chip select: %d\n", cs);
+ return -EINVAL;
+ }
+
ebu_host->cs_num = cs;
resname = devm_kasprintf(dev, GFP_KERNEL, "nand_cs%d", cs);
--
2.26.2
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH] mtd: rawnand: intel: Fix potential buffer overflow in probe
@ 2021-09-03 8:26 ` Evgeny Novikov
0 siblings, 0 replies; 4+ messages in thread
From: Evgeny Novikov @ 2021-09-03 8:26 UTC (permalink / raw)
To: Miquel Raynal
Cc: Evgeny Novikov, Richard Weinberger, Vignesh Raghavendra,
Ramuthevar Vadivel Murugan, Martin Blumenstingl,
Christophe JAILLET, Kirill Shilimanov, Anton Vasilyev, linux-mtd,
linux-kernel, ldv-project
ebu_nand_probe() read the value of u32 variable "cs" from the device
firmware description and used it as the index for array ebu_host->cs
that can contain MAX_CS (2) elements at most. That could result in
a buffer overflow and various bad consequences later.
Fix the potential buffer overflow by restricting values of "cs" with
MAX_CS in probe.
Found by Linux Driver Verification project (linuxtesting.org).
Fixes: 0b1039f016e8 ("mtd: rawnand: Add NAND controller support on Intel LGM SoC")
Signed-off-by: Evgeny Novikov <novikov@ispras.ru>
Co-developed-by: Kirill Shilimanov <kirill.shilimanov@huawei.com>
Signed-off-by: Kirill Shilimanov <kirill.shilimanov@huawei.com>
Co-developed-by: Anton Vasilyev <vasilyev@ispras.ru>
Signed-off-by: Anton Vasilyev <vasilyev@ispras.ru>
---
drivers/mtd/nand/raw/intel-nand-controller.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/drivers/mtd/nand/raw/intel-nand-controller.c b/drivers/mtd/nand/raw/intel-nand-controller.c
index 8b49fd56cf96..81678088fdca 100644
--- a/drivers/mtd/nand/raw/intel-nand-controller.c
+++ b/drivers/mtd/nand/raw/intel-nand-controller.c
@@ -609,6 +609,11 @@ static int ebu_nand_probe(struct platform_device *pdev)
dev_err(dev, "failed to get chip select: %d\n", ret);
return ret;
}
+ if (cs >= MAX_CS) {
+ dev_err(dev, "got invalid chip select: %d\n", cs);
+ return -EINVAL;
+ }
+
ebu_host->cs_num = cs;
resname = devm_kasprintf(dev, GFP_KERNEL, "nand_cs%d", cs);
--
2.26.2
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] mtd: rawnand: intel: Fix potential buffer overflow in probe
2021-09-03 8:26 ` Evgeny Novikov
@ 2021-09-14 17:39 ` Miquel Raynal
-1 siblings, 0 replies; 4+ messages in thread
From: Miquel Raynal @ 2021-09-14 17:39 UTC (permalink / raw)
To: Evgeny Novikov, Miquel Raynal
Cc: Richard Weinberger, Vignesh Raghavendra,
Ramuthevar Vadivel Murugan, Martin Blumenstingl,
Christophe JAILLET, Kirill Shilimanov, Anton Vasilyev, linux-mtd,
linux-kernel, ldv-project
On Fri, 2021-09-03 at 08:26:53 UTC, Evgeny Novikov wrote:
> ebu_nand_probe() read the value of u32 variable "cs" from the device
> firmware description and used it as the index for array ebu_host->cs
> that can contain MAX_CS (2) elements at most. That could result in
> a buffer overflow and various bad consequences later.
>
> Fix the potential buffer overflow by restricting values of "cs" with
> MAX_CS in probe.
>
> Found by Linux Driver Verification project (linuxtesting.org).
>
> Fixes: 0b1039f016e8 ("mtd: rawnand: Add NAND controller support on Intel LGM SoC")
> Signed-off-by: Evgeny Novikov <novikov@ispras.ru>
> Co-developed-by: Kirill Shilimanov <kirill.shilimanov@huawei.com>
> Signed-off-by: Kirill Shilimanov <kirill.shilimanov@huawei.com>
> Co-developed-by: Anton Vasilyev <vasilyev@ispras.ru>
> Signed-off-by: Anton Vasilyev <vasilyev@ispras.ru>
Applied to https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git nand/next, thanks.
Miquel
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] mtd: rawnand: intel: Fix potential buffer overflow in probe
@ 2021-09-14 17:39 ` Miquel Raynal
0 siblings, 0 replies; 4+ messages in thread
From: Miquel Raynal @ 2021-09-14 17:39 UTC (permalink / raw)
To: Evgeny Novikov, Miquel Raynal
Cc: Richard Weinberger, Vignesh Raghavendra,
Ramuthevar Vadivel Murugan, Martin Blumenstingl,
Christophe JAILLET, Kirill Shilimanov, Anton Vasilyev, linux-mtd,
linux-kernel, ldv-project
On Fri, 2021-09-03 at 08:26:53 UTC, Evgeny Novikov wrote:
> ebu_nand_probe() read the value of u32 variable "cs" from the device
> firmware description and used it as the index for array ebu_host->cs
> that can contain MAX_CS (2) elements at most. That could result in
> a buffer overflow and various bad consequences later.
>
> Fix the potential buffer overflow by restricting values of "cs" with
> MAX_CS in probe.
>
> Found by Linux Driver Verification project (linuxtesting.org).
>
> Fixes: 0b1039f016e8 ("mtd: rawnand: Add NAND controller support on Intel LGM SoC")
> Signed-off-by: Evgeny Novikov <novikov@ispras.ru>
> Co-developed-by: Kirill Shilimanov <kirill.shilimanov@huawei.com>
> Signed-off-by: Kirill Shilimanov <kirill.shilimanov@huawei.com>
> Co-developed-by: Anton Vasilyev <vasilyev@ispras.ru>
> Signed-off-by: Anton Vasilyev <vasilyev@ispras.ru>
Applied to https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git nand/next, thanks.
Miquel
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-09-14 17:39 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-03 8:26 [PATCH] mtd: rawnand: intel: Fix potential buffer overflow in probe Evgeny Novikov
2021-09-03 8:26 ` Evgeny Novikov
2021-09-14 17:39 ` Miquel Raynal
2021-09-14 17:39 ` Miquel Raynal
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.