All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] nvmem: nintendo-otp: add dependency on CONFIG_HAS_IOMEM
@ 2021-09-17 11:20 Michal Kubecek
  2021-09-17 11:37 ` Michal Kubecek
  0 siblings, 1 reply; 2+ messages in thread
From: Michal Kubecek @ 2021-09-17 11:20 UTC (permalink / raw)
  To: Srinivas Kandagatla, linux-kernel; +Cc: Emmanuel Gil Peyrot, Greg Kroah-Hartman

Function nintendo_otp_probe() calls devm_ioremap_resource() which is only
available if CONFIG_HAS_IOMEM is enabled. Add a kconfig dependency like
other similar drivers have.

Fixes: 3683b761fe3a ("nvmem: nintendo-otp: Add new driver for the Wii and Wii U OTP")
Signed-off-by: Michal Kubecek <mkubecek@suse.cz>
---
 drivers/nvmem/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/nvmem/Kconfig b/drivers/nvmem/Kconfig
index 39854d43758b..fb4005df86c0 100644
--- a/drivers/nvmem/Kconfig
+++ b/drivers/nvmem/Kconfig
@@ -108,6 +108,7 @@ config MTK_EFUSE
 	  will be called efuse-mtk.
 
 config NVMEM_NINTENDO_OTP
+	depends on HAS_IOMEM
 	tristate "Nintendo Wii and Wii U OTP Support"
 	help
 	  This is a driver exposing the OTP of a Nintendo Wii or Wii U console.
-- 
2.33.0


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] nvmem: nintendo-otp: add dependency on CONFIG_HAS_IOMEM
  2021-09-17 11:20 [PATCH] nvmem: nintendo-otp: add dependency on CONFIG_HAS_IOMEM Michal Kubecek
@ 2021-09-17 11:37 ` Michal Kubecek
  0 siblings, 0 replies; 2+ messages in thread
From: Michal Kubecek @ 2021-09-17 11:37 UTC (permalink / raw)
  To: Srinivas Kandagatla, linux-kernel; +Cc: Emmanuel Gil Peyrot, Greg Kroah-Hartman

On Fri, Sep 17, 2021 at 01:20:18PM +0200, Michal Kubecek wrote:
> Function nintendo_otp_probe() calls devm_ioremap_resource() which is only
> available if CONFIG_HAS_IOMEM is enabled. Add a kconfig dependency like
> other similar drivers have.
> 
> Fixes: 3683b761fe3a ("nvmem: nintendo-otp: Add new driver for the Wii and Wii U OTP")
> Signed-off-by: Michal Kubecek <mkubecek@suse.cz>

A note: the build failure was already reported in

  https://lore.kernel.org/all/202108250657.h5CWR7Xf-lkp@intel.com/

Michal

> ---
>  drivers/nvmem/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/nvmem/Kconfig b/drivers/nvmem/Kconfig
> index 39854d43758b..fb4005df86c0 100644
> --- a/drivers/nvmem/Kconfig
> +++ b/drivers/nvmem/Kconfig
> @@ -108,6 +108,7 @@ config MTK_EFUSE
>  	  will be called efuse-mtk.
>  
>  config NVMEM_NINTENDO_OTP
> +	depends on HAS_IOMEM
>  	tristate "Nintendo Wii and Wii U OTP Support"
>  	help
>  	  This is a driver exposing the OTP of a Nintendo Wii or Wii U console.
> -- 
> 2.33.0
> 

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-09-17 11:37 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-17 11:20 [PATCH] nvmem: nintendo-otp: add dependency on CONFIG_HAS_IOMEM Michal Kubecek
2021-09-17 11:37 ` Michal Kubecek

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.