All of lore.kernel.org
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
To: linux-nfc@lists.01.org
Cc: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
Subject: [linux-nfc] [neard][PATCH 6/8] ci: install pkg-config
Date: Wed, 22 Sep 2021 18:11:11 +0200	[thread overview]
Message-ID: <20210922161113.142758-6-krzysztof.kozlowski@canonical.com> (raw)
In-Reply-To: <20210922161113.142758-1-krzysztof.kozlowski@canonical.com>

Some newer distros (e.g. Fedora 35) might not pull pkg-config and print
confusing errors like:

  configure.ac:61: error: possibly undefined macro: AC_MSG_ERROR
  If this token and others are legitimate, please use m4_pattern_allow.
  See the Autoconf documentation.
  configure.ac:179: error: possibly undefined macro: AC_DEFINE

Configure explicitly uses pkg-config so install it always.

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
---
 HACKING      | 1 +
 ci/alpine.sh | 1 +
 ci/debian.sh | 1 +
 3 files changed, 3 insertions(+)

diff --git a/HACKING b/HACKING
index 40bde2fb3c8b..db75f0d11a17 100644
--- a/HACKING
+++ b/HACKING
@@ -16,6 +16,7 @@ Required packages and tools:
   libnl-3
   libnl-genl-3
   make
+  pkg-config
 
 See also installation scripts for  Continuous Integration in ci/ directory.
 
diff --git a/ci/alpine.sh b/ci/alpine.sh
index 56449dd7c969..bf87068228f3 100755
--- a/ci/alpine.sh
+++ b/ci/alpine.sh
@@ -33,6 +33,7 @@ apk add \
 	libtool \
 	make \
 	musl-dev \
+	pkgconfig \
 	$PKGS_CC
 
 # Packages needed by CI
diff --git a/ci/debian.sh b/ci/debian.sh
index 962e554304ee..adb683eadf81 100755
--- a/ci/debian.sh
+++ b/ci/debian.sh
@@ -36,6 +36,7 @@ apt install -y --no-install-recommends \
 	libnl-genl-3-dev \
 	libtool \
 	make \
+	pkg-config \
 	$PKGS_CC
 
 echo "Install finished: $0"
-- 
2.30.2
_______________________________________________
Linux-nfc mailing list -- linux-nfc@lists.01.org
To unsubscribe send an email to linux-nfc-leave@lists.01.org
%(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s

WARNING: multiple messages have this Message-ID (diff)
From: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
To: linux-nfc@lists.01.org
Subject: [neard][PATCH 6/8] ci: install pkg-config
Date: Wed, 22 Sep 2021 18:11:11 +0200	[thread overview]
Message-ID: <20210922161113.142758-6-krzysztof.kozlowski@canonical.com> (raw)
In-Reply-To: <20210922161113.142758-1-krzysztof.kozlowski@canonical.com>

[-- Attachment #1: Type: text/plain, Size: 1413 bytes --]

Some newer distros (e.g. Fedora 35) might not pull pkg-config and print
confusing errors like:

  configure.ac:61: error: possibly undefined macro: AC_MSG_ERROR
  If this token and others are legitimate, please use m4_pattern_allow.
  See the Autoconf documentation.
  configure.ac:179: error: possibly undefined macro: AC_DEFINE

Configure explicitly uses pkg-config so install it always.

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
---
 HACKING      | 1 +
 ci/alpine.sh | 1 +
 ci/debian.sh | 1 +
 3 files changed, 3 insertions(+)

diff --git a/HACKING b/HACKING
index 40bde2fb3c8b..db75f0d11a17 100644
--- a/HACKING
+++ b/HACKING
@@ -16,6 +16,7 @@ Required packages and tools:
   libnl-3
   libnl-genl-3
   make
+  pkg-config
 
 See also installation scripts for  Continuous Integration in ci/ directory.
 
diff --git a/ci/alpine.sh b/ci/alpine.sh
index 56449dd7c969..bf87068228f3 100755
--- a/ci/alpine.sh
+++ b/ci/alpine.sh
@@ -33,6 +33,7 @@ apk add \
 	libtool \
 	make \
 	musl-dev \
+	pkgconfig \
 	$PKGS_CC
 
 # Packages needed by CI
diff --git a/ci/debian.sh b/ci/debian.sh
index 962e554304ee..adb683eadf81 100755
--- a/ci/debian.sh
+++ b/ci/debian.sh
@@ -36,6 +36,7 @@ apt install -y --no-install-recommends \
 	libnl-genl-3-dev \
 	libtool \
 	make \
+	pkg-config \
 	$PKGS_CC
 
 echo "Install finished: $0"
-- 
2.30.2

  parent reply	other threads:[~2021-09-22 16:12 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-22 16:11 [linux-nfc] [neard][PATCH 1/8] build: adjust configure.ac syntax to match autoupdate Krzysztof Kozlowski
2021-09-22 16:11 ` Krzysztof Kozlowski
2021-09-22 16:11 ` [linux-nfc] [neard][PATCH 2/8] build: replace deprecated AC_HELP_STRING Krzysztof Kozlowski
2021-09-22 16:11   ` Krzysztof Kozlowski
2021-09-22 16:11 ` [linux-nfc] [neard][PATCH 3/8] ci: switch to dnf on Fedora Krzysztof Kozlowski
2021-09-22 16:11   ` Krzysztof Kozlowski
2021-09-22 16:11 ` [linux-nfc] [neard][PATCH 4/8] ci: add more Fedora containers Krzysztof Kozlowski
2021-09-22 16:11   ` Krzysztof Kozlowski
2021-09-22 16:11 ` [linux-nfc] [neard][PATCH 5/8] ci: add ArchLinux container Krzysztof Kozlowski
2021-09-22 16:11   ` Krzysztof Kozlowski
2021-09-22 16:11 ` Krzysztof Kozlowski [this message]
2021-09-22 16:11   ` [neard][PATCH 6/8] ci: install pkg-config Krzysztof Kozlowski
2021-09-22 16:11 ` [linux-nfc] [neard][PATCH 7/8] HACKING: rephrase message about dependencies Krzysztof Kozlowski
2021-09-22 16:11   ` Krzysztof Kozlowski
2021-09-22 16:11 ` [linux-nfc] [neard][PATCH 8/8] ci: group package installation on Alpine Krzysztof Kozlowski
2021-09-22 16:11   ` Krzysztof Kozlowski
2021-09-23 15:54 ` [linux-nfc] Re: [neard][PATCH 1/8] build: adjust configure.ac syntax to match autoupdate Krzysztof Kozlowski
2021-09-23 15:54   ` Krzysztof Kozlowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210922161113.142758-6-krzysztof.kozlowski@canonical.com \
    --to=krzysztof.kozlowski@canonical.com \
    --cc=linux-nfc@lists.01.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.