All of lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH 1/1] package/python-pip: needs python3
@ 2021-09-25  8:33 Fabrice Fontaine
  2021-09-26 19:41 ` Arnout Vandecappelle
  0 siblings, 1 reply; 2+ messages in thread
From: Fabrice Fontaine @ 2021-09-25  8:33 UTC (permalink / raw)
  To: buildroot; +Cc: Fabrice Fontaine, Asaf Kahlon, Thomas Petazzoni

python 2 support has been dropped since version 21.0 resulting in the
following build failure since bump to version 21.2.4 in commit
3491f34d9ed97ac5980ff4a450367914b6985ff1:

  File "setup.py", line 7
    def read(rel_path: str) -> str:
                     ^

Fixes:
 - http://autobuild.buildroot.org/results/ed74f4ca96332454af329fac23505000c379d4a3

Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
 package/python-pip/Config.in         |  5 ++---
 package/python-pip/python-pip.mk     |  1 -
 package/python3-pip/python3-pip.hash |  1 -
 package/python3-pip/python3-pip.mk   | 19 -------------------
 4 files changed, 2 insertions(+), 24 deletions(-)
 delete mode 120000 package/python3-pip/python3-pip.hash
 delete mode 100644 package/python3-pip/python3-pip.mk

diff --git a/package/python-pip/Config.in b/package/python-pip/Config.in
index 61d8d7d317..92c3e3bd46 100644
--- a/package/python-pip/Config.in
+++ b/package/python-pip/Config.in
@@ -1,9 +1,8 @@
 config BR2_PACKAGE_PYTHON_PIP
 	bool "python-pip"
-	select BR2_PACKAGE_PYTHON_HASHLIB if BR2_PACKAGE_PYTHON # runtime
+	depends on BR2_PACKAGE_PYTHON3
 	select BR2_PACKAGE_PYTHON_SETUPTOOLS # runtime
-	select BR2_PACKAGE_PYTHON_SSL if BR2_PACKAGE_PYTHON # runtime
-	select BR2_PACKAGE_PYTHON3_SSL if BR2_PACKAGE_PYTHON3 # runtime
+	select BR2_PACKAGE_PYTHON3_SSL
 	help
 	  The PyPA recommended tool for installing Python packages.
 
diff --git a/package/python-pip/python-pip.mk b/package/python-pip/python-pip.mk
index ba7134e235..81fc87d5f0 100644
--- a/package/python-pip/python-pip.mk
+++ b/package/python-pip/python-pip.mk
@@ -4,7 +4,6 @@
 #
 ################################################################################
 
-# Please keep in sync with package/python3-pip/python3-pip.mk
 PYTHON_PIP_VERSION = 21.2.4
 PYTHON_PIP_SOURCE = pip-$(PYTHON_PIP_VERSION).tar.gz
 PYTHON_PIP_SITE = https://files.pythonhosted.org/packages/52/e1/06c018197d8151383f66ebf6979d951995cf495629fc54149491f5d157d0
diff --git a/package/python3-pip/python3-pip.hash b/package/python3-pip/python3-pip.hash
deleted file mode 120000
index d90fb3d005..0000000000
--- a/package/python3-pip/python3-pip.hash
+++ /dev/null
@@ -1 +0,0 @@
-../python-pip/python-pip.hash
\ No newline at end of file
diff --git a/package/python3-pip/python3-pip.mk b/package/python3-pip/python3-pip.mk
deleted file mode 100644
index 5e20b06865..0000000000
--- a/package/python3-pip/python3-pip.mk
+++ /dev/null
@@ -1,19 +0,0 @@
-################################################################################
-#
-# python3-pip
-#
-################################################################################
-
-# Please keep in sync with package/python-pip/python-pip.mk
-PYTHON3_PIP_VERSION = 21.2.4
-PYTHON3_PIP_SOURCE = pip-$(PYTHON_PIP_VERSION).tar.gz
-PYTHON3_PIP_SITE = https://files.pythonhosted.org/packages/52/e1/06c018197d8151383f66ebf6979d951995cf495629fc54149491f5d157d0
-PYTHON3_PIP_SETUP_TYPE = setuptools
-PYTHON3_PIP_LICENSE = MIT
-PYTHON3_PIP_LICENSE_FILES = LICENSE.txt
-PYTHON3_PIP_CPE_ID_VENDOR = pypa
-PYTHON3_PIP_CPE_ID_PRODUCT = pip
-HOST_PYTHON3_PIP_DL_SUBDIR = python-pip
-HOST_PYTHON3_PIP_NEEDS_HOST_PYTHON = python3
-
-$(eval $(host-python-package))
-- 
2.33.0

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply related	[flat|nested] 2+ messages in thread
* Re: [Buildroot] [PATCH 1/1] package/python-pip: needs python3
  2021-09-25  8:33 [Buildroot] [PATCH 1/1] package/python-pip: needs python3 Fabrice Fontaine
@ 2021-09-26 19:41 ` Arnout Vandecappelle
  0 siblings, 0 replies; 2+ messages in thread
From: Arnout Vandecappelle @ 2021-09-26 19:41 UTC (permalink / raw)
  To: Fabrice Fontaine, buildroot, Chan, Donald
  Cc: James Hilliard, Thomas Petazzoni, Asaf Kahlon



On 25/09/2021 10:33, Fabrice Fontaine wrote:
> python 2 support has been dropped since version 21.0 resulting in the
> following build failure since bump to version 21.2.4 in commit
> 3491f34d9ed97ac5980ff4a450367914b6985ff1:
> 
>    File "setup.py", line 7
>      def read(rel_path: str) -> str:
>                       ^
> 
> Fixes:
>   - http://autobuild.buildroot.org/results/ed74f4ca96332454af329fac23505000c379d4a3
> 
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
>   package/python-pip/Config.in         |  5 ++---
>   package/python-pip/python-pip.mk     |  1 -
>   package/python3-pip/python3-pip.hash |  1 -
>   package/python3-pip/python3-pip.mk   | 19 -------------------

  You removed python3-pip which is no longer needed, you forgot to mention that 
in the commit message.

  More importantly, though: python3-cryptography still depends on it.

  However, there are a few things wrong with python3-cryptography.

  Since your commit 0c7e30b43a, python-cryptography depends on python3. So 
python3-cryptography already became redundant at that point. However, 
python3-cryptography is a host-only package, while python-cryptography is a 
python-only package, so it's a bit more work to get rid of it.

  Since commit c64abc693 (which precedes the above commit by a couple of days), 
James "stuck" the version of python-cryptography to 3.3.2 which is the last one 
to support python2, while the current version is 3.4.8. So a version bump is in 
order.

  Also, there's something fishy about python3-cryptography: it depends on 
python3-pip, while (target) python-cryptography doesn't depend on python-pip 
(neither build nor runtime). This has been the case since Donald Chan created 
the package in commit 7cee1f6e. Chan, can you comment on this?

  So what I think should be done:

1. add host-python-cryptography;
2. remove python3-cryptography;
3. remove python3-pip (which is now unused);
4. this patch.
(5. bump python-cryptography to 3.4.8 - pretty much independent of this patch)

  Regards,
  Arnout


>   4 files changed, 2 insertions(+), 24 deletions(-)
>   delete mode 120000 package/python3-pip/python3-pip.hash
>   delete mode 100644 package/python3-pip/python3-pip.mk
> 
> diff --git a/package/python-pip/Config.in b/package/python-pip/Config.in
> index 61d8d7d317..92c3e3bd46 100644
> --- a/package/python-pip/Config.in
> +++ b/package/python-pip/Config.in
> @@ -1,9 +1,8 @@
>   config BR2_PACKAGE_PYTHON_PIP
>   	bool "python-pip"
> -	select BR2_PACKAGE_PYTHON_HASHLIB if BR2_PACKAGE_PYTHON # runtime
> +	depends on BR2_PACKAGE_PYTHON3
>   	select BR2_PACKAGE_PYTHON_SETUPTOOLS # runtime
> -	select BR2_PACKAGE_PYTHON_SSL if BR2_PACKAGE_PYTHON # runtime
> -	select BR2_PACKAGE_PYTHON3_SSL if BR2_PACKAGE_PYTHON3 # runtime
> +	select BR2_PACKAGE_PYTHON3_SSL
>   	help
>   	  The PyPA recommended tool for installing Python packages.
>   
> diff --git a/package/python-pip/python-pip.mk b/package/python-pip/python-pip.mk
> index ba7134e235..81fc87d5f0 100644
> --- a/package/python-pip/python-pip.mk
> +++ b/package/python-pip/python-pip.mk
> @@ -4,7 +4,6 @@
>   #
>   ################################################################################
>   
> -# Please keep in sync with package/python3-pip/python3-pip.mk
>   PYTHON_PIP_VERSION = 21.2.4
>   PYTHON_PIP_SOURCE = pip-$(PYTHON_PIP_VERSION).tar.gz
>   PYTHON_PIP_SITE = https://files.pythonhosted.org/packages/52/e1/06c018197d8151383f66ebf6979d951995cf495629fc54149491f5d157d0
> diff --git a/package/python3-pip/python3-pip.hash b/package/python3-pip/python3-pip.hash
> deleted file mode 120000
> index d90fb3d005..0000000000
> --- a/package/python3-pip/python3-pip.hash
> +++ /dev/null
> @@ -1 +0,0 @@
> -../python-pip/python-pip.hash
> \ No newline at end of file
> diff --git a/package/python3-pip/python3-pip.mk b/package/python3-pip/python3-pip.mk
> deleted file mode 100644
> index 5e20b06865..0000000000
> --- a/package/python3-pip/python3-pip.mk
> +++ /dev/null
> @@ -1,19 +0,0 @@
> -################################################################################
> -#
> -# python3-pip
> -#
> -################################################################################
> -
> -# Please keep in sync with package/python-pip/python-pip.mk
> -PYTHON3_PIP_VERSION = 21.2.4
> -PYTHON3_PIP_SOURCE = pip-$(PYTHON_PIP_VERSION).tar.gz
> -PYTHON3_PIP_SITE = https://files.pythonhosted.org/packages/52/e1/06c018197d8151383f66ebf6979d951995cf495629fc54149491f5d157d0
> -PYTHON3_PIP_SETUP_TYPE = setuptools
> -PYTHON3_PIP_LICENSE = MIT
> -PYTHON3_PIP_LICENSE_FILES = LICENSE.txt
> -PYTHON3_PIP_CPE_ID_VENDOR = pypa
> -PYTHON3_PIP_CPE_ID_PRODUCT = pip
> -HOST_PYTHON3_PIP_DL_SUBDIR = python-pip
> -HOST_PYTHON3_PIP_NEEDS_HOST_PYTHON = python3
> -
> -$(eval $(host-python-package))
> 
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-09-26 19:41 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-25  8:33 [Buildroot] [PATCH 1/1] package/python-pip: needs python3 Fabrice Fontaine
2021-09-26 19:41 ` Arnout Vandecappelle

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.