* [driver-core:debugfs_cleanup 1/2] fs/d_path.c:59 prepend() warn: unsigned 'p->len' is never less than zero.
@ 2021-09-30 9:46 ` Dan Carpenter
0 siblings, 0 replies; 2+ messages in thread
From: kernel test robot @ 2021-09-30 4:17 UTC (permalink / raw)
To: kbuild-all
[-- Attachment #1: Type: text/plain, Size: 2566 bytes --]
tree: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-core.git debugfs_cleanup
head: c4535d1b074f3fdd9476e83526d4e9b53f41a7b5
commit: 473082c5bbad92c5909ccf75fb28df699b94de82 [1/2] fs: make d_path-like functions all have unsigned size
config: i386-randconfig-m021-20210929 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
smatch warnings:
fs/d_path.c:59 prepend() warn: unsigned 'p->len' is never less than zero.
vim +59 fs/d_path.c
b0cfcdd9b9672ea Linus Torvalds 2021-07-16 55
b0cfcdd9b9672ea Linus Torvalds 2021-07-16 56 static bool prepend(struct prepend_buffer *p, const char *str, int namelen)
b0cfcdd9b9672ea Linus Torvalds 2021-07-16 57 {
b0cfcdd9b9672ea Linus Torvalds 2021-07-16 58 // Already overflowed?
b0cfcdd9b9672ea Linus Torvalds 2021-07-16 @59 if (p->len < 0)
b0cfcdd9b9672ea Linus Torvalds 2021-07-16 60 return false;
b0cfcdd9b9672ea Linus Torvalds 2021-07-16 61
b0cfcdd9b9672ea Linus Torvalds 2021-07-16 62 // Will overflow?
b0cfcdd9b9672ea Linus Torvalds 2021-07-16 63 if (p->len < namelen) {
b0cfcdd9b9672ea Linus Torvalds 2021-07-16 64 // Fill as much as possible from the end of the name
b0cfcdd9b9672ea Linus Torvalds 2021-07-16 65 str += namelen - p->len;
b0cfcdd9b9672ea Linus Torvalds 2021-07-16 66 p->buf -= p->len;
b0cfcdd9b9672ea Linus Torvalds 2021-07-16 67 prepend_copy(p->buf, str, p->len);
b0cfcdd9b9672ea Linus Torvalds 2021-07-16 68 p->len = -1;
b0cfcdd9b9672ea Linus Torvalds 2021-07-16 69 return false;
b0cfcdd9b9672ea Linus Torvalds 2021-07-16 70 }
b0cfcdd9b9672ea Linus Torvalds 2021-07-16 71
b0cfcdd9b9672ea Linus Torvalds 2021-07-16 72 // Fits fully
ad08ae586586ea9 Al Viro 2021-05-12 73 p->len -= namelen;
ad08ae586586ea9 Al Viro 2021-05-12 74 p->buf -= namelen;
b0cfcdd9b9672ea Linus Torvalds 2021-07-16 75 return prepend_copy(p->buf, str, namelen);
7a5cf791a747640 Al Viro 2018-03-05 76 }
7a5cf791a747640 Al Viro 2018-03-05 77
:::::: The code at line 59 was first introduced by commit
:::::: b0cfcdd9b9672ea90642f33d6c0dd8516553adf2 d_path: make 'prepend()' fill up the buffer exactly on overflow
:::::: TO: Linus Torvalds <torvalds@linux-foundation.org>
:::::: CC: Linus Torvalds <torvalds@linux-foundation.org>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 35352 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
* [driver-core:debugfs_cleanup 1/2] fs/d_path.c:59 prepend() warn: unsigned 'p->len' is never less than zero.
@ 2021-09-30 9:46 ` Dan Carpenter
0 siblings, 0 replies; 2+ messages in thread
From: Dan Carpenter @ 2021-09-30 9:46 UTC (permalink / raw)
To: Greg Kroah-Hartman; +Cc: devel, kbuild-all, linux-kernel
tree: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-core.git debugfs_cleanup
head: c4535d1b074f3fdd9476e83526d4e9b53f41a7b5
commit: 473082c5bbad92c5909ccf75fb28df699b94de82 [1/2] fs: make d_path-like functions all have unsigned size
config: i386-randconfig-m021-20210929 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
smatch warnings:
fs/d_path.c:59 prepend() warn: unsigned 'p->len' is never less than zero.
vim +59 fs/d_path.c
b0cfcdd9b9672ea Linus Torvalds 2021-07-16 56 static bool prepend(struct prepend_buffer *p, const char *str, int namelen)
b0cfcdd9b9672ea Linus Torvalds 2021-07-16 57 {
b0cfcdd9b9672ea Linus Torvalds 2021-07-16 58 // Already overflowed?
b0cfcdd9b9672ea Linus Torvalds 2021-07-16 @59 if (p->len < 0)
This is impossible now.
b0cfcdd9b9672ea Linus Torvalds 2021-07-16 60 return false;
b0cfcdd9b9672ea Linus Torvalds 2021-07-16 61
b0cfcdd9b9672ea Linus Torvalds 2021-07-16 62 // Will overflow?
b0cfcdd9b9672ea Linus Torvalds 2021-07-16 63 if (p->len < namelen) {
b0cfcdd9b9672ea Linus Torvalds 2021-07-16 64 // Fill as much as possible from the end of the name
b0cfcdd9b9672ea Linus Torvalds 2021-07-16 65 str += namelen - p->len;
b0cfcdd9b9672ea Linus Torvalds 2021-07-16 66 p->buf -= p->len;
b0cfcdd9b9672ea Linus Torvalds 2021-07-16 67 prepend_copy(p->buf, str, p->len);
b0cfcdd9b9672ea Linus Torvalds 2021-07-16 68 p->len = -1;
b0cfcdd9b9672ea Linus Torvalds 2021-07-16 69 return false;
b0cfcdd9b9672ea Linus Torvalds 2021-07-16 70 }
b0cfcdd9b9672ea Linus Torvalds 2021-07-16 71
b0cfcdd9b9672ea Linus Torvalds 2021-07-16 72 // Fits fully
ad08ae586586ea9 Al Viro 2021-05-12 73 p->len -= namelen;
ad08ae586586ea9 Al Viro 2021-05-12 74 p->buf -= namelen;
b0cfcdd9b9672ea Linus Torvalds 2021-07-16 75 return prepend_copy(p->buf, str, namelen);
7a5cf791a747640 Al Viro 2018-03-05 76 }
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-09-30 9:47 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-30 4:17 [driver-core:debugfs_cleanup 1/2] fs/d_path.c:59 prepend() warn: unsigned 'p->len' is never less than zero kernel test robot
2021-09-30 9:46 ` Dan Carpenter
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.