All of lore.kernel.org
 help / color / mirror / Atom feed
From: Shawn Guo <shawnguo@kernel.org>
To: Martin Kepplinger <martin.kepplinger@puri.sm>
Cc: robh@kernel.org, kernel@pengutronix.de, festevam@gmail.com,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, phone-devel@vger.kernel.org,
	kernel@puri.sm, "Guido Günther" <agx@sigxcpu.org>
Subject: Re: [PATCH v1 3/6] arm64: dts: imx8mq-librem5: wire up the wifi regulator
Date: Mon, 4 Oct 2021 20:00:57 +0800	[thread overview]
Message-ID: <20211004120054.GG15650@dragon> (raw)
In-Reply-To: <20210913135706.309685-4-martin.kepplinger@puri.sm>

On Mon, Sep 13, 2021 at 03:57:03PM +0200, Martin Kepplinger wrote:
> From: Guido Günther <agx@sigxcpu.org>
> 
> Connect the wifi power regulator to the corresponding GPIO.
> 
> Signed-off-by: Guido Günther <agx@sigxcpu.org>
> Signed-off-by: Martin Kepplinger <martin.kepplinger@puri.sm>
> ---
>  arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi | 13 +++++++++++++
>  1 file changed, 13 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi b/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi
> index ba26c6ee98a0..b5562c8f9a3c 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi
> @@ -138,9 +138,15 @@ reg_vsys_3v4: regulator-vsys-3v4 {
>  
>  	reg_wifi_3v3: regulator-wifi-3v3 {
>  		compatible = "regulator-fixed";
> +		pinctrl-names = "default";
> +		pinctrl-0 = <&pinctrl_wifi_pwr>;
>  		regulator-name = "3V3_WIFI";
>  		regulator-min-microvolt = <3300000>;
>  		regulator-max-microvolt = <3300000>;
> +		gpio = <&gpio3 10 GPIO_ACTIVE_HIGH>;
> +		enable-active-high;
> +		vin-supply = <&reg_vdd_3v3>;
> +		regulator-always-on;

Any reason you need to have this always-on?

Shawn

>  	};
>  
>  	sound {
> @@ -638,6 +644,13 @@ MX8MQ_IOMUXC_SD2_RESET_B_USDHC2_RESET_B 0xc1
>  		>;
>  	};
>  
> +	pinctrl_wifi_pwr: wifipwrgrp {
> +		fsl,pins = <
> +			/* WIFI3V3_EN */
> +			MX8MQ_IOMUXC_NAND_DATA04_GPIO3_IO10	0x83
> +		>;
> +	};
> +
>  	pinctrl_wdog: wdoggrp {
>  		fsl,pins = <
>  			/* nWDOG */
> -- 
> 2.30.2
> 

WARNING: multiple messages have this Message-ID (diff)
From: Shawn Guo <shawnguo@kernel.org>
To: Martin Kepplinger <martin.kepplinger@puri.sm>
Cc: robh@kernel.org, kernel@pengutronix.de, festevam@gmail.com,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, phone-devel@vger.kernel.org,
	kernel@puri.sm, "Guido Günther" <agx@sigxcpu.org>
Subject: Re: [PATCH v1 3/6] arm64: dts: imx8mq-librem5: wire up the wifi regulator
Date: Mon, 4 Oct 2021 20:00:57 +0800	[thread overview]
Message-ID: <20211004120054.GG15650@dragon> (raw)
In-Reply-To: <20210913135706.309685-4-martin.kepplinger@puri.sm>

On Mon, Sep 13, 2021 at 03:57:03PM +0200, Martin Kepplinger wrote:
> From: Guido Günther <agx@sigxcpu.org>
> 
> Connect the wifi power regulator to the corresponding GPIO.
> 
> Signed-off-by: Guido Günther <agx@sigxcpu.org>
> Signed-off-by: Martin Kepplinger <martin.kepplinger@puri.sm>
> ---
>  arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi | 13 +++++++++++++
>  1 file changed, 13 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi b/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi
> index ba26c6ee98a0..b5562c8f9a3c 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi
> @@ -138,9 +138,15 @@ reg_vsys_3v4: regulator-vsys-3v4 {
>  
>  	reg_wifi_3v3: regulator-wifi-3v3 {
>  		compatible = "regulator-fixed";
> +		pinctrl-names = "default";
> +		pinctrl-0 = <&pinctrl_wifi_pwr>;
>  		regulator-name = "3V3_WIFI";
>  		regulator-min-microvolt = <3300000>;
>  		regulator-max-microvolt = <3300000>;
> +		gpio = <&gpio3 10 GPIO_ACTIVE_HIGH>;
> +		enable-active-high;
> +		vin-supply = <&reg_vdd_3v3>;
> +		regulator-always-on;

Any reason you need to have this always-on?

Shawn

>  	};
>  
>  	sound {
> @@ -638,6 +644,13 @@ MX8MQ_IOMUXC_SD2_RESET_B_USDHC2_RESET_B 0xc1
>  		>;
>  	};
>  
> +	pinctrl_wifi_pwr: wifipwrgrp {
> +		fsl,pins = <
> +			/* WIFI3V3_EN */
> +			MX8MQ_IOMUXC_NAND_DATA04_GPIO3_IO10	0x83
> +		>;
> +	};
> +
>  	pinctrl_wdog: wdoggrp {
>  		fsl,pins = <
>  			/* nWDOG */
> -- 
> 2.30.2
> 

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2021-10-04 12:01 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-13 13:57 [PATCH v1 0/6] arm64: dts: imx8mq-librem5: wifi updates and minor fixes Martin Kepplinger
2021-09-13 13:57 ` Martin Kepplinger
2021-09-13 13:57 ` [PATCH v1 1/6] arm64: dts: imx8mq-librem5: add reset gpio to mantix panel description Martin Kepplinger
2021-09-13 13:57   ` Martin Kepplinger
2021-09-13 13:57 ` [PATCH v1 2/6] arm64: dts: imx8mq-librem5: Fix led_r and led_g pinctrl assignments Martin Kepplinger
2021-09-13 13:57   ` Martin Kepplinger
2021-09-13 13:57 ` [PATCH v1 3/6] arm64: dts: imx8mq-librem5: wire up the wifi regulator Martin Kepplinger
2021-09-13 13:57   ` Martin Kepplinger
2021-10-04 12:00   ` Shawn Guo [this message]
2021-10-04 12:00     ` Shawn Guo
2021-10-05 12:12     ` Guido Günther
2021-10-05 12:12       ` Guido Günther
2021-09-13 13:57 ` [PATCH v1 4/6] arm64: dts: imx8mq-librem5: delay the startup of the SDIO Martin Kepplinger
2021-09-13 13:57   ` Martin Kepplinger
2021-09-13 13:57 ` [PATCH v1 5/6] arm64: dts: imx8mq-librem5: add power sequencing for M.2 cards Martin Kepplinger
2021-09-13 13:57   ` Martin Kepplinger
2021-09-13 13:57 ` [PATCH v1 6/6] arm64: dts: imx8mq-librem5: Limit the max sdio frequency Martin Kepplinger
2021-09-13 13:57   ` Martin Kepplinger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211004120054.GG15650@dragon \
    --to=shawnguo@kernel.org \
    --cc=agx@sigxcpu.org \
    --cc=devicetree@vger.kernel.org \
    --cc=festevam@gmail.com \
    --cc=kernel@pengutronix.de \
    --cc=kernel@puri.sm \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=martin.kepplinger@puri.sm \
    --cc=phone-devel@vger.kernel.org \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.