[Buildroot] [PATCH 1/1] package/libuev: bump version to v2.4.0

[Buildroot] [PATCH 1/1] package/libuev: bump version to v2.4.0

[Joachim Wiberg]

This update is critical for linking against GLIBC v2.34, due to the
changes related to 64-bit time_t on 32-bit systems.  See ChangeLog
for details:

  https://github.com/troglobit/libuev/releases/tag/v2.4.0

Signed-off-by: Joachim Wiberg <troglobit@gmail.com>
---
 package/libuev/libuev.hash | 4 ++--
 package/libuev/libuev.mk   | 2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/package/libuev/libuev.hash b/package/libuev/libuev.hash
index d52d210d10..e5c9660a02 100644
--- a/package/libuev/libuev.hash
+++ b/package/libuev/libuev.hash
@@ -1,4 +1,4 @@
-# From https://github.com/troglobit/libuev/releases/download/v2.3.2/libuev-2.3.2.tar.xz.sha256
-sha256  af31ffe1058a2ff6c56fee26ec8749688704d297189b6a898380a601efefbec9  libuev-2.3.2.tar.xz
+# From https://github.com/troglobit/libuev/releases/download/v2.4.0/libuev-2.4.0.tar.xz.sha256
+sha256  31f1aa4f492ba4f6a5dd6b19968ae6a732968dc05cae6575930560b6cee1f5ef  libuev-2.4.0.tar.xz
 # License files
 sha256  694a734d9c1b46ae203314ed1c744a1acebd4fe5fc964b761703772546f0d3ab  LICENSE
diff --git a/package/libuev/libuev.mk b/package/libuev/libuev.mk
index 8a6759a2d7..a32381dcc5 100644
--- a/package/libuev/libuev.mk
+++ b/package/libuev/libuev.mk
@@ -4,7 +4,7 @@
 #
 ################################################################################
 
-LIBUEV_VERSION = 2.3.2
+LIBUEV_VERSION = 2.4.0
 LIBUEV_SOURCE = libuev-$(LIBUEV_VERSION).tar.xz
 LIBUEV_SITE = https://github.com/troglobit/libuev/releases/download/v$(LIBUEV_VERSION)
 LIBUEV_LICENSE = MIT
-- 
2.25.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] package/libuev: bump version to v2.4.0

[Peter Seiderer]

Hello Joachim,

On Sat,  9 Oct 2021 11:41:44 +0200, Joachim Wiberg <troglobit@gmail.com> wrote:

> This update is critical for linking against GLIBC v2.34, due to the
> changes related to 64-bit time_t on 32-bit systems.  See ChangeLog
> for details:
>
>   https://github.com/troglobit/libuev/releases/tag/v2.4.0
>
> Signed-off-by: Joachim Wiberg <troglobit@gmail.com>

Thanks for the patch, version bump already suggested, see [1], but
preferring your version because of the additional glibc-2.34 info ;-)

Feel free to (additional) adopt the package ;-)

Reviewed-by: Peter Seiderer <ps.report@gmx.net>

Regards,
Peter

[1] https://patchwork.ozlabs.org/project/buildroot/patch/20211005203156.23462-1-ps.report@gmx.net/

> ---
>  package/libuev/libuev.hash | 4 ++--
>  package/libuev/libuev.mk   | 2 +-
>  2 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/package/libuev/libuev.hash b/package/libuev/libuev.hash
> index d52d210d10..e5c9660a02 100644
> --- a/package/libuev/libuev.hash
> +++ b/package/libuev/libuev.hash
> @@ -1,4 +1,4 @@
> -# From https://github.com/troglobit/libuev/releases/download/v2.3.2/libuev-2.3.2.tar.xz.sha256
> -sha256  af31ffe1058a2ff6c56fee26ec8749688704d297189b6a898380a601efefbec9  libuev-2.3.2.tar.xz
> +# From https://github.com/troglobit/libuev/releases/download/v2.4.0/libuev-2.4.0.tar.xz.sha256
> +sha256  31f1aa4f492ba4f6a5dd6b19968ae6a732968dc05cae6575930560b6cee1f5ef  libuev-2.4.0.tar.xz
>  # License files
>  sha256  694a734d9c1b46ae203314ed1c744a1acebd4fe5fc964b761703772546f0d3ab  LICENSE
> diff --git a/package/libuev/libuev.mk b/package/libuev/libuev.mk
> index 8a6759a2d7..a32381dcc5 100644
> --- a/package/libuev/libuev.mk
> +++ b/package/libuev/libuev.mk
> @@ -4,7 +4,7 @@
>  #
>  ################################################################################
>
> -LIBUEV_VERSION = 2.3.2
> +LIBUEV_VERSION = 2.4.0
>  LIBUEV_SOURCE = libuev-$(LIBUEV_VERSION).tar.xz
>  LIBUEV_SITE = https://github.com/troglobit/libuev/releases/download/v$(LIBUEV_VERSION)
>  LIBUEV_LICENSE = MIT

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] package/libuev: bump version to v2.4.0

[Joachim Wiberg]

Hi Peter,

On 10/9/21 12:30 PM, Peter Seiderer wrote:
> Hello Joachim,
> On Sat,  9 Oct 2021 11:41:44 +0200, Joachim Wiberg <troglobit@gmail.com> wrote:
>> This update is critical for linking against GLIBC v2.34, due to the
>> changes related to 64-bit time_t on 32-bit systems.
> Thanks for the patch, version bump already suggested, see [1], but
> preferring your version because of the additional glibc-2.34 info ;-)

Ouch, sorry about that, totally overlooked checking the mailing list 
first!  Thank you, yeah I thought it worth mentioning since that
transition will be a bitch for a lot of packages.

> Feel free to (additional) adopt the package ;-)

OK, will do! :-)

Best regards
  /Joachim
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] package/libuev: bump version to v2.4.0

[Thomas Petazzoni]

On Sat,  9 Oct 2021 11:41:44 +0200
Joachim Wiberg <troglobit@gmail.com> wrote:

> This update is critical for linking against GLIBC v2.34, due to the
> changes related to 64-bit time_t on 32-bit systems.  See ChangeLog
> for details:
> 
>   https://github.com/troglobit/libuev/releases/tag/v2.4.0
> 
> Signed-off-by: Joachim Wiberg <troglobit@gmail.com>
> ---
>  package/libuev/libuev.hash | 4 ++--
>  package/libuev/libuev.mk   | 2 +-
>  2 files changed, 3 insertions(+), 3 deletions(-)

Applied to master, thanks.

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] package/libuev: bump version to v2.4.0

[Peter Korsgaard]

>>>>> "Joachim" == Joachim Wiberg <troglobit@gmail.com> writes:

 > This update is critical for linking against GLIBC v2.34, due to the
 > changes related to 64-bit time_t on 32-bit systems.  See ChangeLog
 > for details:

 >   https://github.com/troglobit/libuev/releases/tag/v2.4.0

 > Signed-off-by: Joachim Wiberg <troglobit@gmail.com>

This presumably also affect musl, which moved to 64 bit time_t back in
1.2.0. I don't see any autobuilder issues related to older libuev
versions (or uredir, as it probably only triggers when a dependency
tries to link with it)?

What about uclibc-ng, which still uses 32bit time_t?

-- 
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] package/libuev: bump version to v2.4.0

[Joachim Wiberg]

[-- Attachment #1.1.1: Type: text/plain, Size: 1459 bytes --]

Hi Peter!

On 10/10/21 10:29 AM, Peter Korsgaard wrote:
>>>>>> "Joachim" == Joachim Wiberg <troglobit@gmail.com> writes:
>  > This update is critical for linking against GLIBC v2.34, due to the
>  > changes related to 64-bit time_t on 32-bit systems.  See ChangeLog
>  > for details:
>  >   https://github.com/troglobit/libuev/releases/tag/v2.4.0
>  > Signed-off-by: Joachim Wiberg <troglobit@gmail.com>
> This presumably also affect musl, which moved to 64 bit time_t back in
> 1.2.0. I don't see any autobuilder issues related to older libuev
> versions (or uredir, as it probably only triggers when a dependency
> tries to link with it)?

The change is only related to GLIBC, which from v2.34 requires an
additional build flag to enable 64-bit time_t.  The latest libuev
release adds the following to the .pc file (and it's test suite):

    -D_TIME_BITS=64 -D_FILE_OFFSET_BITS=64

I don't think musl needs anything other than recompiling from source,
which we do already.  At least from what I can see from this page:

    https://musl.libc.org/time64.html

> What about uclibc-ng, which still uses 32bit time_t?

Absolute time in a future after 2038 on systems with 32-bit time_t is
pretty much undefined.  Fortunately, most common use-cases with libuev
involves periodic or oneshot (monotonic) timers that are relative to
their individual start, which as far as I know are not affected.

Best regards
 /Joachim





[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 495 bytes --]

[-- Attachment #2: Type: text/plain, Size: 150 bytes --]

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] package/libuev: bump version to v2.4.0

[Peter Korsgaard]

>>>>> "Joachim" == Joachim Wiberg <troglobit@gmail.com> writes:

Hi,

 >> This presumably also affect musl, which moved to 64 bit time_t back in
 >> 1.2.0. I don't see any autobuilder issues related to older libuev
 >> versions (or uredir, as it probably only triggers when a dependency
 >> tries to link with it)?

 > The change is only related to GLIBC, which from v2.34 requires an
 > additional build flag to enable 64-bit time_t.  The latest libuev
 > release adds the following to the .pc file (and it's test suite):

 >     -D_TIME_BITS=64 -D_FILE_OFFSET_BITS=64

Ahh ok. We already globally set _FILE_OFFSET_BITS in
package/Makefile.in.

 > I don't think musl needs anything other than recompiling from source,
 > which we do already.  At least from what I can see from this page:

 >     https://musl.libc.org/time64.html

Correct.

 >> What about uclibc-ng, which still uses 32bit time_t?

 > Absolute time in a future after 2038 on systems with 32-bit time_t is
 > pretty much undefined.  Fortunately, most common use-cases with libuev
 > involves periodic or oneshot (monotonic) timers that are relative to
 > their individual start, which as far as I know are not affected.

Yes, indeed.

Thanks!

-- 
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot