From: Jason Wang <jasowang@redhat.com>
To: mst@redhat.com, virtualization@lists.linux-foundation.org
Cc: linux-kernel@vger.kernel.org, f.hetzelt@tu-berlin.de,
david.kaplan@amd.com, konrad.wilk@oracle.com,
Jason Wang <jasowang@redhat.com>
Subject: [PATCH V5 4/4] virtio-scsi: don't let virtio core to validate used buffer length
Date: Wed, 27 Oct 2021 10:21:07 +0800 [thread overview]
Message-ID: <20211027022107.14357-5-jasowang@redhat.com> (raw)
In-Reply-To: <20211027022107.14357-1-jasowang@redhat.com>
We never tries to use used length, so the patch prevents the virtio
core from validating used length.
Signed-off-by: Jason Wang <jasowang@redhat.com>
---
drivers/scsi/virtio_scsi.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/scsi/virtio_scsi.c b/drivers/scsi/virtio_scsi.c
index 07d0250f17c3..03b09ecea42d 100644
--- a/drivers/scsi/virtio_scsi.c
+++ b/drivers/scsi/virtio_scsi.c
@@ -977,6 +977,7 @@ static unsigned int features[] = {
static struct virtio_driver virtio_scsi_driver = {
.feature_table = features,
.feature_table_size = ARRAY_SIZE(features),
+ .suppress_used_validation = true,
.driver.name = KBUILD_MODNAME,
.driver.owner = THIS_MODULE,
.id_table = id_table,
--
2.25.1
WARNING: multiple messages have this Message-ID (diff)
From: Jason Wang <jasowang@redhat.com>
To: mst@redhat.com, virtualization@lists.linux-foundation.org
Cc: f.hetzelt@tu-berlin.de, linux-kernel@vger.kernel.org,
david.kaplan@amd.com, konrad.wilk@oracle.com
Subject: [PATCH V5 4/4] virtio-scsi: don't let virtio core to validate used buffer length
Date: Wed, 27 Oct 2021 10:21:07 +0800 [thread overview]
Message-ID: <20211027022107.14357-5-jasowang@redhat.com> (raw)
In-Reply-To: <20211027022107.14357-1-jasowang@redhat.com>
We never tries to use used length, so the patch prevents the virtio
core from validating used length.
Signed-off-by: Jason Wang <jasowang@redhat.com>
---
drivers/scsi/virtio_scsi.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/scsi/virtio_scsi.c b/drivers/scsi/virtio_scsi.c
index 07d0250f17c3..03b09ecea42d 100644
--- a/drivers/scsi/virtio_scsi.c
+++ b/drivers/scsi/virtio_scsi.c
@@ -977,6 +977,7 @@ static unsigned int features[] = {
static struct virtio_driver virtio_scsi_driver = {
.feature_table = features,
.feature_table_size = ARRAY_SIZE(features),
+ .suppress_used_validation = true,
.driver.name = KBUILD_MODNAME,
.driver.owner = THIS_MODULE,
.id_table = id_table,
--
2.25.1
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
next prev parent reply other threads:[~2021-10-27 2:21 UTC|newest]
Thread overview: 65+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-27 2:21 [PATCH V5 0/4] Validate used buffer length Jason Wang
2021-10-27 2:21 ` Jason Wang
2021-10-27 2:21 ` [PATCH V5 1/4] virtio_ring: validate " Jason Wang
2021-10-27 2:21 ` Jason Wang
2021-11-02 3:18 ` Xuan Zhuo
2021-11-02 3:54 ` Jason Wang
2021-11-02 3:54 ` Jason Wang
2021-11-19 15:09 ` Halil Pasic
2021-11-19 15:09 ` Halil Pasic
2021-11-22 3:51 ` Jason Wang
2021-11-22 3:51 ` Jason Wang
2021-11-22 5:35 ` Halil Pasic
2021-11-22 5:35 ` Halil Pasic
2021-11-22 5:49 ` Halil Pasic
2021-11-22 5:49 ` Halil Pasic
2021-11-22 6:25 ` Jason Wang
2021-11-22 6:25 ` Jason Wang
2021-11-22 7:55 ` Stefano Garzarella
2021-11-22 7:55 ` Stefano Garzarella
2021-11-22 11:08 ` Stefano Garzarella
2021-11-22 11:08 ` Stefano Garzarella
2021-11-22 14:24 ` Halil Pasic
2021-11-22 14:24 ` Halil Pasic
2021-11-22 16:23 ` Stefano Garzarella
2021-11-22 16:23 ` Stefano Garzarella
2021-11-22 13:50 ` Halil Pasic
2021-11-22 13:50 ` Halil Pasic
2021-11-23 2:30 ` Jason Wang
2021-11-23 2:30 ` Jason Wang
2021-11-23 12:17 ` Michael S. Tsirkin
2021-11-23 12:17 ` Michael S. Tsirkin
2021-11-23 12:43 ` Halil Pasic
2021-11-23 12:43 ` Halil Pasic
2021-11-22 20:23 ` Halil Pasic
2021-11-22 20:23 ` Halil Pasic
2021-11-23 2:25 ` Jason Wang
2021-11-23 2:25 ` Jason Wang
2021-11-23 11:05 ` Michael S. Tsirkin
2021-11-23 11:05 ` Michael S. Tsirkin
2021-11-24 1:30 ` Michael Ellerman
2021-11-24 1:30 ` Michael Ellerman
2021-11-24 2:26 ` Jason Wang
2021-11-24 2:26 ` Jason Wang
2021-11-24 2:33 ` Jason Wang
2021-11-24 2:33 ` Jason Wang
2021-11-24 7:22 ` Michael S. Tsirkin
2021-11-24 7:22 ` Michael S. Tsirkin
2021-11-24 7:59 ` Jason Wang
2021-11-24 7:59 ` Jason Wang
2021-11-24 8:24 ` Michael S. Tsirkin
2021-11-24 8:24 ` Michael S. Tsirkin
2021-11-24 8:28 ` Jason Wang
2021-11-24 8:28 ` Jason Wang
2021-11-24 11:33 ` Halil Pasic
2021-11-24 11:33 ` Halil Pasic
2021-11-25 2:27 ` Jason Wang
2021-11-25 2:27 ` Jason Wang
2021-11-22 7:42 ` Stefano Garzarella
2021-11-22 7:42 ` Stefano Garzarella
2021-10-27 2:21 ` [PATCH V5 2/4] virtio-net: don't let virtio core to validate used length Jason Wang
2021-10-27 2:21 ` Jason Wang
2021-10-27 2:21 ` [PATCH V5 3/4] virtio-blk: " Jason Wang
2021-10-27 2:21 ` Jason Wang
2021-10-27 2:21 ` Jason Wang [this message]
2021-10-27 2:21 ` [PATCH V5 4/4] virtio-scsi: don't let virtio core to validate used buffer length Jason Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211027022107.14357-5-jasowang@redhat.com \
--to=jasowang@redhat.com \
--cc=david.kaplan@amd.com \
--cc=f.hetzelt@tu-berlin.de \
--cc=konrad.wilk@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.