From: kernel test robot <lkp@intel.com>
To: Marc Zyngier <maz@kernel.org>
Cc: llvm@lists.linux.dev, kbuild-all@lists.01.org,
linux-arm-kernel@lists.infradead.org,
Oliver Upton <oupton@google.com>,
Mark Rutland <mark.rutland@arm.com>
Subject: [arm-platforms:timers/tval-ectomy 2/17] drivers/clocksource/arm_arch_timer.c:156:3: warning: variable 'val' is used uninitialized whenever switch default is taken
Date: Sun, 7 Nov 2021 10:10:03 +0800 [thread overview]
Message-ID: <202111071053.ynszyL5B-lkp@intel.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 4839 bytes --]
Hi Marc,
FYI, the error/warning still remains.
tree: https://git.kernel.org/pub/scm/linux/kernel/git/maz/arm-platforms.git timers/tval-ectomy
head: c171b519551d424290bb74a3ddbd9068b30c0396
commit: 9c6e4aa680ebd5ad816fc8f97858ec6057362c9e [2/17] clocksource/arm_arch_timer: Drop CNT*_TVAL read accessors
config: arm-randconfig-c002-20210929 (attached as .config)
compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project dc6e8dfdfe7efecfda318d43a06fae18b40eb498)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install arm cross compiling tool for clang build
# apt-get install binutils-arm-linux-gnueabi
# https://git.kernel.org/pub/scm/linux/kernel/git/maz/arm-platforms.git/commit/?id=9c6e4aa680ebd5ad816fc8f97858ec6057362c9e
git remote add arm-platforms https://git.kernel.org/pub/scm/linux/kernel/git/maz/arm-platforms.git
git fetch --no-tags arm-platforms timers/tval-ectomy
git checkout 9c6e4aa680ebd5ad816fc8f97858ec6057362c9e
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 ARCH=arm
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All warnings (new ones prefixed by >>):
>> drivers/clocksource/arm_arch_timer.c:156:3: warning: variable 'val' is used uninitialized whenever switch default is taken [-Wsometimes-uninitialized]
default:
^~~~~~~
drivers/clocksource/arm_arch_timer.c:163:9: note: uninitialized use occurs here
return val;
^~~
drivers/clocksource/arm_arch_timer.c:147:3: warning: variable 'val' is used uninitialized whenever switch default is taken [-Wsometimes-uninitialized]
default:
^~~~~~~
drivers/clocksource/arm_arch_timer.c:163:9: note: uninitialized use occurs here
return val;
^~~
drivers/clocksource/arm_arch_timer.c:139:9: note: initialize the variable 'val' to silence this warning
u32 val;
^
= 0
2 warnings generated.
vim +/val +156 drivers/clocksource/arm_arch_timer.c
f4e00a1a55c7f9 Marc Zyngier 2017-01-20 134
f4e00a1a55c7f9 Marc Zyngier 2017-01-20 135 static __always_inline
f4e00a1a55c7f9 Marc Zyngier 2017-01-20 136 u32 arch_timer_reg_read(int access, enum arch_timer_reg reg,
f4e00a1a55c7f9 Marc Zyngier 2017-01-20 137 struct clock_event_device *clk)
f4e00a1a55c7f9 Marc Zyngier 2017-01-20 138 {
f4e00a1a55c7f9 Marc Zyngier 2017-01-20 139 u32 val;
f4e00a1a55c7f9 Marc Zyngier 2017-01-20 140
f4e00a1a55c7f9 Marc Zyngier 2017-01-20 141 if (access == ARCH_TIMER_MEM_PHYS_ACCESS) {
f4e00a1a55c7f9 Marc Zyngier 2017-01-20 142 struct arch_timer *timer = to_arch_timer(clk);
f4e00a1a55c7f9 Marc Zyngier 2017-01-20 143 switch (reg) {
f4e00a1a55c7f9 Marc Zyngier 2017-01-20 144 case ARCH_TIMER_REG_CTRL:
f4e00a1a55c7f9 Marc Zyngier 2017-01-20 145 val = readl_relaxed(timer->base + CNTP_CTL);
f4e00a1a55c7f9 Marc Zyngier 2017-01-20 146 break;
0bc2c9327c236c Marc Zyngier 2021-09-20 147 default:
0bc2c9327c236c Marc Zyngier 2021-09-20 148 BUILD_BUG();
f4e00a1a55c7f9 Marc Zyngier 2017-01-20 149 }
f4e00a1a55c7f9 Marc Zyngier 2017-01-20 150 } else if (access == ARCH_TIMER_MEM_VIRT_ACCESS) {
f4e00a1a55c7f9 Marc Zyngier 2017-01-20 151 struct arch_timer *timer = to_arch_timer(clk);
f4e00a1a55c7f9 Marc Zyngier 2017-01-20 152 switch (reg) {
f4e00a1a55c7f9 Marc Zyngier 2017-01-20 153 case ARCH_TIMER_REG_CTRL:
f4e00a1a55c7f9 Marc Zyngier 2017-01-20 154 val = readl_relaxed(timer->base + CNTV_CTL);
f4e00a1a55c7f9 Marc Zyngier 2017-01-20 155 break;
0bc2c9327c236c Marc Zyngier 2021-09-20 @156 default:
0bc2c9327c236c Marc Zyngier 2021-09-20 157 BUILD_BUG();
f4e00a1a55c7f9 Marc Zyngier 2017-01-20 158 }
f4e00a1a55c7f9 Marc Zyngier 2017-01-20 159 } else {
f4e00a1a55c7f9 Marc Zyngier 2017-01-20 160 val = arch_timer_reg_read_cp15(access, reg);
f4e00a1a55c7f9 Marc Zyngier 2017-01-20 161 }
f4e00a1a55c7f9 Marc Zyngier 2017-01-20 162
f4e00a1a55c7f9 Marc Zyngier 2017-01-20 163 return val;
f4e00a1a55c7f9 Marc Zyngier 2017-01-20 164 }
f4e00a1a55c7f9 Marc Zyngier 2017-01-20 165
:::::: The code at line 156 was first introduced by commit
:::::: 0bc2c9327c236c28cdb2784d11ca349ef3b1ca0a clocksource/arm_arch_timer: Add build-time guards for unhandled register accesses
:::::: TO: Marc Zyngier <maz@kernel.org>
:::::: CC: Marc Zyngier <maz@kernel.org>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 38002 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: kernel test robot <lkp@intel.com>
To: Marc Zyngier <maz@kernel.org>
Cc: llvm@lists.linux.dev, kbuild-all@lists.01.org,
linux-arm-kernel@lists.infradead.org,
Oliver Upton <oupton@google.com>,
Mark Rutland <mark.rutland@arm.com>
Subject: [arm-platforms:timers/tval-ectomy 2/17] drivers/clocksource/arm_arch_timer.c:156:3: warning: variable 'val' is used uninitialized whenever switch default is taken
Date: Sun, 7 Nov 2021 10:10:03 +0800 [thread overview]
Message-ID: <202111071053.ynszyL5B-lkp@intel.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 4839 bytes --]
Hi Marc,
FYI, the error/warning still remains.
tree: https://git.kernel.org/pub/scm/linux/kernel/git/maz/arm-platforms.git timers/tval-ectomy
head: c171b519551d424290bb74a3ddbd9068b30c0396
commit: 9c6e4aa680ebd5ad816fc8f97858ec6057362c9e [2/17] clocksource/arm_arch_timer: Drop CNT*_TVAL read accessors
config: arm-randconfig-c002-20210929 (attached as .config)
compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project dc6e8dfdfe7efecfda318d43a06fae18b40eb498)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install arm cross compiling tool for clang build
# apt-get install binutils-arm-linux-gnueabi
# https://git.kernel.org/pub/scm/linux/kernel/git/maz/arm-platforms.git/commit/?id=9c6e4aa680ebd5ad816fc8f97858ec6057362c9e
git remote add arm-platforms https://git.kernel.org/pub/scm/linux/kernel/git/maz/arm-platforms.git
git fetch --no-tags arm-platforms timers/tval-ectomy
git checkout 9c6e4aa680ebd5ad816fc8f97858ec6057362c9e
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 ARCH=arm
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All warnings (new ones prefixed by >>):
>> drivers/clocksource/arm_arch_timer.c:156:3: warning: variable 'val' is used uninitialized whenever switch default is taken [-Wsometimes-uninitialized]
default:
^~~~~~~
drivers/clocksource/arm_arch_timer.c:163:9: note: uninitialized use occurs here
return val;
^~~
drivers/clocksource/arm_arch_timer.c:147:3: warning: variable 'val' is used uninitialized whenever switch default is taken [-Wsometimes-uninitialized]
default:
^~~~~~~
drivers/clocksource/arm_arch_timer.c:163:9: note: uninitialized use occurs here
return val;
^~~
drivers/clocksource/arm_arch_timer.c:139:9: note: initialize the variable 'val' to silence this warning
u32 val;
^
= 0
2 warnings generated.
vim +/val +156 drivers/clocksource/arm_arch_timer.c
f4e00a1a55c7f9 Marc Zyngier 2017-01-20 134
f4e00a1a55c7f9 Marc Zyngier 2017-01-20 135 static __always_inline
f4e00a1a55c7f9 Marc Zyngier 2017-01-20 136 u32 arch_timer_reg_read(int access, enum arch_timer_reg reg,
f4e00a1a55c7f9 Marc Zyngier 2017-01-20 137 struct clock_event_device *clk)
f4e00a1a55c7f9 Marc Zyngier 2017-01-20 138 {
f4e00a1a55c7f9 Marc Zyngier 2017-01-20 139 u32 val;
f4e00a1a55c7f9 Marc Zyngier 2017-01-20 140
f4e00a1a55c7f9 Marc Zyngier 2017-01-20 141 if (access == ARCH_TIMER_MEM_PHYS_ACCESS) {
f4e00a1a55c7f9 Marc Zyngier 2017-01-20 142 struct arch_timer *timer = to_arch_timer(clk);
f4e00a1a55c7f9 Marc Zyngier 2017-01-20 143 switch (reg) {
f4e00a1a55c7f9 Marc Zyngier 2017-01-20 144 case ARCH_TIMER_REG_CTRL:
f4e00a1a55c7f9 Marc Zyngier 2017-01-20 145 val = readl_relaxed(timer->base + CNTP_CTL);
f4e00a1a55c7f9 Marc Zyngier 2017-01-20 146 break;
0bc2c9327c236c Marc Zyngier 2021-09-20 147 default:
0bc2c9327c236c Marc Zyngier 2021-09-20 148 BUILD_BUG();
f4e00a1a55c7f9 Marc Zyngier 2017-01-20 149 }
f4e00a1a55c7f9 Marc Zyngier 2017-01-20 150 } else if (access == ARCH_TIMER_MEM_VIRT_ACCESS) {
f4e00a1a55c7f9 Marc Zyngier 2017-01-20 151 struct arch_timer *timer = to_arch_timer(clk);
f4e00a1a55c7f9 Marc Zyngier 2017-01-20 152 switch (reg) {
f4e00a1a55c7f9 Marc Zyngier 2017-01-20 153 case ARCH_TIMER_REG_CTRL:
f4e00a1a55c7f9 Marc Zyngier 2017-01-20 154 val = readl_relaxed(timer->base + CNTV_CTL);
f4e00a1a55c7f9 Marc Zyngier 2017-01-20 155 break;
0bc2c9327c236c Marc Zyngier 2021-09-20 @156 default:
0bc2c9327c236c Marc Zyngier 2021-09-20 157 BUILD_BUG();
f4e00a1a55c7f9 Marc Zyngier 2017-01-20 158 }
f4e00a1a55c7f9 Marc Zyngier 2017-01-20 159 } else {
f4e00a1a55c7f9 Marc Zyngier 2017-01-20 160 val = arch_timer_reg_read_cp15(access, reg);
f4e00a1a55c7f9 Marc Zyngier 2017-01-20 161 }
f4e00a1a55c7f9 Marc Zyngier 2017-01-20 162
f4e00a1a55c7f9 Marc Zyngier 2017-01-20 163 return val;
f4e00a1a55c7f9 Marc Zyngier 2017-01-20 164 }
f4e00a1a55c7f9 Marc Zyngier 2017-01-20 165
:::::: The code at line 156 was first introduced by commit
:::::: 0bc2c9327c236c28cdb2784d11ca349ef3b1ca0a clocksource/arm_arch_timer: Add build-time guards for unhandled register accesses
:::::: TO: Marc Zyngier <maz@kernel.org>
:::::: CC: Marc Zyngier <maz@kernel.org>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 38002 bytes --]
[-- Attachment #3: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: kernel test robot <lkp@intel.com>
To: kbuild-all@lists.01.org
Subject: [arm-platforms:timers/tval-ectomy 2/17] drivers/clocksource/arm_arch_timer.c:156:3: warning: variable 'val' is used uninitialized whenever switch default is taken
Date: Sun, 07 Nov 2021 10:10:03 +0800 [thread overview]
Message-ID: <202111071053.ynszyL5B-lkp@intel.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 4930 bytes --]
Hi Marc,
FYI, the error/warning still remains.
tree: https://git.kernel.org/pub/scm/linux/kernel/git/maz/arm-platforms.git timers/tval-ectomy
head: c171b519551d424290bb74a3ddbd9068b30c0396
commit: 9c6e4aa680ebd5ad816fc8f97858ec6057362c9e [2/17] clocksource/arm_arch_timer: Drop CNT*_TVAL read accessors
config: arm-randconfig-c002-20210929 (attached as .config)
compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project dc6e8dfdfe7efecfda318d43a06fae18b40eb498)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install arm cross compiling tool for clang build
# apt-get install binutils-arm-linux-gnueabi
# https://git.kernel.org/pub/scm/linux/kernel/git/maz/arm-platforms.git/commit/?id=9c6e4aa680ebd5ad816fc8f97858ec6057362c9e
git remote add arm-platforms https://git.kernel.org/pub/scm/linux/kernel/git/maz/arm-platforms.git
git fetch --no-tags arm-platforms timers/tval-ectomy
git checkout 9c6e4aa680ebd5ad816fc8f97858ec6057362c9e
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 ARCH=arm
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All warnings (new ones prefixed by >>):
>> drivers/clocksource/arm_arch_timer.c:156:3: warning: variable 'val' is used uninitialized whenever switch default is taken [-Wsometimes-uninitialized]
default:
^~~~~~~
drivers/clocksource/arm_arch_timer.c:163:9: note: uninitialized use occurs here
return val;
^~~
drivers/clocksource/arm_arch_timer.c:147:3: warning: variable 'val' is used uninitialized whenever switch default is taken [-Wsometimes-uninitialized]
default:
^~~~~~~
drivers/clocksource/arm_arch_timer.c:163:9: note: uninitialized use occurs here
return val;
^~~
drivers/clocksource/arm_arch_timer.c:139:9: note: initialize the variable 'val' to silence this warning
u32 val;
^
= 0
2 warnings generated.
vim +/val +156 drivers/clocksource/arm_arch_timer.c
f4e00a1a55c7f9 Marc Zyngier 2017-01-20 134
f4e00a1a55c7f9 Marc Zyngier 2017-01-20 135 static __always_inline
f4e00a1a55c7f9 Marc Zyngier 2017-01-20 136 u32 arch_timer_reg_read(int access, enum arch_timer_reg reg,
f4e00a1a55c7f9 Marc Zyngier 2017-01-20 137 struct clock_event_device *clk)
f4e00a1a55c7f9 Marc Zyngier 2017-01-20 138 {
f4e00a1a55c7f9 Marc Zyngier 2017-01-20 139 u32 val;
f4e00a1a55c7f9 Marc Zyngier 2017-01-20 140
f4e00a1a55c7f9 Marc Zyngier 2017-01-20 141 if (access == ARCH_TIMER_MEM_PHYS_ACCESS) {
f4e00a1a55c7f9 Marc Zyngier 2017-01-20 142 struct arch_timer *timer = to_arch_timer(clk);
f4e00a1a55c7f9 Marc Zyngier 2017-01-20 143 switch (reg) {
f4e00a1a55c7f9 Marc Zyngier 2017-01-20 144 case ARCH_TIMER_REG_CTRL:
f4e00a1a55c7f9 Marc Zyngier 2017-01-20 145 val = readl_relaxed(timer->base + CNTP_CTL);
f4e00a1a55c7f9 Marc Zyngier 2017-01-20 146 break;
0bc2c9327c236c Marc Zyngier 2021-09-20 147 default:
0bc2c9327c236c Marc Zyngier 2021-09-20 148 BUILD_BUG();
f4e00a1a55c7f9 Marc Zyngier 2017-01-20 149 }
f4e00a1a55c7f9 Marc Zyngier 2017-01-20 150 } else if (access == ARCH_TIMER_MEM_VIRT_ACCESS) {
f4e00a1a55c7f9 Marc Zyngier 2017-01-20 151 struct arch_timer *timer = to_arch_timer(clk);
f4e00a1a55c7f9 Marc Zyngier 2017-01-20 152 switch (reg) {
f4e00a1a55c7f9 Marc Zyngier 2017-01-20 153 case ARCH_TIMER_REG_CTRL:
f4e00a1a55c7f9 Marc Zyngier 2017-01-20 154 val = readl_relaxed(timer->base + CNTV_CTL);
f4e00a1a55c7f9 Marc Zyngier 2017-01-20 155 break;
0bc2c9327c236c Marc Zyngier 2021-09-20 @156 default:
0bc2c9327c236c Marc Zyngier 2021-09-20 157 BUILD_BUG();
f4e00a1a55c7f9 Marc Zyngier 2017-01-20 158 }
f4e00a1a55c7f9 Marc Zyngier 2017-01-20 159 } else {
f4e00a1a55c7f9 Marc Zyngier 2017-01-20 160 val = arch_timer_reg_read_cp15(access, reg);
f4e00a1a55c7f9 Marc Zyngier 2017-01-20 161 }
f4e00a1a55c7f9 Marc Zyngier 2017-01-20 162
f4e00a1a55c7f9 Marc Zyngier 2017-01-20 163 return val;
f4e00a1a55c7f9 Marc Zyngier 2017-01-20 164 }
f4e00a1a55c7f9 Marc Zyngier 2017-01-20 165
:::::: The code at line 156 was first introduced by commit
:::::: 0bc2c9327c236c28cdb2784d11ca349ef3b1ca0a clocksource/arm_arch_timer: Add build-time guards for unhandled register accesses
:::::: TO: Marc Zyngier <maz@kernel.org>
:::::: CC: Marc Zyngier <maz@kernel.org>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 38002 bytes --]
next reply other threads:[~2021-11-07 2:10 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-07 2:10 kernel test robot [this message]
2021-11-07 2:10 ` [arm-platforms:timers/tval-ectomy 2/17] drivers/clocksource/arm_arch_timer.c:156:3: warning: variable 'val' is used uninitialized whenever switch default is taken kernel test robot
2021-11-07 2:10 ` kernel test robot
-- strict thread matches above, loose matches on Subject: below --
2021-10-09 21:12 kernel test robot
2021-10-09 21:12 ` kernel test robot
2021-10-09 21:12 ` kernel test robot
2021-10-10 9:37 ` Marc Zyngier
2021-10-10 9:37 ` Marc Zyngier
2021-10-10 9:37 ` Marc Zyngier
2021-10-10 10:54 ` Miguel Ojeda
2021-10-10 10:54 ` Miguel Ojeda
2021-10-10 10:54 ` Miguel Ojeda
2021-10-11 20:18 ` Nick Desaulniers
2021-10-11 20:18 ` Nick Desaulniers
2021-10-11 20:18 ` Nick Desaulniers
2021-10-14 13:27 ` Miguel Ojeda
2021-10-14 13:27 ` Miguel Ojeda
2021-10-14 13:27 ` Miguel Ojeda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202111071053.ynszyL5B-lkp@intel.com \
--to=lkp@intel.com \
--cc=kbuild-all@lists.01.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=llvm@lists.linux.dev \
--cc=mark.rutland@arm.com \
--cc=maz@kernel.org \
--cc=oupton@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.