From: kernel test robot <lkp@intel.com>
To: kbuild-all@lists.01.org
Subject: Re: [RFC 06/20] ima: Move policy related variables into ima_namespace
Date: Wed, 01 Dec 2021 03:29:47 +0800 [thread overview]
Message-ID: <202112010308.LL7v8AgH-lkp@intel.com> (raw)
In-Reply-To: <20211130160654.1418231-7-stefanb@linux.ibm.com>
[-- Attachment #1: Type: text/plain, Size: 7975 bytes --]
Hi Stefan,
[FYI, it's a private test report for your RFC patch.]
[auto build test ERROR on zohar-integrity/next-integrity]
[also build test ERROR on linus/master v5.16-rc3]
[cannot apply to pcmoore-selinux/next jmorris-security/next-testing next-20211130]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Stefan-Berger/ima-Namespace-IMA-with-audit-support-in-IMA-ns/20211201-001242
base: https://git.kernel.org/pub/scm/linux/kernel/git/zohar/linux-integrity.git next-integrity
config: um-i386_defconfig (https://download.01.org/0day-ci/archive/20211201/202112010308.LL7v8AgH-lkp(a)intel.com/config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce (this is a W=1 build):
# https://github.com/0day-ci/linux/commit/16cf15c54af1f4eb0ad259bdc1d08f6d275817d3
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Stefan-Berger/ima-Namespace-IMA-with-audit-support-in-IMA-ns/20211201-001242
git checkout 16cf15c54af1f4eb0ad259bdc1d08f6d275817d3
# save the config file to linux build tree
mkdir build_dir
make W=1 O=build_dir ARCH=um SUBARCH=i386 SHELL=/bin/bash
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
fs/namei.c: In function 'vfs_tmpfile':
>> fs/namei.c:3488:26: error: passing argument 1 of 'ima_post_create_tmpfile' from incompatible pointer type [-Werror=incompatible-pointer-types]
3488 | ima_post_create_tmpfile(mnt_userns, inode);
| ^~~~~~~~~~
| |
| struct user_namespace *
In file included from fs/namei.c:28:
include/linux/ima.h:85:66: note: expected 'struct ima_namespace *' but argument is of type 'struct user_namespace *'
85 | static inline void ima_post_create_tmpfile(struct ima_namespace *ns,
| ~~~~~~~~~~~~~~~~~~~~~~^~
fs/namei.c:3488:38: error: passing argument 2 of 'ima_post_create_tmpfile' from incompatible pointer type [-Werror=incompatible-pointer-types]
3488 | ima_post_create_tmpfile(mnt_userns, inode);
| ^~~~~
| |
| struct inode *
In file included from fs/namei.c:28:
include/linux/ima.h:86:32: note: expected 'struct user_namespace *' but argument is of type 'struct inode *'
86 | struct user_namespace *mnt_userns,
| ~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~
>> fs/namei.c:3488:2: error: too few arguments to function 'ima_post_create_tmpfile'
3488 | ima_post_create_tmpfile(mnt_userns, inode);
| ^~~~~~~~~~~~~~~~~~~~~~~
In file included from fs/namei.c:28:
include/linux/ima.h:85:20: note: declared here
85 | static inline void ima_post_create_tmpfile(struct ima_namespace *ns,
| ^~~~~~~~~~~~~~~~~~~~~~~
cc1: some warnings being treated as errors
vim +/ima_post_create_tmpfile +3488 fs/namei.c
fb1cc555d53386 Al Viro 2009-12-24 3441
6521f891708292 Christian Brauner 2021-01-21 3442 /**
6521f891708292 Christian Brauner 2021-01-21 3443 * vfs_tmpfile - create tmpfile
6521f891708292 Christian Brauner 2021-01-21 3444 * @mnt_userns: user namespace of the mount the inode was found from
6521f891708292 Christian Brauner 2021-01-21 3445 * @dentry: pointer to dentry of the base directory
6521f891708292 Christian Brauner 2021-01-21 3446 * @mode: mode of the new tmpfile
2111c3c0124f74 Randy Dunlap 2021-02-15 3447 * @open_flag: flags
6521f891708292 Christian Brauner 2021-01-21 3448 *
6521f891708292 Christian Brauner 2021-01-21 3449 * Create a temporary file.
6521f891708292 Christian Brauner 2021-01-21 3450 *
6521f891708292 Christian Brauner 2021-01-21 3451 * If the inode has been found through an idmapped mount the user namespace of
6521f891708292 Christian Brauner 2021-01-21 3452 * the vfsmount must be passed through @mnt_userns. This function will then take
6521f891708292 Christian Brauner 2021-01-21 3453 * care to map the inode according to @mnt_userns before checking permissions.
6521f891708292 Christian Brauner 2021-01-21 3454 * On non-idmapped mounts or if permission checking is to be performed on the
6521f891708292 Christian Brauner 2021-01-21 3455 * raw inode simply passs init_user_ns.
6521f891708292 Christian Brauner 2021-01-21 3456 */
6521f891708292 Christian Brauner 2021-01-21 3457 struct dentry *vfs_tmpfile(struct user_namespace *mnt_userns,
6521f891708292 Christian Brauner 2021-01-21 3458 struct dentry *dentry, umode_t mode, int open_flag)
af7bd4dc13093b Amir Goldstein 2017-01-17 3459 {
af7bd4dc13093b Amir Goldstein 2017-01-17 3460 struct dentry *child = NULL;
af7bd4dc13093b Amir Goldstein 2017-01-17 3461 struct inode *dir = dentry->d_inode;
af7bd4dc13093b Amir Goldstein 2017-01-17 3462 struct inode *inode;
af7bd4dc13093b Amir Goldstein 2017-01-17 3463 int error;
af7bd4dc13093b Amir Goldstein 2017-01-17 3464
af7bd4dc13093b Amir Goldstein 2017-01-17 3465 /* we want directory to be writable */
6521f891708292 Christian Brauner 2021-01-21 3466 error = inode_permission(mnt_userns, dir, MAY_WRITE | MAY_EXEC);
af7bd4dc13093b Amir Goldstein 2017-01-17 3467 if (error)
af7bd4dc13093b Amir Goldstein 2017-01-17 3468 goto out_err;
af7bd4dc13093b Amir Goldstein 2017-01-17 3469 error = -EOPNOTSUPP;
af7bd4dc13093b Amir Goldstein 2017-01-17 3470 if (!dir->i_op->tmpfile)
af7bd4dc13093b Amir Goldstein 2017-01-17 3471 goto out_err;
af7bd4dc13093b Amir Goldstein 2017-01-17 3472 error = -ENOMEM;
cdf01226b26e98 David Howells 2017-07-04 3473 child = d_alloc(dentry, &slash_name);
af7bd4dc13093b Amir Goldstein 2017-01-17 3474 if (unlikely(!child))
af7bd4dc13093b Amir Goldstein 2017-01-17 3475 goto out_err;
549c7297717c32 Christian Brauner 2021-01-21 3476 error = dir->i_op->tmpfile(mnt_userns, dir, child, mode);
af7bd4dc13093b Amir Goldstein 2017-01-17 3477 if (error)
af7bd4dc13093b Amir Goldstein 2017-01-17 3478 goto out_err;
af7bd4dc13093b Amir Goldstein 2017-01-17 3479 error = -ENOENT;
af7bd4dc13093b Amir Goldstein 2017-01-17 3480 inode = child->d_inode;
af7bd4dc13093b Amir Goldstein 2017-01-17 3481 if (unlikely(!inode))
af7bd4dc13093b Amir Goldstein 2017-01-17 3482 goto out_err;
af7bd4dc13093b Amir Goldstein 2017-01-17 3483 if (!(open_flag & O_EXCL)) {
af7bd4dc13093b Amir Goldstein 2017-01-17 3484 spin_lock(&inode->i_lock);
af7bd4dc13093b Amir Goldstein 2017-01-17 3485 inode->i_state |= I_LINKABLE;
af7bd4dc13093b Amir Goldstein 2017-01-17 3486 spin_unlock(&inode->i_lock);
af7bd4dc13093b Amir Goldstein 2017-01-17 3487 }
a2d2329e30e224 Christian Brauner 2021-01-21 @3488 ima_post_create_tmpfile(mnt_userns, inode);
af7bd4dc13093b Amir Goldstein 2017-01-17 3489 return child;
af7bd4dc13093b Amir Goldstein 2017-01-17 3490
af7bd4dc13093b Amir Goldstein 2017-01-17 3491 out_err:
af7bd4dc13093b Amir Goldstein 2017-01-17 3492 dput(child);
af7bd4dc13093b Amir Goldstein 2017-01-17 3493 return ERR_PTR(error);
af7bd4dc13093b Amir Goldstein 2017-01-17 3494 }
af7bd4dc13093b Amir Goldstein 2017-01-17 3495 EXPORT_SYMBOL(vfs_tmpfile);
af7bd4dc13093b Amir Goldstein 2017-01-17 3496
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
next prev parent reply other threads:[~2021-11-30 19:29 UTC|newest]
Thread overview: 70+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-30 16:06 [RFC 00/20] ima: Namespace IMA with audit support in IMA-ns Stefan Berger
2021-11-30 16:06 ` [RFC 01/20] ima: Add IMA namespace support Stefan Berger
2021-11-30 21:53 ` kernel test robot
2021-11-30 21:53 ` kernel test robot
2021-11-30 22:03 ` kernel test robot
2021-11-30 22:03 ` kernel test robot
2021-11-30 22:42 ` [RFC PATCH] ima: imans_cache_init() can be static kernel test robot
2021-11-30 22:44 ` [RFC 01/20] ima: Add IMA namespace support kernel test robot
2021-11-30 16:06 ` [RFC 02/20] ima: Define ns_status for storing namespaced iint data Stefan Berger
2021-11-30 23:21 ` kernel test robot
2021-11-30 23:21 ` kernel test robot
2021-12-01 0:31 ` [RFC PATCH] ima: insert_ns_status() can be static kernel test robot
2021-12-01 0:33 ` [RFC 02/20] ima: Define ns_status for storing namespaced iint data kernel test robot
2021-11-30 16:06 ` [RFC 03/20] ima: Namespace audit status flags Stefan Berger
2021-11-30 16:06 ` [RFC 04/20] ima: Move delayed work queue and variables into ima_namespace Stefan Berger
2021-11-30 16:06 ` [RFC 05/20] ima: Move IMA's keys queue related " Stefan Berger
2021-11-30 16:06 ` [RFC 06/20] ima: Move policy " Stefan Berger
2021-11-30 19:29 ` kernel test robot [this message]
2021-11-30 16:06 ` [RFC 07/20] ima: Move ima_htable " Stefan Berger
2021-11-30 16:06 ` [RFC 08/20] ima: Move measurement list related variables " Stefan Berger
2021-12-02 12:46 ` James Bottomley
2021-12-02 13:41 ` Stefan Berger
2021-12-02 16:29 ` James Bottomley
2021-12-02 16:45 ` Stefan Berger
2021-12-02 17:44 ` James Bottomley
2021-12-02 18:03 ` Stefan Berger
2021-12-02 20:03 ` James Bottomley
2021-11-30 16:06 ` [RFC 09/20] ima: Only accept AUDIT rules for IMA non-init_ima_ns namespaces for now Stefan Berger
2021-11-30 16:06 ` [RFC 10/20] ima: Implement hierarchical processing of file accesses Stefan Berger
2021-11-30 16:06 ` [RFC 11/20] securityfs: Prefix global variables with securityfs_ Stefan Berger
2021-11-30 16:06 ` [RFC 12/20] securityfs: Pass static variables as parameters from top level functions Stefan Berger
2021-12-01 3:55 ` [RFC PATCH] securityfs: _securityfs_create_symlink() can be static kernel test robot
2021-12-01 4:02 ` [RFC 12/20] securityfs: Pass static variables as parameters from top level functions kernel test robot
2021-11-30 16:06 ` [RFC 13/20] securityfs: Build securityfs_ns for namespacing support Stefan Berger
2021-12-02 13:35 ` Christian Brauner
2021-12-02 13:47 ` Stefan Berger
2021-11-30 16:06 ` [RFC 14/20] ima: Move some IMA policy and filesystem related variables into ima_namespace Stefan Berger
2021-11-30 16:06 ` [RFC 15/20] capabilities: Introduce CAP_INTEGRITY_ADMIN Stefan Berger
2021-11-30 17:27 ` Casey Schaufler
2021-11-30 17:41 ` Stefan Berger
2021-11-30 17:50 ` Casey Schaufler
2021-11-30 16:06 ` [RFC 16/20] ima: Use ns_capable() for namespace policy access Stefan Berger
2021-11-30 16:06 ` [RFC 17/20] ima: Use integrity_admin_ns_capable() to check corresponding capability Stefan Berger
2021-12-01 16:58 ` James Bottomley
2021-12-01 17:35 ` Stefan Berger
2021-12-01 19:29 ` James Bottomley
2021-12-02 7:16 ` Denis Semakin
2021-12-02 12:33 ` James Bottomley
2021-12-02 17:54 ` Stefan Berger
2021-12-02 12:59 ` Christian Brauner
2021-12-02 13:01 ` Christian Brauner
2021-12-02 15:58 ` Casey Schaufler
2021-11-30 16:06 ` [RFC 18/20] userns: Introduce a refcount variable for calling early teardown function Stefan Berger
2021-11-30 16:06 ` [RFC 19/20] ima/userns: Define early teardown function for IMA namespace Stefan Berger
2021-11-30 20:42 ` kernel test robot
2021-11-30 16:06 ` [RFC 20/20] ima: Setup securityfs_ns " Stefan Berger
2021-12-01 2:14 ` [RFC PATCH] ima: ima_fs_ns_permission() can be static kernel test robot
2021-12-01 2:15 ` [RFC 20/20] ima: Setup securityfs_ns for IMA namespace kernel test robot
2021-12-01 17:56 ` James Bottomley
2021-12-01 18:11 ` Stefan Berger
2021-12-01 19:21 ` James Bottomley
2021-12-01 20:25 ` Stefan Berger
2021-12-01 21:11 ` James Bottomley
2021-12-01 21:34 ` Stefan Berger
2021-12-01 22:01 ` James Bottomley
2021-12-01 22:09 ` Stefan Berger
2021-12-01 22:19 ` James Bottomley
2021-12-02 0:02 ` Stefan Berger
2021-12-02 13:18 ` Christian Brauner
2021-12-02 13:52 ` Stefan Berger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202112010308.LL7v8AgH-lkp@intel.com \
--to=lkp@intel.com \
--cc=kbuild-all@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.