From: Kefeng Wang <wangkefeng.wang@huawei.com> To: Marco Elver <elver@google.com>, Catalin Marinas <catalin.marinas@arm.com>, Will Deacon <will@kernel.org>, <linux-arm-kernel@lists.infradead.org>, <linux-kernel@vger.kernel.org> Cc: <mark.rutland@arm.com>, Kefeng Wang <wangkefeng.wang@huawei.com> Subject: [PATCH v3] arm64: Enable KCSAN Date: Thu, 2 Dec 2021 22:33:31 +0800 [thread overview] Message-ID: <20211202143331.15259-1-wangkefeng.wang@huawei.com> (raw) This patch enables KCSAN for arm64, with updates to build rules to not use KCSAN for several incompatible compilation units. Resent GCC version(at least GCC10) made outline-atomics as the default option(unlike Clang), which will cause linker errors for kernel/kcsan/core.o. Disables the out-of-line atomics by no-outline-atomics to fix the linker errors. Meanwhile, as Mark said[1], there is a specific issue on arm64 about ARM64_BTI with Clang 11 if KCSAN enabled, which is fixed by Clang 12, add CLANG_VERSION check. And also some latent issues are need to be fixed which isn't just a KCSAN problem, we make the KCSAN depends on EXPERT for now. Tested selftest and kcsan_test(built with GCC11 and Clang 13), and all passed. [1] https://lkml.org/lkml/2021/12/1/354 Signed-off-by: Kefeng Wang <wangkefeng.wang@huawei.com> --- Tested on Qemu with clang 13 / gcc 11, based on 5.16-rc3. [ 0.221518] kcsan: enabled early [ 0.222422] kcsan: strict mode configured ... [ 5.839223] kcsan: selftest: 3/3 tests passed ... [ 517.895102] # kcsan: pass:24 fail:0 skip:0 total:24 [ 517.896393] # Totals: pass:168 fail:0 skip:0 total:168 [ 517.897502] ok 1 - kcsan v3: - add EXPERT and CLANG_VERSION depends suggested by Mark Rutland v2: - tested on GCC11 and disable outline-atomics for kernel/kcsan/core.c suggested by Marco Elver arch/arm64/Kconfig | 1 + arch/arm64/kernel/vdso/Makefile | 1 + arch/arm64/kvm/hyp/nvhe/Makefile | 1 + kernel/kcsan/Makefile | 1 + 4 files changed, 4 insertions(+) diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig index 4ff73299f8a9..3a7b17742cde 100644 --- a/arch/arm64/Kconfig +++ b/arch/arm64/Kconfig @@ -150,6 +150,7 @@ config ARM64 select HAVE_ARCH_KASAN_VMALLOC if HAVE_ARCH_KASAN select HAVE_ARCH_KASAN_SW_TAGS if HAVE_ARCH_KASAN select HAVE_ARCH_KASAN_HW_TAGS if (HAVE_ARCH_KASAN && ARM64_MTE) + select HAVE_ARCH_KCSAN if EXPERT && (CC_IS_GCC || CLANG_VERSION >= 120000) select HAVE_ARCH_KFENCE select HAVE_ARCH_KGDB select HAVE_ARCH_MMAP_RND_BITS diff --git a/arch/arm64/kernel/vdso/Makefile b/arch/arm64/kernel/vdso/Makefile index 700767dfd221..60813497a381 100644 --- a/arch/arm64/kernel/vdso/Makefile +++ b/arch/arm64/kernel/vdso/Makefile @@ -32,6 +32,7 @@ ccflags-y += -DDISABLE_BRANCH_PROFILING -DBUILD_VDSO CFLAGS_REMOVE_vgettimeofday.o = $(CC_FLAGS_FTRACE) -Os $(CC_FLAGS_SCS) $(GCC_PLUGINS_CFLAGS) \ $(CC_FLAGS_LTO) KASAN_SANITIZE := n +KCSAN_SANITIZE := n UBSAN_SANITIZE := n OBJECT_FILES_NON_STANDARD := y KCOV_INSTRUMENT := n diff --git a/arch/arm64/kvm/hyp/nvhe/Makefile b/arch/arm64/kvm/hyp/nvhe/Makefile index c3c11974fa3b..24b2c2425b38 100644 --- a/arch/arm64/kvm/hyp/nvhe/Makefile +++ b/arch/arm64/kvm/hyp/nvhe/Makefile @@ -89,6 +89,7 @@ KBUILD_CFLAGS := $(filter-out $(CC_FLAGS_FTRACE) $(CC_FLAGS_SCS) $(CC_FLAGS_CFI) # cause crashes. Just disable it. GCOV_PROFILE := n KASAN_SANITIZE := n +KCSAN_SANITIZE := n UBSAN_SANITIZE := n KCOV_INSTRUMENT := n diff --git a/kernel/kcsan/Makefile b/kernel/kcsan/Makefile index c2bb07f5bcc7..e893b0e1d62a 100644 --- a/kernel/kcsan/Makefile +++ b/kernel/kcsan/Makefile @@ -8,6 +8,7 @@ CFLAGS_REMOVE_debugfs.o = $(CC_FLAGS_FTRACE) CFLAGS_REMOVE_report.o = $(CC_FLAGS_FTRACE) CFLAGS_core.o := $(call cc-option,-fno-conserve-stack) \ + $(call cc-option,-mno-outline-atomics) \ -fno-stack-protector -DDISABLE_BRANCH_PROFILING obj-y := core.o debugfs.o report.o -- 2.26.2
WARNING: multiple messages have this Message-ID (diff)
From: Kefeng Wang <wangkefeng.wang@huawei.com> To: Marco Elver <elver@google.com>, Catalin Marinas <catalin.marinas@arm.com>, Will Deacon <will@kernel.org>, <linux-arm-kernel@lists.infradead.org>, <linux-kernel@vger.kernel.org> Cc: <mark.rutland@arm.com>, Kefeng Wang <wangkefeng.wang@huawei.com> Subject: [PATCH v3] arm64: Enable KCSAN Date: Thu, 2 Dec 2021 22:33:31 +0800 [thread overview] Message-ID: <20211202143331.15259-1-wangkefeng.wang@huawei.com> (raw) This patch enables KCSAN for arm64, with updates to build rules to not use KCSAN for several incompatible compilation units. Resent GCC version(at least GCC10) made outline-atomics as the default option(unlike Clang), which will cause linker errors for kernel/kcsan/core.o. Disables the out-of-line atomics by no-outline-atomics to fix the linker errors. Meanwhile, as Mark said[1], there is a specific issue on arm64 about ARM64_BTI with Clang 11 if KCSAN enabled, which is fixed by Clang 12, add CLANG_VERSION check. And also some latent issues are need to be fixed which isn't just a KCSAN problem, we make the KCSAN depends on EXPERT for now. Tested selftest and kcsan_test(built with GCC11 and Clang 13), and all passed. [1] https://lkml.org/lkml/2021/12/1/354 Signed-off-by: Kefeng Wang <wangkefeng.wang@huawei.com> --- Tested on Qemu with clang 13 / gcc 11, based on 5.16-rc3. [ 0.221518] kcsan: enabled early [ 0.222422] kcsan: strict mode configured ... [ 5.839223] kcsan: selftest: 3/3 tests passed ... [ 517.895102] # kcsan: pass:24 fail:0 skip:0 total:24 [ 517.896393] # Totals: pass:168 fail:0 skip:0 total:168 [ 517.897502] ok 1 - kcsan v3: - add EXPERT and CLANG_VERSION depends suggested by Mark Rutland v2: - tested on GCC11 and disable outline-atomics for kernel/kcsan/core.c suggested by Marco Elver arch/arm64/Kconfig | 1 + arch/arm64/kernel/vdso/Makefile | 1 + arch/arm64/kvm/hyp/nvhe/Makefile | 1 + kernel/kcsan/Makefile | 1 + 4 files changed, 4 insertions(+) diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig index 4ff73299f8a9..3a7b17742cde 100644 --- a/arch/arm64/Kconfig +++ b/arch/arm64/Kconfig @@ -150,6 +150,7 @@ config ARM64 select HAVE_ARCH_KASAN_VMALLOC if HAVE_ARCH_KASAN select HAVE_ARCH_KASAN_SW_TAGS if HAVE_ARCH_KASAN select HAVE_ARCH_KASAN_HW_TAGS if (HAVE_ARCH_KASAN && ARM64_MTE) + select HAVE_ARCH_KCSAN if EXPERT && (CC_IS_GCC || CLANG_VERSION >= 120000) select HAVE_ARCH_KFENCE select HAVE_ARCH_KGDB select HAVE_ARCH_MMAP_RND_BITS diff --git a/arch/arm64/kernel/vdso/Makefile b/arch/arm64/kernel/vdso/Makefile index 700767dfd221..60813497a381 100644 --- a/arch/arm64/kernel/vdso/Makefile +++ b/arch/arm64/kernel/vdso/Makefile @@ -32,6 +32,7 @@ ccflags-y += -DDISABLE_BRANCH_PROFILING -DBUILD_VDSO CFLAGS_REMOVE_vgettimeofday.o = $(CC_FLAGS_FTRACE) -Os $(CC_FLAGS_SCS) $(GCC_PLUGINS_CFLAGS) \ $(CC_FLAGS_LTO) KASAN_SANITIZE := n +KCSAN_SANITIZE := n UBSAN_SANITIZE := n OBJECT_FILES_NON_STANDARD := y KCOV_INSTRUMENT := n diff --git a/arch/arm64/kvm/hyp/nvhe/Makefile b/arch/arm64/kvm/hyp/nvhe/Makefile index c3c11974fa3b..24b2c2425b38 100644 --- a/arch/arm64/kvm/hyp/nvhe/Makefile +++ b/arch/arm64/kvm/hyp/nvhe/Makefile @@ -89,6 +89,7 @@ KBUILD_CFLAGS := $(filter-out $(CC_FLAGS_FTRACE) $(CC_FLAGS_SCS) $(CC_FLAGS_CFI) # cause crashes. Just disable it. GCOV_PROFILE := n KASAN_SANITIZE := n +KCSAN_SANITIZE := n UBSAN_SANITIZE := n KCOV_INSTRUMENT := n diff --git a/kernel/kcsan/Makefile b/kernel/kcsan/Makefile index c2bb07f5bcc7..e893b0e1d62a 100644 --- a/kernel/kcsan/Makefile +++ b/kernel/kcsan/Makefile @@ -8,6 +8,7 @@ CFLAGS_REMOVE_debugfs.o = $(CC_FLAGS_FTRACE) CFLAGS_REMOVE_report.o = $(CC_FLAGS_FTRACE) CFLAGS_core.o := $(call cc-option,-fno-conserve-stack) \ + $(call cc-option,-mno-outline-atomics) \ -fno-stack-protector -DDISABLE_BRANCH_PROFILING obj-y := core.o debugfs.o report.o -- 2.26.2 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next reply other threads:[~2021-12-02 14:23 UTC|newest] Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-12-02 14:33 Kefeng Wang [this message] 2021-12-02 14:33 ` [PATCH v3] arm64: Enable KCSAN Kefeng Wang 2021-12-02 14:36 ` Marco Elver 2021-12-02 14:36 ` Marco Elver 2021-12-02 14:44 ` Mark Rutland 2021-12-02 14:44 ` Mark Rutland 2021-12-03 2:29 ` Kefeng Wang 2021-12-03 2:29 ` Kefeng Wang 2021-12-03 10:41 ` Mark Rutland 2021-12-03 10:41 ` Mark Rutland 2021-12-10 6:58 ` Kefeng Wang 2021-12-10 6:58 ` Kefeng Wang 2021-12-02 16:13 ` Joey Gouly 2021-12-02 16:13 ` Joey Gouly 2021-12-02 16:56 ` Nathan Chancellor 2021-12-02 16:56 ` Nathan Chancellor
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20211202143331.15259-1-wangkefeng.wang@huawei.com \ --to=wangkefeng.wang@huawei.com \ --cc=catalin.marinas@arm.com \ --cc=elver@google.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=mark.rutland@arm.com \ --cc=will@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.