From: kernel test robot <lkp@intel.com>
To: Matthew Rosato <mjrosato@linux.ibm.com>, linux-s390@vger.kernel.org
Cc: kbuild-all@lists.01.org, alex.williamson@redhat.com,
cohuck@redhat.com, schnelle@linux.ibm.com, farman@linux.ibm.com,
pmorel@linux.ibm.com, borntraeger@linux.ibm.com,
hca@linux.ibm.com, gor@linux.ibm.com,
gerald.schaefer@linux.ibm.com
Subject: Re: [PATCH 23/32] KVM: s390: pci: handle refresh of PCI translations
Date: Wed, 8 Dec 2021 16:04:22 +0800 [thread overview]
Message-ID: <202112081537.qiFqvLb1-lkp@intel.com> (raw)
In-Reply-To: <20211207205743.150299-24-mjrosato@linux.ibm.com>
Hi Matthew,
I love your patch! Perhaps something to improve:
[auto build test WARNING on v5.16-rc4]
[cannot apply to s390/features kvms390/next awilliam-vfio/next next-20211207]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Matthew-Rosato/KVM-s390-enable-zPCI-for-interpretive-execution/20211208-050204
base: 0fcfb00b28c0b7884635dacf38e46d60bf3d4eb1
config: s390-allyesconfig (https://download.01.org/0day-ci/archive/20211208/202112081537.qiFqvLb1-lkp@intel.com/config)
compiler: s390-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/84cb5df859beb99f52b3d3b133ff1f9b5a459558
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Matthew-Rosato/KVM-s390-enable-zPCI-for-interpretive-execution/20211208-050204
git checkout 84cb5df859beb99f52b3d3b133ff1f9b5a459558
# save the config file to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=s390 SHELL=/bin/bash arch/s390/kvm/
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All warnings (new ones prefixed by >>):
>> arch/s390/kvm/pci.c:179:16: warning: no previous prototype for 'dma_walk_guest_cpu_trans' [-Wmissing-prototypes]
179 | unsigned long *dma_walk_guest_cpu_trans(struct kvm_vcpu *vcpu,
| ^~~~~~~~~~~~~~~~~~~~~~~~
vim +/dma_walk_guest_cpu_trans +179 arch/s390/kvm/pci.c
178
> 179 unsigned long *dma_walk_guest_cpu_trans(struct kvm_vcpu *vcpu,
180 struct kvm_zdev_ioat *ioat,
181 dma_addr_t dma_addr)
182 {
183 unsigned long *rto, *sto, *pto;
184 unsigned int rtx, rts, sx, px, idx;
185 struct page *page;
186 gpa_t addr;
187 int i;
188
189 /* Pin guest segment table if needed */
190 rtx = calc_rtx(dma_addr);
191 rto = ioat->head[(rtx / ZPCI_TABLE_ENTRIES_PER_PAGE)];
192 rts = rtx * ZPCI_TABLE_PAGES;
193 if (!ioat->seg[rts]) {
194 if (!reg_entry_isvalid(rto[rtx % ZPCI_TABLE_ENTRIES_PER_PAGE]))
195 return NULL;
196 sto = get_rt_sto(rto[rtx % ZPCI_TABLE_ENTRIES_PER_PAGE]);
197 addr = ((u64)sto & ZPCI_RTE_ADDR_MASK);
198 idx = srcu_read_lock(&vcpu->kvm->srcu);
199 for (i = 0; i < ZPCI_TABLE_PAGES; i++) {
200 page = gfn_to_page(vcpu->kvm, gpa_to_gfn(addr));
201 if (is_error_page(page)) {
202 srcu_read_unlock(&vcpu->kvm->srcu, idx);
203 return NULL;
204 }
205 ioat->seg[rts + i] = page_to_virt(page) +
206 (addr & ~PAGE_MASK);
207 addr += PAGE_SIZE;
208 }
209 srcu_read_unlock(&vcpu->kvm->srcu, idx);
210 }
211
212 /* Allocate pin pointers for another segment table if needed */
213 if (!ioat->pt[rtx]) {
214 ioat->pt[rtx] = kcalloc(ZPCI_TABLE_ENTRIES,
215 (sizeof(unsigned long *)), GFP_KERNEL);
216 if (!ioat->pt[rtx])
217 return NULL;
218 }
219 /* Pin guest page table if needed */
220 sx = calc_sx(dma_addr);
221 sto = ioat->seg[(rts + (sx / ZPCI_TABLE_ENTRIES_PER_PAGE))];
222 if (!ioat->pt[rtx][sx]) {
223 if (!reg_entry_isvalid(sto[sx % ZPCI_TABLE_ENTRIES_PER_PAGE]))
224 return NULL;
225 pto = get_st_pto(sto[sx % ZPCI_TABLE_ENTRIES_PER_PAGE]);
226 if (!pto)
227 return NULL;
228 addr = ((u64)pto & ZPCI_STE_ADDR_MASK);
229 idx = srcu_read_lock(&vcpu->kvm->srcu);
230 page = gfn_to_page(vcpu->kvm, gpa_to_gfn(addr));
231 srcu_read_unlock(&vcpu->kvm->srcu, idx);
232 if (is_error_page(page))
233 return NULL;
234 ioat->pt[rtx][sx] = page_to_virt(page) + (addr & ~PAGE_MASK);
235 }
236 pto = ioat->pt[rtx][sx];
237
238 /* Return guest PTE */
239 px = calc_px(dma_addr);
240 return &pto[px];
241 }
242
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
WARNING: multiple messages have this Message-ID (diff)
From: kernel test robot <lkp@intel.com>
To: kbuild-all@lists.01.org
Subject: Re: [PATCH 23/32] KVM: s390: pci: handle refresh of PCI translations
Date: Wed, 08 Dec 2021 16:04:22 +0800 [thread overview]
Message-ID: <202112081537.qiFqvLb1-lkp@intel.com> (raw)
In-Reply-To: <20211207205743.150299-24-mjrosato@linux.ibm.com>
[-- Attachment #1: Type: text/plain, Size: 4455 bytes --]
Hi Matthew,
I love your patch! Perhaps something to improve:
[auto build test WARNING on v5.16-rc4]
[cannot apply to s390/features kvms390/next awilliam-vfio/next next-20211207]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Matthew-Rosato/KVM-s390-enable-zPCI-for-interpretive-execution/20211208-050204
base: 0fcfb00b28c0b7884635dacf38e46d60bf3d4eb1
config: s390-allyesconfig (https://download.01.org/0day-ci/archive/20211208/202112081537.qiFqvLb1-lkp(a)intel.com/config)
compiler: s390-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/84cb5df859beb99f52b3d3b133ff1f9b5a459558
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Matthew-Rosato/KVM-s390-enable-zPCI-for-interpretive-execution/20211208-050204
git checkout 84cb5df859beb99f52b3d3b133ff1f9b5a459558
# save the config file to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=s390 SHELL=/bin/bash arch/s390/kvm/
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All warnings (new ones prefixed by >>):
>> arch/s390/kvm/pci.c:179:16: warning: no previous prototype for 'dma_walk_guest_cpu_trans' [-Wmissing-prototypes]
179 | unsigned long *dma_walk_guest_cpu_trans(struct kvm_vcpu *vcpu,
| ^~~~~~~~~~~~~~~~~~~~~~~~
vim +/dma_walk_guest_cpu_trans +179 arch/s390/kvm/pci.c
178
> 179 unsigned long *dma_walk_guest_cpu_trans(struct kvm_vcpu *vcpu,
180 struct kvm_zdev_ioat *ioat,
181 dma_addr_t dma_addr)
182 {
183 unsigned long *rto, *sto, *pto;
184 unsigned int rtx, rts, sx, px, idx;
185 struct page *page;
186 gpa_t addr;
187 int i;
188
189 /* Pin guest segment table if needed */
190 rtx = calc_rtx(dma_addr);
191 rto = ioat->head[(rtx / ZPCI_TABLE_ENTRIES_PER_PAGE)];
192 rts = rtx * ZPCI_TABLE_PAGES;
193 if (!ioat->seg[rts]) {
194 if (!reg_entry_isvalid(rto[rtx % ZPCI_TABLE_ENTRIES_PER_PAGE]))
195 return NULL;
196 sto = get_rt_sto(rto[rtx % ZPCI_TABLE_ENTRIES_PER_PAGE]);
197 addr = ((u64)sto & ZPCI_RTE_ADDR_MASK);
198 idx = srcu_read_lock(&vcpu->kvm->srcu);
199 for (i = 0; i < ZPCI_TABLE_PAGES; i++) {
200 page = gfn_to_page(vcpu->kvm, gpa_to_gfn(addr));
201 if (is_error_page(page)) {
202 srcu_read_unlock(&vcpu->kvm->srcu, idx);
203 return NULL;
204 }
205 ioat->seg[rts + i] = page_to_virt(page) +
206 (addr & ~PAGE_MASK);
207 addr += PAGE_SIZE;
208 }
209 srcu_read_unlock(&vcpu->kvm->srcu, idx);
210 }
211
212 /* Allocate pin pointers for another segment table if needed */
213 if (!ioat->pt[rtx]) {
214 ioat->pt[rtx] = kcalloc(ZPCI_TABLE_ENTRIES,
215 (sizeof(unsigned long *)), GFP_KERNEL);
216 if (!ioat->pt[rtx])
217 return NULL;
218 }
219 /* Pin guest page table if needed */
220 sx = calc_sx(dma_addr);
221 sto = ioat->seg[(rts + (sx / ZPCI_TABLE_ENTRIES_PER_PAGE))];
222 if (!ioat->pt[rtx][sx]) {
223 if (!reg_entry_isvalid(sto[sx % ZPCI_TABLE_ENTRIES_PER_PAGE]))
224 return NULL;
225 pto = get_st_pto(sto[sx % ZPCI_TABLE_ENTRIES_PER_PAGE]);
226 if (!pto)
227 return NULL;
228 addr = ((u64)pto & ZPCI_STE_ADDR_MASK);
229 idx = srcu_read_lock(&vcpu->kvm->srcu);
230 page = gfn_to_page(vcpu->kvm, gpa_to_gfn(addr));
231 srcu_read_unlock(&vcpu->kvm->srcu, idx);
232 if (is_error_page(page))
233 return NULL;
234 ioat->pt[rtx][sx] = page_to_virt(page) + (addr & ~PAGE_MASK);
235 }
236 pto = ioat->pt[rtx][sx];
237
238 /* Return guest PTE */
239 px = calc_px(dma_addr);
240 return &pto[px];
241 }
242
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
next prev parent reply other threads:[~2021-12-08 8:04 UTC|newest]
Thread overview: 122+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-07 20:57 [PATCH 00/32] KVM: s390: enable zPCI for interpretive execution Matthew Rosato
2021-12-07 20:57 ` [PATCH 01/32] s390/sclp: detect the zPCI interpretation facility Matthew Rosato
2021-12-08 11:12 ` Christian Borntraeger
2021-12-08 14:33 ` Eric Farman
2021-12-08 13:06 ` Claudio Imbrenda
2021-12-07 20:57 ` [PATCH 02/32] s390/sclp: detect the AISII facility Matthew Rosato
2021-12-08 11:13 ` Christian Borntraeger
2021-12-08 13:07 ` Claudio Imbrenda
2021-12-07 20:57 ` [PATCH 03/32] s390/sclp: detect the AENI facility Matthew Rosato
2021-12-08 11:17 ` Christian Borntraeger
2021-12-08 13:08 ` Claudio Imbrenda
2021-12-07 20:57 ` [PATCH 04/32] s390/sclp: detect the AISI facility Matthew Rosato
2021-12-08 11:18 ` Christian Borntraeger
2021-12-08 13:09 ` Claudio Imbrenda
2021-12-07 20:57 ` [PATCH 05/32] s390/airq: pass more TPI info to airq handlers Matthew Rosato
2021-12-08 11:25 ` Christian Borntraeger
2021-12-08 13:14 ` Claudio Imbrenda
2021-12-13 14:35 ` Pierre Morel
2021-12-07 20:57 ` [PATCH 06/32] s390/airq: allow for airq structure that uses an input vector Matthew Rosato
2021-12-08 10:04 ` Thomas Huth
2021-12-08 12:59 ` Christian Borntraeger
2021-12-07 20:57 ` [PATCH 07/32] s390/pci: externalize the SIC operation controls and routine Matthew Rosato
2021-12-08 13:09 ` Christian Borntraeger
2021-12-08 13:53 ` Niklas Schnelle
2021-12-08 15:33 ` Matthew Rosato
2021-12-08 15:59 ` Niklas Schnelle
2021-12-08 16:20 ` Matthew Rosato
2021-12-08 16:41 ` Niklas Schnelle
2021-12-08 18:18 ` Niklas Schnelle
2021-12-07 20:57 ` [PATCH 08/32] s390/pci: stash associated GISA designation Matthew Rosato
2021-12-09 15:07 ` Christian Borntraeger
2021-12-10 19:01 ` Eric Farman
2021-12-13 14:59 ` Pierre Morel
2021-12-07 20:57 ` [PATCH 09/32] s390/pci: export some routines related to RPCIT processing Matthew Rosato
2021-12-09 15:20 ` Christian Borntraeger
2021-12-07 20:57 ` [PATCH 10/32] s390/pci: stash dtsm and maxstbl Matthew Rosato
2021-12-08 16:18 ` Niklas Schnelle
2021-12-09 9:13 ` Pierre Morel
2021-12-09 15:25 ` Christian Borntraeger
2021-12-07 20:57 ` [PATCH 11/32] s390/pci: add helper function to find device by handle Matthew Rosato
2021-12-09 15:28 ` Christian Borntraeger
2021-12-10 19:04 ` Eric Farman
2021-12-07 20:57 ` [PATCH 12/32] s390/pci: get SHM information from list pci Matthew Rosato
2021-12-08 12:21 ` Niklas Schnelle
2021-12-09 18:25 ` Matthew Rosato
2021-12-09 15:47 ` Christian Borntraeger
2021-12-10 8:45 ` Niklas Schnelle
2021-12-07 20:57 ` [PATCH 13/32] KVM: s390: pci: add basic kvm_zdev structure Matthew Rosato
2021-12-09 15:54 ` Christian Borntraeger
2021-12-10 19:04 ` Eric Farman
2021-12-13 15:19 ` Pierre Morel
2021-12-14 9:15 ` Pierre Morel
2021-12-17 20:26 ` Matthew Rosato
2021-12-20 17:26 ` Pierre Morel
2021-12-07 20:57 ` [PATCH 14/32] KVM: s390: pci: do initial setup for AEN interpretation Matthew Rosato
2021-12-08 7:53 ` kernel test robot
2021-12-08 7:53 ` kernel test robot
2021-12-09 19:54 ` Christian Borntraeger
2021-12-09 20:20 ` Matthew Rosato
2021-12-09 20:23 ` Christian Borntraeger
2021-12-10 8:36 ` Niklas Schnelle
2021-12-10 9:54 ` Pierre Morel
2021-12-10 10:55 ` Pierre Morel
2021-12-07 20:57 ` [PATCH 15/32] KVM: s390: pci: enable host forwarding of Adapter Event Notifications Matthew Rosato
2021-12-10 21:51 ` Eric Farman
2021-12-17 16:56 ` Christian Borntraeger
2021-12-17 17:42 ` Matthew Rosato
2021-12-07 20:57 ` [PATCH 16/32] KVM: s390: expose the guest zPCI interpretation facility Matthew Rosato
2021-12-17 15:05 ` Christian Borntraeger
2021-12-17 15:19 ` Matthew Rosato
2021-12-17 16:58 ` Christian Borntraeger
2021-12-17 17:13 ` Matthew Rosato
2021-12-07 20:57 ` [PATCH 17/32] KVM: s390: expose the guest Adapter Interruption Source ID facility Matthew Rosato
2021-12-17 15:06 ` Christian Borntraeger
2021-12-07 20:57 ` [PATCH 18/32] KVM: s390: expose guest Adapter Event Notification Interpretation facility Matthew Rosato
2021-12-07 20:57 ` [PATCH 19/32] KVM: s390: mechanism to enable guest zPCI Interpretation Matthew Rosato
2021-12-10 13:27 ` Christian Borntraeger
2021-12-10 14:21 ` Matthew Rosato
2021-12-07 20:57 ` [PATCH 20/32] KVM: s390: pci: provide routines for enabling/disabling interpretation Matthew Rosato
2021-12-08 9:44 ` Niklas Schnelle
2021-12-08 15:04 ` Matthew Rosato
2021-12-14 9:16 ` Pierre Morel
2021-12-07 20:57 ` [PATCH 21/32] KVM: s390: pci: provide routines for enabling/disabling interrupt forwarding Matthew Rosato
2021-12-08 10:58 ` kernel test robot
2021-12-08 10:58 ` kernel test robot
2021-12-14 9:26 ` Pierre Morel
2021-12-07 20:57 ` [PATCH 22/32] KVM: s390: pci: provide routines for enabling/disabling IOAT assist Matthew Rosato
2021-12-14 17:46 ` Pierre Morel
2021-12-14 18:13 ` Matthew Rosato
2021-12-07 20:57 ` [PATCH 23/32] KVM: s390: pci: handle refresh of PCI translations Matthew Rosato
2021-12-08 8:04 ` kernel test robot [this message]
2021-12-08 8:04 ` kernel test robot
2021-12-08 10:30 ` Niklas Schnelle
2021-12-08 18:04 ` Matthew Rosato
2021-12-14 16:59 ` Pierre Morel
2021-12-14 17:54 ` Matthew Rosato
2021-12-16 14:39 ` Niklas Schnelle
2021-12-16 14:51 ` Matthew Rosato
2021-12-17 9:41 ` Niklas Schnelle
2021-12-07 20:57 ` [PATCH 24/32] KVM: s390: intercept the rpcit instruction Matthew Rosato
2021-12-14 17:04 ` Pierre Morel
2021-12-14 18:00 ` Matthew Rosato
2021-12-07 20:57 ` [PATCH 25/32] vfio/pci: re-introduce CONFIG_VFIO_PCI_ZDEV Matthew Rosato
2021-12-17 16:49 ` Christian Borntraeger
2021-12-17 17:54 ` Matthew Rosato
2021-12-07 20:57 ` [PATCH 26/32] vfio-pci/zdev: wire up group notifier Matthew Rosato
2021-12-21 18:47 ` Alex Williamson
2021-12-07 20:57 ` [PATCH 27/32] vfio-pci/zdev: wire up zPCI interpretive execution support Matthew Rosato
2021-12-14 16:30 ` Pierre Morel
2021-12-21 18:48 ` Alex Williamson
2021-12-07 20:57 ` [PATCH 28/32] vfio-pci/zdev: wire up zPCI adapter interrupt forwarding support Matthew Rosato
2021-12-14 9:48 ` Pierre Morel
2021-12-07 20:57 ` [PATCH 29/32] vfio-pci/zdev: wire up zPCI IOAT assist support Matthew Rosato
2021-12-14 9:46 ` Pierre Morel
2021-12-07 20:57 ` [PATCH 30/32] vfio-pci/zdev: add DTSM to clp group capability Matthew Rosato
2021-12-14 9:58 ` Pierre Morel
2021-12-14 14:59 ` Matthew Rosato
2021-12-07 20:57 ` [PATCH 31/32] KVM: s390: introduce CPU feature for zPCI Interpretation Matthew Rosato
2021-12-07 20:57 ` [PATCH 32/32] MAINTAINERS: additional files related kvm s390 pci passthrough Matthew Rosato
2021-12-17 14:55 ` Christian Borntraeger
2021-12-21 19:11 ` Alex Williamson
2021-12-07 21:16 ` [PATCH 00/32] KVM: s390: enable zPCI for interpretive execution Matthew Rosato
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202112081537.qiFqvLb1-lkp@intel.com \
--to=lkp@intel.com \
--cc=alex.williamson@redhat.com \
--cc=borntraeger@linux.ibm.com \
--cc=cohuck@redhat.com \
--cc=farman@linux.ibm.com \
--cc=gerald.schaefer@linux.ibm.com \
--cc=gor@linux.ibm.com \
--cc=hca@linux.ibm.com \
--cc=kbuild-all@lists.01.org \
--cc=linux-s390@vger.kernel.org \
--cc=mjrosato@linux.ibm.com \
--cc=pmorel@linux.ibm.com \
--cc=schnelle@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.